From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D237C433EF for ; Fri, 3 Dec 2021 13:02:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 856936B0072; Fri, 3 Dec 2021 08:02:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 805B76B0074; Fri, 3 Dec 2021 08:02:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CCB46B0075; Fri, 3 Dec 2021 08:02:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 59EC06B0072 for ; Fri, 3 Dec 2021 08:02:44 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1FBA189542 for ; Fri, 3 Dec 2021 13:02:34 +0000 (UTC) X-FDA: 78876497028.16.81C8B68 Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by imf18.hostedemail.com (Postfix) with ESMTP id 933A1400208D for ; Fri, 3 Dec 2021 13:02:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1638536553; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=S0boIMq9CsUZ+THAcamuP4gAY6wx2Qx7eFqNdDb2HYs=; b=gY6eEB8AWQjO59qXNYENcxrr5BUy2usMd/DYUvI3X8KqYt9/758TP8orPaKJ6EeBhrg2u2Pj gCcl+14PGzq1gnqU6EvtWu/4tXsNOhThJ+9uHqsWd+LMVzBHx2KQXgsvNGBnIc6PwhkFpkHE R22imDnSXrswvPfgFbirvHFljyQ= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyIwY2Q3OCIsICJsaW51eC1tbUBrdmFjay5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 61aa1568df12ba53c49082a2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 03 Dec 2021 13:02:32 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CB23EC4360D; Fri, 3 Dec 2021 13:02:31 +0000 (UTC) Received: from [192.168.29.110] (unknown [49.37.157.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: charante) by smtp.codeaurora.org (Postfix) with ESMTPSA id 04359C4338F; Fri, 3 Dec 2021 13:02:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 04359C4338F Subject: Re: [PATCH v2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem To: Matthew Wilcox , Charan Teja Reddy Cc: hughd@google.com, akpm@linux-foundation.org, vbabka@suse.cz, rientjes@google.com, david@redhat.com, mhocko@suse.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1638442253-1591-1-git-send-email-quic_charante@quicinc.com> From: Charan Teja Kalla Message-ID: <1a88ed3f-ad7d-9d06-108e-e00f06b0ed19@codeaurora.org> Date: Fri, 3 Dec 2021 18:32:25 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 933A1400208D Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=mg.codeaurora.org header.s=smtp header.b=gY6eEB8A; spf=pass (imf18.hostedemail.com: domain of "bounce+d06763.be9e4a-linux-mm=kvack.org@mg.codeaurora.org" designates 69.72.43.7 as permitted sender) smtp.mailfrom="bounce+d06763.be9e4a-linux-mm=kvack.org@mg.codeaurora.org"; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: af3hm1upc7hhyhuinbi6obyxxcaufgf1 X-HE-Tag: 1638536553-638252 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000096, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/2/2021 8:29 PM, Matthew Wilcox wrote: >> + list_add(&page->lru, list); >> + inc_node_page_state(page, NR_ISOLATED_ANON + >> + page_is_file_lru(page)); > ... what if the page is a THP? Will take care of THP pages in the next spin. Thanks for pointing it out. -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project