From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E63AC433FE for ; Fri, 30 Sep 2022 23:10:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 849E08D0002; Fri, 30 Sep 2022 19:10:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F9296B0075; Fri, 30 Sep 2022 19:10:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6995B8D0002; Fri, 30 Sep 2022 19:10:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 598396B0074 for ; Fri, 30 Sep 2022 19:10:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0E86D1C7172 for ; Fri, 30 Sep 2022 23:10:01 +0000 (UTC) X-FDA: 79970296602.29.766D914 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf08.hostedemail.com (Postfix) with ESMTP id 9A653160009 for ; Fri, 30 Sep 2022 23:09:59 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id d11so5150756pll.8 for ; Fri, 30 Sep 2022 16:09:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Z4pwa9gyuRqjS+eeSbjJShInrhr7/HchgUX3g2MI7Qo=; b=01waiXwd4MZZ3LxATVL4IG9OwNkJnPrCk6JCJfUK6fYGRGtzxqTn80VoU4hkFv5Bvj tSDZXiVqNe/DfdolbG41gqqxsKHSkdPeDtbNirtpDDbQBgewyvQyx/p8il0/gl6YLHV6 2P9sxjONLCnqVVU1NlApiEDi6364RosQmn+8cKQMnqHIOF0Vd+s/HGwmG9DAiuUq1G+z K1Bj/0xD69fu+X+CnSbrhW/cKk1+t3KKs40AraRyErM/yQmcMHzdEOnkiGBTMYWc51h9 oMFtVbwqRzZre/YbhLC4lL5q3pZPgOCrOLcg9/diNqio32s3NwQ2n+wz6jf/C3N6/Zy5 kawA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Z4pwa9gyuRqjS+eeSbjJShInrhr7/HchgUX3g2MI7Qo=; b=sO7L0Zyw6MAuVqwgKI0fr2VIrWnIoVK2WgTriEctYGplhUjw2K7F52GaPkc3VCCHEi eYRFRyT7AfjKxLN7RxyJAW+FDLDEppUvxhCdr47HYWw2NzDlOQxbT5bWVdIzBd1wEYRW 8a1dq0y4ALKFSdv2Zs/1G91q0jrLOdcqDZZJTCeOaWvswRnSAnBaGvvT6J4qqwW6oQvA 6Qktt81jJNHMlmXSjAacm8eybViie8h88e7pJI2konkv2NDI8Zp/OE6HuS+88fmA7zaj TJ14L1Usb3nkQjB/b7fMEe7al6aw4tiLjYvHqAJL9s1tDLgvqigmiiiFlVVFQWqC1/GP 0PYA== X-Gm-Message-State: ACrzQf0l+aMzRFkqVzMaT/tAWfvFp5u7JlfvtoC4oUtBia155h2ZOMkm yU2tClkOlfPOJjaYJ0aCtHu3OQ== X-Google-Smtp-Source: AMsMyM4TdHJBditr2nIJON4fzX9DhjVKj8xdWhyvXPRvQd0oWhWzm/OKUm1lhy3laeebjv0gu19+kw== X-Received: by 2002:a17:903:1c5:b0:178:44cd:e9c with SMTP id e5-20020a17090301c500b0017844cd0e9cmr11481864plh.132.1664579398319; Fri, 30 Sep 2022 16:09:58 -0700 (PDT) Received: from [10.4.189.225] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id m13-20020a65564d000000b00442c70b659esm1261782pgs.91.2022.09.30.16.09.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 16:09:57 -0700 (PDT) Message-ID: <1a679784-542f-1ab7-7ba8-3d560c264479@bytedance.com> Date: Sat, 1 Oct 2022 07:09:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 1/2] mm: use update_mmu_tlb() on the second thread Content-Language: en-US To: Andrew Morton Cc: David Hildenbrand , maobibo@loongson.cn, chenhuacai@loongson.cn, songmuchun@bytedance.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, chris@zankel.net, jcmvbkbc@gmail.com References: <20220929112318.32393-1-zhengqi.arch@bytedance.com> <20220929112318.32393-2-zhengqi.arch@bytedance.com> <0fecbcdc-7324-2d76-8452-b60b4638d074@redhat.com> <32a53a8f-f6f8-6efc-a5f6-a004ffab8c99@bytedance.com> <673e494c-eb91-470a-026b-59e414d0916e@redhat.com> <20220930153135.164240eadc71ddf94d8200fb@linux-foundation.org> From: Qi Zheng In-Reply-To: <20220930153135.164240eadc71ddf94d8200fb@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664579400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z4pwa9gyuRqjS+eeSbjJShInrhr7/HchgUX3g2MI7Qo=; b=kQ7C4AXiSsuk80KLdvUA4sVK7wXN/8p+Ir8fNGfDoM1ioqlz96EUDe8uZxWtmSwRRdSMOs PfnfcPTKV+uC0aHcBPbUxT+101Nee9CjggskYrUYnsA4jndEV6uzdPw7bL9PAiABL9Sq2g oi24ttnGMPqdRrOP7B1pAzTdSoFt76c= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=01waiXwd; spf=pass (imf08.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664579400; a=rsa-sha256; cv=none; b=ayqJslk3y5V/TQvGiy7EY4P4xDvvztz4QPkNj16PZKiRl/PuCrE5CpHX2dDYwbEULpRxS3 Ud1TS4ZjswZrdj1mrqUkSWnwPrjcL624FfRV4ZXzptfNdJj02l7KaS4hTCGIhcUS4CAb3W pIEhpVvInR+7cHOscFB5KpwqC1fstMI= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=01waiXwd; spf=pass (imf08.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Stat-Signature: e5r8hedmots8dpyjahffcgsjgy67soc8 X-Rspamd-Queue-Id: 9A653160009 X-Rspamd-Server: rspam08 X-HE-Tag: 1664579399-802807 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/1 06:31, Andrew Morton wrote: > On Fri, 30 Sep 2022 10:44:21 +0200 David Hildenbrand wrote: > >>> Oh, this is better. Hi Andrew, do I need to resend the v4? >>> >> >> I assume he can squash it, most probably no need to resend. :) > > > From: Qi Zheng > Subject: mm: use update_mmu_tlb() on the second thread > Date: Thu, 29 Sep 2022 19:23:17 +0800 > > As message in commit 7df676974359 ("mm/memory.c: Update local TLB if PTE > entry exists") said, we should update local TLB only on the second thread. > So in the do_anonymous_page() here, we should use update_mmu_tlb() > instead of update_mmu_cache() on the second thread. > > As David pointed out, this is a performance improvement, not a > correctness fix. > > Link: https://lkml.kernel.org/r/20220929112318.32393-2-zhengqi.arch@bytedance.com > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > Acked-by: David Hildenbrand > Cc: Bibo Mao > Cc: Chris Zankel > Cc: Huacai Chen > Cc: Max Filippov > Signed-off-by: Andrew Morton > --- > > mm/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/mm/memory.c~mm-use-update_mmu_tlb-on-the-second-thread > +++ a/mm/memory.c > @@ -4136,7 +4136,7 @@ static vm_fault_t do_anonymous_page(stru > vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, > &vmf->ptl); > if (!pte_none(*vmf->pte)) { > - update_mmu_cache(vma, vmf->address, vmf->pte); > + update_mmu_tlb(vma, vmf->address, vmf->pte); > goto release; > } > > _ Thank you very much! :) > -- Thanks, Qi