From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADBEAC433E0 for ; Mon, 29 Jun 2020 08:16:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5ADC72335A for ; Mon, 29 Jun 2020 08:16:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5ADC72335A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DE8726B000C; Mon, 29 Jun 2020 04:16:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D97816B000D; Mon, 29 Jun 2020 04:16:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAE8A6B000E; Mon, 29 Jun 2020 04:16:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0186.hostedemail.com [216.40.44.186]) by kanga.kvack.org (Postfix) with ESMTP id B1F8F6B000C for ; Mon, 29 Jun 2020 04:16:00 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 709D5181AC9CC for ; Mon, 29 Jun 2020 08:16:00 +0000 (UTC) X-FDA: 76981541280.11.burn68_0a0374b26e6d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 46A1F180F8B82 for ; Mon, 29 Jun 2020 08:16:00 +0000 (UTC) X-HE-Tag: burn68_0a0374b26e6d X-Filterd-Recvd-Size: 14647 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 29 Jun 2020 08:15:59 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9498131B; Mon, 29 Jun 2020 01:15:58 -0700 (PDT) Received: from [10.163.83.176] (unknown [10.163.83.176]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9CA863F71E; Mon, 29 Jun 2020 01:15:47 -0700 (PDT) Subject: Re: [PATCH V3 2/4] mm/debug_vm_pgtable: Add tests validating advanced arch page table helpers To: Christophe Leroy , linux-mm@kvack.org Cc: ziy@nvidia.com, gerald.schaefer@de.ibm.com, Andrew Morton , Mike Rapoport , Vineet Gupta , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Kirill A . Shutemov" , Paul Walmsley , Palmer Dabbelt , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <1592192277-8421-1-git-send-email-anshuman.khandual@arm.com> <1592192277-8421-3-git-send-email-anshuman.khandual@arm.com> <4da41eee-5ce0-2a5e-40eb-4424655b3489@csgroup.eu> From: Anshuman Khandual Message-ID: <1a6138ca-40b0-5076-2f09-4ce6b7ee8d36@arm.com> Date: Mon, 29 Jun 2020 13:45:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4da41eee-5ce0-2a5e-40eb-4424655b3489@csgroup.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: 46A1F180F8B82 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/27/2020 12:56 PM, Christophe Leroy wrote: >=20 >=20 > Le 15/06/2020 =C3=A0 05:37, Anshuman Khandual a =C3=A9crit=C2=A0: >> This adds new tests validating for these following arch advanced page = table >> helpers. These tests create and test specific mapping types at various= page >> table levels. >> >> 1. pxxp_set_wrprotect() >> 2. pxxp_get_and_clear() >> 3. pxxp_set_access_flags() >> 4. pxxp_get_and_clear_full() >> 5. pxxp_test_and_clear_young() >> 6. pxx_leaf() >> 7. pxx_set_huge() >> 8. pxx_(clear|mk)_savedwrite() >> 9. huge_pxxp_xxx() >> >> Cc: Andrew Morton >> Cc: Mike Rapoport >> Cc: Vineet Gupta >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Benjamin Herrenschmidt >> Cc: Paul Mackerras >> Cc: Michael Ellerman >> Cc: Heiko Carstens >> Cc: Vasily Gorbik >> Cc: Christian Borntraeger >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: Borislav Petkov >> Cc: "H. Peter Anvin" >> Cc: Kirill A. Shutemov >> Cc: Paul Walmsley >> Cc: Palmer Dabbelt >> Cc: linux-snps-arc@lists.infradead.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linuxppc-dev@lists.ozlabs.org >> Cc: linux-s390@vger.kernel.org >> Cc: linux-riscv@lists.infradead.org >> Cc: x86@kernel.org >> Cc: linux-mm@kvack.org >> Cc: linux-arch@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Suggested-by: Catalin Marinas >> Signed-off-by: Anshuman Khandual >> --- >> =C2=A0 mm/debug_vm_pgtable.c | 306 +++++++++++++++++++++++++++++++++++= +++++++ >> =C2=A0 1 file changed, 306 insertions(+) >> >> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c >> index ffa163d4c63c..e3f9f8317a98 100644 >> --- a/mm/debug_vm_pgtable.c >> +++ b/mm/debug_vm_pgtable.c >> @@ -21,6 +21,7 @@ >> =C2=A0 #include >> =C2=A0 #include >> =C2=A0 #include >> +#include >> =C2=A0 #include >> =C2=A0 #include >> =C2=A0 #include >> @@ -28,6 +29,7 @@ >> =C2=A0 #include >> =C2=A0 #include >> =C2=A0 #include >> +#include >> =C2=A0 =C2=A0 #define VMFLAGS=C2=A0=C2=A0=C2=A0 (VM_READ|VM_WRITE|VM_E= XEC) >> =C2=A0 @@ -55,6 +57,54 @@ static void __init pte_basic_tests(unsigned = long pfn, pgprot_t prot) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(pte_write(pte_wrprotect(pte_mkw= rite(pte)))); >> =C2=A0 } >> =C2=A0 +static void __init pte_advanced_tests(struct mm_struct *mm, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 st= ruct vm_area_struct *vma, pte_t *ptep, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 un= signed long pfn, unsigned long vaddr, pgprot_t prot) >=20 > Align args properly. >=20 >> +{ >> +=C2=A0=C2=A0=C2=A0 pte_t pte =3D pfn_pte(pfn, prot); >> + >> +=C2=A0=C2=A0=C2=A0 pte =3D pfn_pte(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 set_pte_at(mm, vaddr, ptep, pte); >> +=C2=A0=C2=A0=C2=A0 ptep_set_wrprotect(mm, vaddr, ptep); >> +=C2=A0=C2=A0=C2=A0 pte =3D READ_ONCE(*ptep); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(pte_write(pte)); >> + >> +=C2=A0=C2=A0=C2=A0 pte =3D pfn_pte(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 set_pte_at(mm, vaddr, ptep, pte); >> +=C2=A0=C2=A0=C2=A0 ptep_get_and_clear(mm, vaddr, ptep); >> +=C2=A0=C2=A0=C2=A0 pte =3D READ_ONCE(*ptep); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pte_none(pte)); >> + >> +=C2=A0=C2=A0=C2=A0 pte =3D pfn_pte(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 pte =3D pte_wrprotect(pte); >> +=C2=A0=C2=A0=C2=A0 pte =3D pte_mkclean(pte); >> +=C2=A0=C2=A0=C2=A0 set_pte_at(mm, vaddr, ptep, pte); >> +=C2=A0=C2=A0=C2=A0 pte =3D pte_mkwrite(pte); >> +=C2=A0=C2=A0=C2=A0 pte =3D pte_mkdirty(pte); >> +=C2=A0=C2=A0=C2=A0 ptep_set_access_flags(vma, vaddr, ptep, pte, 1); >> +=C2=A0=C2=A0=C2=A0 pte =3D READ_ONCE(*ptep); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!(pte_write(pte) && pte_dirty(pte))); >> + >> +=C2=A0=C2=A0=C2=A0 pte =3D pfn_pte(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 set_pte_at(mm, vaddr, ptep, pte); >> +=C2=A0=C2=A0=C2=A0 ptep_get_and_clear_full(mm, vaddr, ptep, 1); >> +=C2=A0=C2=A0=C2=A0 pte =3D READ_ONCE(*ptep); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pte_none(pte)); >> + >> +=C2=A0=C2=A0=C2=A0 pte =3D pte_mkyoung(pte); >> +=C2=A0=C2=A0=C2=A0 set_pte_at(mm, vaddr, ptep, pte); >> +=C2=A0=C2=A0=C2=A0 ptep_test_and_clear_young(vma, vaddr, ptep); >> +=C2=A0=C2=A0=C2=A0 pte =3D READ_ONCE(*ptep); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(pte_young(pte)); >> +} >> + >> +static void __init pte_savedwrite_tests(unsigned long pfn, pgprot_t p= rot) >> +{ >> +=C2=A0=C2=A0=C2=A0 pte_t pte =3D pfn_pte(pfn, prot); >> + >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pte_savedwrite(pte_mk_savedwrite(pte_clea= r_savedwrite(pte)))); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(pte_savedwrite(pte_clear_savedwrite(pte_mk= _savedwrite(pte)))); >> +} >> =C2=A0 #ifdef CONFIG_TRANSPARENT_HUGEPAGE >> =C2=A0 static void __init pmd_basic_tests(unsigned long pfn, pgprot_t = prot) >> =C2=A0 { >> @@ -77,6 +127,89 @@ static void __init pmd_basic_tests(unsigned long p= fn, pgprot_t prot) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(!pmd_bad(pmd_mkhuge(pmd))); >> =C2=A0 } >> =C2=A0 +static void __init pmd_advanced_tests(struct mm_struct *mm, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct vm_area_struct *vma= , pmd_t *pmdp, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long pfn, unsigne= d long vaddr, pgprot_t prot) >=20 > Align args properly >=20 >> +{ >> +=C2=A0=C2=A0=C2=A0 pmd_t pmd =3D pfn_pmd(pfn, prot); >> + >> +=C2=A0=C2=A0=C2=A0 if (!has_transparent_hugepage()) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return; >> + >> +=C2=A0=C2=A0=C2=A0 /* Align the address wrt HPAGE_PMD_SIZE */ >> +=C2=A0=C2=A0=C2=A0 vaddr =3D (vaddr & HPAGE_PMD_MASK) + HPAGE_PMD_SIZ= E; >> + >> +=C2=A0=C2=A0=C2=A0 pmd =3D pfn_pmd(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 set_pmd_at(mm, vaddr, pmdp, pmd); >> +=C2=A0=C2=A0=C2=A0 pmdp_set_wrprotect(mm, vaddr, pmdp); >> +=C2=A0=C2=A0=C2=A0 pmd =3D READ_ONCE(*pmdp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(pmd_write(pmd)); >> + >> +=C2=A0=C2=A0=C2=A0 pmd =3D pfn_pmd(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 set_pmd_at(mm, vaddr, pmdp, pmd); >> +=C2=A0=C2=A0=C2=A0 pmdp_huge_get_and_clear(mm, vaddr, pmdp); >> +=C2=A0=C2=A0=C2=A0 pmd =3D READ_ONCE(*pmdp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pmd_none(pmd)); >> + >> +=C2=A0=C2=A0=C2=A0 pmd =3D pfn_pmd(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 pmd =3D pmd_wrprotect(pmd); >> +=C2=A0=C2=A0=C2=A0 pmd =3D pmd_mkclean(pmd); >> +=C2=A0=C2=A0=C2=A0 set_pmd_at(mm, vaddr, pmdp, pmd); >> +=C2=A0=C2=A0=C2=A0 pmd =3D pmd_mkwrite(pmd); >> +=C2=A0=C2=A0=C2=A0 pmd =3D pmd_mkdirty(pmd); >> +=C2=A0=C2=A0=C2=A0 pmdp_set_access_flags(vma, vaddr, pmdp, pmd, 1); >> +=C2=A0=C2=A0=C2=A0 pmd =3D READ_ONCE(*pmdp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!(pmd_write(pmd) && pmd_dirty(pmd))); >> + >> +=C2=A0=C2=A0=C2=A0 pmd =3D pmd_mkhuge(pfn_pmd(pfn, prot)); >> +=C2=A0=C2=A0=C2=A0 set_pmd_at(mm, vaddr, pmdp, pmd); >> +=C2=A0=C2=A0=C2=A0 pmdp_huge_get_and_clear_full(vma, vaddr, pmdp, 1); >> +=C2=A0=C2=A0=C2=A0 pmd =3D READ_ONCE(*pmdp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pmd_none(pmd)); >> + >> +=C2=A0=C2=A0=C2=A0 pmd =3D pmd_mkyoung(pmd); >> +=C2=A0=C2=A0=C2=A0 set_pmd_at(mm, vaddr, pmdp, pmd); >> +=C2=A0=C2=A0=C2=A0 pmdp_test_and_clear_young(vma, vaddr, pmdp); >> +=C2=A0=C2=A0=C2=A0 pmd =3D READ_ONCE(*pmdp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(pmd_young(pmd)); >> +} >> + >> +static void __init pmd_leaf_tests(unsigned long pfn, pgprot_t prot) >> +{ >> +=C2=A0=C2=A0=C2=A0 pmd_t pmd =3D pfn_pmd(pfn, prot); >> + >> +=C2=A0=C2=A0=C2=A0 /* >> +=C2=A0=C2=A0=C2=A0=C2=A0 * PMD based THP is a leaf entry. >> +=C2=A0=C2=A0=C2=A0=C2=A0 */ >> +=C2=A0=C2=A0=C2=A0 pmd =3D pmd_mkhuge(pmd); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pmd_leaf(pmd)); >> +} >> + >> +static void __init pmd_huge_tests(pmd_t *pmdp, unsigned long pfn, pgp= rot_t prot) >> +{ >> +=C2=A0=C2=A0=C2=A0 pmd_t pmd; >> + >> +=C2=A0=C2=A0=C2=A0 if (!IS_ENABLED(CONFIG_HAVE_ARCH_HUGE_VMAP)) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return; >> +=C2=A0=C2=A0=C2=A0 /* >> +=C2=A0=C2=A0=C2=A0=C2=A0 * X86 defined pmd_set_huge() verifies that t= he given >> +=C2=A0=C2=A0=C2=A0=C2=A0 * PMD is not a populated non-leaf entry. >> +=C2=A0=C2=A0=C2=A0=C2=A0 */ >> +=C2=A0=C2=A0=C2=A0 WRITE_ONCE(*pmdp, __pmd(0)); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pmd_set_huge(pmdp, __pfn_to_phys(pfn), pr= ot)); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pmd_clear_huge(pmdp)); >> +=C2=A0=C2=A0=C2=A0 pmd =3D READ_ONCE(*pmdp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pmd_none(pmd)); >> +} >> + >> +static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t p= rot) >> +{ >> +=C2=A0=C2=A0=C2=A0 pmd_t pmd =3D pfn_pmd(pfn, prot); >> + >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pmd_savedwrite(pmd_mk_savedwrite(pmd_clea= r_savedwrite(pmd)))); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(pmd_savedwrite(pmd_clear_savedwrite(pmd_mk= _savedwrite(pmd)))); >> +} >> + >> =C2=A0 #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD >> =C2=A0 static void __init pud_basic_tests(unsigned long pfn, pgprot_t = prot) >> =C2=A0 { >> @@ -100,12 +233,115 @@ static void __init pud_basic_tests(unsigned lon= g pfn, pgprot_t prot) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(!pud_bad(pud_mkhuge(pud))); >> =C2=A0 } >> + >> +static void pud_advanced_tests(struct mm_struct *mm, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct vm_area_struct *vma= , pud_t *pudp, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long pfn, unsigne= d long vaddr, pgprot_t prot) >=20 > Align args properly >=20 >> +{ >> +=C2=A0=C2=A0=C2=A0 pud_t pud =3D pfn_pud(pfn, prot); >> + >> +=C2=A0=C2=A0=C2=A0 if (!has_transparent_hugepage()) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return; >> + >> +=C2=A0=C2=A0=C2=A0 /* Align the address wrt HPAGE_PUD_SIZE */ >> +=C2=A0=C2=A0=C2=A0 vaddr =3D (vaddr & HPAGE_PUD_MASK) + HPAGE_PUD_SIZ= E; >> + >> +=C2=A0=C2=A0=C2=A0 set_pud_at(mm, vaddr, pudp, pud); >> +=C2=A0=C2=A0=C2=A0 pudp_set_wrprotect(mm, vaddr, pudp); >> +=C2=A0=C2=A0=C2=A0 pud =3D READ_ONCE(*pudp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(pud_write(pud)); >> + >> +#ifndef __PAGETABLE_PMD_FOLDED >> +=C2=A0=C2=A0=C2=A0 pud =3D pfn_pud(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 set_pud_at(mm, vaddr, pudp, pud); >> +=C2=A0=C2=A0=C2=A0 pudp_huge_get_and_clear(mm, vaddr, pudp); >> +=C2=A0=C2=A0=C2=A0 pud =3D READ_ONCE(*pudp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pud_none(pud)); >> + >> +=C2=A0=C2=A0=C2=A0 pud =3D pfn_pud(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 set_pud_at(mm, vaddr, pudp, pud); >> +=C2=A0=C2=A0=C2=A0 pudp_huge_get_and_clear_full(mm, vaddr, pudp, 1); >> +=C2=A0=C2=A0=C2=A0 pud =3D READ_ONCE(*pudp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pud_none(pud)); >> +#endif /* __PAGETABLE_PMD_FOLDED */ >> +=C2=A0=C2=A0=C2=A0 pud =3D pfn_pud(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 pud =3D pud_wrprotect(pud); >> +=C2=A0=C2=A0=C2=A0 pud =3D pud_mkclean(pud); >> +=C2=A0=C2=A0=C2=A0 set_pud_at(mm, vaddr, pudp, pud); >> +=C2=A0=C2=A0=C2=A0 pud =3D pud_mkwrite(pud); >> +=C2=A0=C2=A0=C2=A0 pud =3D pud_mkdirty(pud); >> +=C2=A0=C2=A0=C2=A0 pudp_set_access_flags(vma, vaddr, pudp, pud, 1); >> +=C2=A0=C2=A0=C2=A0 pud =3D READ_ONCE(*pudp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!(pud_write(pud) && pud_dirty(pud))); >> + >> +=C2=A0=C2=A0=C2=A0 pud =3D pud_mkyoung(pud); >> +=C2=A0=C2=A0=C2=A0 set_pud_at(mm, vaddr, pudp, pud); >> +=C2=A0=C2=A0=C2=A0 pudp_test_and_clear_young(vma, vaddr, pudp); >> +=C2=A0=C2=A0=C2=A0 pud =3D READ_ONCE(*pudp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(pud_young(pud)); >> +} >> + >> +static void __init pud_leaf_tests(unsigned long pfn, pgprot_t prot) >> +{ >> +=C2=A0=C2=A0=C2=A0 pud_t pud =3D pfn_pud(pfn, prot); >> + >> +=C2=A0=C2=A0=C2=A0 /* >> +=C2=A0=C2=A0=C2=A0=C2=A0 * PUD based THP is a leaf entry. >> +=C2=A0=C2=A0=C2=A0=C2=A0 */ >> +=C2=A0=C2=A0=C2=A0 pud =3D pud_mkhuge(pud); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pud_leaf(pud)); >> +} >> + >> +static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgp= rot_t prot) >> +{ >> +=C2=A0=C2=A0=C2=A0 pud_t pud; >> + >> +=C2=A0=C2=A0=C2=A0 if (!IS_ENABLED(CONFIG_HAVE_ARCH_HUGE_VMAP)) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return; >> +=C2=A0=C2=A0=C2=A0 /* >> +=C2=A0=C2=A0=C2=A0=C2=A0 * X86 defined pud_set_huge() verifies that t= he given >> +=C2=A0=C2=A0=C2=A0=C2=A0 * PUD is not a populated non-leaf entry. >> +=C2=A0=C2=A0=C2=A0=C2=A0 */ >> +=C2=A0=C2=A0=C2=A0 WRITE_ONCE(*pudp, __pud(0)); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pud_set_huge(pudp, __pfn_to_phys(pfn), pr= ot)); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pud_clear_huge(pudp)); >> +=C2=A0=C2=A0=C2=A0 pud =3D READ_ONCE(*pudp); >> +=C2=A0=C2=A0=C2=A0 WARN_ON(!pud_none(pud)); >> +} >> =C2=A0 #else=C2=A0 /* !CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */ >> =C2=A0 static void __init pud_basic_tests(unsigned long pfn, pgprot_t = prot) { } >> +static void pud_advanced_tests(struct mm_struct *mm, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct vm_area_struct *vma= , pud_t *pudp, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long pfn, unsigne= d long vaddr, pgprot_t prot) >=20 > Align args properly >=20 >> +{ >> +} >> +static void __init pud_leaf_tests(unsigned long pfn, pgprot_t prot) {= } >> +static void __init pud_huge_tests(pud_t *pudp, unsigned long pfn, pgp= rot_t prot) >> +{ >> +} >> =C2=A0 #endif /* CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */ >> =C2=A0 #else=C2=A0 /* !CONFIG_TRANSPARENT_HUGEPAGE */ >> =C2=A0 static void __init pmd_basic_tests(unsigned long pfn, pgprot_t = prot) { } >> =C2=A0 static void __init pud_basic_tests(unsigned long pfn, pgprot_t = prot) { } >> +static void __init pmd_advanced_tests(struct mm_struct *mm, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct vm_area_struct *vma= , pmd_t *pmdp, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long pfn, unsigne= d long vaddr, pgprot_t prot) >=20 > Align args properly >=20 >> +{ >> +} >> +static void __init pud_advanced_tests(struct mm_struct *mm, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct vm_area_struct *vma= , pud_t *pudp, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long pfn, unsigne= d long vaddr, pgprot_t prot) >=20 > Align args properly >=20 Sure, will fix the arguments alignment in the above mentioned places.