From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 550A6C46CD2 for ; Tue, 30 Jan 2024 05:13:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A498C6B0092; Tue, 30 Jan 2024 00:13:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AA476B0093; Tue, 30 Jan 2024 00:13:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FD4F6B0099; Tue, 30 Jan 2024 00:13:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 671196B0092 for ; Tue, 30 Jan 2024 00:13:08 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CD8EC14036F for ; Tue, 30 Jan 2024 05:13:07 +0000 (UTC) X-FDA: 81734808414.09.ACE63F6 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf06.hostedemail.com (Postfix) with ESMTP id EEEAA180002 for ; Tue, 30 Jan 2024 05:13:04 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=EcYbLzxr; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.46 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706591585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=kgeDU61xpXmO9yARRomsrfS77QJfqHMvQL82d6t3wk0=; b=VyZnhb6QhKRldVuR4mvJwVBd/ejQB2Tqk1ZYMGZiv2qXkzKl7Y/hm+FB197KYJFiXetLWa BCJC7XoJSjL2yeZ38wRkCzmo0KXE0WtNp3FQOf1fX0JkFtzHpeMZaA+4mIe5q7hOuOo1nX lt+6AnkCjpYp1txdCpJGdd/tKFEOeI0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=EcYbLzxr; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf06.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.46 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706591585; a=rsa-sha256; cv=none; b=vXzmuhLWlFyrakni8DOwIH+l2m4sfAMprfX6lJwxRCH24yKAxaskWKQEkCDhmkTsAXec9H SXcSH1Ty8i8L8ngnMvd4wSE7pizDNEh/mwtb8WZCL5p+JDGA6zzANmbcYo9uOy5Io7ESP/ EVxUtvp9kx8S9ul2A3jgMcIyqqa9SNU= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-40e72a567eeso53763265e9.0 for ; Mon, 29 Jan 2024 21:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706591583; x=1707196383; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=kgeDU61xpXmO9yARRomsrfS77QJfqHMvQL82d6t3wk0=; b=EcYbLzxr3eNHWPKLpigxsD5gK1kNXV4jUaZDYnkccJNewbEOINwBU5ciriBA45rnUz JZFCglXd5TbFpM3iS/Cmy8TJLEjPHmjKETvYUwLPelZUIwqQ/DUY00gxZhut61wVmxph Xfh7cPsLNhJrUFWKTeYEpOPDamrZJO0kqfAj7mtnXuJftjX/g9vUOY47V75MY8AJNXHt 5GCaDfhwFGW0oM5zbYyZygGAKcsnj46IufMSl5MELgLoCpxRY50F4QUXmYWgiq1rh46Y SJJuIkVi+eK7qXJgQeA+X0e67Mjj/NK6kRGK+YElt2lGKf5aM3vVc/X3lxzcEeWg3HIz JQEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706591583; x=1707196383; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kgeDU61xpXmO9yARRomsrfS77QJfqHMvQL82d6t3wk0=; b=JPOkPAQNAC4mD4Wbxr1ZijaSHuyFmf5L4MeI/irBZkl5tk6/gnAHUHAx5W42fd9DU0 uVKWbHYFS+PkYsARkZuOe6X3k7Nt+6X/L4Y11hhSS9omrWVKP6If/U6Vnf/KwVY6F05r pMwEn71zFQPl1dBF00IaxNPC1Y/YsJ/LPsn3Hco2L/12FlsBbiDUCXUTtfhwI5HRcX3e 6AX5ofCBAoro+jtE2sECiPQHo2EsaAEa+M8mzDgdO9oSFg/lMHt3FdU/izcqrMMrUIwx I0rVZQpTgjA68UhH/xuxVkOcMYeUKBC4xQxWagv+3zCTrSYPZNHFf4DTxvNZYURQboxD IMJQ== X-Gm-Message-State: AOJu0YyEBw6azcN5wP4qzt6mljt5pMWRkb0TWreJzOlDsmihgVMNTlWy KNWYh4XE6T3M8N8kp3ogppqN9bErs6M7NP3ELLYyg12HEyPLHNuU1hmGnNraXUI= X-Google-Smtp-Source: AGHT+IEWywyF/XrrWi7Mz9vD7AK2hoDQAcOwEQjixZKeoSfeXBjBDZvimd+by4z7GcPqn9/zBswmoQ== X-Received: by 2002:a05:600c:3ba7:b0:40e:f161:bf10 with SMTP id n39-20020a05600c3ba700b0040ef161bf10mr5828652wms.16.1706591583404; Mon, 29 Jan 2024 21:13:03 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id c11-20020a05600c0a4b00b0040ebf603a89sm15486103wmq.11.2024.01.29.21.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 21:13:03 -0800 (PST) Date: Tue, 30 Jan 2024 08:13:00 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Suren Baghdasaryan Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Subject: [linux-next:master 2565/2825] mm/userfaultfd.c:983 move_zeropage_pte() warn: inconsistent returns 'dst_ptl'. Message-ID: <1a42e4fc-54a0-49f1-94ba-f075e0ef29a8@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EEEAA180002 X-Stat-Signature: 3kc87eqkiby6c9ww6honjgireb7zicfs X-Rspam-User: X-HE-Tag: 1706591584-690739 X-HE-Meta: U2FsdGVkX1+PuWUhg8cPIFtuKSmcv8QDgCpUfFF/IE/3vrPHsQ8XGD+WgP92/gTqM95392MMxegfSwtlyUXd/5Rh022MrG7uTBvbUijmdpE7xgECRrD1KRM02KW6R8EQXqsVql5NGuYN/hIUcWfsUFbX4oeFRfKb2v1Mk6SWwkEYsjvl01PfosqwxrsYSdg866J/+dHx4nD6gNG5PtShozPlDmhXOfHee8bMNQAVD3jUul9TPlkbK8r/BZDKnRwWN+QRamh+JChun70zIxJ0r6ARBYvugxjwltut3F9JvoabZGclye26VL8L0LIIUGuSe2LEBEH1ZWVhYmKE6Wlc4lha6LerlddoTGnXS0usJAqOvmOKS7oCcxyGfzpcFIKBOOf7Z2pC/GztYPvh6CtobrIlHJcVirFTVJFhy38uAjkHaxvayuVkCGWmkyu5HwJwdgTgEqWemCFx6M1Ks4nj7ltWcSJC6yuwyoChzcSYY3CPE4GdZXmytQVYqn0kASVwvgMIoVoG04F7Y56TD1gHvYJyDrL4gOiw/tL9w7PVDmlWwkYusHVLoyhvwZfdoWFqZC0i4u8BAFItmbhdVQ+vaOn52KYCxcpmXI9N+AdyVwwQ92yuXv58c8wVtKFPE/Ijv6YrOEFXnHhOBJVzgAg/L1U7y6Zq4kT8wi/qNAWyA3T4CtECnyt28acq2iIPAnOptE1Dmr8/6mZzYPW4yL7lJ6AI14GOEmB5Df65ySQOAQX/S7wAy/EcOGHrmk+0ktPx9yBIR9mB0H4SttPrLvlbRHElhf8DDroLz/HerA8eQvAiMikK0Lrq+grhmqrv3uGDJhICdE27hFzPEB7JbgXto32fugbHE9zycdTelagvV4/riGtDz+P/ZbXLZ48I3Afg2tUiCnDNCifCkKd5t7yjOkcOneYFImB5hezHUnr9oYPOlthLFp/uhWBnz/133ZV8JZ4wVWkcGiYMlmlRGkE qdB9Vi8h 2C54UA3TKgVSSgsFgeBYljbrzZPe0auZgAhoPJSBMmBqwEd/0P4rGZr388YtuuSiK8AWQ0Tuzg9lqTr4YkZEkIuwmGk105804S+p8Lrsd+8LUrRAV4lnzbE6PmEnumq2S0Z+i/8UpGOanEpJwVW5JrMa5N4b9BYJdaRmdt9MIdMygHhRy6N4bEikPD6eVBiYy1aZtmIlYgcajWkg+Zc1Ag1dLocXf9LZ4TGxA79O8HgU91+NZ9wVdFPjN8uTcDlvdC0IBjHcxpQNsA9Fw018kAhKkICgO+6bZAvPejZ6pEHqqjfkUZMG9bxqbROuzvCps+CzQIo2UiCF6Rw3DAfus2nQwh45bdrFLAjINAJli4KAj5L/b5H7gp1mejR58QYaeA7UH2Nz7HVbW4KkySqbgjaF+eGTspea2pnrjHRdCnMSGMGK6CiQDFhaKNyvCK8NCLIVfNbeWZUrFG+D3PYjHzsglpt/jmCZKax8eSD0GS62T1gj/263u8rFe7WqFKvF46T9dVVUEcPUKCLZhK7GMufdUYz1U5ajeH9glpKR4lu1pSiQ8xu3jJy0DoaFlP3R95VwA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 596764183be8ebb13352b281a442a1f1151c9b06 commit: ea4df6a5ea81105879ca5549555e231c4596fbc4 [2565/2825] userfaultfd: handle zeropage moves by UFFDIO_MOVE config: x86_64-randconfig-161-20240129 (https://download.01.org/0day-ci/archive/20240130/202401300107.U8iMAkTl-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202401300107.U8iMAkTl-lkp@intel.com/ smatch warnings: mm/userfaultfd.c:983 move_zeropage_pte() warn: inconsistent returns 'dst_ptl'. vim +/dst_ptl +983 mm/userfaultfd.c ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 962 static int move_zeropage_pte(struct mm_struct *mm, ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 963 struct vm_area_struct *dst_vma, ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 964 struct vm_area_struct *src_vma, ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 965 unsigned long dst_addr, unsigned long src_addr, ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 966 pte_t *dst_pte, pte_t *src_pte, ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 967 pte_t orig_dst_pte, pte_t orig_src_pte, ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 968 spinlock_t *dst_ptl, spinlock_t *src_ptl) ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 969 { ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 970 pte_t zero_pte; ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 971 ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 972 double_pt_lock(dst_ptl, src_ptl); ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 973 if (!pte_same(ptep_get(src_pte), orig_src_pte) || ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 974 !pte_same(ptep_get(dst_pte), orig_dst_pte)) ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 975 return -EAGAIN; double_pt_unlock(dst_ptl, src_ptl) before returning? ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 976 ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 977 zero_pte = pte_mkspecial(pfn_pte(my_zero_pfn(dst_addr), ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 978 dst_vma->vm_page_prot)); ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 979 ptep_clear_flush(src_vma, src_addr, src_pte); ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 980 set_pte_at(mm, dst_addr, dst_pte, zero_pte); ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 981 double_pt_unlock(dst_ptl, src_ptl); ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 982 ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 @983 return 0; ea4df6a5ea8110 Suren Baghdasaryan 2024-01-24 984 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki