From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26406C4345F for ; Tue, 30 Apr 2024 11:58:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 697456B007B; Tue, 30 Apr 2024 07:58:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6456A6B0083; Tue, 30 Apr 2024 07:58:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E6086B0085; Tue, 30 Apr 2024 07:58:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 31F636B007B for ; Tue, 30 Apr 2024 07:58:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BC2AEC06E4 for ; Tue, 30 Apr 2024 11:58:05 +0000 (UTC) X-FDA: 82066049730.23.CD95900 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf13.hostedemail.com (Postfix) with ESMTP id 7E30D20002 for ; Tue, 30 Apr 2024 11:58:03 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZxCoCfN1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9PlC4dB+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZxCoCfN1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9PlC4dB+; dmarc=none; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714478283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=la5CF5OAx7+cqHrbFJp6N7G39/wD+FkDOJjA/zkUEu0=; b=y6VlRt+nsfMXEzkNu+itqlXJg1N+7xK4fIPPzhUgCFZOuvWNYW+fnoKyJ4dJEwzHZtnNH8 cXCn9Tm1uSeb/iAjChF5guOqL7wPoeZSUgJCxHiFMQGT5SYyISl7QHTIbAwEMEUcQrBTde sN3Mg/XDQSkqRYOb8323GncOzUxIB5A= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZxCoCfN1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9PlC4dB+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZxCoCfN1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9PlC4dB+; dmarc=none; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714478283; a=rsa-sha256; cv=none; b=QOzZ6ZmXGE3LHcLxl+q924IdYuwXyVn9aqxEQKeFupyb4KnpyCrYtc4uYPDbQ0I+VXEsom ZAEyQHmE2Yro4nrfKTFTua2ZWW9OtHKEP6/TVp9D6PTvCKZ9FmuqVoBQd8KTlqXeHZVRup AgK6lUTMvUJaEz3mLFfeqw24v14DKmM= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 731BA1F7B4; Tue, 30 Apr 2024 11:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1714478281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=la5CF5OAx7+cqHrbFJp6N7G39/wD+FkDOJjA/zkUEu0=; b=ZxCoCfN1XYrktw6evJehl5Zk6+c5bd63Wk52UaI3sbHPeXzUnp/dac/SGp/zHRK/u5WpUo QgBOih1HTTrwdlSTAgTr0MWJ3MgXmd4xvnprNRxFQMIMHs313oLEc4KaWsYz/nvpLLf1dc gB92UAfa+ONLsb4d7viZEp2t0KEXcMU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1714478281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=la5CF5OAx7+cqHrbFJp6N7G39/wD+FkDOJjA/zkUEu0=; b=9PlC4dB+oTcG0Vvh8S7u+cMvfHgvJfV0X8V/5+1QUBv0kobXpnmtceedYV+4+dWoQt2g0J /7ctlyh6PGpOibBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1714478281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=la5CF5OAx7+cqHrbFJp6N7G39/wD+FkDOJjA/zkUEu0=; b=ZxCoCfN1XYrktw6evJehl5Zk6+c5bd63Wk52UaI3sbHPeXzUnp/dac/SGp/zHRK/u5WpUo QgBOih1HTTrwdlSTAgTr0MWJ3MgXmd4xvnprNRxFQMIMHs313oLEc4KaWsYz/nvpLLf1dc gB92UAfa+ONLsb4d7viZEp2t0KEXcMU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1714478281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=la5CF5OAx7+cqHrbFJp6N7G39/wD+FkDOJjA/zkUEu0=; b=9PlC4dB+oTcG0Vvh8S7u+cMvfHgvJfV0X8V/5+1QUBv0kobXpnmtceedYV+4+dWoQt2g0J /7ctlyh6PGpOibBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5B78A133A7; Tue, 30 Apr 2024 11:58:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id anXxFcncMGanEwAAD6G6ig (envelope-from ); Tue, 30 Apr 2024 11:58:01 +0000 Message-ID: <1a2e8da7-6969-43ac-9e65-2361c93d107f@suse.cz> Date: Tue, 30 Apr 2024 13:58:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] slub: Fixes freepointer encoding for single free Content-Language: en-US To: Nicolas Bouchinet , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Chengming Zhou , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7E30D20002 X-Stat-Signature: p7kr78jw4jpj4o5kdbc7fciaptczoed3 X-Rspam-User: X-HE-Tag: 1714478283-296197 X-HE-Meta: U2FsdGVkX18Z9ZH+ozvuHkFNA9314TKf1xL6CxOK9t340AFuIn/phUHw6Oqx012A1qPD9r+ZPIW3zIA/d9xPkHPjJeDWplNmuCZIWhG0lJP3me7BD9S9NdOw/rCE59/57O2I4cud768jUmyg8o0MsZqzTphqmQl6QO+1J8HsHyhFibSREEkOPzqI1J4u0YVHMdmA0KhxQnuAETMhAkE5jNj4VgPFe0LRbJylUFJLExCxGhsJstrACRjp0cd4Y9j4ycRejxgEJAjFhbyWa/UcW/nGayMglyykF+JAON8SagOEw4bz26kT7ceFMsakwQ5B8ftTo6ecz7WYDzxpx4IH2l0FSYQSwhjpgm1XHg5iTNQ+bizkH9Ma5uiU1Sjlv16up6Jlnly3aQ9qZEHk8K7vWk+FMCszLO22zghh+Ccfk5Vt3LAZ+PWniQIuXt2oqHzX8yRaFUzfL5vo2/+mSG9Iox0G8mT+1Q03A2LIKbj2m7Sc2MxX+ov1gFXW3I7Z5a9YlPYbYWWRp9faUWK3qGRShMR5DHH+nOzTunCJgmPGY6kfTaxeqQAMxBmGIaBNhsW3HBJdiSzFacUnvgoyY17sGuGLpG6RqrdBPBlugF0XAXBukUS9PaEZPS2ZtS0DNWIDdlD94mc9YZyoOB73om4Wg6/xC3mZPxIH2jvd2aSuXDusQmg3doCPGujjyljwCfWZKzNEPahY+b/fYpE08l8Ke2IdU9WvfUdtcdiXkMAlZ1YEpQFJICfP7upf9XB1lIAFlYRDxWvvqL/4sh8LzNmz1VJPuokb5iNry4XgIrr3hc/UmAu1kgQRSnveUpTvr8hS4kNKMefpKk84cG63UjXK+oH/G7QvoLsnLS6lpxW4cV1ZhiB9CCA8FtWnXtpbFapFFDCEDLk/tFjI5p+NspmI1jyq2kZNfby5WFNTHdF/6yk6MQwcY4eiw9Qe9E/ac1PwNdZuidCOTyGu5NoSKl4 tr5NN8gG ADgr37LvfHJERUU1nipFP5Ng3McE+1PSXehoz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/30/24 1:34 PM, Nicolas Bouchinet wrote: > From: Nicolas Bouchinet > > Commit 284f17ac13fe ("mm/slub: handle bulk and single object freeing > separately") splits single and bulk object freeing in two functions > slab_free() and slab_free_bulk() which leads slab_free() to call > slab_free_hook() directly instead of slab_free_freelist_hook(). > > If `init_on_free` is set, slab_free_hook() zeroes the object. > Afterward, if `slub_debug=F` and `CONFIG_SLAB_FREELIST_HARDENED` are > set, the do_slab_free() slowpath executes freelist consistency > checks and try to decode a zeroed freepointer which leads to a > "Freepointer corrupt" detection in check_object(). > > During bulk free, slab_free_freelist_hook() isn't affected as it always > sets it objects freepointer using set_freepointer() to maintain its > reconstructed freelist after `init_on_free`. > > For single free, object's freepointer thus needs to be avoided when > stored outside the object if `init_on_free` is set. The freepointer left > as is, check_object() may later detect an invalid pointer value due to > objects overflow. > > To reproduce, set `slub_debug=FU init_on_free=1 log_level=7` on the > command line of a kernel build with `CONFIG_SLAB_FREELIST_HARDENED=y`. > > dmesg sample log: > [ 10.708715] ============================================================================= > [ 10.710323] BUG kmalloc-rnd-05-32 (Tainted: G B T ): Freepointer corrupt > [ 10.712695] ----------------------------------------------------------------------------- > [ 10.712695] > [ 10.712695] Slab 0xffffd8bdc400d580 objects=32 used=4 fp=0xffff9d9a80356f80 flags=0x200000000000a00(workingset|slab|node=0|zone=2) > [ 10.716698] Object 0xffff9d9a80356600 @offset=1536 fp=0x7ee4f480ce0ecd7c > [ 10.716698] > [ 10.716698] Bytes b4 ffff9d9a803565f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > [ 10.720703] Object ffff9d9a80356600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > [ 10.720703] Object ffff9d9a80356610: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > [ 10.724696] Padding ffff9d9a8035666c: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > [ 10.724696] Padding ffff9d9a8035667c: 00 00 00 00 .... > [ 10.724696] FIX kmalloc-rnd-05-32: Object at 0xffff9d9a80356600 not freed > > Co-developed-by: Chengming Zhou Chengming Zhou, could you provide your s-o-b please? > Signed-off-by: Nicolas Bouchinet Added to slab/for-6.9-rc7/fixes, thanks!