From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA63C433FE for ; Thu, 11 Nov 2021 15:44:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A15A36113A for ; Thu, 11 Nov 2021 15:44:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A15A36113A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B8E076B006C; Thu, 11 Nov 2021 10:44:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B3E356B0071; Thu, 11 Nov 2021 10:44:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2D4D6B0072; Thu, 11 Nov 2021 10:44:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 93D7A6B006C for ; Thu, 11 Nov 2021 10:44:32 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4E74918132D1F for ; Thu, 11 Nov 2021 15:44:32 +0000 (UTC) X-FDA: 78797071584.11.373C996 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by imf15.hostedemail.com (Postfix) with ESMTP id 24CD9D0000B2 for ; Thu, 11 Nov 2021 15:44:16 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R361e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0Uw3iC5R_1636645462; Received: from B-X3VXMD6M-2058.lan(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0Uw3iC5R_1636645462) by smtp.aliyun-inc.com(127.0.0.1); Thu, 11 Nov 2021 23:44:22 +0800 From: Xin Hao Reply-To: xhao@linux.alibaba.com Subject: Re: [PATCH V2 0/4] mm/damon: Do some small changes To: SeongJae Park Cc: sjpark@amazon.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20211111092440.11576-1-sj@kernel.org> Message-ID: <1a2e1816-70d1-c463-9133-eeb8108daac1@linux.alibaba.com> Date: Thu, 11 Nov 2021 23:44:18 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211111092440.11576-1-sj@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 24CD9D0000B2 X-Stat-Signature: bjydfoeyto8geadeeapg63kxf11e5acn Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf15.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.54 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com X-HE-Tag: 1636645456-730535 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Park: On 2021/11/11 =E4=B8=8B=E5=8D=885:24, SeongJae Park wrote: > Hello Xin, > > On Thu, 11 Nov 2021 14:07:00 +0800 Xin Hao wro= te: > >> These four patches are mainly to do some small changes. >> >> V1 -> V2 >> Add reviewed by SeongJae Park >> Add two new patches >> V1: >> https://lore.kernel.org/linux-mm/cover.1636546262.git.xhao@linux.aliba= ba.com/ >> >> >> Xin Hao (4): >> mm/damon: Unified access_check function naming rules >> mm/damon: Add 'age' of region tracepoint support >> mm/damon/core: Using function abs() instead of diff_of() >> mm/damon: Remove some no need func definitions in damon.h file > Overall, all patches looks good to me, though I asked[1] a trivial chan= ge in > the commit message of the second patch. Ok,=C2=A0 I will add a detail message to explain it in commit in my next=20 patch, thanks. > > Also, I found one interesting thing. It seems you are wrapping body of= the > commit messages at <75 columns[2]? That's obviously neither a problem,= nor > even trivial nit. But... I'd prefer the messages look more consistent = with > others. Thank you very much for your careful correction,=C2=A0 I will fix it in m= y=20 next patch too. > > [1] https://lore.kernel.org/linux-mm/20211111082034.13323-1-sj@kernel.o= rg/ > [2] https://docs.kernel.org/process/submitting-patches.html?highlight=3D= 75#the-canonical-patch-format > > > Thanks, > SJ > >> include/linux/damon.h | 25 ++----------------------- >> include/trace/events/damon.h | 7 +++++-- >> mm/damon/core.c | 6 ++---- >> mm/damon/vaddr.c | 8 ++++---- >> 4 files changed, 13 insertions(+), 33 deletions(-) >> >> -- >> 2.31.0 --=20 Best Regards! Xin Hao