From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F067FC6FD1F for ; Tue, 26 Mar 2024 10:06:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DA4B6B0093; Tue, 26 Mar 2024 06:06:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 762826B0095; Tue, 26 Mar 2024 06:06:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F30E6B0096; Tue, 26 Mar 2024 06:06:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3CB6B6B0093 for ; Tue, 26 Mar 2024 06:06:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 19BF51A0991 for ; Tue, 26 Mar 2024 10:06:50 +0000 (UTC) X-FDA: 81938761380.25.125AAC6 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2119.outbound.protection.outlook.com [40.107.220.119]) by imf10.hostedemail.com (Postfix) with ESMTP id 2A52FC0003 for ; Tue, 26 Mar 2024 10:06:46 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=zoTbS1Em; spf=pass (imf10.hostedemail.com: domain of Vignesh.Balasubrmanian@amd.com designates 40.107.220.119 as permitted sender) smtp.mailfrom=Vignesh.Balasubrmanian@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1711447607; a=rsa-sha256; cv=pass; b=8fiVFmtRL/YkhFTpUZ2CgWzonwt+yMaJ2SGnggGa1BF2WcrPvhUSosJl5fUGBy4jh3mU1B Z+1kmAMMnq5SalSVlk9I26UNp49OKp/SNzDAo67AeWTBgC8QX6XYqB+lkhGl0CKa70v5yP p4sRNncCkwrtWjrs/oF3iBKYWktzs5E= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=zoTbS1Em; spf=pass (imf10.hostedemail.com: domain of Vignesh.Balasubrmanian@amd.com designates 40.107.220.119 as permitted sender) smtp.mailfrom=Vignesh.Balasubrmanian@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711447607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kCZcqiQX/KGmjB7Thv3ntO08cG61XMpTYWhL49fL5hY=; b=KVu6CRwvTS6C7Vr6KyjJxH+Fhf11JlVkOcRUZNXVGHNZRiRzDkf755mzcst8tlMQEVKt1/ L3IMER4PTjejKVvl5egKiaF6xLneRolZ4K8e0MKxbcfecJYkizjAUnHApWF1gQTZZRGW3N XR7/UDEZWNadiH1Ktx1C9NWz1KtgxKk= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PlHJlrfEMvuWzHDlOrmpMjiG80/dBj2Ht8Xym6E2Ld2yAMnzCpGUivo0skYFrxKIVajcPTkfd34gNlN3SjwupNXbviIn9wKvl3qgzs4+LL6z0UUZS7IuY8A3muZj7F3pHOpPl1AqTJnWE8k4emYrL9zBxhTS5R7JWAIah5vPccC5KEv6MonZdZMtlE/URwYyHsE38oLMVvwcusZUUso69sFos9VnnhfiHGF6aRajGE+HVkksGax0E26xqYwBi9YGFTZD+n9MhI8sgDCmekvcL8l4tGsMvjHVBSREh4tFuWEdwb9+pb98E/WqAAZaabMWSJe2yKrG1934qokoSRIEow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kCZcqiQX/KGmjB7Thv3ntO08cG61XMpTYWhL49fL5hY=; b=iBY7dc+FUynsnHTVl+rLa6LygvqI7+ObJ0VMcp72+IV9ar2FsUUbEMHWRZeKwCkznATcOLao2Prk3/mZ8knncF/h1dAtJI1pVXwRgSF9YXF3yEYLWp1YIYE9E6AMezkvlnOhYhvFgYtW5MaOb6vJGjz3XgESZYPxYE01qNLxXvGtg84sVmS6d60Q8ryS7ZwwcceGW6De4FSZEBXYV6J5YoWd+I5lrwckAEGiVntuN9JdHLRQEWX8T8HYdnjWL4MPhYlF+uKZaSS5blk3obiOKt6oy9Rj45JiGMuXhDBr+2k91vwOwu7bGyPr2GrsmG0329bNDg9PkPUA87sEfWeByg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kCZcqiQX/KGmjB7Thv3ntO08cG61XMpTYWhL49fL5hY=; b=zoTbS1EmCZWFpacyEWlWDnoAVBokGX22BaFND4t8am+ZbA9YkmQkfW4OV1qc8XLbepe+088vA1FJbts3iDUdsgaKppYCR5d/58obqgiJ/PyiTI3TqASIdmZkqj1RTLZ+OxVl3eZEPVDzhyHN9QfjH+b0sH1a+c1DK5jvtIaGrpc= Received: from SJ1PR12MB6124.namprd12.prod.outlook.com (2603:10b6:a03:459::15) by IA1PR12MB8555.namprd12.prod.outlook.com (2603:10b6:208:44f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Tue, 26 Mar 2024 10:06:41 +0000 Received: from SJ1PR12MB6124.namprd12.prod.outlook.com ([fe80::c2c5:a349:ed66:b28]) by SJ1PR12MB6124.namprd12.prod.outlook.com ([fe80::c2c5:a349:ed66:b28%7]) with mapi id 15.20.7409.031; Tue, 26 Mar 2024 10:06:41 +0000 Message-ID: <1a2b604e-6e1b-4da9-ac2f-e2f2c80054ce@amd.com> Date: Tue, 26 Mar 2024 15:36:31 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files Content-Language: en-US To: Kees Cook , "Balasubrmanian, Vignesh" Cc: "linux-kernel@vger.kernel.org" , "linux-toolchains@vger.kernel.org" , "mpe@ellerman.id.au" , "npiggin@gmail.com" , "christophe.leroy@csgroup.eu" , "aneesh.kumar@kernel.org" , "naveen.n.rao@linux.ibm.com" , "ebiederm@xmission.com" , "x86@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-mm@kvack.org" , "Petkov, Borislav" , "George, Jini Susan" , "matz@suse.de" , "binutils@sourceware.org" , "jhb@freebsd.org" , "felix.willgerodt@intel.com" References: <20240314112359.50713-1-vigbalas@amd.com> <20240314112359.50713-2-vigbalas@amd.com> <202403140850.5659C0F4@keescook> From: "Balasubrmanian, Vignesh" In-Reply-To: <202403140850.5659C0F4@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0245.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:21a::10) To SJ1PR12MB6124.namprd12.prod.outlook.com (2603:10b6:a03:459::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PR12MB6124:EE_|IA1PR12MB8555:EE_ X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iZJumW9HgAFn9PMKdUDpo5la0RLXOjBVx6tsFP43BBsgUHkQr6KGrdvO3svbamTvTisdv0A3zH9d9di3vw2qFGGQRQWp92yaEIcK2MyuABNIanc/DZ7chVBxAjgyg4SRFcltOwPWVxbqDo3bWCa5bkoDH85jHF5cYY2LVv0P+Fzd8GZ1hG912F6Y27dGw5kXxLyN+a2ZWN99CwNIdXnsPlBGAS1QvcZslCTKw93qUna2kGAkvLGpAYQtErT0j2CaOIoEXpTUgQuFrYCq+V0dCU8fNQfLTrmU7oGqmZIkygEZaHSegsvvrLQ9LOWm/HjpGizCnhdYZgp9pZwiHr66PCdbPX3l6H9NpYtNlRslIm8RoPmfRY6B+ekEtdQp/MlWRUDnT0U8OxYdRgqrJ8/CLrpTvpGsN1QtrnnXx6s/XIr98XsLnqkfsd27hkfNjfxNi6EoV4ABjWs+prJfX1QVduxFOLABJCg2avE2tlJX1UGN/Tyx9JC2YHiY7QbBdq+5FKJRGgfK53M6mkWcblgYd0mDg6d23gGAkUlHU2U7VQ89/Gn/c5OAJNGBuNvZm0QZbYcAUm4KgCCeIihHygztUDD2H3zhvT6VljsRKWEnwRFz1V7auxQKBEbKBARFep88gJ/FjaS+1kbqUthaM+crjKO5kczHkgrdiH7kzQU50EA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ1PR12MB6124.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(7416005)(1800799015)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amlUNjFXNzJ3b1JHbk0ya1NSNjVHRVROR2FNc0pyT1c5QVh0Ky82clhLc1lQ?= =?utf-8?B?d1Q1Z05ITHlyQVhMVFJoUWNxdHlxUDluYk8vU1htd0g0TE41WkdFWHpTV3Bl?= =?utf-8?B?bURZclB0b3MvbWl0bmQ4cldPZ2Q4RDZUc3BQa2IyaHVTUXh3L2owbVJPTXN4?= =?utf-8?B?ZVlkaHZ3cUV3T1kvTjNaRUlRVExSazNiS09wZFBnWHlETGw3OVJCRUd3ak82?= =?utf-8?B?U0NsVFRNdDVEczJVeGY1b21xeEhxVDdUZHVoMjBrcGtrMkZSbEo5TU5RaVBR?= =?utf-8?B?bTNqUThQVVpvMkxkcHBYQ21nV2RNOXZqVUNuaU5JaUFiZTBvYzhnSElkT1lN?= =?utf-8?B?dFlpRU5sZUlJTE1BSGtxbWs4ZjhldU5MSzhNVWMzNEJMaFdxZW9lc3kxZWJD?= =?utf-8?B?aG84UzZ3ZVJpMzEyNEU3Sm5wT0xwQktaSTZhdHVuTEdEZzJMcXEvSkpnbHR2?= =?utf-8?B?Q2M1cE03T0JFSHNYRVFweDB3em5KWXIrK0tVT0JSK0ZLaXg4QnlpREhubzM0?= =?utf-8?B?SVhSVUZKODR3dC9OWi9vMG5sL2JBNlVDSFlXUnJaUGk2bUpWRmRnMFJpeFZG?= =?utf-8?B?R2JHQ3RmaVVGSlZlUWNSdGwwVUM2ZUtOWHVGcytLWWxBdnZUOElvN2g1dUZR?= =?utf-8?B?L1ZuWm1kYnlieUljSmJpdGtiWEdrWkx0VlFtci9MWUh4NkxWL0lwdjhDY2ZY?= =?utf-8?B?UTk0TTB2ekxhQ1FNamx4Vm5MM0VQV3hwUGJQc0pZL3Y2N3lqeitIbFRRem5F?= =?utf-8?B?dmdNUkF3WElZaGVjUHc5b2kxT2FYU0ZzbE05U2lFUjVzUG5IOHd1dUVHcklB?= =?utf-8?B?WkIyZDI0K1g2SlJhUHBjK3o1QmN5UUxtWHdrdWdwMk1vb2Z1cUxHQXE5OHVX?= =?utf-8?B?S0F2VnREZzRyS2ZaWFhEUGN5RlE3a3NRRGtUVW5BNi9FZzBZYTFuVDhMUFlF?= =?utf-8?B?anJ0bzQ5ZFgyN2tjTFpsRXhhVGROaUpVdkd1dnVzMEw1dE9ZUC9CblhPZ01y?= =?utf-8?B?d3ZIZnpiU3BTNm1FNFZrcGtmMGpFYno4R0M2R1d0QkVGM3NVTVN2N1haUXhj?= =?utf-8?B?ekYvWTVLUjEyZzNYclcyRjFnbjAwanZLbWtrZTJaMHRlWjQ0LzV1eFd1aVh2?= =?utf-8?B?dm9WQWs3dFMzYlVRTjVUTTZ6YjNUL0ViMnRFR3FlRERvRGdDa0FjQ0Zybktx?= =?utf-8?B?SndOKzNWTytKY0h4WVp6QkIzRk5GUW5YalRlQ0Q3Ymk1eVk3bDd1MmdPc3Y0?= =?utf-8?B?MG9XZGpGQ3R1UUpKbXhHQnRwMFdnVlJkeW9rTFRIK2QvNkhJeHVSN3F1ai9H?= =?utf-8?B?QkdhbGNwY3o1S3FHT0x6aVE0azNiV1RTYTBxaHIyVkxOQTRnRXZtT05IWXdq?= =?utf-8?B?Z3FMbjFCVUpmQ2xKWmhndE9JMVU2VkNwVHpBMVBnK3VQUEJjenNyTWx6Tm5H?= =?utf-8?B?TmxvUnJEakJ6Umw1em9CS1UwYUZnWFlpSEFtWGV0eUg4ZnJVSDVvUjRmZnQ5?= =?utf-8?B?c1dES05aeExxTjJrRjYvUVFjem94RDJ0TDJybzdTZ2g0RnllZFFzU0RNQXU0?= =?utf-8?B?ZjVJbWRXRFk5U1Yyb0tNblMxQ1JqWXJ2REtaZnFaVXBUVnNHejl0VjdZZGRZ?= =?utf-8?B?UDJWeHgrVUJNeGwxV0NaMTIvbnNLTU8zVVFPTnM2dXYrcEZLSHRoNThjVXdn?= =?utf-8?B?RmFEd2JDeTc5V3VwbE50S2kxekgzK3BoMUJQRGowN28vRW1HK0tGb1M3eFJI?= =?utf-8?B?NzREZEpHMnJuT1h4VjFYYVlDQ1Q5d1BXM1NTZy9ZY3RaL3oyVjc0ZXJJQVBF?= =?utf-8?B?ZFR3TzJHTEdHZUxzd1ZPSXJBcFRFVDdhT0NUcTBmaXVKc3UvTHhJWVZLQStD?= =?utf-8?B?MWVBWFA0U0dQTEw5Mi9YeXpJTVJiN2p5eFJCcHJ6QmFjdEFNTlhhTndrNnc5?= =?utf-8?B?SWNaSi9DcUVCUUFqOFN3dVFmL1Q0aTFRR3pkd2JPZ21qSDBxbTRoRDBRTlQ5?= =?utf-8?B?eGtDd0J6Q3VwZldzSlV0VkNYMTZraUF5Sk5kZU5OcVBSa0wyTE1NSzN0MVEy?= =?utf-8?B?d3h3L2R2dENkWXkwc3k5MTNPVFZkaXZnSlJZM1pCMGpXTTRheXNsYTNFOTNV?= =?utf-8?Q?PlXID0VRltIjHWIdRgRzUWh2n?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88c1d0fd-4728-45ce-2f7f-08dc4d7c6ea0 X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6124.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 10:06:41.0119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wgiD5X4SumZXyZv/PAUOXuuBwqnrLhGgQ/B8J4NVt7TzRBQA+Rc4JVRm/4LhcnclEB+3QSPVJ2nlXmkz18DTIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8555 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2A52FC0003 X-Stat-Signature: it7kcoo3iqg9mxmehte353jt7s519qkk X-Rspam-User: X-HE-Tag: 1711447606-547410 X-HE-Meta: U2FsdGVkX1/3NdH9FMho1n7PP+x1CwFE17g987kBASGMWhKL66ji7kBuuNGWHTEBhVWbNdwHwH+OnACOistG+9b5oA5ztZcQJB+pxXgqmmJBWOX97GZwhQ9xbvTUA1dcDeyviCVRkZlkVpOVYF4sFEXgYuUamVPA6vwFKaOCssgtiDdU1X0LY9LADI6oe2hIgrBzjDZpVSL+9vmnoYLlG3w44a23MUHi/j5y6ggeUBtA8I6U1iWa7IV7pGyS4i8xpqoAEEPY4f8hj6+ejlXBAa/LmCz3VAt78Vw2YrmhOjVJdrGtFN9/y1EV2B3W47X8Mt+LImyy85mUlYMktbXAV42r+MkklDIpsm9zf0TOZb9E3KJaM+t9DtX68Q1cSm0zSOchbNBf5058X0vakkM5T+27gTqUkTl2i5287AQ1AzfcylsGxCFRDkR4ks4RFxYUoucXN78ZkyXsIUvgUfVyT5iaRcOlQVoQIEZtxd0iYi6z6JFnFm8+AxKuCqqv+53HHuT1ZyWhNbh4dIZb2gOWxq/XwaxDLq0V+m6De13/1P3CQUIvXCNW1eAfGaxxP53K/E53CMoHxJqNRXmVfKG968zH9nPf/IV7gTR8H6w9btbXTa3KBY39k+8pcN00TwGIlrHQLD7+B0HJ7pf9bcHsz/7ryQqmT4L3k492lHyJkSw+iJH65njiANJHlLN8fqZFbqJwGxpzbZncSu58h9JLDN3EbzJoKek/xxWk2FAiuVGwtBS4vz3Hf8FsNkkW5IzPX92etGpkM1qrshGH3QUcQd8xYObZbXpkUl8ppxIqjWW/PIi1P42Ox0/nFQdrGjo9iXds8MIgdTUBOfm9cuQLCypQScjnAL+MAZ/+i63j0qE1003nMhflcSiNmjYmg44SaDH68yNMx5ajrg2hHReFo1c76eArRif9DJJmT9ZL4sQzUms4fssjC/6kFL4J8onWS8mS1jA4IV3pZjRNuFo +1TDVwaE ULfrnPoe7qNioqkJev1NYYK9oihUL8TLr8NqnhYf2CtTFzRTbvdfPG6UXzgFksWzmdMx+R7Nx7UqXGEtTwIPrdUa8rtFFhY66TGIKtJe+outRCFm4YeNhEM8+KGHU4UhTncDeK4HQA/5hR72dkQ7W2DbkwTCGuzzSivrAmLf+8t3KrFtBrZuEw8uMu0zAshefUULCI5fJ88umXH9mKmdmrLfb2lf9gsAXviG1VY30dJZsoVWpWnd51eTj8FTs+TNxusCRAIIvU+iiBhuCeV9+0Qy8TvSzoHyVTENLVqu809eErFbdu+ByDPCxE3gVctuWCoDoLVIineAkEXMpmpV8kEgxwiqw1xyEAROL9+KZNKtGFhFEMTYsbYm2Pg+aUV0ewycOKKNm38XmWYix24pfbfYuuKS5mwzCbmkegKbSgBw7sTUjFWvpNnu7DOY5KEgjmNUl/UEL6AL/dV5gut0MQ97gu4q5YTUp/Hdo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Otherwise looks reasonable, though I see Dave has feedback to address > too. :) > > Thanks for working on this! > > -Kees Thank you for the review. I will address all this on next version. thanks, vigneshbalu. > -- > Kees Cook