From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D10FC43334 for ; Fri, 1 Jul 2022 10:10:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E5116B0071; Fri, 1 Jul 2022 06:10:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 993E86B0073; Fri, 1 Jul 2022 06:10:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 884016B0074; Fri, 1 Jul 2022 06:10:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7A19B6B0071 for ; Fri, 1 Jul 2022 06:10:26 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 271B011E6 for ; Fri, 1 Jul 2022 10:10:26 +0000 (UTC) X-FDA: 79638111252.14.2D954A6 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf06.hostedemail.com (Postfix) with ESMTP id 9397F18003A for ; Fri, 1 Jul 2022 10:10:25 +0000 (UTC) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 261A3W2m020456; Fri, 1 Jul 2022 10:10:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=UmCQjA2ABCVvbRbvlQlcH+BQVveyAfSCV76NYtzcJMQ=; b=lRTeTe4JAIqo1bOU6r8rZrO5jFYNPr2QmO5l/kIzN8rb6/35/7sxx65xXFL3juz9pjrq GKkbmes5c7ULSxwAuvjSV4w/ZbiwzvYxlcLervIZyk7Z4nWLtQj3K9x9apiOyz2cqSgW iETWHEKRj3HMsmybnrOq6zw1zXAEkNCIkJ+yXLFZjTSO+QayrgGeS6yUG436xCPJ9iXu LusKUyV3TcbsgtqhBbXGIIEQLjujMuXBR+elmb9elz9SFXiHZr5iSFOANgneit0p7bO5 gau8/6VjTGBnYFN7BgUYp0yrF8pBOj8jwGJ+ljOR50fPudA7osMMm7VZXXAylDbLz+pX Qw== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3h1xua869a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Jul 2022 10:10:24 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 261A5NrD012209; Fri, 1 Jul 2022 10:10:22 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03ams.nl.ibm.com with ESMTP id 3gwt091gr5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Jul 2022 10:10:22 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 261AARl328377528 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Jul 2022 10:10:27 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5C000AE055; Fri, 1 Jul 2022 10:10:19 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BEE3FAE04D; Fri, 1 Jul 2022 10:10:18 +0000 (GMT) Received: from [9.171.7.21] (unknown [9.171.7.21]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 1 Jul 2022 10:10:18 +0000 (GMT) Message-ID: <1a2a885b-d408-0426-8e8c-ad1c56f4c215@linux.ibm.com> Date: Fri, 1 Jul 2022 12:10:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] s390/hwcaps: Add HWCAP_UV Content-Language: en-US To: Steffen Eiden , Heiko Carstens , Alexander Gordeev , Janosch Frank , Claudio Imbrenda , Vasily Gorbik , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: nrb@linux.ibm.com References: <20220701100210.5482-1-seiden@linux.ibm.com> <20220701100210.5482-2-seiden@linux.ibm.com> From: Christian Borntraeger In-Reply-To: <20220701100210.5482-2-seiden@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: HnRw0gHl-MraEG-yNXmflP3eDogCoNE0 X-Proofpoint-ORIG-GUID: HnRw0gHl-MraEG-yNXmflP3eDogCoNE0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-01_06,2022-06-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 adultscore=0 phishscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 lowpriorityscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2207010037 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656670225; a=rsa-sha256; cv=none; b=OJtXP6fgoXjVEXmZpTs8KzhVCVm6KKHKlgSl4wAHu9GX028tRsk+8Rt8+ipJNvetdaHjWp NuqTjjnIMzDwqzJgMpK96PK4ZiBiUFhOA+mb0d8hOHPba8di/PDPmjAcTXSKY7nK6Bbph1 9UykY3hoe49hgvPvEqoRoLnfVehBrVY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=lRTeTe4J; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf06.hostedemail.com: domain of borntraeger@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=borntraeger@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656670225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UmCQjA2ABCVvbRbvlQlcH+BQVveyAfSCV76NYtzcJMQ=; b=BJa87FF4S0lW5FTW+6e2lFc8+yVNhdI688La7b48UjhQr+q/oL5WP6OJE+UhyK5bPSTWFA /Jzj+3gRB39raHXzOUDO5Sk2S58vtZgqAfoAOMvVM8EmwnECszXuwdshLpljQp9uWDylVp hQewUGJ3p1522FzCIsh1Y4IschIpk4M= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9397F18003A Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=lRTeTe4J; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf06.hostedemail.com: domain of borntraeger@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=borntraeger@linux.ibm.com X-Rspam-User: X-Stat-Signature: qmx8yibxek3guptuen4w6mgbrfmsaqoj X-HE-Tag: 1656670225-270598 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 01.07.22 um 12:02 schrieb Steffen Eiden: > This patch adds a hardware capability for the Ultravisor. > This capability will be present if facility 158 is enabled. > > Signed-off-by: Steffen Eiden > --- > arch/s390/include/asm/elf.h | 2 ++ > arch/s390/kernel/processor.c | 5 +++++ > 2 files changed, 7 insertions(+) > > diff --git a/arch/s390/include/asm/elf.h b/arch/s390/include/asm/elf.h > index 70a30ae258b7..3a5e89ce4fd0 100644 > --- a/arch/s390/include/asm/elf.h > +++ b/arch/s390/include/asm/elf.h > @@ -115,6 +115,7 @@ enum { > HWCAP_NR_NNPA = 20, > HWCAP_NR_PCI_MIO = 21, > HWCAP_NR_SIE = 22, > + HWCAP_NR_UV = 23, > HWCAP_NR_MAX > }; question for Heiko, Vasily, Alexander. This certainly works. An alternative implementation would be to separate module_cpu_feature_match from HWCAP. (so uv would not be shown in /proc/cpuinfo and it would be seen in the aux vector). I would imagine that we might have more drivers in the future that depend on a facility but this facility is not really useful for userspace to know. See arch/s390/include/asm/cpufeature.h * Restrict the set of exposed CPU features to ELF hardware capabilities for * now. Additional machine flags can be indicated by values larger than * MAX_ELF_HWCAP_FEATURES. Any preference from your side? > > @@ -142,6 +143,7 @@ enum { > #define HWCAP_NNPA BIT(HWCAP_NR_NNPA) > #define HWCAP_PCI_MIO BIT(HWCAP_NR_PCI_MIO) > #define HWCAP_SIE BIT(HWCAP_NR_SIE) > +#define HWCAP_UV BIT(HWCAP_NR_UV) > > /* > * These are used to set parameters in the core dumps. > diff --git a/arch/s390/kernel/processor.c b/arch/s390/kernel/processor.c > index aa0e0e7fc773..80ccd57a2b00 100644 > --- a/arch/s390/kernel/processor.c > +++ b/arch/s390/kernel/processor.c > @@ -141,6 +141,7 @@ static void show_cpu_summary(struct seq_file *m, void *v) > [HWCAP_NR_NNPA] = "nnpa", > [HWCAP_NR_PCI_MIO] = "pcimio", > [HWCAP_NR_SIE] = "sie", > + [HWCAP_NR_UV] = "uv", > }; > int i, cpu; > > @@ -249,6 +250,10 @@ static int __init setup_hwcaps(void) > if (sclp.has_sief2) > elf_hwcap |= HWCAP_SIE; > > + /* ultravisor-call (secure execution) */ > + if (test_facility(158)) > + elf_hwcap |= HWCAP_UV; > + > return 0; > } > arch_initcall(setup_hwcaps);