From: Anshuman Khandual <anshuman.khandual@arm.com>
To: "Christoph Lameter (Ampere)" <cl@linux.com>,
Matthew Wilcox <willy@infradead.org>
Cc: Shubhang Kaushik OS <Shubhang@os.amperecomputing.com>,
"ampere-linux-kernel@lists.amperecomputing.com"
<ampere-linux-kernel@lists.amperecomputing.com>,
Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Lorenzo Stoakes <lstoakes@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] vmalloc: Modify the alloc_vmap_area() error message for better diagnostics
Date: Tue, 4 Jun 2024 08:00:18 +0530 [thread overview]
Message-ID: <1a28fda9-be47-4b03-811b-43498622523f@arm.com> (raw)
In-Reply-To: <3329c844-509b-8769-01b6-a191b60bee35@linux.com>
On 6/4/24 05:46, Christoph Lameter (Ampere) wrote:
> On Tue, 4 Jun 2024, Matthew Wilcox wrote:
>
>> On Mon, Jun 03, 2024 at 09:30:54PM +0000, Shubhang Kaushik OS wrote:
>>> 'vmap allocation for size %lu failed: use vmalloc=<size> to increase size'
>>> The above warning is seen in the kernel functionality for allocation of
>>> the restricted virtual memory range till exhaustion.
>>>
>>> This message is misleading because 'vmalloc=' is not a valid kernel
>>> parameter on a number of platforms, in particular it is not supported
>>> on arm64. With the update, the output gets modified to include the function
>>
>> Why not fix arm64?
>
> Arm64 does not need vmalloc= tuning and the problem is not related to being out of vmalloc space in general.
>
> This occurs if the virtual range during a vmalloc was restricted and is not available (f.e. if one wants a module to be loaded in optimal branch distance to the kernel text segment and we loaded too many modules). The error message needs to indicate the virtual memory restriction which helps the developer/user to debug the situation and not create a wild goose chase for a kernel parmaeter that does not exist.
Agreed, current warning message here is misleading pointing to a non-existent
kernel command line parameter on the given platform.
This kernel parameter i.e 'vmalloc=' seems to be supported only on the x86 and
arm (32) platforms. Should not Documentation/admin-guide/kernel-parameters.txt
be updated as well making this bit clear ?
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-06-04 2:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 21:30 Shubhang Kaushik OS
2024-06-03 23:35 ` Matthew Wilcox
[not found] ` <3329c844-509b-8769-01b6-a191b60bee35@linux.com>
2024-06-04 2:30 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a28fda9-be47-4b03-811b-43498622523f@arm.com \
--to=anshuman.khandual@arm.com \
--cc=Shubhang@os.amperecomputing.com \
--cc=akpm@linux-foundation.org \
--cc=ampere-linux-kernel@lists.amperecomputing.com \
--cc=cl@linux.com \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox