From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 244DFC77B6E for ; Fri, 14 Apr 2023 09:52:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9761A6B0075; Fri, 14 Apr 2023 05:52:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FF096B0078; Fri, 14 Apr 2023 05:52:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77B2E900002; Fri, 14 Apr 2023 05:52:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 682396B0075 for ; Fri, 14 Apr 2023 05:52:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 21EF3401B7 for ; Fri, 14 Apr 2023 09:52:48 +0000 (UTC) X-FDA: 80679532416.14.9B0ACED Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id E0EAC40008 for ; Fri, 14 Apr 2023 09:52:45 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VRKy29c8; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681465966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=36cFCzN7i4Qa6Nw/h904auZ24hEonHUCle7ZOEbyOEY=; b=LfagIw2btX+Xd9APm7Cez0OOyj7sOTLDkDLMU1M3IQhvioBkrOdR6dxXdkV5F17TTSIYhg yYfKjmXVqflgxwmlTxo8n15SZkNMWCegWAqiTfKRdjgX/rtWLPyvW1ELmE1TM+QKz7fWW/ JHtJGAkout+BxpqapK0bm3gEB7thXic= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VRKy29c8; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681465966; a=rsa-sha256; cv=none; b=otVTkpeI9OBtGaqWP+NTXcpFKc+8mbUoP013T+I/i7eFROKjFtm+H1kRi2oYwr/QlQwzjE s3WTKa9GJnmIPiRbNhTsKzY5ZxwL/lnUi40o7FhT52d6U5cHyb2d4BjvVe4ii9ZDtH+ycJ pvQ9VrpGuhFiBdW1JSumCeOSQUuV628= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681465965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=36cFCzN7i4Qa6Nw/h904auZ24hEonHUCle7ZOEbyOEY=; b=VRKy29c8LJfnqhcJ3FGT5HPi0FEVlS+1HesLb00RxnbbPRgBldeZm6SK8iAJVgdNGAuhMK tpDrk8SoCBom6/6zcSPtiEoQVSZ8pHByIg2gv0/Pt2xr1lym4Nt3oUf0jusAlhWcSyH+3A ahfdFzsRCsgxTllIXn7Y727i1HhUAWE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-nRVaO90tMyK9Ozfh6uiqlQ-1; Fri, 14 Apr 2023 05:52:43 -0400 X-MC-Unique: nRVaO90tMyK9Ozfh6uiqlQ-1 Received: by mail-wm1-f70.google.com with SMTP id u9-20020a05600c00c900b003f144967a91so220807wmm.3 for ; Fri, 14 Apr 2023 02:52:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681465962; x=1684057962; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=36cFCzN7i4Qa6Nw/h904auZ24hEonHUCle7ZOEbyOEY=; b=KfS+voo02lsWUmowRTcRQhcsr8qWaGFjFglyH30NeAAx7drt7aZ4KLcemvWa8OSCTH +d/LAHizUq+rvxDplQMYeg1kNcF9p5/2H2CEf7qefszAk++LmhbXnW3TPV5t3p6A0e14 NrwTXYuNrHE45YQcXdgv1zojEFp/USxiEv8VC1Ga84KuHTNxTgqyC8oh0FLzZJC5wq/C FccHTvs9nlwOzsQYVm0uhSgT72qjA/WV9SS1XTUZiwKJCrfqIHe1sRMlovctvOHJRX22 28SkI66loLfXIKMvcrcO9hWyxOM+rpnQNqMvAVtw3iaihFgBlg7AUZdWeuLqTnZaWl4T ch/A== X-Gm-Message-State: AAQBX9ezr6ma9NcNXTBaKkazRBQnAbngap75phL504VrHOpLsmR/JJQl LWIG7XQiGP+Ad9nMUWHekCKhwCqg9TMeta8RG7g4HW0DH05YmTIYl9SItL7rH4k2tWWhgpbHFeC lkDQ4cFXnX4rac3HPOhc= X-Received: by 2002:a7b:c395:0:b0:3f0:3a5a:362e with SMTP id s21-20020a7bc395000000b003f03a5a362emr3968643wmj.39.1681465961962; Fri, 14 Apr 2023 02:52:41 -0700 (PDT) X-Google-Smtp-Source: AKy350aRy4TRCmo8oxHFnjtdO3wCEfkusFzgY7VdMpgtuzV9kgTe6yTmTkleM0kONQ2A7d6Cj0V0dA== X-Received: by 2002:a7b:c395:0:b0:3f0:3a5a:362e with SMTP id s21-20020a7bc395000000b003f03a5a362emr3968630wmj.39.1681465961622; Fri, 14 Apr 2023 02:52:41 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:5700:cb5b:f73a:c650:1d9? (p200300cbc7025700cb5bf73ac65001d9.dip0.t-ipconnect.de. [2003:cb:c702:5700:cb5b:f73a:c650:1d9]) by smtp.gmail.com with ESMTPSA id j4-20020a05600c1c0400b003ee8ab8d6cfsm7721232wms.21.2023.04.14.02.52.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 02:52:41 -0700 (PDT) Message-ID: <1a2544eb-7d42-eda3-fafa-9bed1377841d@redhat.com> Date: Fri, 14 Apr 2023 11:52:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 5/6] selftests/mm: Rename COW_EXTRA_LIBS to IOURING_EXTRA_LIBS To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Axel Rasmussen , Andrew Morton , Mike Kravetz , Nadav Amit , Andrea Arcangeli References: <20230413231120.544685-1-peterx@redhat.com> <20230413231120.544685-6-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230413231120.544685-6-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E0EAC40008 X-Stat-Signature: 7ky71dtohcus5adqj3b5chqy5h6s8r7s X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681465965-855533 X-HE-Meta: U2FsdGVkX18FoETsBNKXaIR41zSxxfmtsDowJq6V6KxB0StXrFA7QFqDYy4quP3W7UdNDPkVQkwdY4BFMeQbLjqVsQA6S5Hz2HRU3I0x6Z4EjtsCL7ELw+Piap1mQ3I/w4qztYwhAejint+n0a7Bdfi0zn693weHZbSaeoCoNWz/8LqtroKLxk49lsacVgTfhwNc/1LSuh2gQ7AzniVMJWnQ6qp3kaVJymJHrLo+0iUOibiBjW6iy2JjpMRT4jL8Ez9NXjenmkf7xEMX/PsHCb4a6bx/sQwnWkNQe5Fw9HRLZegmfBr/LxG2mDWuckZ5lbzuFa9C+zywuNBSOIbOZTABH8nB+RRkLl4BJWatyCwg3gE9/kC1QIXtTg7SciWvPEVQ2pB9U88tgenE1VTFMfEcrTESLmkRhIX19VxehpGW3/UN0m3IAe06Th/jLI9G/wkGwMmEQDlcV3LMnUxmEDeG8WEIv7oDcprbfjHp7gFDhYeHBhCDdCLP8Z3JCD7cs93YCwS4CVNHydVwI/O7nfYdeQZ0LTF+/Ba3+6dKmxc6eTZbpnUQxTV9gLEVF1uYRlf1kpG1ISjnAJ+HdPSceknR2s8tLoFT4mx36DxGOoOYQkRwri8kEb9wsfcLQuvHby+wkgy6N+qFrMya4dbhr7A7j5/dBPJD9/elQU2qtjjWpQuW7X+MPPPMdcUpswuHJ9KO3hfyKnyN3Nz4AvoXqvzQQNVheWRnWPcaVQRBpjDiVeFAFalp6FYZ08XQss8F5CpNVw4I78VyrRbvvVprecXxXaN7c0w6uV6Wn9UVvo7v/Q3/1LofvEbq5rXY+DmnwxaLVq/sCd8WduS41pnpsXBeFG0iSEY1M8LthJkIcpDIO2ZAeNN2IAD0UEecdl7jh1tng4mfJqKZOWKFXozXFxl71jLQSrp7TFZKs1QwURSfrrBrYCqooJrGtaXwMaS2HboMON/tV0DqMg221kO MlmXAjB/ Keh3RBM55daqv5Lul9yP/ekR2opNtmVpuQ9R7/kPlKBLipabEfDS/kls1ZTFmIOudVEZ7nIQild0aUh6bBjwiJVYMncrQcSSJZDeILzGNI4vXmnT7lR7GIXbMFca2fTuRP/nBH7EmsbantyFzjPtiBCO2s1klZ2yYgiKHjI7Asz6UNQZq1md8IJzdYsT/W+9UtDR2nkhOqEHjuOmZTIIF2oWcp78AlFH+a14C7W157B4YoHIzTUAS/iv2djDhY/6ttb/6dwvQYraC7pw3PUGTiJsfbN0xsccG8rpWjkeXyc4vUpUI+SIhF1+GUNuXYWo+GOdCS4xWdQXYzfnmUWzqXSveu/o+yas8zFoh7qBjQBByJUnbKJVbJS5InKpGgBAE1r9UNOTitN3btioBJcT38+DizjB+WBX/RsRVW8pZzH4SfCq//TqGkRmMpp/2Eh32WXbsg3wrPsTsuIHEHIHjes4NR776QltVkqczTjiVV+vSrbGLdsr8B1vBibJGiTD17nn2MQK0R223oFV+tYGsLBGvKXqUBR4Gatha X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.04.23 01:11, Peter Xu wrote: > The macro and facility can be reused in other tests too. Make it general. > > Signed-off-by: Peter Xu > --- > tools/testing/selftests/mm/Makefile | 8 ++++---- > tools/testing/selftests/mm/check_config.sh | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 5a3434419403..9ffce175d5e6 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -161,8 +161,8 @@ warn_32bit_failure: > endif > endif > > -# cow_EXTRA_LIBS may get set in local_config.mk, or it may be left empty. > -$(OUTPUT)/cow: LDLIBS += $(COW_EXTRA_LIBS) > +# IOURING_EXTRA_LIBS may get set in local_config.mk, or it may be left empty. > +$(OUTPUT)/cow: LDLIBS += $(IOURING_EXTRA_LIBS) > > $(OUTPUT)/mlock-random-test $(OUTPUT)/memfd_secret: LDLIBS += -lcap > > @@ -175,11 +175,11 @@ local_config.mk local_config.h: check_config.sh > > EXTRA_CLEAN += local_config.mk local_config.h > > -ifeq ($(COW_EXTRA_LIBS),) > +ifeq ($(IOURING_EXTRA_LIBS),) > all: warn_missing_liburing > > warn_missing_liburing: > @echo ; \ > - echo "Warning: missing liburing support. Some COW tests will be skipped." ; \ > + echo "Warning: missing liburing support. Some tests will be skipped." ; \ > echo > endif > diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh > index bcba3af0acea..3954f4746161 100644 > --- a/tools/testing/selftests/mm/check_config.sh > +++ b/tools/testing/selftests/mm/check_config.sh > @@ -21,11 +21,11 @@ $CC -c $tmpfile_c -o $tmpfile_o >/dev/null 2>&1 > > if [ -f $tmpfile_o ]; then > echo "#define LOCAL_CONFIG_HAVE_LIBURING 1" > $OUTPUT_H_FILE > - echo "COW_EXTRA_LIBS = -luring" > $OUTPUT_MKFILE > + echo "IOURING_EXTRA_LIBS = -luring" > $OUTPUT_MKFILE > else > echo "// No liburing support found" > $OUTPUT_H_FILE > echo "# No liburing support found, so:" > $OUTPUT_MKFILE > - echo "COW_EXTRA_LIBS = " >> $OUTPUT_MKFILE > + echo "IOURING_EXTRA_LIBS = " >> $OUTPUT_MKFILE > fi > > rm ${tmpname}.* Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb