From: "Yin, Fengwei" <fengwei.yin@intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <david@redhat.com>, <linux-mm@kvack.org>, <dave.hansen@intel.com>,
<tim.c.chen@intel.com>, <ying.huang@intel.com>
Subject: Re: [RFC PATCH v3 1/4] filemap: add function filemap_map_folio_range()
Date: Sat, 4 Feb 2023 11:25:41 +0800 [thread overview]
Message-ID: <1a133da1-ffe7-b52d-719d-89a891c66ace@intel.com> (raw)
In-Reply-To: <Y90R0FIQpOC7Gs/J@casper.infradead.org>
On 2/3/2023 9:53 PM, Matthew Wilcox wrote:
> On Fri, Feb 03, 2023 at 09:16:33PM +0800, Yin Fengwei wrote:
>> filemap_map_folio_range() maps partial/full folio. Comparing to
>> original filemap_map_pages(), it batched updates refcount and
>> get minor performance improvement for large folio.
>>
>> a self cooked will-it-scale.page_fault3 like app (change file
>> write fault to read fault) with xfs filesystem got 2% performance
>> gain.
>
> Please delete folio_more_pages() as part of this patch; this was the
> only caller.
OK. Will update in next version.
>
>> + ret |= filemap_map_folio_range(vmf, folio,
>> + xas.xa_index - folio->index, addr, nr_pages);
>
> Sorry to nitpick, but there's an extra space between |= and
> filemap_map_folio_range() here.
OK. Will update in next version.
Regards
Yin, Fengwei
>
next prev parent reply other threads:[~2023-02-04 3:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:16 [RFC PATCH v3 0/4] folio based filemap_map_pages() Yin Fengwei
2023-02-03 13:16 ` [RFC PATCH v3 1/4] filemap: add function filemap_map_folio_range() Yin Fengwei
2023-02-03 13:53 ` Matthew Wilcox
2023-02-04 3:25 ` Yin, Fengwei [this message]
2023-02-03 14:17 ` Kirill A. Shutemov
2023-02-04 3:31 ` Yin, Fengwei
2023-02-03 13:16 ` [RFC PATCH v3 2/4] rmap: add folio_add_file_rmap_range() Yin Fengwei
2023-02-03 14:02 ` Matthew Wilcox
2023-02-04 3:34 ` Yin, Fengwei
2023-02-03 14:19 ` Kirill A. Shutemov
2023-02-04 3:35 ` Yin, Fengwei
2023-02-03 13:16 ` [RFC PATCH v3 3/4] mm: add do_set_pte_range() Yin Fengwei
2023-02-03 13:25 ` David Hildenbrand
2023-02-03 13:30 ` Yin, Fengwei
2023-02-03 13:34 ` David Hildenbrand
2023-02-03 13:39 ` Yin, Fengwei
2023-02-03 13:32 ` Chih-En Lin
2023-02-03 13:38 ` Yin, Fengwei
2023-02-03 14:30 ` Chih-En Lin
2023-02-04 5:47 ` Yin, Fengwei
2023-02-03 13:16 ` [RFC PATCH v3 4/4] filemap: batched update mm counter,rmap when map file folio Yin Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a133da1-ffe7-b52d-719d-89a891c66ace@intel.com \
--to=fengwei.yin@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=tim.c.chen@intel.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox