From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA22C4345F for ; Wed, 24 Apr 2024 07:17:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DE406B024A; Wed, 24 Apr 2024 03:17:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 466C36B024B; Wed, 24 Apr 2024 03:17:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 246116B024C; Wed, 24 Apr 2024 03:17:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F37856B024A for ; Wed, 24 Apr 2024 03:17:22 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7434B1C0091 for ; Wed, 24 Apr 2024 07:17:22 +0000 (UTC) X-FDA: 82043569524.12.B73E4B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 3A9D7180006 for ; Wed, 24 Apr 2024 07:17:20 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QbCax0Lv; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713943040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9iaYIAZiKliqY/TEMeW9+sVZsOPyKdm6944m3JCdN9c=; b=y94dEQNVcPCmzwPeloLzZIl4oFFq4qtk67HuNapScJP7vlhRBCCCdvLfhFVl65UaJyrN/J 7We0Q31PAoDqMALgoP19afIp8qClRI5XvtqoNr+NFfejUVmcR7n+zfJToZWu4p4+3snylr qXUwHg5rYAU+92xkmKvT1VbbSf+jfmc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QbCax0Lv; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713943040; a=rsa-sha256; cv=none; b=B88wYZ5cXnHKp1+o60GeBZqH5YED42N50X7zZXHWEmMZFv2csxnncUfjlmrMnVA+BCIP/U W1b9YGuzRfZ+IU8f+Y0LKjORgDby3NOGMpx5FfYlNmjTDrA/WRMXOK/YX+C1RjSXH1MDX0 C4TOE8rl3FaSquyJhZ+ywfQ70MqSFWc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713943039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9iaYIAZiKliqY/TEMeW9+sVZsOPyKdm6944m3JCdN9c=; b=QbCax0LvovSU7UGm7s4JJRL2hWO3lhCzy9wbYTIddyLgwKVHohnjL8ExwSUheB+4P5/FX/ 0Rzb6XxmxPDOqFiUW03QLBzbb2mkgcXmCAJ2xS6sLYuqJMJDAIfY0vYn/Y3Ae2Nj1JN+pX qBNu8GwM4LFAVD6Ojb43nOIoCOud2HA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-VV_GVvZLOfCWJES25j5g_w-1; Wed, 24 Apr 2024 03:17:16 -0400 X-MC-Unique: VV_GVvZLOfCWJES25j5g_w-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41aa1bbddadso10580525e9.0 for ; Wed, 24 Apr 2024 00:17:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713943035; x=1714547835; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9iaYIAZiKliqY/TEMeW9+sVZsOPyKdm6944m3JCdN9c=; b=fpWOsEDhT1RfXdyv9fzTVrMHko5fAZcad5VDDHsABccjk/U2XgILrB0mHxrv8YZUbe hFyesElvLfrPB5l+Hp5cTa9JROIYNBzP2ZKFl0vxBu8pvFpsQcDH2xG42+dfCxtB8EuK tT8jZj8jom6sQGxnNQgqtOu9Ux1XguGTWo5OlshClrNxfQFIlZMGWU/DiZKiPHJD5fe5 7UgUhx7Wg/4Zpu466p13aVulJKYdMnQM0Nw75CW9uHMIPej+qEfvVqKrSaZTqkHjwj6/ BBirBFac318UVjTZDleoSfA+Zq2UHeLDaykB5V1vbAFY4gA2mGSJt93fCNK9lRjX/f6k GZQw== X-Forwarded-Encrypted: i=1; AJvYcCXh8O70hh+KKENfzPnKperQzuMVXUE/VPUpqCQ8GLHEkNoC6ibyqqood+ZKbV6gqrtip+SHaUVedKKpljis8enlPxQ= X-Gm-Message-State: AOJu0Yx/mBoUwhqyDP68RGLvpA6rWp34ZW7mcJFo6AoL6zKf8w8oKPWn oNg16CkYlQGesLVfXoEtxlnglAY9GtCoRGr323fqiUKjwp71SpBh0X8WDe9laQKwzpH8dQZipFt 0JnbPqq2W2VPuecD52pIL3SKIwRgxLu/T27RPNX/2fq+BE3Gb X-Received: by 2002:a05:600c:3b14:b0:418:a985:3ca with SMTP id m20-20020a05600c3b1400b00418a98503camr1747515wms.31.1713943034985; Wed, 24 Apr 2024 00:17:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENk37ZqeMVuNNj8JxEPChwKk/OCBk2hMQQvnZVyuzvgKBaOTQwhdp2HFHPmtBXRGKrNBMCoA== X-Received: by 2002:a05:600c:3b14:b0:418:a985:3ca with SMTP id m20-20020a05600c3b1400b00418a98503camr1747483wms.31.1713943034592; Wed, 24 Apr 2024 00:17:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:1f00:7a4e:8f21:98db:baef? (p200300cbc70d1f007a4e8f2198dbbaef.dip0.t-ipconnect.de. [2003:cb:c70d:1f00:7a4e:8f21:98db:baef]) by smtp.gmail.com with ESMTPSA id fm13-20020a05600c0c0d00b0041b0ade42b1sm731364wmb.7.2024.04.24.00.17.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 00:17:14 -0700 (PDT) Message-ID: <1a0ca018-8ad3-42b0-b98a-8e6b6862fc7a@redhat.com> Date: Wed, 24 Apr 2024 09:17:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] mm/vmscan: avoid split PMD-mapped THP during shrink_folio_list() To: Matthew Wilcox , Lance Yang Cc: akpm@linux-foundation.org, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240422055213.60231-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: cgs4r5ny9ws8hjto43b4cbtqum9sbqsn X-Rspamd-Queue-Id: 3A9D7180006 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713943040-203801 X-HE-Meta: U2FsdGVkX19Fik/9rAs3ZnmeqmZPn67qzbBkqWJ3aZ/++5de3Sm7kE34fonHKa0ETeL2wa+G99sAVXjdLNBj9YAeOAdjnh58bx/gnOk2TNB6SXLjuhtrKRreseL5OgT5PFDV77J19ece9TqV/cizJmnssUm72VpR44zYZqbWioEy8/KKKQr+tSxxcoFmkCAEInIWMcsPGZZHUeZ0kXr6ec65r/vbSdjFtByHx5rMVRUmt/Pd94y3WilsFBKIM+wKQpS7Grm85djfhZvFKu3M9UwnNGJdcEaWJZJnh2EhSXhenJS/+OWi/7WCmd1jZqZsgl3RgO2Av8qGuNEgqpD0/1lqXSwTMVJV6PJyLDtQp22I2nU8LhmuNsSq4ORXCeEDRa27VRz+i5P9mHVNTSsY5xUer5jdOCdb+EJ9Yn0apVfrVrp7C7mv8gTr+mQSMSmSJdxX4I/3lwfIyHw2LjgGT9EfWKGA44KQ4r9UTvLhqBkce5H+mUaj1ptxCg055QyXqHIO9tNPrNARLCog2ASPvw41yxCZgktqjBIFsYRkc+zsuqnk3a6uST2KjyIxS5XT9FW//+hAUL1dQoUq6Q1v/hrOqr7eQAXffBPYOY6cKue5Inw68EMxjAZJxRNMmxCyQlyXsW8r076HGxGljImFuDVLKMHEdPqCo3RJmdE79P6VDuq+/ILUkWe5ZR5AzbFH70qT59huBhknB4rKpl8pqZFStaXUQ2Cx/fKMzki3qc2VpsSdwzWRwZ3PSMry6SIhGLAtchvIKzn54q6cppTXhY0dsjjzF3FRV4cCAZDR7Oamd6CAMVfPoQmTG2fd7n8OWtWsdEzFBAa46IqMSx/gl2aIDgU5UkN+vL+7piTOKvcn7Bz/GuDldCbdWhERIr0Edyay0Zu/Eyy//QcEKLS0FzP/QnuRap9bY7i4bjeSQhnfQL3vBKs6kT9m9TRaWtR55Tho2nHHgxMz1x2zDT8 /Wae5esW Qm4va7YfonCAm9XWBPSIbjHXznsmHh06pXjCKUhj2tu0C8jkBp2NK4SN5fzkhZnNI+s0HR2gW3o47hXvFElygr1LjJzUfsRnjTRt5yEbZlGU5IL0fx6Jw4zrN1ZyqrS20SIT8k/G5ovhUUqJhnmYd9DgjiXSdTHY9i+2vo7MNcuE62qpyeBYnH7JnHFca5xCygh4BdQP/p7s6ZtZ1rYu2/57Sn/1v+vMdgmkYAJgcbqwTviNw4aKKo9+/YIlVosM69izEu3+DnfMpts8oXaAWgABtXHxjPUUT1O7KfzJV9e9pKbVGQQdtYvo8mWNR48gRU2AEsLdmO9MMdc77aEMbULZnVlH2TQ+JtjQRVr9gR4u98S4p+Kbh0gQbnEx/akczuG5ZGMpdpjn4P7J08Q8Z0h6a2xjqJ4at8I1xoY/Ym3EmkKLIyM5Lb+NBP71rW7N9xB/YOOal6SLd6cknTmqdMRpBGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.24 06:15, Matthew Wilcox wrote: > On Mon, Apr 22, 2024 at 01:52:13PM +0800, Lance Yang wrote: >> When the user no longer requires the pages, they would use >> madvise(MADV_FREE) to mark the pages as lazy free. IMO, they would not >> typically rewrite to the given range. >> >> At present, PMD-mapped THPs that are marked as lazyfree during >> shrink_folio_list() are unconditionally split, which may be unnecessary. >> If the THP is clean, its PMD is also clean, and there are no unexpected >> references, then we can attempt to remove the PMD mapping from it. This >> change will improve the efficiency of memory reclamation in this case. > > Does this happen outside of benchmarks? I'm really struggling to see > how we end up in this situation. We have a clean THP without swap > backing, so it's full of zeroes, but for some reason we haven't used the > shared huge zero page? What is going on? It's not full of zeroes. User space called MADV_FREE on a PMD-mapped THP. During MADV_FREE, we mark the PTEs as clean, the folio as clean and sd "lazyfree" (no swap backend). If, during memory reclaim, we detect that (a) the folio is still clean (b) the PTEs are still clean and (c) there are no unexpected references (GUP), user space didn't re-write to that memory again, so we can just discard the memory "lazily". -- Cheers, David / dhildenb