From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11224C3DA59 for ; Fri, 19 Jul 2024 08:28:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F4D26B0082; Fri, 19 Jul 2024 04:28:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87CE96B0083; Fri, 19 Jul 2024 04:28:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6ABA76B0088; Fri, 19 Jul 2024 04:28:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 488F46B0082 for ; Fri, 19 Jul 2024 04:28:23 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B06391A02E5 for ; Fri, 19 Jul 2024 08:28:22 +0000 (UTC) X-FDA: 82355825244.16.0AE2492 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 344CA160029 for ; Fri, 19 Jul 2024 08:28:19 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DtUZ0CYq; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721377657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RRex67Mz8epoWANX5IYCXnoNaj4foCtRpW//w2kagY4=; b=5YQLNUY91ixAmbx1QdSDsFFNTMGL8c9QC4nQ17KOlVpGSraU3L+sksZ9/u7xAQ2l91sMQK jU4PMevOHnE4v1TrSMwwnaqTy3NzZcMWJlDnu47N6SssJ6xB2EsJDKqaBPJ1s2os6UG+0z noLm2DBcorySsSLrp2IgABiweiidfZw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721377657; a=rsa-sha256; cv=none; b=yJkVX2ateFUinSg8onU7vHl9RRAAg8t2kozE+RJFEKiFBIpUIn5L/Py8HfLqLjOAyczMpz NymtDEi5jSn1OISZ3a0BeWsLwcxI3iXjKdG3aDkRLG0L16nqtDz1gb+mk4FUdQyMCvt/WO XKxojPdzBOOfatv8b4Z+qlAQ4ECNJcg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DtUZ0CYq; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721377698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RRex67Mz8epoWANX5IYCXnoNaj4foCtRpW//w2kagY4=; b=DtUZ0CYqngnhglnwOuZV+E0kQI0aL4u6v2jqeAh8AtrWYa5sG0sdKqDiFAZN0DHC58iHbl PIl83pXCfVYk0oh46FonAMtP8W77AI0InIZcgONkooGMqx895PE7CH8fxico6OC/tnn4Pg rCr51Hs5CT9cttixLvefSY3ApcaWXUI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-173rzUb3MrOib3clCzDtGQ-1; Fri, 19 Jul 2024 04:28:13 -0400 X-MC-Unique: 173rzUb3MrOib3clCzDtGQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-426d0bead0aso10093645e9.1 for ; Fri, 19 Jul 2024 01:28:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721377692; x=1721982492; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RRex67Mz8epoWANX5IYCXnoNaj4foCtRpW//w2kagY4=; b=qZWqbmT8CPhWZTPGsj8j1g3hf7qIs5EdPm19j9KjMpnGHpsGgEiY4eHqhsa3PODTkf sALqd5vy6cajOwZucvC0nVKNl2G/9m31cbL+xy3T64LQ8FIbDrilF/xxKwD+6GfACchI rYFfuSK86a4OJpfzIJqOdS0j9w+ostglheMytnGyoUi6zgr/xgGvsw0rJQ0VnUA92s/8 KSj4z0I3kP+Gpvmj/poew20dMLyEWy+774wvbxqvhhz/cdWb7n07dET9NIhSp8M0wUG2 xF2jna+rhbFIHascV0q+vKhK+QcvloLLnD6i4C+Tkj10oBWVd3TqC4XTJ/LUZs2KDvg4 BSfw== X-Forwarded-Encrypted: i=1; AJvYcCXkA2Ncx4MgVMQOpTNyhsOTZD3FjtWG6LcQptpOXHiEFWKt1wXCGQGuF13hfkifJm5ODwvXqxJRqKQiTSqocIXNmmo= X-Gm-Message-State: AOJu0YygKz1keCKYom9oLqYTsqgheJOum49skx1PAF57YCYwyGckEKkL 7/eOAJ6GZ7Z/g87raClCv8gEGeYMd0rtbb/n8UlN0NlGmq6oYgb7HDB6Hj155Bw9j4JQEwh+OPW 4P70kRa5fBgq4W2QCZM72JAB1cXm9W84yGhuHq6OPq7HJMb4EFmdRZApV X-Received: by 2002:a05:600c:1c03:b0:426:668f:5eca with SMTP id 5b1f17b1804b1-427c2c99b70mr47225915e9.7.1721377691930; Fri, 19 Jul 2024 01:28:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9el61BzvNN7OiAoaIackyBdrRqSv7IvxZKq4Eq22fjV+zSZ1D7W4iI1PPo1840RGDlLtPmg== X-Received: by 2002:a05:600c:1c03:b0:426:668f:5eca with SMTP id 5b1f17b1804b1-427c2c99b70mr47225705e9.7.1721377691478; Fri, 19 Jul 2024 01:28:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:1000:c4af:a24f:b8ba:8bbc? (p200300cbc7051000c4afa24fb8ba8bbc.dip0.t-ipconnect.de. [2003:cb:c705:1000:c4af:a24f:b8ba:8bbc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d2a3c0fasm44307985e9.7.2024.07.19.01.28.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jul 2024 01:28:11 -0700 (PDT) Message-ID: <1a0884cb-39ed-455e-a505-7c1b2a0e5225@redhat.com> Date: Fri, 19 Jul 2024 10:28:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/x86/pat: Only untrack the pfn range if unmap region To: Yan Zhao , Peter Xu Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Alex Williamson , Jason Gunthorpe , Al Viro , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "Kirill A . Shutemov" , "x86@kernel.org" , "Tian, Kevin" , Pei Li , David Wang <00107082@163.com>, Bert Karwatzki , Sergey Senozhatsky References: <20240712144244.3090089-1-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: o4m8nppyrwao9t63twn9sz1dim747tes X-Rspamd-Queue-Id: 344CA160029 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721377699-161652 X-HE-Meta: U2FsdGVkX1/m/HhCxugno/4HX5BSULXAlEPWIH1TJjAxFw5Vb9pg2LjOO4g4ghp5FXLc+xL2tLQKnB0p3h420R8HAauJ8q9uHkCXVlqvB8X4RDhFgY4wIgQpUnUFxRBm/R6ANwMk1M7ZudSnGTmAIaPcfkTjTiGys/+OmvOg/4lKWf2//NryvvFq5oOdQDA46BPPLlI7sUP48sM9slqokhw7fhKpDXVRPXgEcOTb4FPPKgc9B0UvZYp42PogNsKzqpHeIRNgRm6O0DXhXAm2gYju3L6PApX66SpdM6zn7qc5JA+Wt70z2WxV7Ds2hk14jR8g2l+ecEt13a6UsynmwEISjHMLO34TOeCDhTiv40qoynJUx7cNd6aYuF/0JL8G+0E6tIYTNeH73s8C355NQOckPwSlM8MR7AdzeEJ9Zp3Q+qTNSLDbDb9SLUASoe7cVkeUmfEdc/ZAQEVFHhTZp0kt3cRiR3KLg6K//qqbSEdsihNeaDQgXiW6XZn8Tjvym7QqO1OEuDcXKlcc21xyO+uJAS1VHVCGj6I3zERy/KJjFKR1BcCEMc3JHdsEE+p3+5oSNUhvOcwdX3Y+aCGTwSSEHZH26474KbCtOhOd94VG3PTQq5neP6bhfrXhfO4kY9MUmMk7eboj/GPtCIqC/kQCq67vWl5hHitv3fyucrf8OJ8hkc4UE2Dydh/auIRDEmknptn1AJrTgd3do1r9TswaF09ZYbL4UD6paOj+R+aE8TBoWUT7ax+TgA7twlm9CxpiZy/DpC8UPAQXii137OHDKsfTsh5KYrKPey7rztnhkUu+rNjVcf0pW2y2OKHSaWk/Gk0suoKcMGHuKhojKOCpsNWUJPB+fcnQaJ/1DTpKum3+F+D4xtur/WA5MCg9/0AcgEfa/0Mo6FoWjtry+0C2rhLBP8Urbxtu5obR4+AQPLKd2wrvb5fQS3LoKEuPm9RRvUC6TXBEZqrwxaP vs5WdFdt 51NPrciEnirAcDidLv3DTXVwU4XZBS4tOpbObzzU4xzRJOTkkgVNj4Ooe8H7Xb64RoTjOqRbx6dhw4hG581HHp9/GkPzBSMO4KyqDx/c7tqy6RI/0kNFrpjQ5xGKaUi5tpkO6DzfhGNeWhqizCeT6Ko+ofwZ+sJRT07kM3qjXSAJRLbeacWZ4Gn2xAj7pRY50cjkPzVoENJtXVDUyACry+oxsH3MhVXIlYL8gXvL1lm2kZvtj2iBPIE57vq4NoOji+q+moIfvu6onuxkSuES2OL3cDbAT4DnBNho08jBfm/kkOfv/NZM5uX+OxAxoweYA9kI61ttSIFm2M1eFbk8pDCBhRIYDyv3K/tra5x60H8aZrC2lJVk21Su6ReshAXSHxKsLYwjBdM7M4o+DCP8UFDvMQCw62Wb8tg/NOt+BQMQL9Kki2TlkNW3Ohel+s23BPVsBn1QbGox0fsspDAfPOJ7Te/cq0V7dfXoTErBKV8bVIQM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.07.24 01:18, Yan Zhao wrote: > On Thu, Jul 18, 2024 at 10:03:01AM -0400, Peter Xu wrote: >> On Thu, Jul 18, 2024 at 09:50:31AM +0800, Yan Zhao wrote: >>> Ok. Then if we have two sets of pfns, then we can >>> 1. Call remap_pfn_range() in mmap() for pfn set 1. >> >> I don't think this will work.. At least from the current implementation, >> remap_pfn_range() will only reserve the memtype if the range covers the >> whole vma. > Hmm, by referring to pfn set 1 and pfn set 2, I mean that they're both > covering the entire vma, but at different times. > > To make it more accurately: > > Consider this hypothetical scenario (not the same as what's implemented in > vfio-pci, but seems plausible): > > Suppose we have a vma covering only one page, then > (1) Initially, the vma is mapped to pfn1, with remap_pfn_range(). > (2) Subsequently, unmap_single_vma() is invoked to unmap the entire VMA. > (3) The driver then maps the entire vma to pfn2 in fault handler > > Given this context, my questions are: > 1. How can we reserve the memory type for pfn2? Should we call > track_pfn_remap() in mmap() in advance? > 2. How do we untrack the memory type for pfn1 and pfn2, considering they > belong to the same VMA but mutual exclusively and not concurrently? Do we really have to support such changing PFNs in a VMA? Are there existing use cases that would rely on that? Would it be a problem if we would merge the mmap+track_pfn_remap, such that such a special VMA can only ever belong to a single PFN range, that is fixed, but PFNs can be faulted in lazily? -- Cheers, David / dhildenb