From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A8ABC021A6 for ; Mon, 24 Feb 2025 12:44:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A23F46B007B; Mon, 24 Feb 2025 07:44:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AD386B0083; Mon, 24 Feb 2025 07:44:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84E2A6B0085; Mon, 24 Feb 2025 07:44:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 699556B007B for ; Mon, 24 Feb 2025 07:44:54 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2955D51045 for ; Mon, 24 Feb 2025 12:44:54 +0000 (UTC) X-FDA: 83154807708.26.ADB29FE Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf21.hostedemail.com (Postfix) with ESMTP id 337381C0002 for ; Mon, 24 Feb 2025 12:44:51 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nnOO7DP0; spf=pass (imf21.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740401092; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uUlJ/YqOHEUEcaQH1p9PSJzfXPsJSMUPR0Rqgv6f4Tw=; b=Z/6GZQWJyVXG65NkDQv/A9DtwG31YS4GfbEzcYObcZ7BeNTSTfO1IDVYUK/aloifTnbuKZ +R6mEpu+KDbA6rJc4UW3ChzPs/zWGWdnfpvQAem5w5Xym0wlyuOm72sSEI4u9qYnDvx7bI DgZaKpNcwcK/htaBSbVUho7jFU14qGQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740401092; a=rsa-sha256; cv=none; b=hohvETPTwDv1hMWZ/rvy7qjIza5Hko16GSX/OG9tz6YrmMc8r7N6Q0IF+dc7Nj0VfTWe25 lMKaqgFRzrAiR2PcPeVnPNzacDttSrEYwiO8QO8J2Icv2PtnbWWkw0OWwNZK24zfS3nCoP tvpWAR/feBVPaoG/X++GAP7XvKAuuTM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nnOO7DP0; spf=pass (imf21.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5e04cb346eeso7244839a12.2 for ; Mon, 24 Feb 2025 04:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740401091; x=1741005891; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uUlJ/YqOHEUEcaQH1p9PSJzfXPsJSMUPR0Rqgv6f4Tw=; b=nnOO7DP0bilqn2QNlGK6uReog8b86ctrq8GwZ16wNGk5ECL0fC+VnCTI5ddidUF0Uh L32J+Vz721fo1Du/hubmFCN99f4Tv0PnYqDBHxEcWrM+8s+34mZeFjhD4oDg5zyPt6o1 zI79sxVLX7fETHkDbjBs7EL6wMA7+6QrbfSBAOhwyh1K2rhrpHgyqZDYMQjohK8io7Yc H0kfubXWfML5atF3aMHT7wwzzYjA12w4ZBDnkjNYzOCgv3RHr4We42n+EHwv8MI5IeBA iCip5z8EtfD8A3qw6OMl9Dr0iVsSv6/b29saQ1L5CJleAu+p5F1Ocy/yJ5AKnuhD38i5 yFFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740401091; x=1741005891; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uUlJ/YqOHEUEcaQH1p9PSJzfXPsJSMUPR0Rqgv6f4Tw=; b=bxOeCwFaZ0mmlZVNBTxXkIUyWe7vzbaOVrKIDkaAVYoVmKOIMOQcjQIaNKh6QXJHZW O/wg272lRjRa5QW2azyf7pp2YSgs39lK3kCcMfdC7egizAZ03TqMurGy+DcUW36TFUK/ W/1hDJkZcenYSarkbv3rW0uL3Y46rhE5jF5U/V47XCIaiwi63Ld6gdQfGbWJY3/vuxoM u9Co+5/CvADeYL4M8derBrbZJEWWOaIDCqz2vnEIgyQWzMvKqN1I0XZ6RuuOCo+BLTvJ nf+5fIHYMYVGbIjzdZ8PmwBfjCcnxmvhzTjsUgfLdOXeqdU+79xFDVHyL0VyqGe3UoZ8 uSaQ== X-Forwarded-Encrypted: i=1; AJvYcCWVKRH45kCUj/m/elbUPSm8shgBqPziDPQ+OyvuFIarUSwqa1f2cdgpz4hfZkJIG4OM9AF78nCqkg==@kvack.org X-Gm-Message-State: AOJu0YyYjbbNHyxvXEtUsYcvF+wTvuHTEezaRO1+fA6eS+CYaoeO/Hze r8E4K4+2+hU6yvmGt0tzwn9yUM/rfusIaJm1OPabCmARI8R3+QCn X-Gm-Gg: ASbGncubTOXrVH9i/+4wpASYdtLkpBNsyCpfNYRjybENuEI//9IJkBS+0fkubqxz1Fx tYagqcXUhlxSBscDYtgoeTTNaGs61IbXmdMXP3e/NorqYEByCAF5/HnWc2EGG+JdrvK/g4yUJNG FfiOxZcav9kYJq6W6MXiH3sR+LhV+zNkqnGg4+ZkeLf3S+d426hkDGGIwmKl76Ef5f88h0QhCHJ I5IIl6JmpS1JT81YQthsgMcPcfa9amToSHmssDOjuB1kpbcJS8YVYnLXU51KjUHxb29sGfDRRsP 2od3RzI5yI0PImhnfbdiLwyqvvjyfmPOuPB+PuMRCwt8XGs= X-Google-Smtp-Source: AGHT+IEJb/DYjRK1zQULnRrxfy1ILl8jlEBKOOE4wo/W0zWqZBA/YjJvnbL6+997MY2DmHfnXEtzSQ== X-Received: by 2002:a17:907:60c8:b0:abe:cbc3:a148 with SMTP id a640c23a62f3a-abecbc3b1c1mr12117666b.50.1740401090165; Mon, 24 Feb 2025 04:44:50 -0800 (PST) Received: from smtpclient.apple ([212.59.70.42]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aba53280ee4sm2222831766b.78.2025.02.24.04.44.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Feb 2025 04:44:49 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: [PATCH v13 04/14] x86/mm: use INVLPGB for kernel TLB flushes From: Nadav Amit In-Reply-To: <20250224123142.GFZ7xmruuyrc2Wy0r7@fat_crate.local> Date: Mon, 24 Feb 2025 14:44:37 +0200 Cc: the arch/x86 maintainers , Linux Kernel Mailing List , peterz@infradead.org, Dave Hansen , zhengqi.arch@bytedance.com, thomas.lendacky@amd.com, kernel-team@meta.com, "open list:MEMORY MANAGEMENT" , Andrew Morton , jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, Ingo Molnar , Borislav Petkov Content-Transfer-Encoding: quoted-printable Message-Id: <1FC042E2-7210-45F1-A094-40849100F483@gmail.com> References: <20250223194943.3518952-1-riel@surriel.com> <20250223194943.3518952-5-riel@surriel.com> <20250224123142.GFZ7xmruuyrc2Wy0r7@fat_crate.local> To: Rik van Riel X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Rspam-User: X-Rspamd-Queue-Id: 337381C0002 X-Rspamd-Server: rspam07 X-Stat-Signature: 3tif111pycy7y1sunrt317446fsp4jdm X-HE-Tag: 1740401091-147315 X-HE-Meta: U2FsdGVkX1/QMG/VoZuQKL9bJUSNJQyHp55PQiYWEYlhpo4/C+fybJgYVJ4AZ+m25KfwTYXjCjTegZpx8x1kX61CPo0omz2TRbJbKMuNiyem/JQAiffCJWAOnSXIgJVf25c7hTSAGXvSuc72KbJzlteMFGnwPIa07EBE18yVzRE5w9AWNBcwhgFOEYX7devCiGDuhoA3Y7W/ZuL08vL0DFfN8Uku8v4/vUwq7UUMwP2gACxqJtgeEc8ZwBkFksdMivrStZFgdWSPXFXwXZNYsEFeF8DglNjjl48Bgt33npmiWg7NxHcZu1ct/aHQkHozov1tfeaYsxifkx/H5/iHzc4agrq35oqlUBz15Nr2PSt6Bjl5CSjlx7qEpYY/edfud7CUTc7cC2pEzeiO66IYOkEmVBbl6urwuDx6dSjXVahfwprDVJ59oUWx6TQYaa/yPT8dV06kxQ+K0UpOpkciNq2pXL0+7/pIvAvR+SNU+rlYNHvSzd5JhCkYHC5leZUcGQEysyKVmwJ9H3/0zlSPtLLzoMc7Gp5r4Qq2dROA5pJ5PQh4Ibyc2DSoIFO/ooumozjIiy9o6c7hgZQ0WeUCvlsJg3i1tnkAYsE/w3gFyso+XO7XzT3XbXWerZaq/mXO4HiM/t6oWyjFhAbOJfWbPC/5ytg3KwzVubc/o07+8q1TPsymMTvo6zdcOC6S4r7paVrU6mliGWoWVq5EqdWnEzflSvtglSLJ6EMODBsPOp0sc90PO4/j4rka/tExnwW5XrowPI1ifyR6rgtmNe0I/mZJS7dZV3kidaw2+Str6Eh44W+8QktxYvVSXbUOC7ENdFLyRyHsMDWHGGIU1VXQuK3PbX3SqOrG07GN9akVgfMunCZT4Yrbbwd/tqH7YmKjqeazeHaXNLVhuCE08kWqdWC9JoBPukeJx5xv4sgRyltIq0ey6JETNum2piNgVgVtmQK3mK1DlK20dhQSMC8 szl00X6l pCH4asewjWcWy0QhTL8yhSrMYRm2ZfztJpdVp8dJhLQItWi1eDoTZq8l3/bx9/WUrPDFoeY6AFQjI4UJbMenRhvq/0ST08cjEqWXJDK7V8xLL20bqZt5SAttkB4T2ApRCMNjE8hNPDQ5Lw681IbG/0pIAJ1LpRAPBsJqu+nscWf0X+7P6lTMsp9BnlKPjXVfUJeeagab96BljoFqTp4pSYKa1q6niBsylEfjmtU/EJMk0AJbMxrkrFPN5p/f67brlNr82c6PaCDSFcroumJ4U0xvWjHD1stsiSZwVMrNwr3hzkyzfZ1koiB+cJqRsooJMKPjP93nAEvK2UdQAYOg3PBDS1lD/ouq1G7bK7D1Q7ohYP7MNR1dSHfeCKYSwnvuZzatBEd7R7lw9otAAP+R7Qr7nWBcMUiRyC0s+HyfeG9mVUpRIAjkMRXibstdOwoz9QPcIrO5MYt/BcpysF+XsOGLec5Gtqo9cC78Uv9drZ+tKYSvLZb8nNI/vWEOperZTEsjx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On 24 Feb 2025, at 14:31, Borislav Petkov wrote: >=20 > On Sun, Feb 23, 2025 at 02:48:54PM -0500, Rik van Riel wrote: >> Use broadcast TLB invalidation for kernel addresses when available. >>=20 >> Remove the need to send IPIs for kernel TLB flushes. >>=20 >> Signed-off-by: Rik van Riel >> Reviewed-by: Nadav Amit Nothing concrete against this patch, but I do not remember reviewing it thoroughly, and I do not see that I sent any =E2=80=9CReviewed-by=E2=80=9D= tag for it before, so please remove it. I only reviewed thoroughly and gave =E2=80=9Creviewed-by=E2=80=9D for patch 9. [ I would note at this opportunity that while I managed to convince = myself patch 9 is safe, I personally would have considered taking a more = defensive approach there. I may reiterate it there. ]