From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B55CC432C0 for ; Wed, 27 Nov 2019 19:06:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E3D202080F for ; Wed, 27 Nov 2019 19:05:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Dvz3/mFm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3D202080F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 839796B04CC; Wed, 27 Nov 2019 14:05:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C1F86B04E2; Wed, 27 Nov 2019 14:05:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68AAD6B04E3; Wed, 27 Nov 2019 14:05:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 4DCD46B04CC for ; Wed, 27 Nov 2019 14:05:59 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id F2125824999B for ; Wed, 27 Nov 2019 19:05:58 +0000 (UTC) X-FDA: 76202987196.07.ear89_514495a259157 X-HE-Tag: ear89_514495a259157 X-Filterd-Recvd-Size: 5536 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Nov 2019 19:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574881557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nPK1uKbvCdfloKioaMzTiu8Ub2ENTVhi00J6YfIG22A=; b=Dvz3/mFmXJhPDxWME0egHZgSP4c4cGdIfxGU22uUKoaXPPcbvIPC5IG5GgTRyUnTPCrR5y xLzju1qlplk8K/Ie8nG0Y17eFT3BdOtjUEta8B6qVLveXXWOTsa9xKfTgpbeJrDdbpnveB cBoO1gxzLWx2eGL3IRg5MN8SDQJ2LJU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-G7pTzcywODqlpoJ-CzkXeA-1; Wed, 27 Nov 2019 14:05:56 -0500 Received: by mail-wm1-f69.google.com with SMTP id y133so2778752wmd.8 for ; Wed, 27 Nov 2019 11:05:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=N+mx2v5Qhmct9j+TWX3Bk8z8S7DDXof1/IQjLkrr1bY=; b=bbkGyYHmvdsvbgovgO6h+VKZ6dfs/v678NirA3tyQUE3+9s/sQUhO6FyTCl7urMQ1s nfbplUY0qAbV1ggCkIFyVIPxsL7qykG/JaTQStWgqeod9L/zCB3BRzn60I5ffwC95BJ3 dUma9WUWCZmZEIHhfBFwFsDYDmg/ZmFrbzX7x0pVH1TUE2cN+cwkN+2ZFU9pGh1fRloK P6ViI0LyAgxYiFEhnaMziVeMpS8CUH5K7xGZSs06yNnjWZ0OypNzVPTSMqcKRV5Ff4Ih /L6H/W7S0nNatosPdTn6ETIwOBypRQJm6drPrSS8/Is8iRTKAqrPEy6MK2Ld8u0ZiDqI +NnA== X-Gm-Message-State: APjAAAXNy1iwtsZniYytsuQQbRPhkx+WlKN6GpmgiOOPmv4XyuQL++Js yP608Jxbq4dIWsu16lfISVh1d6LjzViRtUspHma9v4hmPqafy8ZCek05IziKz7hEHFsB0dHyQf0 Fh1ScTkcpLiA= X-Received: by 2002:adf:e94e:: with SMTP id m14mr45434448wrn.233.1574881555436; Wed, 27 Nov 2019 11:05:55 -0800 (PST) X-Google-Smtp-Source: APXvYqzS3GD0yCu0lPMXf7TJ3jsw4UEOG2LnCGqBp/mJt19sZ8lSVW7CRB+bzWsy9O6DezolcMRjCw== X-Received: by 2002:adf:e94e:: with SMTP id m14mr45434430wrn.233.1574881555252; Wed, 27 Nov 2019 11:05:55 -0800 (PST) Received: from [192.168.3.122] (p5B0C6355.dip0.t-ipconnect.de. [91.12.99.85]) by smtp.gmail.com with ESMTPSA id g74sm7515055wme.5.2019.11.27.11.05.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2019 11:05:54 -0800 (PST) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn Date: Wed, 27 Nov 2019 20:05:52 +0100 Message-Id: <1F8C5EE3-4F07-4B23-9612-25FA265557C5@redhat.com> References: <74CE315E-319F-4D2D-8276-7F89293286CF@lca.pw> Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Michal Hocko , Oscar Salvador In-Reply-To: <74CE315E-319F-4D2D-8276-7F89293286CF@lca.pw> To: Qian Cai X-Mailer: iPhone Mail (17A878) X-MC-Unique: G7pTzcywODqlpoJ-CzkXeA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 27.11.2019 um 20:03 schrieb Qian Cai : >=20 > =EF=BB=BF >=20 >> On Nov 27, 2019, at 12:42 PM, David Hildenbrand wrote= : >>=20 >> Now that we always check against a zone, we can stop checking against >> the nid, it is implicitly covered by the zone. >>=20 >> Cc: Andrew Morton >> Cc: Michal Hocko >> Cc: Oscar Salvador >> Signed-off-by: David Hildenbrand >> --- >> mm/memory_hotplug.c | 23 ++++++++--------------- >> 1 file changed, 8 insertions(+), 15 deletions(-) >>=20 >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 46b2e056a43f..602f753c662c 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -344,17 +344,14 @@ int __ref __add_pages(int nid, unsigned long pfn, = unsigned long nr_pages, >> } >>=20 >> /* find the smallest valid pfn in the range [start_pfn, end_pfn) */ >> -static unsigned long find_smallest_section_pfn(int nid, struct zone *zo= ne, >> - unsigned long start_pfn, >> - unsigned long end_pfn) >> +static unsigned long find_smallest_section_pfn(struct zone *zone, >> + unsigned long start_pfn, >> + unsigned long end_pfn) >> { >> for (; start_pfn < end_pfn; start_pfn +=3D PAGES_PER_SUBSECTION) { >> if (unlikely(!pfn_to_online_page(start_pfn))) >> continue; >>=20 >> - if (unlikely(pfn_to_nid(start_pfn) !=3D nid)) >> - continue; >=20 > Are you sure? I thought this is to check against machines with odd layout= s, no?=20 The zone pointer is unique for every node. (in contrast to the zone index). Thanks! >=20 > /* > * Nodes's pfns can be overlapping. > * We know some arch can have a nodes layout such as > * -------------pfn--------------> > * N0 | N1 | N2 | N0 | N1 | N2|.... > */ >=20