From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93EE1C02183 for ; Fri, 17 Jan 2025 19:09:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8651280005; Fri, 17 Jan 2025 14:09:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E358B280004; Fri, 17 Jan 2025 14:09:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD6C0280005; Fri, 17 Jan 2025 14:09:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AA91A280004 for ; Fri, 17 Jan 2025 14:09:30 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5788CC0A66 for ; Fri, 17 Jan 2025 19:09:30 +0000 (UTC) X-FDA: 83017882500.12.1F83613 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2078.outbound.protection.outlook.com [40.107.237.78]) by imf08.hostedemail.com (Postfix) with ESMTP id 7204816001D for ; Fri, 17 Jan 2025 19:09:27 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=g7bg8F13; spf=pass (imf08.hostedemail.com: domain of ziy@nvidia.com designates 40.107.237.78 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737140967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qhjz9o9AeVD36lgWDGo3rT11YVCJc8M6hT5GKSzF60Q=; b=rXhDIw6AcgrPENwWzziGCRsaDF2hxUIVkXggiD5GagH7pOZgP9TSRoX1ZzGdXqE0GDsMas lumsbvrc44nwQIQnB34V1+BVk1g4nYoiPlczZ7C9pDQTEW75EL4dbSnPU7RVU7iBn+d17B bzcah8lbHouIDDubJeFxzNYLpxCFVrs= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=g7bg8F13; spf=pass (imf08.hostedemail.com: domain of ziy@nvidia.com designates 40.107.237.78 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1737140967; a=rsa-sha256; cv=pass; b=JnveD+pBA4/qFEKpadbeEFQYzU7A+z04ZantG8JSFIlc41dTKqTQ3gbiOdHrX+jI/KrtTY t1X2ALM1B6hrd4fEmTf/IlLk7R2YL39vtKVE5jhZxRFx8Hc/ZzDU6lJIAeupf+7HTXPbhh 54aq552nrsCnh42YBu9unl31aiODzxQ= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ODFgeXSLeikoqvORrGPZdVGRyhS+8FNX8EQ/tMgGLqPrT+SSvEDY9EVaNCQoz1e40h55Wi6L5o03lI+Itlix+krAtA1OyacFkJAcnU5MoTJpylsNGVSxPQIuKapW7jxxh30r0Tl2c37upWcOyNXJzCvdM+nbuXepe321L/+g3ltCM9ZT7ReD9OVbwh5FX3onKoLbD7jlzurHPdDJCM2I7T1fEurpwXATaDeWx85elgldvg+V4r5J9Wn/7Gt6qkwzH1zq8FAtm8XUTshlehv7KBs/5g6MF/W7iW8thDakBtDhWFB27FLf6qnKEMvK3CseUdENQ4nVMEMgZ5UthGpEew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qhjz9o9AeVD36lgWDGo3rT11YVCJc8M6hT5GKSzF60Q=; b=x3UV9+gcmG5jTqxvgntJEuWgS2MM+pdh57w7l7FWmPgqaxW70RmuRO9sOkSHyfwmHOBVKkjVp4uP0GRXxzkGQ7QXzMNnENKdLu9EI/4fjSZHmSQaioZ0KGCOlbcvf5y1VKaJs9zZRxoxgeGy3B6L8vboiC9CV6HOH3O6DeMUaadDgIRfmFSra0zsLcT+S80mBi6SRMIscjDyHR/t5M8dsjsbwU8uX1X50Lcwyq32EIY1om/m59Lvclx2sHG8GK5zYpij4vzY56WKSt96h9+YvcrIrJ6+xznxG5NkDGqkD8DEQMCJk6TiqkYLMXL4VWCmY79Mtvx1bzSdMmiT4rGaCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qhjz9o9AeVD36lgWDGo3rT11YVCJc8M6hT5GKSzF60Q=; b=g7bg8F13Rjl1EVdeLFB4K9xFLNyzUaBKUTv8HQjQf0RiiVjaxqqco+Sf/hpCvG93Uk7bgJBZi6zsTv1dRrmxiXT9x61Nr2iUqaVBSxWnGrMy1SekrBH/CMENa6dktxKu70iN+CwGhXPJ0D/mlvh0TnaESZ557uU6tMkj/I514Wx2i/X/XIGLbkKp33nf8XdqSXdvkuodckz7Eb+pj0RDPkkZNnH4SQ+vUnftCRCwjviYVgkimwBUmsNUBBSHHjPe+jAs1PGOv/EQ/TtZLWSO/LQAYROo2JlIv2hIhLSchx51LGY3//3IKnMIjtWrythGSYc084K2L1657QilTPT/Tw== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9133.namprd12.prod.outlook.com (2603:10b6:408:188::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.16; Fri, 17 Jan 2025 19:09:25 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%3]) with mapi id 15.20.8356.014; Fri, 17 Jan 2025 19:09:25 +0000 From: Zi Yan To: Hyeonggon Yoo Cc: Bruno Faccini , linux-kernel@vger.kernel.org, kernel_team@skhynix.com, 42.hyeyoo@gmail.com, linux-mm@kvack.org, akpm@linux-foundation.org, rppt@kernel.org, david@redhat.com, jhubbard@nvidia.com, mrusiniak@nvidia.com Subject: Re: [fake numa not working] [PATCH 1/1] mm/fake-numa: allow later numa node hotplug Date: Fri, 17 Jan 2025 14:09:22 -0500 X-Mailer: MailMate (2.0r6203) Message-ID: <1DC02706-256B-4B61-B309-7D86595F4B22@nvidia.com> In-Reply-To: References: <20250106120659.359610-1-bfaccini@nvidia.com> <20250106120659.359610-2-bfaccini@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0195.namprd13.prod.outlook.com (2603:10b6:208:2be::20) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9133:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c4ba6ae-9539-4828-71b8-08dd372a751d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VW8xbmhVejVCWk4vWWJOcDRLWG55TXBLTzFvd21pdzJZV3VNQ0pSL05ibHJm?= =?utf-8?B?NHBpTFR3MkM1cU52bHRQaFU5SVpUUGNmVjBIUlRmdTY1endCS2hiSkpROHR6?= =?utf-8?B?SVdnZWlST0RTaEJlNXhCeE1CN28vRzE2cFFSQ3VaTGNOUVJiTFB6SVdzS0M2?= =?utf-8?B?KzhoM2owTWNHbk4xbUNuZjBXTzhsUjNVTHEwMGlGOWhuY2NwOGh5cFBEclly?= =?utf-8?B?VU5YZ1B2NWYyOGQ4dVpvU3dlVnlCWFEyeHVZQm9RRXVMU01lQ2ZNR2x1VzZM?= =?utf-8?B?M2lDUGQ0SVVzcUNwL0dZRGU5bHVmZUpEdTVQTUNzMWFFeS9zalpZajIxQmtu?= =?utf-8?B?UkppNGVKMzVDU1hiNHgrbUY5ZzVDNnhiN1J1dEpzdFM5VGhobExvWm1ZWmla?= =?utf-8?B?T3ozeDQvYisycGhKOEliTldKN1dKNWJkWkJaZnVqVTVpSWRycExnKzVoVjlq?= =?utf-8?B?ZzgzK0QwK2RHak1WMkdMYVJyRmI3Q2lFa0NVUVpyc3VLL0JrWUtybTVKNTVB?= =?utf-8?B?cFo2MEdIMEg5TCt6dnp5S1B4WjhaRG1aeUtGSW55VlBnTXJrd2lJa2VoZHl0?= =?utf-8?B?UlR3Z2ViMXVIREQ5L1FZczIwSU42b0ZxNVRISzNHV1IzVzYvNVk0S2RjRzVI?= =?utf-8?B?Y1FsVys3ZmdwT0VHaGZnN1FOdnlLbCtEcmZPQXJ6VC84NC9TdGNPTVB5NWRZ?= =?utf-8?B?QjVCOU5HandSaU1ya3lkSVAwUi9yb3JtWVBjWS9qK0ZsNEttV3Y0RjRyZU51?= =?utf-8?B?NjJNTFlsQlkwNlMxUlp2Z0VFQjJHMUpXZEY1RVAxcDdCTmVtZ2VhOFUrdFBB?= =?utf-8?B?dWwxbUdNY250eHZVUUhiNFpKbFEzbDhGeHp3cERQTmVVN3ZiVEpuV2lCdTUz?= =?utf-8?B?MTd0elQ0MmdMYU8vN05ueUFlNkRiRVplQWxYTEtuVDd0cGQxMGdZOFpmRFNW?= =?utf-8?B?c0dWSW9LYXZmSEh1M0ttZEpJTTEwV292YzdZY0lTNlVoRXRrQnBhTHJVUkFz?= =?utf-8?B?dkppM1VFd0s5THZMdjlOa01pQ2pwSVJYTWJNSmNNbkxXL1I4bGgvWDNPUGRt?= =?utf-8?B?TVRpUEJibjQ5VElhWXBaMVFtQ0d5bmk0UThqZ09ycjdPdEx4Q1M4M3pabDZ4?= =?utf-8?B?dm9Ydlo4MWxzWWxKZkpxQkNlczR4OUR1eU1zMXpyamw5Q1pnWm45VlMyZDBJ?= =?utf-8?B?a1l6ODluS2YwNUNzTDdxbCtKTVc1UW9FV3c0QWtqS2xOUklTb2djZXkzMTV1?= =?utf-8?B?WHY3NnRjMHNTYjZHOHdHY1ZnTDN1TTJXa2hYMHlpaVc1Z0NOQ1cwdmdOU2t5?= =?utf-8?B?Qy9Xbmo1Y09pMCtkbzl1eTRVVW9WNTJ4RC9jdkR4UmNxVDB4by9DVFFkb3Zi?= =?utf-8?B?L3JxdWJkRGxlSEw3a29IR2hNT2NiTWpteXU1S0NVbzJsOWhXd25vbmwydllm?= =?utf-8?B?U3ovakhWdko5dkRCSXRUY3IrNUhnRk41L3VjTmJLYXlNcmpleUxWcDJwbEpW?= =?utf-8?B?VXFETURxSTBJd0tleGg5NTBNbGRRMVRLUGxtK1hHT3EwT2pISytUWk1XcmQ4?= =?utf-8?B?MUhQeEMrdWRsMnhLZVdwdXI3bHVDanF1NjZobi9XWmdJcnlHS0tRWDlwRlFE?= =?utf-8?B?YWNXSlhZSk9GZlVUWExYVHBzcnNGZXg2U1l5c1RkRjcza0lUQUtpSTFJY0t5?= =?utf-8?B?VVU3dVBGYWVCQVJMclpmRDBTb28zTzNSM2lja21NekNoTjU0cjlQZDY3WTlR?= =?utf-8?B?bGhob2VYNklWNGRPV0VKcXcyMmdCNUdCZ2xwZkJaMU5CcDF1aStoOFJaVUI1?= =?utf-8?B?U09nandlVytIZGE1WWNBRFM3aXliMDljYmlod0xUOG45SCtEenZmVllDTlRy?= =?utf-8?Q?6Xx3Kwn6EJs7p?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkxiTDVPRTBRVHNsM2lOR20zY2YzK0dnWFNHc2lqV0puNkZHeUZPbVBDRHlL?= =?utf-8?B?ZWRDN1huNGtWSVBZTXE4TmQxdlhaRlZ0ME1IWFBPQzhNanFGNjd2ZE8rdzN5?= =?utf-8?B?ZEVncFM4bHREQW12T1dCYmh0cTBjQVRjVU5LZ1hXdkV6OFdRTlRWNUo1UFNj?= =?utf-8?B?RkpIajNUdDl5SC9DSU8zYkRRZkdpdDVxNTdab3FxY2hHVy9DdWNseHNMN2x1?= =?utf-8?B?NXlYYWZVbWh3ZmhLaTZzUGx5TE5WZTUxQjNtamE2WjFMTGV1Zm9EM2c1T2Jq?= =?utf-8?B?MlQyckEwRE53STBrSlkwa0Z6KzRQckxGcTlxRHlIWFI5NGpDTG42QWVDeGZ0?= =?utf-8?B?NzJnRXZGQkt6cjBpZkxIRG9JYzhEVUpXdGVUWHBSMjFlY2ZYNEorTWFSYmpr?= =?utf-8?B?Znc5a05XNTM3czJhMW50VFNqbzZyTndzWng3bGxpdDFucGVZR3JuUWFZUkhz?= =?utf-8?B?OUY4K0cyME5SY0ZwemdtMnJKaUNDOWtVdVlsQ1Fvb1luTDRZNXRsclVxcGI2?= =?utf-8?B?OStzZkdrbTNWb0tUT0t4TGUxaFk3aU9KSlYzcEUvOG5KYUgvWmZKVW1iT2tJ?= =?utf-8?B?bVVXTkZtMVVJVWYwMWY5M3FQYkdXQnZpbTF2eExWczlDcmRSYkxwZGJHUkJX?= =?utf-8?B?dXVqbi9Bczk3bVErTGFzOXZTU0FhOG11OG1mZk1lWFBhbzhhMFFnckZkNU4x?= =?utf-8?B?c3lRbnR0dGNUclpHektvUXUwYzJXU3R2NGh0SmFJZ1JQdWRTRXRxWmt5bHlO?= =?utf-8?B?cXhqelJ6OWlMZi82R1Exc29va3c0bFV0WElIdE9GVjM5eFlxY1ptaFpFVU1Z?= =?utf-8?B?OEZZWW5IRHpwTDNYK1A0ekFkaFdCcTAwWEtwaWRFTml4Y2NJU1lVZDRWMjMw?= =?utf-8?B?S1E4NEx0WGVBVHdaSkw0ZmFPdmpqT09GRUJwRktiMW0xTURRLzJuZlZXblpq?= =?utf-8?B?SlRWZTE4SXpXdEx1R29VSFdWcGVGTmN3eVRlRGhRd04wcGtwQnNKWktZTWcy?= =?utf-8?B?c0c5UGhMMU90TitDdEFPemwxdFFqK2dMKytxREpCdXh3V3FHUTlnSzJ1aDYz?= =?utf-8?B?QXgzMUh2bUJyWVpoeXhRZW9mYVpLVTVaQjVZeHg4eVpBNHNpV2RwZW9tbHRS?= =?utf-8?B?bG1BSHNlSGZwcXVlaW85cTR0KzFCYjFGbzRmdXFTcERrOUo3cGlIMzYzbXJ1?= =?utf-8?B?MUZaNXV1MGZtY1phVVZaNnNtYnMxcmNIbWJyRmNzckwzcGtVelpOMUxpS21S?= =?utf-8?B?TkZ2ajE3ZGEzQlgwNkhYd3JPWHg5bEluNDJZNENCZmFnOUl2ZllLVlBmOW1W?= =?utf-8?B?b0FnQWIySmpDVlRmNC90S2h2UFFQbTlRNG5rNEo2TU1xU3FHd3UyOWtVcWFY?= =?utf-8?B?dnRNLy9oR3V3V0x6NmpXcXRFVU1vbVQ0YXczcVRRN0s5dVBGcXhVTENkanV2?= =?utf-8?B?TmlYKzc2ZVZVWmJadWRiR2cyVFZ5M1hEc0RjSHphenRnY0FrbWpMcmJuSHBO?= =?utf-8?B?ZjZPME44NW9oaHREUUlZY1Y1Sjg2QU00YkdGai9BZVpFelphN04xVFZRcUhK?= =?utf-8?B?ZVd2alhsaFVqSU9sZ1M0Zit5bUlnRmZsZmFHTHg2aDhNUkxqZjlTQXVxNHpk?= =?utf-8?B?aGVwWnpkSlBNeExhdWhnaUIwcDMyWWpHUGxTSGE5Z01ZdjI0YWZTOSs0aEJk?= =?utf-8?B?UW84N3BWNWZjdWFyZ0lMRlRqWE9zc0V3Y01qMHBSL2tXUVFMNy91V2pQY3Zu?= =?utf-8?B?WEdDMTBkc1ZoSHBybVBqMFZvM08xV0Y5cFU2a2hGbkNuV0hXMkE3YnNjSjhu?= =?utf-8?B?cm5EQmR5TnZoY1hHTU9XM3pMOFpxNjRxaDBXMHQ2dVRYU3dlVWcrYm1zNTRV?= =?utf-8?B?aFY1Y2s2ZXBtSFpGYVM2bWpLTGpEbG53cjI4UWo2cVNjb29BeHZIc0ErQkRa?= =?utf-8?B?UUxVYWJPak93bWFYYzlrazBsQXEzMkRqUWNnb0VmTlVoZW9nQ0RKTVdRYmw2?= =?utf-8?B?a0tsbWgzbTdwMkhEWGYvdmFDSWxlUXM2RnN6Y1dDL1hETWI5L0R3WlA4VVZN?= =?utf-8?B?RFExczcxYnErZmxNTzZLMlJ1RjhSRmNZVCs1TTcwYWpDNTdKeWhRd1orVnRo?= =?utf-8?Q?pZpSM8cq1RK13FR1+PwdSW6uW?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c4ba6ae-9539-4828-71b8-08dd372a751d X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 19:09:25.0865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lO+yBqPEXC5j0VvI3AfvESkd9QoRSPesPXzQ0sr4LW+k5aEH7dwpGROGxuVBA1eG X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9133 X-Rspamd-Queue-Id: 7204816001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wx6ieg1osh7bo89mof5agxhhzf5p3hmc X-HE-Tag: 1737140967-253869 X-HE-Meta: U2FsdGVkX19MI7yAaL6xdwG4Ac4nZSWfIeV1rrOEHlVy88dVH3fYKVuVbhoHrF2K8nRSE+Y5JxFntaV3IezFY5nQ48TVz1kJiQI1vwleq4A+XUsrrKl5iRWh8S8l4yQCR60AQWkbu5Kuz+L5TexS1Xle6b+vs58zwhlD6GqFvXgHJJfGCH1nb0b3quxl+cv+CnJaDir34CfoE1ceuqkRMZiglNB3AsHt6CnwA1R6QtIqZBTw+RCFgMHH7ZpTwfLNCaKTj1CCMKj9/THNvaN5sbO6OnVMNyvqj/9zo5cG5zzDiyEbEhPY6lMRsf6gK5hpAKeohzNajWoyYxok5vodvG/5mClAV0PDhWLuFXfX/g6yare0EsUI+HgOfchaHtPSm4yYUhUReTrwIPr6zNbBvqPCAoJfPVJDCrq+bz99OB3nKHUNp3L7BPD+PWNZxndu97BqF2xfatro7x/IrpXoSyxeAyOiBbV2GafxRTY3fEV/aYo5ElLcKjo8lsofT8FqmRdoAsbUBBh5CHnTNh00ZDuwJZuhfQgoKtP3+FsMRgNZ6U8Y5a7rDlp2W8fYZVIeO9NJc6VGM4IMkSVyLzAUiW9cC22MLC0PPuk3Gp8mAmghieeZK2UB6cKo9Oj7Ze98aL9Jp/u0a/vUZR8aDipuuAKHruTXLC5KNTqfHNOu0mahExUgHUkAO7W6xP1RoAiY6iHkRjALZRLnwiBdq5nafrieam195zlbttNl/9KZfKKhTgcHcIxgDbJUz8UQdgy3VLVbNRxYskF7FvZCm7ucHwxewRluMaFvw60XtPbez5YNbXPDoQSu05A/+Y4cDso7pWev7OfqCQyi71YnMQ4lfW4dSCHPinRD45pMPfCB4C0xy9fDB+rzhl+N4OMU7lP60ZtPTt3e8v1d+hNoFUgpmSTN48uKdqLFAhXKE08amWtJCWij7RMoxldo2whgslwPaQWKfHJLkmaIt0038g1 9xaAAMYi 0FwXBCI8Yh6UPr+FmlRpBllS1U66iTYxZlK83BQstuqnl2UfCz61QVTgjXkGlzzOj0H5mGJJBFDSpYrPXezRmPML7JKnPohUpUlALDkHcjBZDQS8vDDCEuoSpPES/sXsZOgCcD129BWU/KENheleZm0mLeqzlNYd3PEgpnL2NfGzyR+OyKMSn5WRlMzhmMoYNsj8eNqoeK3bcTLwM55uBAt/OiMOLjStckGS6GDPwWOqvKdea9HHHJVz8HyoF3iHv8+AOh4aCnfpIz57z/t1WbB7MVJEY0ohhyhK+n/qRXREYD7pRlE8lKwwMYmO8iLhmDwF9jsdEPr0Njchv52Rbi/wmIEfUYzERXdgK53ZnpN8A7fFIPNvxDbkFpOAXWm6DJP+vsJjTIgNshZw25Yox6pU3OdavjIeKxUCquoc7yBwwnrg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17 Jan 2025, at 0:00, Hyeonggon Yoo wrote: > On 1/6/2025 9:06 PM, Bruno Faccini wrote: >> Current fake-numa implementation prevents new Numa >> nodes to be later hot-plugged by drivers. >> A common symptom of this limitation is the >> "node was absent from the node_possible_map" >> message by associated warning in mm/memory_hotplug.c: >> add_memory_resource(). >> This comes from the lack of remapping in both >> pxm_to_node_map[] and node_to_pxm_map[] tables >> to take fake-numa nodes into account and thus >> triggers collisions with original and physical nodes >> only-mapping that had been determined from BIOS tables. >> This patch fixes this by doing the necessary node-ids >> translation in both pxm_to_node_map[]/node_to_pxm_map[] >> tables. >> node_distance[] table has also been fixed accordingly. >> >> Signed-off-by: Bruno Faccini > > Hi Bruno, > > This commit causes WARN() and disables fakenuma > when I pass "numa=3Dfake=3D4U" on my QEMU setup. > > Attaching WARN() log and git bisect log to help debugging. Is your VM getting 4 NUMA nodes at the end? Can you also share your QEMU command line and your kernel config? This can help Bruno reproduce the issue locally. At least, I cannot reproduce it on mm-everything-2025-01-16-23-18. I also notice that my VM does not have =E2=80=9CNo NUMA configuration found=E2=80= =9D (in your log) in its kernel log and that might explain why I could not reproduce it. Thanks. > > Best, > Hyeonggon > > [WARN() splat] > > [ 0.009676] No NUMA configuration found > [ 0.009677] Faking a node at [mem 0x0000000000000000-0x000000083ffffff= f] > [ 0.009705] Fake node size 16895MB too small, increasing to 16896MB > [ 0.009708] Faking node 0 at [mem 0x0000000000001000-0x0000000420000ff= f] (16896MB) > [ 0.009711] Faking node 1 at [mem 0x0000000420001000-0x000000083ffffff= f] (16895MB) > [ 0.009738] ------------[ cut here ]------------ > [ 0.009739] -1 max nid when expected 1 > [ 0.009760] WARNING: CPU: 0 PID: 0 at drivers/acpi/numa/srat.c:120 fix= _pxm_node_maps+0x577/0x810 > [ 0.009766] Modules linked in: > [ 0.009769] CPU: 0 UID: 0 PID: 0 Comm: swapper Not tainted 6.13.0-rc6+= #31 > [ 0.009771] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIO= S 1.15.0-1 04/01/2014 > [ 0.009772] RIP: 0010:fix_pxm_node_maps+0x577/0x810 > [ 0.009774] Code: 8b 85 40 ff ff ff 44 8b 8d 44 ff ff ff 8b 85 48 ff f= f ff e9 83 fb ff ff 44 89 f2 44 89 ce 48 c7 c7 aa 2f 84 8d e8 b9 71 01 fe <= 0f> 0b 41 b8 ff ff ff ff e9 ba fb ff ff 48 c7 c7 a0 d8 d1 8d 44 89 > [ 0.009776] RSP: 0000:ffffffff8da03be0 EFLAGS: 00010046 ORIG_RAX: 0000= 000000000000 > [ 0.009778] RAX: 0000000000000000 RBX: 0000000000000400 RCX: 000000000= 0000000 > [ 0.009779] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 000000000= 0000000 > [ 0.009780] RBP: ffffffff8da03ca8 R08: 0000000000000000 R09: 000000000= 0000000 > [ 0.009781] R10: 0000000000000000 R11: 0000000000000000 R12: 000000000= 0000001 > [ 0.009782] R13: 00000000000007ff R14: 0000000000000001 R15: 000000000= 0000000 > [ 0.009783] FS: 0000000000000000(0000) GS:ffffffff8de8c000(0000) knlG= S:0000000000000000 > [ 0.009784] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 0.009785] CR2: ffff90e4bde01000 CR3: 00000001bd03e000 CR4: 000000000= 00200b0 > [ 0.009788] Call Trace: > [ 0.009790] > [ 0.009792] ? show_regs+0x71/0x90 > [ 0.009797] ? __warn+0x8d/0x150 > [ 0.009799] ? fix_pxm_node_maps+0x577/0x810 > [ 0.009802] ? report_bug+0x1ab/0x1c0 > [ 0.009805] ? fixup_exception+0x27/0x380 > [ 0.009809] ? early_fixup_exception+0xa2/0xf0 > [ 0.009813] ? do_early_exception+0x28/0x90 > [ 0.009816] ? early_idt_handler_common+0x2f/0x3a > [ 0.009819] ? fix_pxm_node_maps+0x577/0x810 > [ 0.009822] ? numa_cleanup_meminfo+0x8c/0x5b0 > [ 0.009828] numa_emulation+0x4e3/0xad0 > [ 0.009830] ? __pfx_dummy_numa_init+0x10/0x10 > [ 0.009833] ? __pfx_dummy_numa_init+0x10/0x10 > [ 0.009836] numa_memblks_init+0x10c/0x2c0 > [ 0.009838] ? __pfx_dummy_numa_init+0x10/0x10 > [ 0.009840] numa_init+0x61/0x3e0 > [ 0.009842] ? topology_register_boot_apic+0x2a/0x40 > [ 0.009846] x86_numa_init+0x65/0x80 > [ 0.009848] initmem_init+0xe/0x20 > [ 0.009850] setup_arch+0x9d8/0xfa0 > [ 0.009852] ? _printk+0x58/0x90 > [ 0.009855] start_kernel+0x5f/0xb50 > [ 0.009860] x86_64_start_reservations+0x18/0x30 > [ 0.009863] x86_64_start_kernel+0xc0/0x110 > [ 0.009864] ? setup_ghcb+0xe/0x140 > [ 0.009867] common_startup_64+0x13e/0x141 > [ 0.009871] > [ 0.009871] ---[ end trace 0000000000000000 ]--- > > [Git bisect log] > > # bad: [f378252a2168c2fbf8fc08b635061e5f6748c1f2] kasan: sw_tags: use str= _on_off() helper in kasan_init_sw_tags() > git bisect bad f378252a2168c2fbf8fc08b635061e5f6748c1f2 > # good: [cbc5dde0a461240046e8a41c43d7c3b76d5db952] fs/proc: fix softlocku= p in __read_vmcore (part 2) > git bisect good cbc5dde0a461240046e8a41c43d7c3b76d5db952 > # good: [fb73203263021f2ee9dd54d280b1c543d10acd76] mm: move common part o= f pagetable_*_ctor to helper > git bisect good fb73203263021f2ee9dd54d280b1c543d10acd76 > # bad: [8fd966c9310f14d5bbe653cf087853582170aad6] mm, swap: remove old al= location path for HDD > git bisect bad 8fd966c9310f14d5bbe653cf087853582170aad6 > # bad: [8646971f02651146554233d63fdd721f5f060973] mm: shmem: skip swapcac= he for swapin of synchronous swap device > git bisect bad 8646971f02651146554233d63fdd721f5f060973 > # good: [b8ba614eaa8dd31702c61e7df7231b1b18b99259] mm/damon/paddr: report= filter-passed bytes back for DAMOS_STAT action > git bisect good b8ba614eaa8dd31702c61e7df7231b1b18b99259 > # good: [fd0935b8e9e8c2edf05a3d0ffa09d0aa3e9cf2dd] Docs/ABI/damon: docume= nt per-region DAMOS filter-passed bytes stat file > git bisect good fd0935b8e9e8c2edf05a3d0ffa09d0aa3e9cf2dd > # good: [3ffd3cd7e2e8793d3b5fbb83c03668c47ab6d599] selftests/damon: remov= e tests for DAMON debugfs interface > git bisect good 3ffd3cd7e2e8793d3b5fbb83c03668c47ab6d599 > # good: [bf9f93f0b7bff8af780330f5094775a39caf3612] mm/damon: remove DAMON= debugfs interface > git bisect good bf9f93f0b7bff8af780330f5094775a39caf3612 > # bad: [1746744be6ff271e29345a5be4cc144aa33b10ab] mm/memmap: prevent doub= le scanning of memmap by kmemleak > git bisect bad 1746744be6ff271e29345a5be4cc144aa33b10ab > # bad: [ca19a5ab8756ef78c34d02d2b8c266a9cc7bf57d] mm/fake-numa: allow lat= er numa node hotplug > git bisect bad ca19a5ab8756ef78c34d02d2b8c266a9cc7bf57d > # first bad commit: [ca19a5ab8756ef78c34d02d2b8c266a9cc7bf57d] mm/fake-nu= ma: allow later numa node hotplug > >> --- >> drivers/acpi/numa/srat.c | 86 ++++++++++++++++++++++++++++++++++++ >> include/acpi/acpi_numa.h | 5 +++ >> include/linux/numa_memblks.h | 3 ++ >> mm/numa_emulation.c | 45 ++++++++++++++++--- >> mm/numa_memblks.c | 2 +- >> 5 files changed, 133 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c >> index bec0dcd1f9c3..59fffe34c9d0 100644 >> --- a/drivers/acpi/numa/srat.c >> +++ b/drivers/acpi/numa/srat.c >> @@ -81,6 +81,92 @@ int acpi_map_pxm_to_node(int pxm) >> } >> EXPORT_SYMBOL(acpi_map_pxm_to_node); >> +#ifdef CONFIG_NUMA_EMU >> +/* >> + * Take max_nid - 1 fake-numa nodes into account in both >> + * pxm_to_node_map()/node_to_pxm_map[] tables. >> + */ >> +int __init fix_pxm_node_maps(int max_nid) >> +{ >> + static int pxm_to_node_map_copy[MAX_PXM_DOMAINS] __initdata >> + =3D { [0 ... MAX_PXM_DOMAINS - 1] =3D NUMA_NO_NODE }; >> + static int node_to_pxm_map_copy[MAX_NUMNODES] __initdata >> + =3D { [0 ... MAX_NUMNODES - 1] =3D PXM_INVAL }; >> + int i, j, index =3D -1, count =3D 0; >> + nodemask_t nodes_to_enable; >> + >> + if (numa_off || srat_disabled()) >> + return -1; >> + >> + /* find fake nodes PXM mapping */ >> + for (i =3D 0; i < MAX_NUMNODES; i++) { >> + if (node_to_pxm_map[i] !=3D PXM_INVAL) { >> + for (j =3D 0; j <=3D max_nid; j++) { >> + if ((emu_nid_to_phys[j] =3D=3D i) && >> + WARN(node_to_pxm_map_copy[j] !=3D PXM_INVAL, >> + "Node %d is already binded to PXM %d\n", >> + j, node_to_pxm_map_copy[j])) >> + return -1; >> + if (emu_nid_to_phys[j] =3D=3D i) { >> + node_to_pxm_map_copy[j] =3D >> + node_to_pxm_map[i]; >> + if (j > index) >> + index =3D j; >> + count++; >> + } >> + } >> + } >> + } >> + if (WARN(index !=3D max_nid, "%d max nid when expected %d\n", >> + index, max_nid)) >> + return -1; >> + >> + nodes_clear(nodes_to_enable); >> + >> + /* map phys nodes not used for fake nodes */ >> + for (i =3D 0; i < MAX_NUMNODES; i++) { >> + if (node_to_pxm_map[i] !=3D PXM_INVAL) { >> + for (j =3D 0; j <=3D max_nid; j++) >> + if (emu_nid_to_phys[j] =3D=3D i) >> + break; >> + /* fake nodes PXM mapping has been done */ >> + if (j <=3D max_nid) >> + continue; >> + /* find first hole */ >> + for (j =3D 0; >> + j < MAX_NUMNODES && >> + node_to_pxm_map_copy[j] !=3D PXM_INVAL; >> + j++) >> + ; >> + if (WARN(j =3D=3D MAX_NUMNODES, >> + "Number of nodes exceeds MAX_NUMNODES\n")) >> + return -1; >> + node_to_pxm_map_copy[j] =3D node_to_pxm_map[i]; >> + node_set(j, nodes_to_enable); >> + count++; >> + } >> + } >> + >> + /* creating reverse mapping in pxm_to_node_map[] */ >> + for (i =3D 0; i < MAX_NUMNODES; i++) >> + if (node_to_pxm_map_copy[i] !=3D PXM_INVAL && >> + pxm_to_node_map_copy[node_to_pxm_map_copy[i]] =3D=3D NUMA_NO_NODE= ) >> + pxm_to_node_map_copy[node_to_pxm_map_copy[i]] =3D i; >> + >> + /* overwrite with new mapping */ >> + for (i =3D 0; i < MAX_NUMNODES; i++) { >> + node_to_pxm_map[i] =3D node_to_pxm_map_copy[i]; >> + pxm_to_node_map[i] =3D pxm_to_node_map_copy[i]; >> + } >> + >> + /* enable other nodes found in PXM for hotplug */ >> + nodes_or(numa_nodes_parsed, nodes_to_enable, numa_nodes_parsed); >> + >> + pr_debug("found %d total number of nodes\n", count); >> + return 0; >> +} >> +#endif >> + >> static void __init >> acpi_table_print_srat_entry(struct acpi_subtable_header *header) >> { >> diff --git a/include/acpi/acpi_numa.h b/include/acpi/acpi_numa.h >> index b5f594754a9e..99b960bd473c 100644 >> --- a/include/acpi/acpi_numa.h >> +++ b/include/acpi/acpi_numa.h >> @@ -17,11 +17,16 @@ extern int node_to_pxm(int); >> extern int acpi_map_pxm_to_node(int); >> extern unsigned char acpi_srat_revision; >> extern void disable_srat(void); >> +extern int fix_pxm_node_maps(int max_nid); >> extern void bad_srat(void); >> extern int srat_disabled(void); >> #else /* CONFIG_ACPI_NUMA */ >> +static inline int fix_pxm_node_maps(int max_nid) >> +{ >> + return 0; >> +} >> static inline void disable_srat(void) >> { >> } >> diff --git a/include/linux/numa_memblks.h b/include/linux/numa_memblks.h >> index cfad6ce7e1bd..dd85613cdd86 100644 >> --- a/include/linux/numa_memblks.h >> +++ b/include/linux/numa_memblks.h >> @@ -29,7 +29,10 @@ int __init numa_cleanup_meminfo(struct numa_meminfo *= mi); >> int __init numa_memblks_init(int (*init_func)(void), >> bool memblock_force_top_down); >> +extern int numa_distance_cnt; >> + >> #ifdef CONFIG_NUMA_EMU >> +extern int emu_nid_to_phys[MAX_NUMNODES]; >> int numa_emu_cmdline(char *str); >> void __init numa_emu_update_cpu_to_node(int *emu_nid_to_phys, >> unsigned int nr_emu_nids); >> diff --git a/mm/numa_emulation.c b/mm/numa_emulation.c >> index 031fb9961bf7..9d55679d99ce 100644 >> --- a/mm/numa_emulation.c >> +++ b/mm/numa_emulation.c >> @@ -8,11 +8,12 @@ >> #include >> #include >> #include >> +#include >> #define FAKE_NODE_MIN_SIZE ((u64)32 << 20) >> #define FAKE_NODE_MIN_HASH_MASK (~(FAKE_NODE_MIN_SIZE - 1UL)) >> -static int emu_nid_to_phys[MAX_NUMNODES]; >> +int emu_nid_to_phys[MAX_NUMNODES]; >> static char *emu_cmdline __initdata; >> int __init numa_emu_cmdline(char *str) >> @@ -379,6 +380,7 @@ void __init numa_emulation(struct numa_meminfo *numa= _meminfo, int numa_dist_cnt) >> size_t phys_size =3D numa_dist_cnt * numa_dist_cnt * sizeof(phys_dist= [0]); >> int max_emu_nid, dfl_phys_nid; >> int i, j, ret; >> + nodemask_t physnode_mask =3D numa_nodes_parsed; >> if (!emu_cmdline) >> goto no_emu; >> @@ -395,7 +397,6 @@ void __init numa_emulation(struct numa_meminfo *numa= _meminfo, int numa_dist_cnt) >> * split the system RAM into N fake nodes. >> */ >> if (strchr(emu_cmdline, 'U')) { >> - nodemask_t physnode_mask =3D numa_nodes_parsed; >> unsigned long n; >> int nid =3D 0; >> @@ -465,9 +466,6 @@ void __init numa_emulation(struct numa_meminfo *num= a_meminfo, int numa_dist_cnt) >> */ >> max_emu_nid =3D setup_emu2phys_nid(&dfl_phys_nid); >> - /* commit */ >> - *numa_meminfo =3D ei; >> - >> /* Make sure numa_nodes_parsed only contains emulated nodes */ >> nodes_clear(numa_nodes_parsed); >> for (i =3D 0; i < ARRAY_SIZE(ei.blk); i++) >> @@ -475,10 +473,21 @@ void __init numa_emulation(struct numa_meminfo *nu= ma_meminfo, int numa_dist_cnt) >> ei.blk[i].nid !=3D NUMA_NO_NODE) >> node_set(ei.blk[i].nid, numa_nodes_parsed); >> - numa_emu_update_cpu_to_node(emu_nid_to_phys, ARRAY_SIZE(emu_nid_to_ph= ys)); >> + /* fix pxm_to_node_map[] and node_to_pxm_map[] to avoid collision >> + * with faked numa nodes, particularly during later memory hotplug >> + * handling, and also update numa_nodes_parsed accordingly. >> + */ >> + ret =3D fix_pxm_node_maps(max_emu_nid); >> + if (ret < 0) >> + goto no_emu; >> + >> + /* commit */ >> + *numa_meminfo =3D ei; >> + >> + numa_emu_update_cpu_to_node(emu_nid_to_phys, max_emu_nid + 1); >> /* make sure all emulated nodes are mapped to a physical node */ >> - for (i =3D 0; i < ARRAY_SIZE(emu_nid_to_phys); i++) >> + for (i =3D 0; i < max_emu_nid + 1; i++) >> if (emu_nid_to_phys[i] =3D=3D NUMA_NO_NODE) >> emu_nid_to_phys[i] =3D dfl_phys_nid; >> @@ -501,12 +510,34 @@ void __init numa_emulation(struct numa_meminfo *n= uma_meminfo, int numa_dist_cnt) >> numa_set_distance(i, j, dist); >> } >> } >> + for (i =3D 0; i < numa_distance_cnt; i++) { >> + for (j =3D 0; j < numa_distance_cnt; j++) { >> + int physi, physj; >> + u8 dist; >> + >> + /* distance between fake nodes is already ok */ >> + if (emu_nid_to_phys[i] !=3D NUMA_NO_NODE && >> + emu_nid_to_phys[j] !=3D NUMA_NO_NODE) >> + continue; >> + if (emu_nid_to_phys[i] !=3D NUMA_NO_NODE) >> + physi =3D emu_nid_to_phys[i]; >> + else >> + physi =3D i - max_emu_nid; >> + if (emu_nid_to_phys[j] !=3D NUMA_NO_NODE) >> + physj =3D emu_nid_to_phys[j]; >> + else >> + physj =3D j - max_emu_nid; >> + dist =3D phys_dist[physi * numa_dist_cnt + physj]; >> + numa_set_distance(i, j, dist); >> + } >> + } >> /* free the copied physical distance table */ >> memblock_free(phys_dist, phys_size); >> return; >> no_emu: >> + numa_nodes_parsed =3D physnode_mask; >> /* No emulation. Build identity emu_nid_to_phys[] for numa_add_cpu()= */ >> for (i =3D 0; i < ARRAY_SIZE(emu_nid_to_phys); i++) >> emu_nid_to_phys[i] =3D i; >> diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c >> index a3877e9bc878..ff4054f4334d 100644 >> --- a/mm/numa_memblks.c >> +++ b/mm/numa_memblks.c >> @@ -7,7 +7,7 @@ >> #include >> #include >> -static int numa_distance_cnt; >> +int numa_distance_cnt; >> static u8 *numa_distance; >> nodemask_t numa_nodes_parsed __initdata; Best Regards, Yan, Zi