From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78FB2C3DA79 for ; Tue, 16 Jan 2024 02:43:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F303F6B0081; Mon, 15 Jan 2024 21:43:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE0A16B0082; Mon, 15 Jan 2024 21:43:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA88E6B0083; Mon, 15 Jan 2024 21:43:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C72436B0081 for ; Mon, 15 Jan 2024 21:43:46 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 89FAF803B7 for ; Tue, 16 Jan 2024 02:43:46 +0000 (UTC) X-FDA: 81683628852.28.877E4A7 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf07.hostedemail.com (Postfix) with ESMTP id 9BB134000C for ; Tue, 16 Jan 2024 02:43:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HpceYECQ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705373025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JE2bpTRB25qTRW1JNAAUJiNRdS0O6dVGGU7CUmkrmSU=; b=RJYPOQBuzlOGni7y0aQ+37O7foXOsGSaZGUuKyUidLrgKKGhZpHIVHW/9d7XbJWCeCn51R ieYl9gVHpzEUM2h3w/EkC2XcZUfE1zcjQoSqjqaFDuozrbhfUfwixcIFpm7zM3kN0HcvTf d6CkVFsqeOUspFai3GpkRFgErO9T6es= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HpceYECQ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705373025; a=rsa-sha256; cv=none; b=cWZBHU2uSp/xagCOnooCScs7RobkNu+5wl7Q1B+vHA0SGkrGYhmlIQvjXDheatX4GOdj2d pE+6phebHWCGregrInDH1F18Cj/akIdXDhj/0HCJAs3U7ItfiNPAIfhTh8sdimh4rO7Fu4 m9qMPdURcm02lvBzCS7PvLCSPYMkyqg= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705373020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JE2bpTRB25qTRW1JNAAUJiNRdS0O6dVGGU7CUmkrmSU=; b=HpceYECQKonmijXYZvgMuzJW8BGPvvYBFSKUy7G+Vxz6aNpQHVq7GNRW54DH1uFXMXobtm CtPGZYRVk1m+WaWCila1tubp/1F+HC/bNQVLPsymT8rpOYHC4YJj+7IT7Y1/BTfQiVcf6o BlHWuAD3vBaP0QqgpuJUb3omleih6Fk= Mime-Version: 1.0 Subject: Re: [PATCH v2] fs/hugetlbfs/inode.c: mm/memory-failure.c: fix hugetlbfs hwpoison handling X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240112180840.367006-1-sidhartha.kumar@oracle.com> Date: Tue, 16 Jan 2024 10:43:00 +0800 Cc: LKML , Linux-MM , Andrew Morton , usama.anjum@collabora.com, Jiaqi Yan , "Matthew Wilcox (Oracle)" , Miaohe Lin , Naoya Horiguchi , Yang Shi , James Houghton , jane.chu@oracle.com, stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <1D4F7C82-92BA-4EFC-A082-B5FE30758E91@linux.dev> References: <20240112180840.367006-1-sidhartha.kumar@oracle.com> To: Sidhartha Kumar X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 9BB134000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 3xbpqpmdxzptu4y6quk73w39wzy15nze X-HE-Tag: 1705373024-492450 X-HE-Meta: U2FsdGVkX1/PVir1pV0UAbpf2CiHoGq5bosdS8R5+uzUe0n5IlhSzNDlzqw613YcRt9iRR57N9Ks9yCAJcGZ/yi3i4CE8vklW4PYEQJbMlTgKFunUZDLNC4T5PcaeAEfFLNkaNH2N5ajLxwUxkoUv9BUTH7o5ESuMA7bjJhUsw88H2VPI3PK0xRTGzfFt57dGfhdxYRP9E5rhS/qjXdn5rurQFo4fu7YL78vpkREa2mxJ9SDGVv/hgkonnHYhFjAdrlvG3ipg6RzSSvSdO8IwcgT7HcTQp1ac1I1I1IqUoD1fv8GAjWsiCNUhuWuh97f0qA1MvCeUOr55yQKTM39ElyvKEygQMidjaheDb6IopPt4L1GZto85QiDprxwWsHHYlyFeVIxd9lM21odXW5OKJ0AtWWAuiGE1tYF6/fUyfQvYNkSNP9deETBmwGIwXtVJCouFMTzwY8po9I3s3uTzi54UZaJS9FXxPe4jLfYGd9cQTMPepsBG4X45r+BhINUXc7fN4rK4b4Ollt1Yc16lg/Z7Qzkbo4VYz87o76RAif8aA3oNovaEvGGo3UT5/nSjWNlxNe1Dm4dtzwaVSajsgaCrY/kVUMPXdWAPVF4twirPurgENhpwgDKJ0T2i2ezhTRklP9FoL6juSB2htuluneBsa0F39fSTHbjGRWbnFTvmjKcF3TLs6qqdPxQwYc9/giUzmd5dRZP9WpFcPJ/jKxRs6BK07Crf0TQfLk0/0I1JS0ZUffCTDWNHblJPGbq8K5LrL5LlB9l22o/ir5LiGburRMKpPkk9xVH9akuMUSYSEcjY0V7h5To41MMGntWrYiCp0ILgM2xTnBoCqoqm30oq3Io8G2MKQ+/Lxzx5h+6Pn7yhs50yYCZzQyL/Gn7ESmfA1HU1XNIHnO8P/ppbC31Npyg7TaRiMVCNR8gaKCaftxTx0jI16BSwJsDaBqMnU8bH5yHQjP4apzKcy/ dL/kaVet D1WjosImTlrk92WDtOhMpsKGOjrV8RMEsrOXtml4FyqRHVv7eLZJ+DSdpz6d2MWFxwYmDLRx7DgTWjWDo4aYRx6hXtmjCXBtxxI05MsrA8QlvTp7FjnFuiS1cSy0UlYbe/73N2GGAsWQrHXP8FxSJ8GHHwMn7wrS5sawOlrFbnELeDIAHK6OASgvDYeCowAWPC5VU85zrhMw/ZzQgUP9clhMvvPO63hkUIW/DRwShezfYSVtxU7Yv+Zm+I3/+byEUTUQeDEFsUG60kHP6LQDrh6SMYZVrLYBcySPKyVaDUfJrGJNxmPQlXVlxsRejLqEtgUb2yye9Nl88qKw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Jan 13, 2024, at 02:08, Sidhartha Kumar = wrote: >=20 > has_extra_refcount() makes the assumption that the page cache adds a = ref > count of 1 and subtracts this in the extra_pins case. Commit = a08c7193e4f1 > (mm/filemap: remove hugetlb special casing in filemap.c) modifies > __filemap_add_folio() by calling folio_ref_add(folio, nr); for all = cases > (including hugtetlb) where nr is the number of pages in the folio. We > should adjust the number of references coming from the page cache by > subtracing the number of pages rather than 1. >=20 > In hugetlbfs_read_iter(), folio_test_has_hwpoisoned() is testing the = wrong > flag as, in the hugetlb case, memory-failure code calls > folio_test_set_hwpoison() to indicate poison. folio_test_hwpoison() is = the > correct function to test for that flag. >=20 > After these fixes, the hugetlb hwpoison read selftest passes all = cases. >=20 > Fixes: a08c7193e4f1 ("mm/filemap: remove hugetlb special casing in = filemap.c") > Closes: = https://lore.kernel.org/linux-mm/20230713001833.3778937-1-jiaqiyan@google.= com/T/#m8e1469119e5b831bbd05d495f96b842e4a1c5519 > Cc: # 6.7+ > Signed-off-by: Sidhartha Kumar > Reported-by: Muhammad Usama Anjum Acked-by: Muchun Song Thanks.