From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EDF4ECAAD4 for ; Sat, 27 Aug 2022 01:59:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 954F7940008; Fri, 26 Aug 2022 21:59:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9038E940007; Fri, 26 Aug 2022 21:59:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F240940008; Fri, 26 Aug 2022 21:59:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 704CD940007 for ; Fri, 26 Aug 2022 21:59:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3E1B5160447 for ; Sat, 27 Aug 2022 01:59:15 +0000 (UTC) X-FDA: 79843715070.23.9A1766A Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf14.hostedemail.com (Postfix) with ESMTP id C0E0110001C for ; Sat, 27 Aug 2022 01:59:14 +0000 (UTC) Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1661565553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XK9wonDbPQGsVKvv5YsvgEUKUZia25uBKsAM8rHUuWs=; b=CL1jVdEeK5ZxOoQyxCYK33HHFIIh/kddkVgeUZQVlgESI+bWcfNJ/m69DnseRy8yFXRDml +NiV/OYuahAkY1FuzsEs/K1oo7kNlOvuJIIQd5WawXuZS3Ao6qSZrYWxKbNfGTbspGfzAK nYhnLOhfgophZC02Uwp54k5bDHhdn7Y= MIME-Version: 1.0 Subject: Re: [PATCH 10/10] hugetlb: make hugetlb selects SYSFS if !SYSCTL X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20220826092422.39591-11-linmiaohe@huawei.com> Date: Sat, 27 Aug 2022 09:59:09 +0800 Cc: Andrew Morton , Mike Kravetz , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <1BAFF85D-F7F5-4DD1-ABEF-2FF621DE34E8@linux.dev> References: <20220826092422.39591-1-linmiaohe@huawei.com> <20220826092422.39591-11-linmiaohe@huawei.com> To: Miaohe Lin X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661565555; a=rsa-sha256; cv=none; b=N4x2WvL27xdPThQPG3docprN73LRHyGu+NKOjm3I7e0JL2HF+V5NgHdrXpiM8gd3lsa5qL iOw3vnaQXt0NznA46+1IvmRZ6BZY5NQpZoglYKPep8AvzhPE4lJgoguDQHuTX/K/Ve8eQS lVVGstDXWCZm09vr1fd8PFCgSMTuqbg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CL1jVdEe; spf=pass (imf14.hostedemail.com: domain of muchun.song@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661565555; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XK9wonDbPQGsVKvv5YsvgEUKUZia25uBKsAM8rHUuWs=; b=8dSGjYgZ3momCHGt22FmFSu0bXCFZdyp2uS3ih9Lge4cBMXmJp8SZFMSTKJ24AcdAFMjTz flP0X2DLMI5cW0TSg7j593dVPVxTJo00MAwoo9L4+InRtYDlmPXJiUoEEit/ccsbQdNvkq 3xE5stqZRcLYeeewEMoGdMFy3pFLukw= X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CL1jVdEe; spf=pass (imf14.hostedemail.com: domain of muchun.song@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspamd-Server: rspam08 X-Stat-Signature: bayuzzjwn7qbjfbiawxsi6cpompgsgkt X-Rspamd-Queue-Id: C0E0110001C X-HE-Tag: 1661565554-228751 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Aug 26, 2022, at 17:24, Miaohe Lin wrote: >=20 > If CONFIG_SYSFS and CONFIG_SYSCTL are both undefined, hugetlb doesn't = work > now as there's no way to set max huge pages. Make sure at least one of = the > above configs is defined to make hugetlb works as expected. Right. I think the majority of the people are usually use /proc knob to reserve HugeTLB pages than /sys fs. So I suggest to add a =E2=80=9Cdepends= on SYSCTL=E2=80=9D item. What=E2=80=99s your thoughts? Thanks. >=20 > Signed-off-by: Miaohe Lin > --- > fs/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/fs/Kconfig b/fs/Kconfig > index a547307c1ae8..b266e7b5de85 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -235,6 +235,7 @@ config ARCH_SUPPORTS_HUGETLBFS > config HUGETLBFS > bool "HugeTLB file system support" > depends on X86 || IA64 || SPARC64 || ARCH_SUPPORTS_HUGETLBFS || = BROKEN > + select SYSFS if !SYSCTL > help > hugetlbfs is a filesystem backing for HugeTLB pages, based on > ramfs. For architectures that support it, say Y here and read > --=20 > 2.23.0 >=20 >=20