From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54963C021B2 for ; Tue, 25 Feb 2025 13:42:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9481280003; Tue, 25 Feb 2025 08:41:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C440A280001; Tue, 25 Feb 2025 08:41:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6F36280003; Tue, 25 Feb 2025 08:41:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8110B280001 for ; Tue, 25 Feb 2025 08:41:59 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0D35FC165E for ; Tue, 25 Feb 2025 13:41:59 +0000 (UTC) X-FDA: 83158580358.18.1648867 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf21.hostedemail.com (Postfix) with ESMTP id 94DB81C0008 for ; Tue, 25 Feb 2025 13:41:55 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=D7JrjGOk; dkim=fail ("body hash did not verify") header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xE6M3rdd; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf21.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740490915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HLgqxOrENauL6tcZlFWjUz7z+IFrvYQHj6jN6QeVfw8=; b=mPfvBVQDxXw+OqmEjUzZIA6M05/BkEF9fA2m9LRRYbYBvZe0la1CyThjWzgEaP3WEt2SES 9Ju2m3+QV9u/ByNN4yT9r6W+bsXESTtnthOuD9xcSRtUH3PQWtYAwvohCkbvNJSe6K0iXk 6acPVucHRmse5z2RD6aebULYQsIXTus= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=D7JrjGOk; dkim=fail ("body hash did not verify") header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xE6M3rdd; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf21.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1740490915; a=rsa-sha256; cv=fail; b=pZh3CpPLOZO8+gq5f7Ee1WFCBcaLf56qLJJK0rHdHKdXrE3mbHMLX25RPrXc/qTHdwhXHQ c40JPqYx35CF+Cw6P9CwZNc0MSHwYYxITIxkO1ylh6rF+dErR0JGnGaAXNCBNip39ZshhG /9q8GxRq6t42grccCIPpRSbyHgiCcb4= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51PCfdwM012266; Tue, 25 Feb 2025 13:41:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=HLgqxOrENauL6tcZlFWjUz7z+IFrvYQHj6jN6QeVfw8=; b= D7JrjGOk1wuCaUp08qHEDyYsKk2ldL6JgZ4gPl2dgBV86F60wPN1ga+NrK25Yi+i 0Qty4mtGc7SRzZ9zJq9XHVg5WWW1zsqKgsU4vSFvrE8OTn3FJSA5Vz8qpQE6Gz9j QnHEeGyna2j8ZhHPrexZ9qiw5U3JknPOEmk1cqilMkGqydLWqfFOjAwJFi0kouNt AF1v+xGMGA3eZljc9ngKnzGnuEjNQaLkWfIFgR5I7p1rrADQxB8PiDHNOSg5jRyP tR2s/Do6loCK4rmsS6V57h55FBWAtm1v7TnNyFQ1wEmIX9ZnluGR3CC77CECCLi0 qhcdATX0HALQifY9J0K2KA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44y5gan7ej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Feb 2025 13:41:32 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 51PCxPsQ024384; Tue, 25 Feb 2025 13:41:31 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44y5196x61-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Feb 2025 13:41:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mLUwX70fV7ca66+akWoqw5QF2vQM2FxjnI+wETWgmsQOHlvodb7pw3ahkqcRBvsgmar/NtNaIXvF+xA9A5A1y9t0PN/y7qmC1jkpSrKyHqLw+hBhf/FZ32xpK+lcpfOyrVreibjIkPR4rlMqQ7SonvnzA5mbB6WBzCjZoBWfFj7CC+6ivW1DGYKuO9bA72/CNKD/ME7nC1G7S7iCjoFz7t7PqQ2ZCUKWLFOKsF/zsreWAtexg5L/QFxDUEaeDRIZu+LZI9MxJWjUq47jfyGGe5Bb96tSMTZcbZ2la1MUMB8DZKHbMNaecXMdtvtgccNXVkH0pfGAIYM55vX3Mo1/9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wQfBlC6l0yQ6qYwzX9iPYhFYMnP8XRn5rFXsWjonKPQ=; b=y7ME+VTdrA68S4Y8EgqOTE9yFCxy5FJoDixNIAiKNGMP/jcpcSjgdJmf9KGNi7F27e3qYPKy3/LhYtlgLvmTVlFkGK6jN6uzX/VA9olIfsiArT1uaAzAb/bOXrscTIIyPwpeGbKLdYN0o4jzGeIWGFKz2Iw6UbR+H6RJoTjBpX2UkVQafg22Bk/BZ2sCXR2bXUZWlNAdPcKNtqpeGL/PShB95/GA162unx//iC3IGAAn6Gc1D85dmqMg/JhJR1H4aNYJX9pf1TIcAUtP8MP1A3qldvgicqA+baLruKmksPSRUpRuHpJr4igyD1FnzH1vZOlqDTHpV4CsfUuz9Or8zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wQfBlC6l0yQ6qYwzX9iPYhFYMnP8XRn5rFXsWjonKPQ=; b=xE6M3rddXmie2hvis0+YbsaTGYT47rBMFhjvFxCvOpRPGzOZRb/wUCELSQfcwVsdwSn2WNtuZFX7caszBcG3aBjStpPzQpf/uheM3+65Kh9SAp1ea9AqQavacehR2uu9I2k3eWOEFG3H9mz+Q81x4aIQHeAW3jD6Cvk35PEmidM= Received: from BN8PR10MB4099.namprd10.prod.outlook.com (2603:10b6:408:b7::32) by CH3PR10MB8213.namprd10.prod.outlook.com (2603:10b6:610:1f5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Tue, 25 Feb 2025 13:41:28 +0000 Received: from BN8PR10MB4099.namprd10.prod.outlook.com ([fe80::5db:fa9a:dfe:2a2d]) by BN8PR10MB4099.namprd10.prod.outlook.com ([fe80::5db:fa9a:dfe:2a2d%4]) with mapi id 15.20.8466.016; Tue, 25 Feb 2025 13:41:28 +0000 Date: Tue, 25 Feb 2025 13:41:25 +0000 From: Lorenzo Stoakes To: Benjamin Berg Cc: "jeffxu@chromium.org" , "Jason@zx2c4.com" , "adobriyan@gmail.com" , "deller@gmx.de" , "gerg@kernel.org" , "anna-maria@linutronix.de" , "davem@davemloft.net" , "avagin@gmail.com" , "mhocko@suse.com" , "enh@google.com" , "thomas.weissschuh@linutronix.de" , "hch@lst.de" , "hca@linux.ibm.com" , "peterz@infradead.org" , "adhemerval.zanella@linaro.org" , "linux-kernel@vger.kernel.org" , "ojeda@kernel.org" , "jannh@google.com" , "f.fainelli@gmail.com" , "sroettger@google.com" , "ardb@google.com" , "jorgelo@chromium.org" , "rdunlap@infradead.org" , "mark.rutland@arm.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "mpe@ellerman.id.au" , "oleg@redhat.com" , "willy@infradead.org" , "keescook@chromium.org" , "peterx@redhat.com" , "mike.rapoport@gmail.com" , "mingo@kernel.org" , "rientjes@google.com" , "groeck@chromium.org" , "linus.walleij@linaro.org" , "pedro.falcato@gmail.com" , "ardb@kernel.org" , "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>, "linux-mm@kvack.org" , "johannes@sipsolutions.net" , "linux-hardening@vger.kernel.org" , "torvalds@linux-foundation.org" , "akpm@linux-foundation.org" , "dave.hansen@linux.intel.com" , "aleksandr.mikhalitsyn@canonical.com" Subject: Re: [PATCH v7 5/7] mseal, system mappings: enable uml architecture Message-ID: <19e81e87-7430-4e23-ac67-dbb987496dd4@lucifer.local> References: <20250224225246.3712295-1-jeffxu@google.com> <20250224225246.3712295-6-jeffxu@google.com> <96ebddf3fe31353c89f6a4680eaeb2793c25cd09.camel@intel.com> <7e91bea34552472757a8eec425d1d10643ca584b.camel@sipsolutions.net> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7e91bea34552472757a8eec425d1d10643ca584b.camel@sipsolutions.net> X-ClientProxiedBy: LO6P123CA0029.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::14) To BN8PR10MB4099.namprd10.prod.outlook.com (2603:10b6:408:b7::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8PR10MB4099:EE_|CH3PR10MB8213:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d2e7a19-7396-4baa-7d72-08dd55a21aee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?TxWdfM8mj2+gynO7GLzvefRbBdBeqGXdIvgLSZawLwF3LSmOk7Op1vEXcO?= =?iso-8859-1?Q?aoBJBRgNVF8h5r5BUtDHbfRRmic/LsybnnZzo8R91sMlQ2YFYYaLV/fGl1?= =?iso-8859-1?Q?urjoEoHZ8XCxfaRVBrn5P6cmeZjhBIGk2++EXsx4CGugG7NOHvZJ+ypJ2k?= =?iso-8859-1?Q?jcb76k0tuns0fYqQ/cm2LH3cxEd5tmKAtlleEmrTUCSnAaY9dXU4XjUApg?= =?iso-8859-1?Q?su3lzisqz5wUojnJGgL4lZRJReBxYoJhSy3mcY3rukLVbjMrFZVn9k/ZzD?= =?iso-8859-1?Q?AfqSvVDXS8gAVQLGxexDNEQZ4x6mkCJ5kk4QKDybenCDwt9Z1L7QmwDVh2?= =?iso-8859-1?Q?J5b7uW0SiNtB4akYe23ft6F1fB9ayxx6TRTEXp9X0Y2c0EcScgTrfUYdT9?= =?iso-8859-1?Q?Qc/pzmwtBnPgnCNcG/I13MpbdDUEUhwruSHye3AHeLzWDtbg9yx3m3315U?= =?iso-8859-1?Q?PLJBWq5gjAiQHOZ+8/CMhfYJ8ll0nRPuOQ6uv5KQVp6m8CQ0Y2Eb6lP4Uf?= =?iso-8859-1?Q?an+yHh8uUK37cf1zgpVdMxcwNIpJltCQziCBITGsyfeysYNYQLGAzZ55O9?= =?iso-8859-1?Q?6TC13ghM6/3Dh2WIudDcSB5LKAPV1EmsgFG1s1SWVIW5fiXi7PVcg20xax?= =?iso-8859-1?Q?/bShSG98/2ru1pPxBcDLUrh0medMFHXoW6eeSl5yvcpAV0J4GOpIhh73iv?= =?iso-8859-1?Q?jqwSBlHMzEqlVzQ1QI/PL8uUaqkAzI160Fo+WwnC/mvvXZsr+V9mx52noM?= =?iso-8859-1?Q?xgcdDsJFOSHnMB6JFXSRbLtiXD1o0xugLXgm0Gnea35mYt0uHi8FJwXHNo?= =?iso-8859-1?Q?ebL+58ZsUoOpBok9/yO+Kl/dyq2BOw5dDsQPslZSJomqJqE2IazAKpAvVr?= =?iso-8859-1?Q?sah+lui/yObz5xUnwR3IyCKCMjTNVS5/sXlRrlLPCva09lrA7U8pymZ/lO?= =?iso-8859-1?Q?Rljml4ZxetObPVazygisaYwe7SdXFFJcg86Nq9HhCkEvLkjubpLECXCEod?= =?iso-8859-1?Q?1oyiayVlO3/kBVSHJUB2/+zpUBng43sSzKj7fZGc/Edo968f6gPoHXiI4m?= =?iso-8859-1?Q?2wR7gGmugRldqn5NXCkw8d/kL8qpFSmpx6MdwLXGvATTgCIx3zvHPwkU39?= =?iso-8859-1?Q?cG8sSp1DtbJ7nxzehO7ce0mY+skR4FAkCZx+87YVIsKucLbpz4cC++8hrv?= =?iso-8859-1?Q?rpje2aQXljfuDe1YqHNXOL2JymHNzmspZ0H6OXOdIcGgcDW5rTbPuuDmTp?= =?iso-8859-1?Q?iqH/BEXHZ6VtjM/D9Osviq9imeGHynUnwGDKjQc+IkDb95Vs39vK9iMNnJ?= =?iso-8859-1?Q?20A6qOoEQDt8mNNPQ3dI/WdSoglZKbTvaxiGKwsrVRHkdMukWZo5bSAA3v?= =?iso-8859-1?Q?qesRi2yxWP?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR10MB4099.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?/TCoXufoiNKLmVuGjugZkhhJCedECj2qTR1n4qL+ilxSpldbGThwjCJQXO?= =?iso-8859-1?Q?PVzIpfJYm6H1KeNk929omtfQ8WY0CmLoIiXfaWMmnct5kwq6iCCP3QYIMS?= =?iso-8859-1?Q?WncmuBZrJ1cDZGBEoKLgmbawFl4XhmwS28tG1pGIxWq5sxhDL/LK9ueTwL?= =?iso-8859-1?Q?vqTWkd9QIQCzvcM8XM0gnq3e7I9Tv5Vi5wIGWVylQorSZ7nnt7i1HRBRYd?= =?iso-8859-1?Q?7/Y/fB9XXvkFPVyMi3NmcIH0Po04b5cnXnbVwD5owqnsQcoAXaK2ae6yLm?= =?iso-8859-1?Q?beSjImtsqYVasaiarMhTmgmzoJYmw+e1SuAxHQsBXEOXIfCg4N+eXNvyvL?= =?iso-8859-1?Q?rrkvaaDLipXSFMDguS5QrXXSdWKmoYosyW33h2jZGaNAlWTzzljhtuVRlQ?= =?iso-8859-1?Q?MG9jhAvMMEPU9y7U65fh3dgi/4p6czQuBAhM9HFV5eWuN7ZPW5b2ZJcaRi?= =?iso-8859-1?Q?6HIay2GIGoa1K4UN34WVoNw0AAQeQJJ2E5lr7cptdcBdtVdPcBvBbmuIIZ?= =?iso-8859-1?Q?WRU9CNCzVnVdgQ0eM7IygxfPoVj4gXMec1Gkda06vbfB5CoZj7uO2fgx36?= =?iso-8859-1?Q?JvcT04EWAiYD+CYglIHsRkpe1Pkc/D+EKu6AuRPFzMB9Y+5jsY535kudnP?= =?iso-8859-1?Q?W6ZR9sl6LaeEMPiS79weK+8f/NE8z8YeaMZYx+bsTjlc6/NUc2F/jxcyBn?= =?iso-8859-1?Q?NHNN7TEiQvzInrq72lnkwRtc/wG4jwl3+DOizBwje0RjCSeRTujfSvw7nH?= =?iso-8859-1?Q?ONSAWSYC77OXVQp46aO20AVAwpDzz/hPHWEhe87rhRQoeRnveCnh6DNHmy?= =?iso-8859-1?Q?S+h7ozg2GCMdq17NMj9HoDEDAu1p1pS6T7X0WTrCZQETsUDuS911uH39EJ?= =?iso-8859-1?Q?CtHRY1SAyB9GIoccE4I0UpVVtuvU2rMi3d5G6/eCYjRUrSTSzK3fMa5NOf?= =?iso-8859-1?Q?rzX7+Mbi0ZIJvatiOzvuh+JJ17F0970/TOvKirzgVaFubilvMneeOrT+7S?= =?iso-8859-1?Q?8MYrETpTCqlaQsAsFbata2LgfQHbp9ZUfee/zWQPQvs6B4m/sjkScYaEM4?= =?iso-8859-1?Q?ttJxl8sBZgBjA+c9rngSu2/q36EuyLoYwIGcC4ok8zmJpKcqO5C9zSnbwb?= =?iso-8859-1?Q?bOuoVZYr8DSVyAjZXDxZcF4l8Qkd+/1MfcuKjV2eCL2lKZGXo6Wio315wH?= =?iso-8859-1?Q?+n97+lh9im8PxVkJ8W+/Nid1e7Bk3KVA33khi9Y3Mzfcdo7C0qXK/LEUOo?= =?iso-8859-1?Q?HTeOXpiqNAkGxrKigEI2S2BFVD1E+K0f/ojENRA0rTRH91umNBKSRWhFPG?= =?iso-8859-1?Q?VaSQTHQMOqghGrteW0PRSX4S4sFNCHc4bAC/w6xrBhgf0+QgvpPK4k/NYs?= =?iso-8859-1?Q?oIb4eq1MEDrCOUgMjL+HkfZEfB58M8/QPM5ogiB4Gi/2DByiSXh6pU+Kyn?= =?iso-8859-1?Q?vkJbXG38AHBcfi1mxT3kijNUfrmpt3SRN/eAmYzLL8YWReBCKKl/PJBV45?= =?iso-8859-1?Q?dBgjchWOuifTG+4Bhovv29iVNSuKX4l6ee1v3aeO8gmkaQlwIKwxQcq0nD?= =?iso-8859-1?Q?9yUr9nP6Zws9h1ZnfXqUHiX5bXmfGo43gGSFNQQ+3LgT/l+ZQpFQ3It84L?= =?iso-8859-1?Q?HydVTs9R4U1O5z1fIMCiQ0vSy3xkYz09DgRhuPm6Iu29nIR+8HQv7IRA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0atScIjO+bTwignb1AyuqrIw4SZU0rdZ4IJ3TxfuTlWPQNMZMQA2UrMaIBG84DjKF3He/d7I+Ehd5rsMcYt02uPO5lZByQOX48nrU8yB9k6RA1yqAOoRy4FGFSwwrgOkdBlFKgNboJjSwPqf26SiqxQnzNeW9nIZm1LPkrHUSzp8Bm1S7MCxCbzL8hdZrL+0y4KyId9BwF/mfY20+Xdh18d4/TfTznyN+gGlBZht/MajN6oyW0s2mwaxtBteuyRI5Nm8ImZH7ofOep28PLnlUzm7JkN3i9510B0kczfj16DE1BjIJgpsQ3BGc+CKGASG0IXR6qsmyG1kDVFLIR2+GvJWb1P4mejZ6ytFUuXTw2GC8byJrHqG5ekuAsPAfpR4iTqSAeJSdJ9sGDJFdt6aE5H0dOmlovkiGZvnUoti5LcsJdNYVGwuCBKzVasnsVjaAiyBU3IZDbXuoFk1ZfZEl0bu0PdQ4jZ0WGgI4P+gsuhU0I8Xpoo9WwyBGemB8EXWLKZvkYb0wt0EW13Ioz+EslYdFYxYeno5HD8scvssOHegKYbZZ5+GKfIc4JRBuGpo789xhi535D2EPuj3wtAw0J3guKxbO+HlP3e3AIbnpqw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d2e7a19-7396-4baa-7d72-08dd55a21aee X-MS-Exchange-CrossTenant-AuthSource: BN8PR10MB4099.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2025 13:41:28.3017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9RZWJCpjOecjkar8NQC2/ARdfTrwPCWvlcb60yqYtObpuleBygcxkDGK9HIBjRt+mazkgCImSrW5AkxzRdWq9GxWI/7AJKhDTknvO4roUbc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB8213 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-25_04,2025-02-25_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502100000 definitions=main-2502250094 X-Proofpoint-ORIG-GUID: 9u2ozqtGpBoOLNgzWjyOGqiDbXcMcw2f X-Proofpoint-GUID: 9u2ozqtGpBoOLNgzWjyOGqiDbXcMcw2f X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 94DB81C0008 X-Stat-Signature: r5q985bti7hem7ijdgjsn6aetdatokga X-Rspam-User: X-HE-Tag: 1740490915-276821 X-HE-Meta: U2FsdGVkX19cy1QW/7ObI50flE14i+y4BydcoQo9/B0UME1RJVTJJHJVztVZ8b8qjORgp5SauEkR1K3JzS1y+PFicAfY83lXy+w5KRxN5LGYC56M7nphA9TOn68dsNPnwYBoQSg1wOmG0SsGoGxjrGnMAud7gR134ClJE3v1frXuU4pOGL6sTMHN6zIfBIhypxYbjg4rKBN166BrQaxpuRhnE+Mr3lfWa8iUeMYwyTBs+AlavgFdImzZoTdEZQIAVxe+eJDiYt76SxSWfSJ4PysLpsQpdWMQZ1y37dUgbApiL53Wj8r2IZOOwCpr3viVndidzv3gAjQdrqeWzZQaj9b5J0CLLkrQWPxglXKL1hCdYT6EF9xMuoix+z5egPEoVxvSpFV+K0K2awEpTHCN1CdFgOZ2jf19jD6HXj1pJPkHG2rWLDOuvrDDpJJDCy5hm8yxj55ZaTjzQhYDTe3tVFc0hM8Skqq9SugTrz0Xlm0PtmFzETrjDVGYhNKh92vMyY5EtmFO9vpNXWKAOclrguLcp/FHKp6lIP0cl8i3F41rXyVFuosTVDKpUBMgakj5FTxdZiBALpYOwo2Cn3r+MFvPkuFEUiXhT5FsMbRXxRZtP/OqD5op4c18Sqb7vq+hqOxdy6sM8o6icuQOilTKhPU8uxTlcZxKFR1FwL4yUEkqvVR2Me6ueWNBqP50WnCFmC07rPqY56LIDWoENZLt0Z2bCvBMyT3eNC7VKfmgLnbUtLYgq9q9DPJ/sJCizwVN/3WjN831qBUrv01mjg9mHKViYmikp3F+QRbwkLfWOW70RdC9MUeFsE3sfsGGjR0TMAX57lAmU/vcCSvYqH6vuD6ZloVGNWEpNWJAmTtbcqTXdmLsR0bLQZVG2Q2boVvEVO97nYOxUWeXkMZU4LFfdOSnonjT+5EPJZRK9M87VnruAc4kh8/wo20MDlT77FGTV5KoPfEs65YLON5Ju4R +vDzI/B5 recP1YZ1/iqgnrgaDQ01WeSQK4mnS+to+Xh3UKLLhSfdU6beBpLS4JHzwMPldJt/a3JUs6yB8TYwRjqUr9LF45IeFbHf3X29rkHoP2q34Qb+MdOmEustZ2D5dCJBilBInxDXGbF0wn8B47ctAuItf7CqWFoxZmtyG7hWfHxUIwESa8ivn3g9lNUC8n6R0G09TlHEjlKuHg5Lq0I5q3bhVnRAqjkvwN0DkUU9DHxQYMD9Vc9Bn2uG/AKYwuZxPA2fVSpdIF8Q70oiXsFwiHKqv7arMTnChgnnFcqMPFub5pH5QlOfIEU1VDnKBxlPEbA3WSlU0R1t3eLHl9kADMut2PZVgg7K3oEzMUOrlTOk5Uw38pF6ZHosVe86zWHDfFO9ud/4owxGa8kIUHGfcea04Uv5TcAAErsQ+N81qdZEp9M7BdgargZNnRKmrV9cwMGJUePkqUgeVqpBHKtxiBS26JuPOaAs5JDdvxGT+WJPPVcP0G7flSDAbA//2OLD75CAaQhPhQggEeXOh8f3WuyTV8nfJiiTstzaPUIgrqvEm9WpkX4DCJNYzam/KX3+cH4AS+oSkbO70VxZZ41PGBuSNj5+EsR/gZog2+vl9LUKg9aNbTPbAliuV9Sn7ulEuIo+FJwxvRTzNHDJ61VXb0uIx8fvRaqsUzeNvSCeV+zjWVs3LV3aXF30ffiABLmRqw6qM2p4dRx7D5KvwGflH6xftM/Nn6MckZu/aIhfSQErJKjxII6MvqBPokzaltF7e3QPfO7qNIsGhbwYdhDZbSND6kLgPr23va8tzEM1RtXZndryF9ySNgesiecmX/ahO/QR55XGT9yoQSy7n6VmuoAmav5jCOIFV0kQWiyQ5A3Re5xz2qi7NgfchhXqFpmTYR9VeklFlQDmtzxOROrjDQpTgSNhKQb4W60JE/C4+QGJzbVoA7nIZyGxOV79+FoIBUNImMfWMXkCVU8YNdYs+nTN0XiA56g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 01:24:49PM +0100, Benjamin Berg wrote: > Hi, > > On Tue, 2025-02-25 at 10:37 +0000, Lorenzo Stoakes wrote: > > On Tue, Feb 25, 2025 at 08:45:21AM +0000, Berg, Benjamin wrote: > > > Hi, > > > > > > On Tue, 2025-02-25 at 06:22 +0000, Lorenzo Stoakes wrote: > > > > On Mon, Feb 24, 2025 at 10:52:44PM +0000, jeffxu@chromium.org wrote: > > > > > From: Jeff Xu > > > > > > > > > > Provide support for CONFIG_MSEAL_SYSTEM_MAPPINGS on UML, covering > > > > > the vdso. > > > > > > > > > > Testing passes on UML. > > > > > > > > Maybe expand on this by stating that it has been confirmed by Benjamin (I > > > > _believe_) that UML has no need for problematic relocation so this is known to > > > > be good. > > > > > > I may well be misreading this message, but this sounds to me that this > > > is a misinterpretation. So, just to clarify in case that is needed. > > > > > > CONFIG_MSEAL_SYSTEM_MAPPINGS does work fine for the UML kernel. > > > However, the UML kernel is a normal userspace application itself and > > > for this application to run, the host kernel must have the feature > > > disabled. > > > > > > So, UML supports the feature. But it still *cannot* run on a host > > > machine that has the feature enabled. > > > > Sigh ok. Apologies if I misunderstood. > > > > Is there any point having this for the 'guest' system? I mean security wise are > > we concerned about sealing of system mappings? > > > > I feel like having this here might just add confusion and churn if it's not > > useful. > > > > If this is useless for UML guest, let's just drop this patch. > > I figured it is not a lot of churn and there isn't really any cost to > enabling the feature. > > That said, the only possible real-life use case I can see is doing MM > subsystem testing using UML. We certainly do not need the feature to > run our UML based wireless stack and driver tests. OK ack - my concern is users getting confused about this ironic host vs. client thing, must disable the security feature in the _actual kernel_ to enable it in the client. I'm not sure this is really worth it? I mean I agree this isn't a _huge_ amount added here and I don't want to be difficult - Jeff, Kees are you really keen on having this? Do you have specific use cases in mind or was this just a 'because we can':>) I guess if intent is to slowly add architectures, it's not totally insane since we kinda know this one is ok so if that's what it is, probably won't oppose it _too_ badly. > > Benjamin > > > > > > > > > Benjamin > > > > > > > > > > > > > > > > > Signed-off-by: Jeff Xu > > > > > Tested-by: Benjamin Berg > > > > > > > > Anyway I know UML has at any rate been confirmed to be good to go + > > > > patch looks > > > > fine, so: > > > > > > > > Reviewed-by: Lorenzo Stoakes > > > > OK guess drop this tag please until we can figure this out, sorry Jeff. (to be clear this is just temporary while we establish what's up with this situation! :>) > > > > > > > > > > > --- > > > > >  arch/um/Kconfig        | 1 + > > > > >  arch/x86/um/vdso/vma.c | 6 ++++-- > > > > >  2 files changed, 5 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/arch/um/Kconfig b/arch/um/Kconfig > > > > > index 18051b1cfce0..eb2d439a5334 100644 > > > > > --- a/arch/um/Kconfig > > > > > +++ b/arch/um/Kconfig > > > > > @@ -10,6 +10,7 @@ config UML > > > > >   select ARCH_HAS_FORTIFY_SOURCE > > > > >   select ARCH_HAS_GCOV_PROFILE_ALL > > > > >   select ARCH_HAS_KCOV > > > > > + select ARCH_HAS_MSEAL_SYSTEM_MAPPINGS > > > > >   select ARCH_HAS_STRNCPY_FROM_USER > > > > >   select ARCH_HAS_STRNLEN_USER > > > > >   select HAVE_ARCH_AUDITSYSCALL > > > > > diff --git a/arch/x86/um/vdso/vma.c b/arch/x86/um/vdso/vma.c > > > > > index f238f7b33cdd..fdfba858ffc9 100644 > > > > > --- a/arch/x86/um/vdso/vma.c > > > > > +++ b/arch/x86/um/vdso/vma.c > > > > > @@ -54,6 +54,7 @@ int arch_setup_additional_pages(struct > > > > > linux_binprm *bprm, int uses_interp) > > > > >  { > > > > >   struct vm_area_struct *vma; > > > > >   struct mm_struct *mm = current->mm; > > > > > + unsigned long vm_flags; > > > > >   static struct vm_special_mapping vdso_mapping = { > > > > >   .name = "[vdso]", > > > > >   }; > > > > > @@ -65,9 +66,10 @@ int arch_setup_additional_pages(struct > > > > > linux_binprm *bprm, int uses_interp) > > > > >   return -EINTR; > > > > > > > > > >   vdso_mapping.pages = vdsop; > > > > > + vm_flags = > > > > > VM_READ|VM_EXEC|VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC; > > > > > + vm_flags |= VM_SEALED_SYSMAP; > > > > >   vma = _install_special_mapping(mm, um_vdso_addr, > > > > > PAGE_SIZE, > > > > > - VM_READ|VM_EXEC| > > > > > - VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC, > > > > > + vm_flags, > > > > >   &vdso_mapping); > > > > > > > > > >   mmap_write_unlock(mm); > > > > > -- > > > > > 2.48.1.658.g4767266eb4-goog > > > > > > > > > > > Intel Deutschland GmbH > > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > > > Tel: +49 89 99 8853-0, www.intel.de > > > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > > > Chairperson of the Supervisory Board: Nicole Lau > > > Registered Office: Munich > > > Commercial Register: Amtsgericht Muenchen HRB 186928 >