From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5BFC369BD for ; Sat, 19 Apr 2025 03:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7485E6B0005; Fri, 18 Apr 2025 23:53:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D0006B0007; Fri, 18 Apr 2025 23:53:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 548546B0008; Fri, 18 Apr 2025 23:53:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 33A136B0005 for ; Fri, 18 Apr 2025 23:53:33 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 53ABA81744 for ; Sat, 19 Apr 2025 03:53:34 +0000 (UTC) X-FDA: 83349423948.14.5115091 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id F41C720002 for ; Sat, 19 Apr 2025 03:53:31 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a+8RvHYB; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745034812; a=rsa-sha256; cv=none; b=yvwGW+nby4WiJBzrPeLezmggbhRUfCqENFUlhGVCkvRRVpYpMIvLhqsOzGDB4V853Nwz60 ESmCDl7poPcThcCD1ObkgWkQnbgBSvk6TEf1anFd4N+AW8bMz2A5EjsZWzAJCJq0XsT/l9 hREMt0qF1Af++45QBzl5Xl6eHjMk2+0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a+8RvHYB; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745034812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LKj6D7ydUvkkkHiFxc83MdzWfmUREj8+ls6NLjJlCpY=; b=f9LeFPsoynJZs3KOitG8R/UEjEdgncXmDbmpX2XFEZJDAOPgWLmEaHWBHjPWYbyhsBi7k1 xwtR8XJH4lmJamo7C/SnCBrcZgUigXtKRPAWj2RIMU5tlhHaWbRCtu2C0tkpqoBg1Gn2UZ 1041n+9/N7o9Zh/7s3HjTcZrr1JdKsQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745034811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LKj6D7ydUvkkkHiFxc83MdzWfmUREj8+ls6NLjJlCpY=; b=a+8RvHYBwIIwcGKqtVCSAM5s7mVYgcneYfgq95hh/CDet/BEJTWEQxDwA+Fur319YqRqSV zXZ7R9cknA3p406iQg/L9sAmk1sDax2LDBd7wEHVeKZkweAVA3P/HF0KKomDu+J+h9l5qb leicxcqkykoAqiqEo+WsR/Q23a0Gd6A= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-4BUrnCLlPDqWkg9p8Q8LSw-1; Fri, 18 Apr 2025 23:53:29 -0400 X-MC-Unique: 4BUrnCLlPDqWkg9p8Q8LSw-1 X-Mimecast-MFC-AGG-ID: 4BUrnCLlPDqWkg9p8Q8LSw_1745034809 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5e2872e57so380342685a.0 for ; Fri, 18 Apr 2025 20:53:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745034809; x=1745639609; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LKj6D7ydUvkkkHiFxc83MdzWfmUREj8+ls6NLjJlCpY=; b=Eo7WcdxhfJr0xwAdEH2vEdgsh3JPa42Cl8DLRJ4IfC8XJRWdMP52qDCn5svJ0FKQs2 j6Q/p61NMEu4bOdBhNRmyKWA8E45TITLJclAE+p5spSJ49Hbn8AgVTQn0kSXitGZ3n62 5dylg5YgGua83FUBbAsKD2WkWZ2WdAqrS8JjvHF6jnbZ8qob4Hm+fzI/eHddeVTd7eZc FZ/rkfVSDpTbYHYTjsmMsvUgLdt4Vyr+BKTkRow/RI86un3ad7PQ+YsDQpopFY3tH77A 4sXNHgpxa9rLyctC4wggEISir32VgyyoyoMoPOoDlNabZ8TVizUQjNq2f7LSpO9vF4bz ghuw== X-Forwarded-Encrypted: i=1; AJvYcCWh3RYVuIOpFEVRs4HKSePCtCfeYWgEsbxDFuluwa1CNgllYQUiJcNnl1AyaBEWYocEwbyRKuikyg==@kvack.org X-Gm-Message-State: AOJu0Yy2iT46RRTAqaKSIfOI8djC4dxfLQWra0AdhE1BI8SDc5PgkpcQ rFPliZCoCjzCmC9YtUdD+v8148xhxobW/UDx6q+boL6AdwAAxLH5Ve28TDFNlbNHmxnlfwPgll4 fq+wJ2X8xwjJ0vtRFEprdN2IzrpeYXCRPJaSzM2lo8P7lREdL X-Gm-Gg: ASbGnctNJqCGK+5BFBI1/WrUump+LPMOjkf3vWK8LoN7iyXC2r8RRomgSymd2G69VY5 QDEqll67U78g5uuGhYw/nxQGGHspBPrZSVS2a86XwAuUtc5D4pqh5KnjqrF1+oE3dftmTrCY5Dl 2CH1UN2rNKDNDjZBUl0jtf5v/IkkpO7b+iFS4vIGXJXJnCNpKkBYjpQRP/pfV2trWD8eKExDRi0 7oPKT9eTZQPv0h2q8AivJgJuV/japomK9FETlp4yzmOFk4uh6ABMZ0oV+RUbz8MPRDW+8yEVeAs QYFRfki+aJy1W/wn0IIBz/1dwAMPnQZoHA+ZmxiH8nB8If54hg== X-Received: by 2002:a05:620a:288b:b0:7c7:5b32:1af9 with SMTP id af79cd13be357-7c927fa1549mr783892485a.25.1745034809117; Fri, 18 Apr 2025 20:53:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHbCaMtgw22RLcM0DduEGN4e9PzjuMCuEVDKnXDXyih6j+UdLAwqczdezz9lgVSPMVUBfIGg== X-Received: by 2002:a05:620a:288b:b0:7c7:5b32:1af9 with SMTP id af79cd13be357-7c927fa1549mr783891085a.25.1745034808813; Fri, 18 Apr 2025 20:53:28 -0700 (PDT) Received: from [192.168.130.170] (67-212-218-66.static.pfnllc.net. [67.212.218.66]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c925b778c0sm176223185a.112.2025.04.18.20.53.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Apr 2025 20:53:28 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <19e268b0-b6d5-4aab-a4d0-cd1102027f3d@redhat.com> Date: Fri, 18 Apr 2025 23:53:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] vmscan,cgroup: apply mems_effective to reclaim To: Gregory Price , Waiman Long Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org References: <20250418031352.1277966-1-gourry@gourry.net> <20250418031352.1277966-2-gourry@gourry.net> <162f1ae4-2adf-4133-8de4-20f240e5469e@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Tr8kzJyuTYhNxFpr2rzQlfPrwK7GLV4kjOg0c-q9Gf0_1745034809 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F41C720002 X-Stat-Signature: phdyynm1xrydr9jf8c7u9z4mactaf4py X-Rspam-User: X-HE-Tag: 1745034811-216168 X-HE-Meta: U2FsdGVkX1/vRMIeqT5IeQqxF/oglaXIBrzZ9ZJ0YYE0X9Bcj4X6ThQTkNqOJEI73wAhtm6lUtyrt+Ht5aGa0GxcioHyuU5zUgRf84cZSVoYHQjfmsBX4+QWZ45k/dgoS81menNfnlfFPRBYNYwcuzmaRIsOXKpQEi+LbAqO7djxyYEbUGqt2fqY7mbhIDsa0WRO5tf82eFZLrAJFpyK5Pwvy06unemBQTTvOIZ22yY1S72a22wZQKaffbFx6fLplI8DtbPWEw0E9VRNH6g9QjDYhm+rc/Ks3fSmgphJKnIPqa/GOMNg4piSF4Pb5s8FHjXgmkkLlYYE1ZEpcuofro0YkxqpGzej10yDEUFyx4nx8Al+v1GP+NrzELYT6pwrjRQaaeNLnHbwBzsC7LSP49KeOn0d1T+VBm010i9WNyaz6g5729bE7EjHQjLefPB88/zkH+5d7esLoqq10IfEv/ELkGDHD+jgpJjPAcvWfQUUvF8VTg6hZ627HmdLZIj3yT9wSBsE/7iopSuJ2TgugRJcmjZNtfx+uAeXQ6ad3TvbSD86uFGevrl3WpL32V3b47GSiQ8om5En3UVyBabot4sYkpP4m0CwCRoUp7Gdc1vQPPHCuFV92OzKIg2jcqnhvmwK1kWvqhdwErEcmj0/8nA4Fy1TylT9TEObg1UNVdCIha0oqrgzP6q+jsyRRhC7/kanLWIU6wUaeg47NAxuqx//K7y5eW0IkGpsrqMTQBH+uIXUQ4WafjG4Z0fYHfOQXOCOk4g1U3k7K8CN1J/L3P3UjRTSBEbDmP3v/Yz+vdGdPTCFcQ2bH/WVT3EvVJi4I0Byf+UfW2agymgCCXEmk/5oLXftqcWgB0X1UIS666xA64T4WMCl4vmhKpM/sLSANUv6GyQhXZvcjWHVpyPVk8jziIhNZvT7L7Y8g65uomNuhGzIbZL6zo2rA8r34gmZM19LcviMrwuH+e6X+kf 5iXr1tzf CWptdmaYX94ACR1briaaxwP00Ex3heEDyaNARn2trw/4cX1toGcA72YRWgzFfcCMO/GjMIrMjTglQa0ao4SB6g/4crCiZhAH65u+5HNe4jLe5llQK6kH9A2OXuDpdSJfc+O2pI01dJP2O9k2B+/yXLCXnBCrcEmsyrIWOJ6h6kqfpgSxYHTotgKTknJr0u3bnrm6GRXhP50gt4sPJwrPLictDWkdFIuZ6F2U/j/1Ju/hhO+BDl8Q0fk4pgfDKh+DgFMQLNN0Qp+/DfGjUCGCtpHKuUI3++CCT0Qx2hqcXilf3pfutz5IT0a2Gulu+SIoec30gb3bmn/0cJ21EVKUU5hoed87FcruKRMeS+krlBQl546oAToB6Gjz723KvcKvVogXCXflQJkZKD4kA72ShWtfp7ZCRZ9uRWkivsAdrAaOcrl9RYYGPuFgIfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/18/25 11:47 PM, Gregory Price wrote: > On Fri, Apr 18, 2025 at 10:06:40PM -0400, Waiman Long wrote: >>> +bool cpuset_node_allowed(struct cgroup *cgroup, int nid) >>> +{ >>> + struct cgroup_subsys_state *css; >>> + unsigned long flags; >>> + struct cpuset *cs; >>> + bool allowed; >>> + >>> + css = cgroup_get_e_css(cgroup, &cpuset_cgrp_subsys); >>> + if (!css) >>> + return true; >>> + >>> + cs = container_of(css, struct cpuset, css); >>> + spin_lock_irqsave(&callback_lock, flags); >>> + /* At least one parent must have a valid node list */ >>> + while (nodes_empty(cs->effective_mems)) >>> + cs = parent_cs(cs); >> For cgroup v2, effective_mems should always be set and walking up the tree >> isn't necessary. For v1, it can be empty, but memory cgroup and cpuset are >> unlikely in the same hierarchy. >> > Hm, do i need different paths here for v1 vs v2 then? Or is it > sufficient to simply return true if effective_mems is empty (which > implies v1)? Yes, you can return true if it happens to be empty, but it is "unlikely". In v1,cpuset and memory cgroup are in separate hierarchies AFAIU. So the cgroup you pass into cpuset_node_allowed() won't have a matching cpuset. Cheers, Longman > Thanks, > ~Gregory >