From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F368C3DA59 for ; Tue, 16 Jul 2024 02:30:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5DD46B0093; Mon, 15 Jul 2024 22:30:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0ECD6B0095; Mon, 15 Jul 2024 22:30:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A87776B0096; Mon, 15 Jul 2024 22:30:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8A3936B0093 for ; Mon, 15 Jul 2024 22:30:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4B93F1202E0 for ; Tue, 16 Jul 2024 02:30:27 +0000 (UTC) X-FDA: 82344036894.19.90BA585 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf17.hostedemail.com (Postfix) with ESMTP id 21C4840013 for ; Tue, 16 Jul 2024 02:30:24 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Qt4uvdiB; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721096994; a=rsa-sha256; cv=none; b=3WX+ZcZwL6FfVMn2+6TRfu3jSagzFDFqy8PTntpp6iRxIW4FsU70Npyd1K7PJRcVT5mmz6 qVumRRxq5q3BsAD7R3EE+KJwhPSMUxqg0PW9bRazcwcqEO8k37B1N43VvTceEKuwhOhWv4 vtBTIHJhUkL31aVDUBxdnV9sdY0V1/0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Qt4uvdiB; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721096994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dp+t4TVVT4KvEUTsJDJgPzRF5rh9Mr0HlvSnhg7VjDo=; b=AYg/HJhRkgEhd3PPdmNMxY4q6w/2RWdWJ9aQ77wJtosDOodNg97wamkyrEL9phlgy6ezZr InGR/DWz1z5uFrM3J6CBLXXZXjkHKkFss+TuiVu+S5udiqzxqX+xEkW5CamQzHkPRJ4lwC MYVyFkqzwz0EzSIOSyC8CGORgQ0bNlo= X-Envelope-To: nphamcs@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721097023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dp+t4TVVT4KvEUTsJDJgPzRF5rh9Mr0HlvSnhg7VjDo=; b=Qt4uvdiBJ63KRbdjDcIfbEAfuFSOjdTP5wypoxktEPs0O++jZOkRTi49OXjTCCJxLlbDWS MNLwDDGYMCDu7RRnH7Kbhcfa8ooasRcIDJAZDeIjbBwDTOkzj3jJoQKqMMEEQm73D6X8H+ dFVFlRPIbfBVkUXuw2SPsxsFc6fk6w4= X-Envelope-To: flintglass@gmail.com X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: yosryahmed@google.com X-Envelope-To: corbet@lwn.net X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: cerasuolodomenico@gmail.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-doc@vger.kernel.org X-Envelope-To: linux-kernel@vger.kernel.org Message-ID: <19ceab41-1537-4fbc-b75d-7a2f5c50c0f3@linux.dev> Date: Tue, 16 Jul 2024 10:30:15 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v2 5/6] mm: zswap: store incompressible page as-is To: Nhat Pham Cc: Takero Funaki , Johannes Weiner , Yosry Ahmed , Jonathan Corbet , Andrew Morton , Domenico Cerasuolo , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240706022523.1104080-1-flintglass@gmail.com> <20240706022523.1104080-6-flintglass@gmail.com> <0afc769e-241a-404e-b2c9-a6a27bdd3c72@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 21C4840013 X-Stat-Signature: hde516tj6tis61rkpg9ww77u1d9iirdt X-Rspam-User: X-HE-Tag: 1721097024-922222 X-HE-Meta: U2FsdGVkX18spzBug2MQU3KRv3pBRma7fDsdrOXQwfj3bBjd9Pkdg16obeUugbogiDdbNcmgYddN/lom5UWkNU+O+Jtip0NfvHNwc+MWh4HdXc3BebRT38HXk9FBPrfvBGFwNrki0Y9vwpxM9RPrvfUWkzEZUBkMiqPOlAkUU3c7cg02c38zPxx2+W9QriLECYFp1I48JBMLW5dv6q7zv6nEfypn9qNtGshIm9FPygBnIu+zXIEfD25cG9GTBQq4dfDySk4MiVWh9Y6NMfMVuWDmIx5Pb5Y1W+BcwU2SH7gai5toYqmyMeIN7g3uHwx/rvxAU7G6Q/kLzvcQ/x/qq0Xl28AQO9/naTN1I6nN62Slm/u3J8IERU4KKdVR2dfJuzs3rLI80Dp4vxAOdUc152ZbzACrv0nJyeX7edL9tuxUxyTo2IRTmzKVyCIesQwQan1qocWIOvfYHGz+DHYvZqryUd8eYdge+8lDLWKyzr+avGuCjM5zOGQZ5dpvktTq6leuw6q4jihgQwstOexUmagURZeaa3G5Fa6DXt/qY1TsIzan7MJJY2212JjbN00FUehOrT2JCGsff1tjbt9vM6zDkcC6+LCbszOWPskgBf5OWPGqF6OihSpVBJMyUna/yX27Q5RE2GRVAHTtEG8uaWBEwlOz06ZZ5k+heR+CPENeLQ1dCDE1+cOiesRnARhQOeC9Ww49mSSazODdHBN/XTxGnLY4VD/kJuorYxIwx34x1ReeeSyz4XSMDPxTxS7kEibqtkRJTgeV3t0Bg98RuulrskmGq0cM5t1daNmkr+8lWVsv5gluhIsIOxOMjWf8LjtmiF1kd0AY3KCwIAs89zbc0pyXvFaxJ/Ty2kILQXSS7sItj1J8IDOun1V98hDU+zr5ZmfwI8E+T+0GGlwNgTEvajAPj+srEQh5fKveddhXNJv2l4sOJXUc4jcKlVE/g5ux3S5ccjfWJZUzuM2 I2N1azIF pZiVcQg1Iki5yAAqvaHsFzlx78s2o9c/PnO6cMQvvBEMOC6v5LxtRI/10ugLnZAf3Y3WfpGwt1+XLAgsZ5JWs3snWy8kzJ5SUoRj0cpgSkW1iwhNvOmb6L5SI3RWYKFjXtbYQSYR5URc+QpHi8ddYI58Stoo+Blu4w7cyV2NYwdcRKBlenw8JVF7Em/sy9ZHljTdMigH60Fwd5v1t688llnO0YQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/13 06:47, Nhat Pham wrote: > On Tue, Jul 9, 2024 at 6:26 AM Chengming Zhou wrote: >> >> On 2024/7/8 21:44, Takero Funaki wrote: >>> 2024年7月8日(月) 12:56 Chengming Zhou : >>> >>>>> comp_ret = crypto_wait_req(crypto_acomp_compress(acomp_ctx->req), &acomp_ctx->wait); >>>>> dlen = acomp_ctx->req->dlen; >>>>> - if (comp_ret) >>>>> + >>>>> + /* coa_compress returns -EINVAL for errors including insufficient dlen */ >>>>> + if (comp_ret && comp_ret != -EINVAL) >>>>> goto unlock; >>>> >>>> Seems we don't need to care about? "comp_ret" is useless anymore. >>>> >>>> Just: >>>> >>>> if (comp_ret || dlen > PAGE_SIZE - 64) >>>> dlen = PAGE_SIZE; >>>> >>>> And remove the checkings of comp_ret at the end. >>>> >>> >>>> >>>> We actually don't need to hold mutex if we are just copying folio. >>>> >>>> Thanks. >>>> >>> >>> Thanks for reviewing. >>> >>> For comp_ret, can we consolidate all possible error codes as >>> incompressible data? >> >> Maybe we still want these debug counters? I'm not sure. > > I'm a bit torn, but ATM I have no strong opinions on these two error > codes. If you do decide to consolidate these two, may I ask you to > separate it into its own patch so that we can review + discuss it > separately? Yeah, I also have no strong opinions on these two error codes, it's just ok to keep them.