From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D2A7E77188 for ; Tue, 31 Dec 2024 07:18:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 875E36B007B; Tue, 31 Dec 2024 02:18:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8262C6B0082; Tue, 31 Dec 2024 02:18:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C75F6B0083; Tue, 31 Dec 2024 02:18:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4D93E6B007B for ; Tue, 31 Dec 2024 02:18:43 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A276D161A41 for ; Tue, 31 Dec 2024 07:18:42 +0000 (UTC) X-FDA: 82954400550.15.A1107F6 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf04.hostedemail.com (Postfix) with ESMTP id 13F4240002 for ; Tue, 31 Dec 2024 07:17:50 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=pR3psg0w; spf=pass (imf04.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735629471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K6XJql5m47BXAvrRdSryIG8UjgiG29oVpHXZwXoQr+w=; b=gtBpLkdI2Z4f3GWpKPM1KNpt4q7/w/rA66TTSHBngxAeTSqmixIITqSFj/sPoJ3lJrcvyx ncCtYbZUbnnsbP1G26lzbnJ1QsEdd8WWBOTXiNLLNlT4O0LYM0LpDHX6RyhCkZe528zDmm dU/Sf6sy2HUnteFDmeduiqA3KPbSMFA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=pR3psg0w; spf=pass (imf04.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735629471; a=rsa-sha256; cv=none; b=k4n+bPJsM5iJEnEpEqSXort4KFgvquocHJ3isizJS+Vxq9/2ypLkiKJ4LA6KW859lIYToW UBRQBNjnaGETnWSGW916Y52UNWNDgydY5UaQZqZTygY3RxgXxqusG9ExRxLjcpiFoSztQW dWY5XvIgL8qNnZzpLTUfbUMTmV6rqYw= Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BV5n5uZ010219; Tue, 31 Dec 2024 07:18:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= K6XJql5m47BXAvrRdSryIG8UjgiG29oVpHXZwXoQr+w=; b=pR3psg0wQx6hwUQv XHenV54hPaE4gIyM1Ed8G2RjRZzVcKHxHsZnk5XoOguQDqpRXa/Xwutt5EkMjdIp ovJpOtcWD4+7WTj879BVTG1LAG+qCC5zorOmzOzIz1cD/nB5X6FEdIkg8qWTcOJ8 7hNa8lp0KtiqhNqxK0zAGeZRxOQf1ravaO1vxNKZXDAHrBUZB4ZjkMUfSvIN4syP V9zIEoNmm5y2bmFqrDuJRR5Mzy8kQJn7bYDuhVUKMRMwV5Cf48ft4tqpJUT0PHW1 RB+H8ZhxxaD2BDJLwELI+DmngsUvteTaNIoK/QnNbOF8WyVQ5wJiYSd4/CdkXmjr WribxA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43vasy861v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 Dec 2024 07:18:33 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BV7IWsm004491 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 Dec 2024 07:18:32 GMT Received: from [10.239.132.245] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 30 Dec 2024 23:18:29 -0800 Message-ID: <19c42e9f-8f61-45d2-9df2-c7f667495b12@quicinc.com> Date: Tue, 31 Dec 2024 15:18:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: mm: implement vmemmap_check_pmd for arm64 To: Anshuman Khandual , Catalin Marinas CC: , , , , , , , , , , , References: <20241209094227.1529977-1-quic_zhenhuah@quicinc.com> <20241209094227.1529977-3-quic_zhenhuah@quicinc.com> <39a85800-47c5-4529-906d-5a40e58ce136@arm.com> <8685ca94-1382-45c0-a3c3-4b5ccf244057@quicinc.com> Content-Language: en-US From: Zhenhua Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: feLxOR_f25bomt_Qth2sIC3sdKgj4HuZ X-Proofpoint-GUID: feLxOR_f25bomt_Qth2sIC3sdKgj4HuZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 phishscore=0 spamscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=445 impostorscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412310060 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 13F4240002 X-Rspam-User: X-Stat-Signature: cb5jcp6fjgbmsps7s3ypyxmkkdm3dxbf X-HE-Tag: 1735629470-897867 X-HE-Meta: U2FsdGVkX18PvKDoTuSC257mp2q/RjnixM7SDU1+qUcGoKbNe9fKGLVmaVGy/rPdLGI9RaxwJ4beWzyQGMRbyaF64T6onwtztwIWpudvQnkH0YPAhy9DVYrPXXy2eWDhR1h3v7LyRdcnd9Luuiu1fA8QPKwKvbI182Fb6PkPwpsohI0eQeX7tLWN9muKj+UNKjo++Kc//GvLt5SYM9Zjs5928BX4H/fovSTmJ0bbOS6+q9j1ScW5oZ49hJraF7jDtZAr4tIPZPmEMxdlpYfvoi5GcqD4p/bdT7fgOQgVYgaPrN2i8Fg38T3lOlyD4IFDfO3ujCZu9RAt7N1SQ/7iok3TUEyTGnWCkww4X759nJBJCCIe9zwQ+DkjR+AvgszQaaN7L33a2xy4x8KaQsEnDO+CjbjMN8D2cyFK18LFxIInuYQYSNNfeoz8zytkU1Xt7tp3mZLuDAkQZH92ZsiDkEM8t3shU6MSop0ZehMIGT3vKzfcsmcH61H9Le3eMVmTPt1O+/t6wfBVcQas4J3GKHJ3HsWcSLzVDLx6x61AT5+XrdPhtOVJJqTqjB/DasaMP3wGnxXFKliFe1T/285MVEUracu6fsIwssueXemKgb8r5UWtjbo5iuN/LDbzepYtKxyylYyxHUsipwCrHTtM7RryKGylLCdhz+EioCqf/rA3WV9HZ4jchfI66gLYnvT4MKOWNehLMwv0IHYJzwa9Xzqd4105CJiyxP42hTW7dRaLFJgOftpzUKhtpuzz66nyasG/QwR3pRwfJLnTXLP7K3rsmG+l2TptkjI3nMIRXrHVY3t0AEKKd0Whhpr0EmEywgQA7zPFA8lG2FK5vwOQQr/NwpFxlAJUeYTKDpjH58+yOB5IXYsXrOuqsGf1vFlE+Wwfbp0E8Yf74+C96/9cJxAJYylKDETVpaRDS3Elw/T5nn5gpCNYwGTYt/I3mRHETCktVZ6gY6tRcj21NER NpSHIVVj 9BXhC8+c2ZHLlXfFpFF+kcIj+AbarGPruyJPaJojCTpHU3eyPGjXnmJLqTlWKMIp5SYRZospZN8Bpu3YqXTpRQG2JUmla18DW7oReVVv8ZDtwWXnv2mrZ+EnK1VeilCdycSRTx1PDw06rkq6FKVWqvOcJEae6mbL3Lm0hT9fQ2I2ocg/rL4RJWJr+T06eW7leUZ+AYGBQXFOOhsv0gp7diptH7/AdhzReqIwWmZ8htCz4YjbeI3vJdrM1eB4GXY/jhsJ3OWzOKbYKsqsVv7UAZZpLv/acIElCZkGaaymrhZw4limPkn11g2INLs1mnT7HZzqpWNyNGJmmDcL0rnT1lkkswTiItYaGzawo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/31 14:59, Anshuman Khandual wrote: > A very small nit regarding the subject line. The callback > vmemmap_check_pmd() is already present on arm64 platform > which is rather incomplete. Something like this might be > better. > > arm64/mm: Test for pmd_sect() in vmemmap_check_pmd() > > On 12/30/24 13:18, Zhenhua Huang wrote: >> >> >> On 2024/12/27 10:57, Anshuman Khandual wrote: >>> However it does not really check the entry to be a section mapping which it should. >>> Returning pmd_sect(READ_ONCE(*pmdp)) is the right thing, which should have been the >>> case from the beginning when vmemmap_check_pmd() was added. I guess because arm64's >>> original vmemmap_populate() checked only for vmemmap_verify() as well. So probably >>> this does not need a "Fixes: " tag. >> >> Hi Anshuman, >> >> I agree, will remove "Fixes: " tag in next patchset > > Could you please send a V3 of this patch separately instead > and not part of this series as they are not really related. Sure, Thanks Anshuman. Will gather information and update after coming back from Holiday! > > But after implementing the following changes > > 1) Use READ_ONCE() as indicated earlier > 2) Drop the "Fixes: " tag > 3) Update the commit message explaining why pmd_sect() is > required here and how the originally commit missed that > 4) Update the subject line