From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5FEFC00528 for ; Tue, 8 Aug 2023 03:17:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A2096B0074; Mon, 7 Aug 2023 23:17:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52BB26B0075; Mon, 7 Aug 2023 23:17:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F3BF8D0001; Mon, 7 Aug 2023 23:17:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2F4C56B0074 for ; Mon, 7 Aug 2023 23:17:40 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 03EA2A049B for ; Tue, 8 Aug 2023 03:17:39 +0000 (UTC) X-FDA: 81099477480.30.3DB64C3 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf29.hostedemail.com (Postfix) with ESMTP id 23FCB12001F for ; Tue, 8 Aug 2023 03:17:36 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691464658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lMblKaooa4tgL7cFekfJkCd+/H1VUgPYOfYffn6N2H0=; b=ycdv3db2THeK7zwK4mgjJJIDVRN3x6yQh4+vZ2GJ4IsJsfxbRhgqaqWAn4iuO7YR88Kdr3 Q7IBEwB+aBrCZ73Vezq9wvANdHwYwAjqBSOKIL2rGZKpX7K71dCBbP/CD8BJaCIOU2pUeR MJetkF3Wm8MqPBIgZt+8LW4FmkwSCFQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691464658; a=rsa-sha256; cv=none; b=q+Llia7PaWcuHvhMQ+7Bd+D9QlQQoCKxhd0XP5UlzN3H1qVKYoUK5YZvFBSWdk+N3a+wam 43T7m01+Vl2gieVebPVX15O7iX1bVUKSG6a0WavPcc54dueTpoEZ1jW38XuiC8ikSrHL4l G2NuIsZnkLeZuLJeZfg3/0V7I7NYiKY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R371e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=24;SR=0;TI=SMTPD_---0VpJIIhI_1691464649; Received: from 30.240.115.244(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VpJIIhI_1691464649) by smtp.aliyun-inc.com; Tue, 08 Aug 2023 11:17:31 +0800 Message-ID: <19bc33e2-1f47-43d6-599c-3e48bb697f7c@linux.alibaba.com> Date: Tue, 8 Aug 2023 11:17:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RESEND PATCH v7 0/2] ACPI: APEI: handle synchronous exceptions with proper si_code From: Shuai Xue To: rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, naoya.horiguchi@nec.com, "james.morse@arm.com" Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, justin.he@arm.com, akpm@linux-foundation.org, ardb@kernel.org, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, bp@alien8.de, cuibixuan@linux.alibaba.com, dave.hansen@linux.intel.com, jarkko@kernel.org, lenb@kernel.org, linmiaohe@huawei.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20230606074238.97166-1-xueshuai@linux.alibaba.com> <1fe4f86e-63ce-3702-4e08-4bc0e7bb391b@linux.alibaba.com> Content-Language: en-US In-Reply-To: <1fe4f86e-63ce-3702-4e08-4bc0e7bb391b@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 23FCB12001F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 7rk43g6erx6w9mfj9xndo639ndzjr5aa X-HE-Tag: 1691464656-601648 X-HE-Meta: U2FsdGVkX18UkJjMn+dVA/rFimUwCJxiZ1zLQEh40CTXIEvLAP4ZJQJoinI7L8yVo304eumSyFg2OjharcdpChnQRGa9s6uM8hlQrpv6eC2IvCpoQIRuXIDKjCrU74HO/oyQ55yJkJ1dhH8Tzs1M9uF7Cw6s+yRDp/Y0VRzmQ5MHpQIjVWslti+FhcsP7ymXU2TPnMo7rpbUsDFQD6DAqAN1iPA6yPJingNsHpMj8iirFL1H1nAelMVuaCaJKGaYF63obBMuVCLgyILpXloibkaxMqhdkwKylIXY+2ukEIhQscnswflvYJ5Vb5p7msT+CK0swV87vSyDxInPhyrXnN82jczydSKH/f+g0b0H/suBMqIXdyBy8AfL4CPHVMfw2mjmcJshkQSraUQQKQCwzZ/wSgdK9h993RF9eUyhdF+X2OSiKLEspdrxbXGRc/VBneuKVg86w3ypBVMokdIaIY5SYR6rtWys2nchRfijNiHM8vLjI5yQ9ok16uJmtHxS/qZPQsnhYLp6+B52saAB/hiXdUFFo6aCBqfW0BPQ7aMGIrtI0a0kQmzvYlc3O0lnDBWqtnxB2K0NXvegkMxAezRc5pm5Fkj5y+iKWTracb3Vh/X7m+bh+/GkcDr8cIIKdQW6JKBjQRjjQ2eyLATEAROabrCfvfTQdDJ3Lg0r7I7rTFDOwIWv1X/AbjCyjdO7891MOAl1qHfNks3g2UJvV5gw//Q4oPvHRTn70kgtB9Onk4ak5OfNnfkguDSVFPqAW9ci+UVglXPSrc2FD0SC+tBa0CxysjE+QOfZOJf3wB/kxzkfxw006iIM6OTrWet9wbFRkzBspzDN3CcnvHqYtqWyvHHlOPsl99qHzDhXUwVHqMndrWpScNJ7jl197YToQwhYrdpHw0/cpGn+V9sQtqbpyPk6xxpjxrkPPLbdITMwNkFt6jgrsOU3RC12KiedFQVCnfFbi1veuIa5Szg 6YBRcMSW M1EfFNFUodX++kT+yWGyvO8XNcdQkKOAr+fUgco3WFYyT4A+pgF5wHH9PrytJKHtm99QNOJw6+d41BEWaxV3k4JPTrPx2x8DKxBHGIXxK8IsGM8hUAWcpfzaJdDqgny7xq6a9/9TQbxTa8HKAJ7ha7fT/UwzFXJ+hCOfoRpmrY+qpZKaDRRzc3zZ6GiWRvuwQhHdpykfwkhZ8BeHzbl+Ni+eoWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/10 11:15, Shuai Xue wrote: > > > On 2023/6/16 15:15, Shuai Xue wrote: >> >> >> On 2023/6/6 15:42, Shuai Xue wrote: >>> changes since v6: >>> - add more explicty error message suggested by Xiaofei >>> - pick up reviewed-by tag from Xiaofei >>> - pick up internal reviewed-by tag from Baolin >>> >>> changes since v5 by addressing comments from Kefeng: >>> - document return value of memory_failure() >>> - drop redundant comments in call site of memory_failure() >>> - make ghes_do_proc void and handle abnormal case within it >>> - pick up reviewed-by tag from Kefeng Wang >>> >>> changes since v4 by addressing comments from Xiaofei: >>> - do a force kill only for abnormal sync errors >>> >>> changes since v3 by addressing comments from Xiaofei: >>> - do a force kill for abnormal memory failure error such as invalid PA, >>> unexpected severity, OOM, etc >>> - pcik up tested-by tag from Ma Wupeng >>> >>> changes since v2 by addressing comments from Naoya: >>> - rename mce_task_work to sync_task_work >>> - drop ACPI_HEST_NOTIFY_MCE case in is_hest_sync_notify() >>> - add steps to reproduce this problem in cover letter >>> >>> changes since v1: >>> - synchronous events by notify type >>> - Link: https://lore.kernel.org/lkml/20221206153354.92394-3-xueshuai@linux.alibaba.com/ >>> >>> >>> Shuai Xue (2): >>> ACPI: APEI: set memory failure flags as MF_ACTION_REQUIRED on >>> synchronous events >>> ACPI: APEI: handle synchronous exceptions in task work >>> >>> arch/x86/kernel/cpu/mce/core.c | 9 +-- >>> drivers/acpi/apei/ghes.c | 113 ++++++++++++++++++++++----------- >>> include/acpi/ghes.h | 3 - >>> mm/memory-failure.c | 17 +---- >>> 4 files changed, 79 insertions(+), 63 deletions(-) >>> >> >> >> Hi, Rafael, >> >> Gentle ping. >> >> Are you happy to queue this patch set or anything I can do to improve it? >> As @Kefeng said, this issue is met in Alibaba and Huawei products, we hope it >> could be fixed ASAP. > > Hi Rafael, Tony, and Naoya, > > Gentle ping. I am sorry to see that we have missed v6.3 and v6.4 merge window > since three Reviewed-by tags and one Tested-by tag. > > Do we still need any designated APEI reviewers Reviewed-by? Could you give me your > Reviewed-by @Tony, and @Naoya if you are happy with the change. > > Or Please could you Ack this change if you are happy with the proposal and the > change? @Rafael > Hi, ALL, Gentle ping. >> >> Thank you. >> >> Best Regards, >> Shuai