From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
maple-tree@lists.infradead.org, akpm@linux-foundation.org,
willy@infradead.org, liam.howlett@oracle.com,
zhangpeng.00@bytedance.com, stable@vger.kernel.org
Subject: Re: [PATCH 6.6.y] maple_tree: do not preallocate nodes for slot stores
Date: Mon, 18 Dec 2023 09:53:53 -0800 [thread overview]
Message-ID: <19b88718-a1e6-d699-f056-cf00b1b75346@oracle.com> (raw)
In-Reply-To: <2023121847-cope-surviving-26bf@gregkh>
On 12/18/23 2:59 AM, Greg KH wrote:
> On Tue, Dec 12, 2023 at 11:52:55AM -0800, Sidhartha Kumar wrote:
>> mas_preallocate() defaults to requesting 1 node for preallocation and then
>> ,depending on the type of store, will update the request variable. There
>> isn't a check for a slot store type, so slot stores are preallocating the
>> default 1 node. Slot stores do not require any additional nodes, so add a
>> check for the slot store case that will bypass node_count_gfp(). Update
>> the tests to reflect that slot stores do not require allocations.
>>
>> User visible effects of this bug include increased memory usage from the
>> unneeded node that was allocated.
>>
>> Fixes: 0b8bb544b1a7 ("maple_tree: update mas_preallocate() testing")
>> Cc: <stable@vger.kernel.org> # 6.6+
>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
>> ---
>> This is a modified backport as the patch to fix this in upstream does not
>> apply to 6.6 because the node_end field was moved from the ma_wr_state to
>> the ma_state after 6.6.
>
> What is the git commit id of this change in Linus's tree?
The patch is in akpm's mm-hotfixes-unstable tree and has not made it to Linus's
tree yet.
Thanks,
Sid
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-12-18 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 19:52 Sidhartha Kumar
2023-12-13 20:54 ` Sidhartha Kumar
2023-12-18 10:59 ` Greg KH
2023-12-18 17:53 ` Sidhartha Kumar [this message]
2023-12-30 11:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19b88718-a1e6-d699-f056-cf00b1b75346@oracle.com \
--to=sidhartha.kumar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox