From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C4B7C4332F for ; Fri, 16 Dec 2022 16:37:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 716B18E0003; Fri, 16 Dec 2022 11:37:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C6BA8E0002; Fri, 16 Dec 2022 11:37:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 567838E0003; Fri, 16 Dec 2022 11:37:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4495B8E0002 for ; Fri, 16 Dec 2022 11:37:34 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F1C111410EA for ; Fri, 16 Dec 2022 16:37:30 +0000 (UTC) X-FDA: 80248725060.12.D3FE6CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id CAA4BA0024 for ; Fri, 16 Dec 2022 16:37:28 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q8qDUksM; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671208648; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qKpV/VqJnDWZ/oVpmuV6caL/79sgF/1JHTzTx6G1qmI=; b=N2SzBAHz3xrrINBPXrDIN2OzqkIU6l5eYZsIlL9QbrUz+h7t9g/yJk3EN5Dn2G3bfXPCKH X5wrqs44ZpCbpQqTv0PZgwOCKEgSKf2GmKxfEIN77XJgJNeY0ZNhiVkzyKNebxMlppDQdO aVT7ZYe9mJZhIcsvYEb4bWH2rThETQY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q8qDUksM; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671208648; a=rsa-sha256; cv=none; b=Hfp04w5FULMvmPh7BrTkCclCDs7QcW3b5s9+LdqVxHoylKE1x+RJgpM9yjNYqkun5u66qW SpKkuPbhVtgcQUJqN4LhrfPnTpfUxQKrIibmRZGbEAXfkHhvsTMKs+6auhfcxfx3VxW71h ZUF8AJDGWQFT+dJQ96DdQ/7TpLj7W1w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671208648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qKpV/VqJnDWZ/oVpmuV6caL/79sgF/1JHTzTx6G1qmI=; b=Q8qDUksMC01wGcr8hdCmpnfbvkCYKMXZtAMouiwFkRorX6dwqGUJjuuPhIngIh22lt6uBH wzucYuaijhOMXB8gOrn+jTaSwWuzaY4PJqg79LxV8Xnq/ufllG7vyxhilR2sXUI7qB4qeO nx2HkbrFbNJY9gh/lM9jFv2bQ2KE0M0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-646-TM8VKiycMF2TZ6YfJL9GZg-1; Fri, 16 Dec 2022 11:37:26 -0500 X-MC-Unique: TM8VKiycMF2TZ6YfJL9GZg-1 Received: by mail-wr1-f72.google.com with SMTP id d6-20020adfa346000000b0024211c0f988so616643wrb.9 for ; Fri, 16 Dec 2022 08:37:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qKpV/VqJnDWZ/oVpmuV6caL/79sgF/1JHTzTx6G1qmI=; b=uHS3pXhF8mYvAcZgb5rdwUZD2zFL4Ly/0/7KGYtSGBUOPIIx4V7Z2iqK98E9EiQ1yj 9/1Q2bKcEEMo2iEFfmkbeMOHwVgLsaIWdSGL/DwU2FGWzLz6eYwmahfcx2BdpsDNJNjc dpehQ5mgSduGiBmQzTUGwOLeRj5+UiFQPIyNIdLIGLhONibOe/6lvA88jLBJZRZ33kcE tGgzkhFJw/TkmZteLTHRgY/8ZN1gH+MiBeV6C0L7JrvtE4l5BTqwS+wctlPWgAAKMqLt Ig+J5FInhBb+fGMFJVWdCUUDXhw50dAUvNHM8rT8j1nO+RxaE4xXeMr5df+CAI0yplv5 kDrg== X-Gm-Message-State: AFqh2kpaju/k+9IE8mvfESKp+sOUuqLTyaMcw1N++0EKqt/GuALjm1ao hsTwojpYw2WYUjCr1gTq1EGKpRBTaTAmXY4Jcod/p76imtr4jEGcBl/UQNc+DJVZBDknX2BqggH 0zDx3gOCqNW4= X-Received: by 2002:a05:600c:1d06:b0:3d3:4aa6:4fe6 with SMTP id l6-20020a05600c1d0600b003d34aa64fe6mr121470wms.3.1671208645697; Fri, 16 Dec 2022 08:37:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXsWRJhHoFiViQpkEdyT8L9CVxpuBTZfVTyGNx3xoccjDeKiUopQOKgssEF482JY1V6yVJ+q0g== X-Received: by 2002:a05:600c:1d06:b0:3d3:4aa6:4fe6 with SMTP id l6-20020a05600c1d0600b003d34aa64fe6mr121455wms.3.1671208645494; Fri, 16 Dec 2022 08:37:25 -0800 (PST) Received: from [192.168.3.108] (p4ff23686.dip0.t-ipconnect.de. [79.242.54.134]) by smtp.gmail.com with ESMTPSA id i6-20020a05600c290600b003cf5ec79bf9sm2867736wmd.40.2022.12.16.08.37.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 08:37:24 -0800 (PST) Message-ID: <19b49f1f-9d2d-6cf1-e764-ca4219b22ab9@redhat.com> Date: Fri, 16 Dec 2022 17:37:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/2] mm/uffd: Fix pte marker when fork() without fork event To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , Pengfei Xu , Nadav Amit , Andrew Morton , Miaohe Lin , Huang Ying , stable@vger.kernel.org References: <20221214200453.1772655-1-peterx@redhat.com> <20221214200453.1772655-2-peterx@redhat.com> <618b69be-0e99-e35f-04b3-9c63d78ece50@redhat.com> <8c36dd0a-90be-91bf-0ded-55b34ee0a770@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CAA4BA0024 X-Rspam-User: X-Stat-Signature: oekbb7ei7gpdcihneqjijjkbjsgbm6qz X-HE-Tag: 1671208648-427956 X-HE-Meta: U2FsdGVkX19X0IQ1eylIu76lb2T8ETtZ6+erRddS83PYJYgk9NbdVKWJDEEH18IMGWVKuTHxx0V6R2wed3rW0BNKJIrrpImvRzd/0r6BupNmT55YYYp25/M3LTfCvVkbtDk2tHoMr6c/X9O1qockA0DB62wuF+XVqHmH5J1QCnyGAoRu3/K9z/cLSrQ5IKDUnMDkbNhUWBdKUryYwHGPuvvFkmIxoJOWViJ+KvqWcDdGGIE3/K1O7wtyvU4OLBGhFqK5cqNwdkq5DVdxBYjl3xv+D21lHqOKywjKEG6gZ7WbHceAqDU6hIwBDRBFi/KGF5yBEiqL2mPg9NoOMZ03FXTl1FPbd0iIJpcx8oXpPO3NEkhEcrJZ5SvXppITLSpKt5R3eSbmlhIig0r5EZPpxqMRonhxMJemx6cIh4QrKZAN/wVGnMZFwYykzhtP4CkrZRzUWQFebDtisRy/ddrpJoNR1q+N5CC1WXtRouNQAqYCPuzgh/xQNFxln74eMKVycRwtIH5NAAS3rOfS6jI9+D0KWtSe2KAnW30Y87U9+4EAk8c3Yd+a8xre8xre9Ful6mFiWimpjX8c9lhtb83eF/0NDgmnxsFUDbk8NAcUCcOdAoWMqo45ZUHCOBqzI1dGP1i6ecy0foZGrXNi+rOOYHH2lXXyjZIBC8ybyBncHljTasDM5t/gslWhRkjm6FIBgORHR5pN0iBJJPVKZeX7I03DPoZQ4OJL6h73cNGgPrKWlFNF/7ZLDYRA7oZ8Pk5y+bjF7XBpo2mfd/1vVFUkdGb9O5rC3RDeNuCEZTsTvbe0yeqyWlBHcR378PJ+J/AjiAAZ+VLpqEu28kJG9OhPw8dQ8ZnQfnGKlLHIPlaV3cIcKbB2r7xXlWE69KC/+mJ59UchOU0qcklG6YoE99VbZ6DfEfXDOe/S0sqQGmfIQfGXBVBT+VgTUt0g1r4RxOZkc6hKwhw8XJWrStlMSYS z6/638eN vU7rTBJwTj3gO9876rVstKyWxxM8QDgdjUwKD8oRgDLcJfk2shPQQMi2ELp385u3A+kDO/Wawl7NJE3d4PhPu46bcFskMVkftvOOoEdQ7hTUU/I8ZwF6Q6KPLvigBS7IyJL/71p+WxTGxIQCPZnBbQNw13kzRCLs9r0mmJY5Dp/wcSJkSimJu5R+vreaUG8JkqAvAZuNKDS2JZzH7Fuv5MnhrNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.12.22 17:24, Peter Xu wrote: > On Fri, Dec 16, 2022 at 04:57:33PM +0100, David Hildenbrand wrote: >> I'm more concerned about backports, when one backports #1 but not #2. In >> theory, patch #2 fixes patch #1, because that introduced IMHO a real >> regression -- a possible memory corruption when discarding a hwpoison >> marker. Warnings are not nice but at least indicate that something needs a >> second look. > > Note that backporting patch 1 only is exactly what I wanted to do here - it > means his/her tree should not have the swapin error pte markers at all. > > The swapin error pte marker change only existed for a few days in Linus's > tree, so no one should be backporting patch 2. Right, and these patches are supposed to land in 6.2 as well. Makes sense to me then. Especially, the other parts in patch #2 are worth being in a separate patch. Acked-by: David Hildenbrand -- Thanks, David / dhildenb