From: kanoj@google.engr.sgi.com (Kanoj Sarcar)
To: Rik van Riel <riel@nl.linux.org>
Cc: linux-mm@kvack.org, sct@redhat.com
Subject: Re: filecache/swapcache questions
Date: Tue, 15 Jun 1999 14:02:07 -0700 (PDT) [thread overview]
Message-ID: <199906152102.OAA22739@google.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.03.9906152223590.534-100000@mirkwood.nl.linux.org> from "Rik van Riel" at Jun 15, 99 10:24:38 pm
>
> On Tue, 15 Jun 1999, Kanoj Sarcar wrote:
>
> > I still can't see how this can happen. Note that try_to_swap_out
> > either does a get_swap_page/swap_duplicate on the swaphandle,
> > which gets the swap_count up to 2, or if it sees a page already in
> > the swapcache, it just does a swap_duplicate. Either way, if the
> > only reference on the physical page is from the swapcache, there
> > will be at least one more reference on the swap page other than
> > due to the swapcache. What am I missing?
>
> When the swap I/O (if needed) finishes, the page count is
> decreased by one.
>
Never mind, I was being blind before. This is why shrink_mmap
has code that reads:
if (PageSwapCache(page)) {
if (referenced && swap_count(page->offset) != 1)
continue;
delete_from_swap_cache(page);
return 1;
}
Say a process is just about to execute exit()/munmap(), and kswapd
steals a page from it, updating the pte with the swaphandle.
zap_pte_range -> free_pte will just free the swaphandle, possibly
leaving the page with a refcount of 1 (from the swapcache) and
a swappage count of 1 (from the swapcache again). shrink_mmap
recognizes the page/swaphandle will not be used by anyone and
frees these up.
Thanks for the pointers, Rik.
Kanoj
--
To unsubscribe, send a message with 'unsubscribe linux-mm my@address'
in the body to majordomo@kvack.org. For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/
next prev parent reply other threads:[~1999-06-15 21:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-06-15 7:16 Kanoj Sarcar
1999-06-15 7:32 ` Rik van Riel
1999-06-15 15:51 ` Kanoj Sarcar
1999-06-15 20:24 ` Rik van Riel
1999-06-15 21:02 ` Kanoj Sarcar [this message]
1999-06-16 20:37 ` Andrea Arcangeli
1999-06-17 23:33 ` Stephen C. Tweedie
1999-06-18 0:20 ` Kanoj Sarcar
1999-06-18 17:00 ` Stephen C. Tweedie
1999-06-18 17:03 ` Kanoj Sarcar
1999-06-21 5:29 Kanoj Sarcar
1999-06-21 11:25 ` Stephen C. Tweedie
1999-06-21 16:46 ` Kanoj Sarcar
1999-06-21 16:57 ` Stephen C. Tweedie
1999-06-21 17:36 ` Kanoj Sarcar
1999-06-21 17:49 ` Stephen C. Tweedie
1999-06-21 18:46 ` Kanoj Sarcar
1999-06-21 23:44 ` Kanoj Sarcar
1999-06-24 22:23 ` Andrea Arcangeli
1999-06-24 23:55 ` Kanoj Sarcar
1999-06-25 0:26 ` Andrea Arcangeli
1999-06-28 22:36 ` Stephen C. Tweedie
1999-06-28 23:24 ` Kanoj Sarcar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199906152102.OAA22739@google.engr.sgi.com \
--to=kanoj@google.engr.sgi.com \
--cc=linux-mm@kvack.org \
--cc=riel@nl.linux.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox