From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6111C3DA64 for ; Wed, 31 Jul 2024 10:56:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AC0B6B0082; Wed, 31 Jul 2024 06:56:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65B066B0083; Wed, 31 Jul 2024 06:56:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D4246B0085; Wed, 31 Jul 2024 06:56:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 313C26B0082 for ; Wed, 31 Jul 2024 06:56:02 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C844E80132 for ; Wed, 31 Jul 2024 10:56:01 +0000 (UTC) X-FDA: 82399742922.08.AC26C0E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 59BBBC0013 for ; Wed, 31 Jul 2024 10:55:59 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bGWGX0Rh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=48k6HJ9B; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bGWGX0Rh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=48k6HJ9B; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722423355; a=rsa-sha256; cv=none; b=w5DpjeIaF5NDA4L622/PuejwoztzaCfEvaaNqVy/BL/v06TmeLokgYLIgnLSq7eWNvJfKR oavo80vi4ADRBZY3KNYmtG/07MVqeqC8UafeaxaExr2Au2rqABLHUHbcwhFrKzzxLmCVcm wPn0rUE1zDIyY3ax5RVA/yNUrNSQQPU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bGWGX0Rh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=48k6HJ9B; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bGWGX0Rh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=48k6HJ9B; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722423355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x2eufugl6JPtMDb75b7WK7LBenki8NzUMhj+piOZtAs=; b=TVSE5tENCzss0Iy1+ri5WW7QTNEYMaI+yJQtEqy7jwkC88W4dMH9ky9A7GPllnSAG8/1dK xp+MX7LD8UncYjdpHJu8oy7GJz0yWYqnEQEV0LNxSIEWEyzksyHOXq4XFtPQQM7xvG9GYn ACvDmN/GCH2Sj6Xqn8g8MPYA1ZUAt2I= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C9FE71F833; Wed, 31 Jul 2024 10:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722423357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=x2eufugl6JPtMDb75b7WK7LBenki8NzUMhj+piOZtAs=; b=bGWGX0RhDJglVDkBItM6dUCPHeKgbw7DQ9AAFRpGOSQBHe/kQYpTdBdB9Z4e8yjjRPUH8x GUeAJqu/DDXX6pi6uykrEI4qTCHF+V7p709II9wrXTriaKdaqSUeWiQXm7kB9K8AJuc8Fl iXG8oNwFVlaOWrqcswb5/yOjZRYYU2o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722423357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=x2eufugl6JPtMDb75b7WK7LBenki8NzUMhj+piOZtAs=; b=48k6HJ9Bi1FVEHZKkySzL9AJjb589qX5zquYysxm7GEwdW84raNKd88N81NLr/yQ7RSrQx zJnqZLnhLtuKXCBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722423357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=x2eufugl6JPtMDb75b7WK7LBenki8NzUMhj+piOZtAs=; b=bGWGX0RhDJglVDkBItM6dUCPHeKgbw7DQ9AAFRpGOSQBHe/kQYpTdBdB9Z4e8yjjRPUH8x GUeAJqu/DDXX6pi6uykrEI4qTCHF+V7p709II9wrXTriaKdaqSUeWiQXm7kB9K8AJuc8Fl iXG8oNwFVlaOWrqcswb5/yOjZRYYU2o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722423357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=x2eufugl6JPtMDb75b7WK7LBenki8NzUMhj+piOZtAs=; b=48k6HJ9Bi1FVEHZKkySzL9AJjb589qX5zquYysxm7GEwdW84raNKd88N81NLr/yQ7RSrQx zJnqZLnhLtuKXCBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9FA6513297; Wed, 31 Jul 2024 10:55:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +M49Jj0YqmYxNAAAD6G6ig (envelope-from ); Wed, 31 Jul 2024 10:55:57 +0000 Message-ID: <19981556-cecd-4f58-8b3b-bc3bb85a6ac4@suse.cz> Date: Wed, 31 Jul 2024 12:55:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] mm: prohibit NULL deference exposed for unsupported non-blockable __GFP_NOFAIL Content-Language: en-US To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: 42.hyeyoo@gmail.com, cl@linux.com, hailong.liu@oppo.com, hch@infradead.org, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, torvalds@linux-foundation.org, urezki@gmail.com, v-songbaohua@oppo.com, virtualization@lists.linux.dev, Kees Cook References: <20240731000155.109583-1-21cnbao@gmail.com> <20240731000155.109583-5-21cnbao@gmail.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240731000155.109583-5-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 59BBBC0013 X-Rspamd-Server: rspam01 X-Stat-Signature: th1cworzfqc9p6w796g9cufd6y83913j X-HE-Tag: 1722423359-376509 X-HE-Meta: U2FsdGVkX194TDPOUErc8sKX3hb2wRLKgJ/qW16kX1VndaSNeV/TkowTvV8h7qrb6oay5TotLJz2UOETQSA/0ssnd7X5Kus22P9G1quCWT0pqiYoODUO1duG8mhff5+g/VSgUmg3ZHUasu/+yX1w0fg/iGZtBFICCIzIpq4W+uCBtb4Lou2lKvty5C6a1kShqtH/P/WhctK/JFN6fqOBLtyZbE9iR5c5v41am5N92rWxZOQgrzxb1OlkYKtQQD5oYpMRe+Jls4wHg+bMvtyVGzeIg2CCqo5xklNFkhMCFAuZVKJ3gk3Pa9FgtOiWuHnI7QazhNafb+IUrc22cRGKTiBiBtNFgpfoJvvtjDPTmZcWfeXnvOu+TFskUzKmcjIGQH6NSP+oev+Pjo3qdGco3C1zpq25+MWVdf/zB75np9RGoSWoEdPtl+7nBHBHILcD5/XIOtt540tZZkHyddNvEG4KH2tOdmmu0chsjyv0UkVDK0XRYrxyuLMRNy7fyFm4L9h9kxkAFW7pbex010/MnXS1TpPLpWBUTTDvNT8PRX5SNufoIcyjD83MxV1ZuWjGDmmhqCsUf/4+4+2ZybQAw7mv0+1Ji7sINaxg4jb1Bz+FgAhOfQ+fY8X5BdXXbbcUfAWyk+gAoS55+n2dtyYK05rt1ST432Y+gv1ZhMfuH6rIUJA0RmYzWYhO8E8udI8BY6/DvHpQ9l/WyLwsovKfVcon8XQxRyJYzbunJXhPxqvkBheMI/m754JBpKjoAPYqtSXyjyC0pMyr0W3RKxGO8KVENueVtibrEEDo17y18c2e8VVoadh5uuG0Iw5w6MobBp/Y7Xr/fM5kSyjo7khM8waAx0b9bIXEyPGbGA0EHeGzBFAGp7U7JEi9qC3llu83i4LhtihoK/7m3nrybIBhuf2XXxWUi8kcY2NCqltRVwY6EsGSERJAYGmaLG+Ek/I+Qn3aUgpKpq2dor4x4un wyQDzvG6 AMTWuKf6zDobdFFC6lfvqo6ZEhUB6ZUGP8s4Knj+aYxU24DEjQmTMtSKcLmrQFuJ4GIx6WnFeSdG4/pvLEP7xSeJ685tHNgnJdNzzv46FoNf/j+7TAMMBKJzK8fiZfEQDLArlXE+RmJndimcQL0jgoT1HNIUxVadCt2i/kOiVnHMfp9eIW81HF+sSlIqUFPclW39z44BCziVxpIiSnAuNgPZ5K6HAvnuQCrlceHiC0oLd4OCWAU3pe46/pQYL/U6WV9F5YyJkic6lfvmLzQnTx897Tr6iCxvcGZJFSZXAio1FSr0Vtdt5sBOlw1gBPyfEYTBv5aibZem2m/ADqrX72PSk8DW69tXbSamGhXeSjbVbXi003tSK9N3/jQEkVe0n9Jh9lcUFzJwHe0NeP2kPu6HEM/QkdJvG2kw8tH9ZUvHLN2m84F+rzfDIUfmzblCLnh9EtuXzbCfdEaNQI1BrIveeOfWLGJRqr2T2xgUQr0iwU1NlyRHRHOkfPfz3YMQHLi+8MwQ2Zszg+gmOA6nYTPYAr81nRf9ufE6V2VLXGoSqtqVIUuw7einrMxGItqd6EOlZlUrcPG/IVxhDV7Vj4K2WehHPkJ8kuzeogl7x3coQsQ6xGOb13fHUk3EGcAKrkg0wZcGrtV2uGc3oWOOQ67xa8hFhkCqdk/D9DuBj+6b7GQjuoSKW5Xd56nBcfU0t0uO8Rff07HgMEe9tad/TAmct0zreTGR1i93P6GmcF2921A/svKwO424JkCJ31C55OrjFk4WEPN1LBT2rNE7yPKg51DrfNyAcJFeoUpdMCIZMfEKzdo0gE9tVg6Lv3DLrgJ1F87qHFGpk6zdGFAeFVYnFiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/31/24 2:01 AM, Barry Song wrote: > From: Barry Song > > When users allocate memory with the __GFP_NOFAIL flag, they might > incorrectly use it alongside GFP_ATOMIC, GFP_NOWAIT, etc. This kind > of non-blockable __GFP_NOFAIL is not supported and is pointless. If > we attempt and still fail to allocate memory for these users, we have > two choices: > > 1. We could busy-loop and hope that some other direct reclamation or > kswapd rescues the current process. However, this is unreliable > and could ultimately lead to hard or soft lockups, which might not > be well supported by some architectures. > > 2. We could use BUG_ON to trigger a reliable system crash, avoiding > exposing NULL dereference. > > This patch chooses the second option because the first is unreliable. Even > if the process incorrectly using __GFP_NOFAIL is sometimes rescued, the > long latency might be unacceptable, especially considering that misusing > GFP_ATOMIC and __GFP_NOFAIL is likely to occur in atomic contexts with > strict timing requirements. > > Cc: Michal Hocko > Cc: Uladzislau Rezki (Sony) > Cc: Christoph Hellwig > Cc: Lorenzo Stoakes > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Vlastimil Babka > Cc: Roman Gushchin > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: Linus Torvalds > Cc: Kees Cook > Signed-off-by: Barry Song > --- > mm/page_alloc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index cc179c3e68df..ed1bd8f595bd 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4439,11 +4439,11 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > */ > if (gfp_mask & __GFP_NOFAIL) { > /* > - * All existing users of the __GFP_NOFAIL are blockable, so warn > - * of any new users that actually require GFP_NOWAIT > + * All existing users of the __GFP_NOFAIL are blockable > + * otherwise we introduce a busy loop with inside the page > + * allocator from non-sleepable contexts > */ > - if (WARN_ON_ONCE_GFP(!can_direct_reclaim, gfp_mask)) > - goto fail; > + BUG_ON(!can_direct_reclaim); We might get more useful output if here we did just "if (!can_direct_reclaim) goto fail; and let warn_alloc() print it, and then there would be a BUG_ON(gfp_mask & __GFP_NOFAIL)? Additionally we could mask out __GFP_NOWARN from gfp_mask before the goto, as a __GFP_NOWARN would suppress the output in a non-recoverable situation so it would be wrong. > > /* > * PF_MEMALLOC request from this context is rather bizarre > @@ -4474,7 +4474,7 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > cond_resched(); > goto retry; > } > -fail: > + > warn_alloc(gfp_mask, ac->nodemask, > "page allocation failure: order:%u", order); > got_pg: