From: "Stephen C. Tweedie" <sct@dcs.ed.ac.uk>
To: Rik van Riel <H.H.vanRiel@fys.ruu.nl>
Cc: "Benjamin C.R. LaHaise" <blah@kvack.org>, linux-mm <linux-mm@kvack.org>
Subject: Re: [uPATCH] small kswapd improvement ???
Date: Wed, 4 Mar 1998 21:11:24 GMT [thread overview]
Message-ID: <199803042111.VAA01668@dax.dcs.ed.ac.uk> (raw)
In-Reply-To: <Pine.LNX.3.91.980304124951.20479B-100000@mirkwood.dummy.home>
Hi,
Regarding the tsk->swap_address stuff: swap_out_pmd() includes the line
tsk->swap_address = address + PAGE_SIZE;
so the setting of tsk->swap_address to zero is only temporary. Indeed,
I can't see how we can block between setting address to 0 and setting it
forward in swap_out_pmd, so we should only allow anybody to see the 0
value if there is truly nothing left to swap in the process's vm space.
Has anybody verified that this change alone, without any other of Rik's
changes, improves performance?
One other observation while looking at this code: we currently walk over
every process when swapping, and this is wrong. We should only walk
over each mm_struct once. Another one for the list for 2.2.
Cheers,
Stephen.
next prev parent reply other threads:[~1998-03-04 21:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-03-03 17:05 Rik van Riel
1998-03-03 19:09 ` Rik van Riel
1998-03-03 23:54 ` Stephen C. Tweedie
1998-03-03 23:59 ` Rik van Riel
1998-03-04 1:17 ` Benjamin C.R. LaHaise
1998-03-04 11:54 ` Rik van Riel
1998-03-04 21:11 ` Stephen C. Tweedie [this message]
1998-03-04 23:27 ` Rik van Riel
1998-03-04 14:00 ` Dr. Werner Fink
1998-03-04 15:33 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199803042111.VAA01668@dax.dcs.ed.ac.uk \
--to=sct@dcs.ed.ac.uk \
--cc=H.H.vanRiel@fys.ruu.nl \
--cc=blah@kvack.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox