From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ACC1E7717D for ; Fri, 13 Dec 2024 15:03:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0D436B007B; Fri, 13 Dec 2024 10:03:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EBCBD6B0082; Fri, 13 Dec 2024 10:03:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5E346B0083; Fri, 13 Dec 2024 10:03:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B9B706B007B for ; Fri, 13 Dec 2024 10:03:25 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 21E6F4394D for ; Fri, 13 Dec 2024 15:03:25 +0000 (UTC) X-FDA: 82890253362.06.B487054 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 0FD03140008 for ; Fri, 13 Dec 2024 15:03:04 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cvr9lYcF; spf=pass (imf09.hostedemail.com: domain of gmonaco@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gmonaco@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734102183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oBcSJQ2t3grJhtRmAoyfmj/BiN/0ePGUbmAHrkcnY0k=; b=A/bG65PjUsk+viLSZgCNejdCo2MN28S/76dN4shLSuL/q1tAvcGLfh9uWDqT6bUHHt2/Xt Afx09Bca6nWYYix/eb/bVDd4D2VgQx/0fG2zvPRTnQpYmbBlqqvf8jbwOo1UXIlIKjPlnz IDYVVwTZaL0wzO/J9UDLk1QKQKD0ygU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cvr9lYcF; spf=pass (imf09.hostedemail.com: domain of gmonaco@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gmonaco@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734102183; a=rsa-sha256; cv=none; b=L+jqGqLiGZCKxpTPdxZPhaMTTmbOJXUr97kwqDQFFc//UIEi6VIGJRjNlEfgwzljeKCUrv d+NIoc7/AonATmZn7g2FGM29+PlA/m2nYUXVc99t4MFjjh21WPM+6/HfU1YvRCgtpx0HyD F6bTYRfKXyzqmpxbafdrVl2nrvSczz0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734102202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oBcSJQ2t3grJhtRmAoyfmj/BiN/0ePGUbmAHrkcnY0k=; b=Cvr9lYcFua1VEBfDHdzvLkAIqMeiGkOUCbsaEfVSwoHQ26uHfokpQ3Oz8U6Pk9aJhN/2hS DVvxFJ2OW93B4iUWoqch59xquR8wrzyl56m44FdHXIYLnK+jz7gO9E5Z0y5FFfrgvSw2n0 BywPJV2cD/cFTeUE+px5fGm2jCG+MFI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-f0xEZWUFOFiehkezKJzN0A-1; Fri, 13 Dec 2024 10:03:20 -0500 X-MC-Unique: f0xEZWUFOFiehkezKJzN0A-1 X-Mimecast-MFC-AGG-ID: f0xEZWUFOFiehkezKJzN0A Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4361d4e8359so15073475e9.3 for ; Fri, 13 Dec 2024 07:03:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734102199; x=1734706999; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oBcSJQ2t3grJhtRmAoyfmj/BiN/0ePGUbmAHrkcnY0k=; b=k7ohI09u63yn76RX4qpSgoEqwn0T024WlFfKd2X8qLTdp1N2Lsi4mqeNc51vljE/Th MeJgldlkdNoXOqDkZN9sGBT+yHXmGY8R1IT+PjS/00tzKQfhHnadLmOlgKY5XCkn7sWH Os4edbvJ7dSSANpkDNxvaOX9M/2FR0zwcgd5LlNJ4nCvnkaAOmKwIyXOpkv+1tPc+9ec RJTikSdegVw+XXEJDcRW1WbEPL+m/X2uSg9dozgoA6TzmXyTolfx/2Pm4IzxPoTfW5GV XbnM7Pv7yQLSQxmAS+LuaROfX52QC25fy2f2WGr9o9Vg9mDHoeQO0gTTIh5rJgdkymoH lqsQ== X-Forwarded-Encrypted: i=1; AJvYcCWF9tUx1WwHxehH/gPdAZXwPF4Z9lybVZ0LWN/GOYEgU2WIsDp345vyPatzTr1jppr4xp5xtqmtYQ==@kvack.org X-Gm-Message-State: AOJu0Yxxp8Yz2irLNFXDVEHy/gFwbQrjoclR0wrF5FadJYFLPazQnHuY CLjVqPJHhHh3xtWsPCgwj37uL6+voa30e2Xh+KbYj2n5o6DYETw2f6w/NxtCvnvm0JS1hXn2WNi 2EjMkbqBhOlNyZgROVEQfx672Q1Qniy4z4NqEE4IRjLghRiZp X-Gm-Gg: ASbGncunaT5hASSUG14KZUHRswfEtRocql3dWqDxAG+1CxD1A/61v79ubT2x2gm9YnL E3CV2SsWuXv4y8X3HrBsqdPCiCG+JUUPUspY/JbhJsyUVtbA6Rfc4iGjOLsiXX+6uP/4FBGHMi1 tYG5Yt5lG14RGPJCSY1KEY/1MI+/7Nwyy1XZbkvKs8HH+ucX9zPfRrx+/SuedUtmb7g8xplX/RF ulrVGbXUsqwjz3Xmq+xM8qKngoKSf7LdbK/PDWCxabuLOZfiOAFkLPgPI+Ej8SNJlVkiy2jzh+9 4B8IdEc= X-Received: by 2002:a05:6000:1848:b0:385:f6de:6266 with SMTP id ffacd0b85a97d-3888e0ae4e6mr2179713f8f.24.1734102199441; Fri, 13 Dec 2024 07:03:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfmoqcWVGaoAEdxBU9PUF7o693pCscmUutfo3TPGUnwsDrq4ACd1XfMkd86Qb9YrgGD48O2g== X-Received: by 2002:a05:6000:1848:b0:385:f6de:6266 with SMTP id ffacd0b85a97d-3888e0ae4e6mr2179654f8f.24.1734102198868; Fri, 13 Dec 2024 07:03:18 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb ([185.107.56.30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38782514beesm7452649f8f.71.2024.12.13.07.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 07:03:18 -0800 (PST) Message-ID: <199437fe21ad5bb47ce81c560fbeb0495b5f9ce3.camel@redhat.com> Subject: Re: [PATCH v2 4/4] rseq/selftests: Add test for mm_cid compaction From: Gabriele Monaco To: Mathieu Desnoyers , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Juri Lelli , Vincent Guittot , Mel Gorman , Shuah Khan , linux-kselftest@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Andrew Morton Date: Fri, 13 Dec 2024 16:03:15 +0100 In-Reply-To: References: <20241213095407.271357-1-gmonaco@redhat.com> <20241213095407.271357-5-gmonaco@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0ByZWRoYXQuY29tPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmbiuWMCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfJzZgD/TXjnqCyqaZH/Y2w+YVbvm93WX2eqBqiVZ6VEjTuGNs8A/iPrKbzdWC7AicnK xyhmqeUWOzFx5P43S1E1dhsrLWgP User-Agent: Evolution 3.54.2 (3.54.2-1.fc41) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ev0F7vpEYwB4GOUcC4fXqUhv12SFazBWb1U7TheFXng_1734102200 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0FD03140008 X-Rspamd-Server: rspam12 X-Stat-Signature: 3p4e8878cjy9jfzke6kc5qcc5qqzdf1h X-Rspam-User: X-HE-Tag: 1734102184-123204 X-HE-Meta: U2FsdGVkX190FdmltPG6w5st9t3cdsynruhOqSNo2vpropmFWDZ9Gg/js0eABIksKByD3lFdq965shHd58ZaGxPhUxudOQa/iczNw3bCQG4osjWG4ZDtgS5ufYE3bIwtOKmZ08PW2nf/ssD2PCJ1hEoC8mGvYdcUKCHp+5EePO1km0PVifLa02yt9LjNxuDCxbFOshpdBPHK0WWPdyRdIEYzfCyJXcGWsBdfnyJQ9yznYBORSSpmWRHauOYvYVjjiX7Ueog6lqQlvAZjt9OaXlSizZAPrXQGRd9TeB1vt1Pfxor4Of5H9s/ZeFGOW0P/6If+01lLiGwBeLYl/oieAE2O2N2bhtzEpu50zq4zxOf2EPrVeF4R1FQHAyh/tQG/d7gF+SB+BbErO1pA6XCV5gis3gFTOepGh7QTxJfM6G6hJU+CKaXTgoZ1Du7Y4D7O1wpnU084OzVAo46LeElsrFhpgvWa0fIzf/TqNxV36VZMagwIQGPDMV+nP9LPFmc8beewNXund0hC3ZvMxupvvdgys0F1tqusmN0Iyu0xu92YARjo6jKqAD/MXRyqhflq1T9cYr2ic0Afnq5SQPqg7tf1CcjPgtETna36BOlpsV+PSrb7/KTSwKUiZedmk0S+QgpzguPQUmpV3AC4hQsLA+zQbRMoOMr2tPC+PRkwEEuliTfLr48XV7M2KRH032DQurtp9hOUok21DgyACwXcUF5WLw4rgpcCI90PMs/9KeoDiw1BSzUh0KECnYb94fenBiZiWdGWFO2NdiSprTSOrdmDbWHyyMNBX7C2huQLN166Vgiml80+znYhgpA4FPXY2yHgDIIWqkrOZocZBchMvoTSGVQ1YB+oLO9/NilhRU2eqPYsFFcVSZxnSGEZm8zV3zitluWfK407rv0ytDaogAqt+YiyiKg8eYmcp1O0BXT3V19YPI99MsQIawEtLPZ1A3ar4TPADT4cJoaMLMR vp4lAsyc AUqXlJow1S+0NneO3Zhjuq4BbN73Usn9kW9bFCtEer7Hru54yEwXNRxjyZNJpKazHOYOeETprN6erIic+d4Tkza/utyq94kbl+e5GIR2hxh5LQbQAGpZtmt/DLhXRnnzPhVompFtf9fOW6/T7JfBZRJjzMqOGdiRANyBsZ02X67exgoHbQeHTGKfQC3L2pkK5s5C9HLY77L1oOi2+aKEnzYtHv28c6RWJcdQ6aopbyva8s0m86CyR6dw9L0E4Xd0d9a92LFKHokDf6OQsPL3xywrJBx0pQEL4sdPt4TWdtZybsnK4kYph+M7aQhsllDGkllvfisRcKfTfH3QBIlZ/HpBqL2eBNAhiIrxEbJffVyr4nrnS1Rc6oejJZo1bcQ5TzJc8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000879, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2024-12-13 at 09:29 -0500, Mathieu Desnoyers wrote: > On 2024-12-13 04:54, Gabriele Monaco wrote: > > A task in the kernel (task_mm_cid_work) runs somewhat periodically > > to > > compact the mm_cid for each process, this test tries to validate > > that > > it runs correctly and timely. > >=20 > > + /* > > + * We select one thread with high enough mm_cid to be the new > > leader > > + * all other threads (including the main thread) will terminate > > + * After some time, the mm_cid of the only remaining thread should > > + * converge to 0, if not, the test fails > > + */ > > + if (curr_mm_cid > args->num_cpus / 2 && >=20 > I think we want=C2=A0 curr_mm_cid >=3D args->num_cpus / 2=C2=A0=C2=A0 her= e, > otherwise the case with 2 cpus would not match. Right, good point. > > + =C2=A0=C2=A0=C2=A0 !pthread_mutex_trylock(&args->token)) { > > + printf_verbose("cpu%d has %d and will be the new leader\n", > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sched_getcpu(), curr_mm_cid); > > + for (i =3D 0; i < args->num_cpus; i++) { > > + if (args->tinfo[i] =3D=3D pthread_self()) > > + continue; > > + ret =3D pthread_join(args->tinfo[i], NULL); >=20 > We'd want a synchronization point to join the main thread. I'm not > sure > if the main thread is joinable. >=20 > Perhaps we could try calling pthread_self() from the main thread, and > store that in the main thread struct thread_args, and use it to join > the main thread afterwards ? > >=20 > > +void test_mm_cid_compaction(void) > > +{ > > + for (i =3D 0, j =3D 0; i < CPU_SETSIZE && j < num_threads; i++) { > > + if (CPU_ISSET(i, &affinity)) { >=20 > Including the main thread, we end up creating nr_cpus + 1 threads. > I suspect we want to take the main thread into account here, and > create > one less thread. >=20 > We could use tinfo[0] to store the main thread info. Good idea, that would get two birds with one stone. I just forgot to pass it but it seems=C2=A0the main thread is perfectly joinable (just checked), so that should work fairly easily. >=20 > > + ret =3D pthread_create(&tinfo[j], NULL, thread_runner, > > + =C2=A0=C2=A0=C2=A0=C2=A0 &args); > > + if (ret) { > > + fprintf(stderr, > > + "Error: failed to create thread(%d): %s\n", > > + ret, strerror(ret)); > > + assert(ret =3D=3D 0); > > + } > > + CPU_SET(i, &test_affinity); > > + pthread_setaffinity_np(tinfo[j], sizeof(test_affinity), > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &test_affinity); >=20 > It would be better that each thread set their own affinity when > they start rather than having the main thread set each created thread > affinity while they are already running. Otherwise it's racy and > timing-dependent. >=20 > And don't forget to set the main thread's affinity. Sure, will do! Thanks for the comments, working on V3. Gabriele