From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF78C369DC for ; Wed, 30 Apr 2025 21:11:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B09636B00D6; Wed, 30 Apr 2025 17:11:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB8386B00D7; Wed, 30 Apr 2025 17:11:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 931F76B00D8; Wed, 30 Apr 2025 17:11:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6BAED6B00D6 for ; Wed, 30 Apr 2025 17:11:10 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 83107C0ED1 for ; Wed, 30 Apr 2025 21:11:11 +0000 (UTC) X-FDA: 83391955542.03.3030205 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 03B60C0006 for ; Wed, 30 Apr 2025 21:11:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=btlloxJZ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746047469; a=rsa-sha256; cv=none; b=AjJICAkW/x34L5906cm/HLjBJZ+bVjnu9A5MWcURdiCgB2gl+b3QTtxZ+eE0BL9Ro4lmKA Fm63U8YXJaLf7YsWrtPOKVyUSAjvfRg2TbxD4YJOyzfIJExodnuUX4LyjRNAf5UXJyBTZ2 ifMvFXT27OgtNzcA0bTy1LVnzohjAfc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=btlloxJZ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746047469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MJwnu/1ECDUV4vAsfHu+1tvoPDbq6UAWsPh7WXrqxcM=; b=6C5YXRRisvK5cKpzTXXPcYjOSvyg6uXlfBbsLsAzerdZlGzN8Iirf+lHsZasLMMRi177F1 WW7QlpzW5IK2hiSOtpsUuDCxMZbbXKlhLvld4ET8QzBGO9j7yFvxuNH/K4FXbRp/rx0v96 lHrE7AO+ZqvBYQ6RDwK+r7B2LIQFz4A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746047468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MJwnu/1ECDUV4vAsfHu+1tvoPDbq6UAWsPh7WXrqxcM=; b=btlloxJZyUMyejhU/lTwKIyGbFEnd8w/OmzSlvh2LUKHke61F59846souabk9VpiGKuVJY /hnCnOzuFuhZ99bIHOnygFDxVP+DQD1gGx9su/6UK96TlvUVeVd6Yw2YFQwcfufuN2gIOs GQrmljHq8mcSlKXbb/jvGVB2ueHArrc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-7Ln-elPtOhSmJY8DNsJV0A-1; Wed, 30 Apr 2025 17:11:06 -0400 X-MC-Unique: 7Ln-elPtOhSmJY8DNsJV0A-1 X-Mimecast-MFC-AGG-ID: 7Ln-elPtOhSmJY8DNsJV0A_1746047465 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-440a4e2bad7so6376075e9.0 for ; Wed, 30 Apr 2025 14:11:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746047465; x=1746652265; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MJwnu/1ECDUV4vAsfHu+1tvoPDbq6UAWsPh7WXrqxcM=; b=FI/66iCDuqJ/nOYnGBfaVJYfW+Wr5aDtuj0msK1F2ZZjRBFz3eEZRmxqdTC3+/xm+T hC9yWXENBiTW4hErSwQlPyt1D4LAGmDWGBUfK2B5UaYDNDkIiW5RP3ROQeHao9PFw71E lOTdDW0O3J8bwLwtm5WMXWLLFl/LDs7mDq3F9O88x3Zzwm6iECfMuE8VuilRQsoZh1bH 183FWO4ugIHWZytBSLXVt3RP4arxf+RSkCfVaGu0BOuwIc6PVt5lM5Dm5/fomfHchN0T TWTQclg+QnOpUO6jWi17fXcR4h7wgFO1BBbSxv8KXaeoqyr/GH3x9aCmcGADVzg/LB8p zk8A== X-Forwarded-Encrypted: i=1; AJvYcCVU37ivjVb8I11Xy2UREY56DpMh6yq9Z8UXssvyfYFqXAMOun3WpufUUfFU7BcGAj4B8CAYWCbafg==@kvack.org X-Gm-Message-State: AOJu0YzVnyq+K6Z8NAp/U7UaVYwNfGu3a8snV/ANaDMvOEDiL9+2JsFS DLib/Vv9zvKAxWxoPIoUodRhFe00MNuvOemEzPX9aFfjL/Z+tUnylCLL19xv1m9hSoLrze4pTtP PSedQ+rM3wfiucHXfhr9rdC3rl9vrg3db+kVax8i2u2w3Zt61 X-Gm-Gg: ASbGncvWrdTBGu9RUstDuSGH7wIng0MlL+K8MqZUvsqWhxVSUNEGTBD+SKXcV/7Wa1v JRU/d1a5G9btezf+CXH9wAcL5HWkZLlKIxxPocl+MmNCbxoeklhzWw7eoEBwnvGp1dqIR03x8jJ J+VB7co84xz9L3LS+DufyrA2x4XKIyJdSC+b9fPmIyXa8DXd6+DHg0ndNJdfWDM+A1miM1ErBY5 7Dyz/ois5KgKrbmuVBmQPNxOTC48C8aNk0w/smm9A1GY6idrS2SUDfWab3zsjE1I4d0F/8F0efv GXGl++GnO2ScmEhngSBs4gOCiqVk9F0VBSNpmw9JqXE/lU756HsJem7OKEHCCcAPvjwGEQEQCEY RO2DtBGMk+ZIQZEYKmiwkH85RI9KljqzAP6O9BV0= X-Received: by 2002:a05:600c:c041:b0:43d:fa5f:7d30 with SMTP id 5b1f17b1804b1-441b5cb808emr6119315e9.16.1746047465237; Wed, 30 Apr 2025 14:11:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHICN3glWXodUAuzMyW/G6kCxTWxvHSd0KflJIRihQl632hNSkeVXqO3Rswqc6b/h177HP3A== X-Received: by 2002:a05:600c:c041:b0:43d:fa5f:7d30 with SMTP id 5b1f17b1804b1-441b5cb808emr6119075e9.16.1746047464758; Wed, 30 Apr 2025 14:11:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:a500:7f54:d66b:cf40:8ee9? (p200300cbc745a5007f54d66bcf408ee9.dip0.t-ipconnect.de. [2003:cb:c745:a500:7f54:d66b:cf40:8ee9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2bb3f34sm35735235e9.19.2025.04.30.14.11.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 14:11:04 -0700 (PDT) Message-ID: <19908a46-feaf-4bbb-b41c-ef5b7d72343a@redhat.com> Date: Wed, 30 Apr 2025 23:11:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] mm: move folio_index to mm/swap.h and remove no longer needed helper To: Kairui Song , linux-mm@kvack.org Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org References: <20250430181052.55698-1-ryncsn@gmail.com> <20250430181052.55698-6-ryncsn@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250430181052.55698-6-ryncsn@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8ux5Q-FqKkLRE_cEOfzjEcmc6Q8m_ryKVDa3RZLJ1tg_1746047465 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 03B60C0006 X-Rspamd-Server: rspam04 X-Stat-Signature: yr37bon7m5pfce3657eabn8rqq1y5pit X-HE-Tag: 1746047468-386042 X-HE-Meta: U2FsdGVkX1+CUL78kH/J+SsaXLZyNFGLoW4B1Sb2BeX4JA/E0DswNEOH6d9Ftwo+P1AiQY/2AWKn0+5HEbgePYatUnDckJxn9PvqUUM6NYb8Zo2shD1ypa8SJ0pukqHPOIu4POIoIgOLwQv24TwEb1c0d/8mLJjvJ0Ub6ikN1h79XwfduAay7uuYDkekaKBzo/dEwzMpEfQL3iaOhbYl7DH+7kHYjzuRfucVTSezLdiPiIfLXabhdsEwiby2MSR939dGNqLLF2vgj7MB45xNGVqIjxBJT/JdbpytNstjw7I8YjQKJJNMP4YcIa2bejz4eZJbOkrJSLmU4ndANueERJyA498g3DybsxVnsJoAOORETXteF9KRKSIYu8/nYdakQwxsGL4kEZ7mUiWlV1q4YwzWV8vPAlwSWjeykpgpXDSkWpzjEt/FZHVCFtZSmIgKOeq9gDV1P9SCbrFIUcpLG3OIXHbsD4WBtDqfcZZJlsp2+xmV5W033HcTyJF/g5AqiEnMYd6dpkmmIcFI+1m5dFOf88LTjMj3gXSFOG/6cx1PLlEk7TXgcSVIvnjo1EQhHRuLidDmn+vz2Cp5Po1NadVlrO9akxcIqX5ZuzF7gO2/kyiNwfCoge3agZbpx9vTfbBZiFWG/434Y8i9fje8LlAnWJpvMXuO/fC9ZnGRUrA2QEw6EyGBOgyPJ8tFoLgfAfD/6EMntoTvTekJP+vwCBZM29LCMjhG+b7CXEVuMMxkaqcqNFBTMk3DF2BqKnr2Igrtp3Tr+GjcpA0Y+c2Dk1m95MzMx0BXVISXDGlSQ0tUwz5LUCmEx1xAbaIQdzURk8bJBqpIk1Fe+ssYu6NavQjPVILp6MEFZeOtUkbrycCzM0oAFLqkANuWcM8LXBj/e+7M0laxiNInSUE9mmCpOCsfSjHFZbc6KRoXYb0rm038tlfuytV7QNXgyXU433CvnUkq6FgPHrnWswLD0tK 3SWanokm NUt6w4rtRN3BOJj6WEI4nmiHIdQ5WqER6v0OKJRgWlErOYiV0biQ9ORcUObOqkYddYVNhl1Cm45Nnyw7V7upnfF4uTkHJ4A/WnfhF/SWwjG61p2BQZ+QMSavuz/lTeN3vsiKsYVTgRS6uxXJA6Kvx9iW4Of7XYNvy9uA78FnSUzvIY1ztdeOO2VQct+hkYczd8YjZKIX4YowMRL0RymQAhaRF9yJqHUzzuvryVEM0obkaROHAd1W8r2qHfT0y5s+Czerpj8DdaaHmHn0EwwIg2kp/f92uL5M5El1M5r5bqkXKFn8iVWrRTSxHB0W8m9MLPA+REmYWQa2Icuq4+n9RjCErxza5NbXV9QEd/DfeM2CJGd7eOtIa0pGxR0k/56jp+ML9E2P+ZLRcuOJallS/AK8ELGNCWgbaauf8oeLBRYcOQxU7oTjSJEqWD1uNwG76uNvegfNTkGwVH2jLaG5LHvI8nOf6prJN65IMmcE9zbJvZGzJd1y4hE91Fw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.25 20:10, Kairui Song wrote: > From: Kairui Song > > There are no remaining users of folio_index() outside the mm subsystem. > Move it to mm/swap.h to co-locate it with swap_cache_index(), eliminating > a forward declaration, and a function call overhead. > > Also remove the helper that was used to fix circular header dependency > issue. > > Signed-off-by: Kairui Song > --- > include/linux/pagemap.h | 20 -------------------- > mm/gup.c | 1 + > mm/memfd.c | 1 + > mm/migrate.c | 1 + > mm/page-writeback.c | 1 + > mm/swap.h | 18 ++++++++++++++++++ > mm/swapfile.c | 6 ------ > 7 files changed, 22 insertions(+), 26 deletions(-) [...] > bool isolate_movable_page(struct page *page, isolate_mode_t mode) > { > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 20e1d76f1eba..9ff44b64d3d6 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -41,6 +41,7 @@ > #include > > #include "internal.h" > +#include "swap.h" I wonder if we should just have it in mm/internal.h instead? In any case Acked-by: David Hildenbrand -- Cheers, David / dhildenb