From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28AC2C48BC4 for ; Fri, 16 Feb 2024 18:49:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88F646B0093; Fri, 16 Feb 2024 13:49:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83D976B0096; Fri, 16 Feb 2024 13:49:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6901B6B009B; Fri, 16 Feb 2024 13:49:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 551A56B0093 for ; Fri, 16 Feb 2024 13:49:08 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 22CE4A0183 for ; Fri, 16 Feb 2024 18:49:08 +0000 (UTC) X-FDA: 81798554376.21.D879426 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id 8CB95C0018 for ; Fri, 16 Feb 2024 18:49:05 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IczKkH7t; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eWjfjtUQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=rwd+seiT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=25wJnxSU; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708109346; a=rsa-sha256; cv=none; b=krqd/pYNPiNHZeL+Ue8rqls6PXOp1NGj1ixykKGMXfsdLrNEstL0r5hA9IsjZOV+tsTRVK jujTn5VY99ChKYMxXdkVbF6QDS5EInutl0uWuKfHHFgnqxgrgCbZNb7JguUzvb+F6sd3Rf UqVo5CnpznG0FF8AW9/Ryo3ZWa05b/Q= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IczKkH7t; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eWjfjtUQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=rwd+seiT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=25wJnxSU; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708109346; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LIy+v1QxzmWGHbmMqIx5w7+6IieTl4Y2Xxq5xuO/0u4=; b=CfO228CtwVLJBCLlC+5aXkTqjYq989L/Hq8aFZuHb7uf1s4D9YombBO4PMDL6/PxemVNKc S1cH1chk99cVjPz4EI3sZqDeTaeHONnHJWGN2nvW0TYd5tQxzlcABqycBOAPCeCD36e9F0 lHDTbmOVrDC3YrtT5OeKojWxfAPBQiY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F1FF92212D; Fri, 16 Feb 2024 18:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708109344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LIy+v1QxzmWGHbmMqIx5w7+6IieTl4Y2Xxq5xuO/0u4=; b=IczKkH7ttqFZkIRIpgaqdovXlBv+wdZc/WVt3WfwuuayALZt1K/ktc8gkJLvb9DV02Aw6O mqoxlagg9OnV1b3uKdi4cPs834trLa4dhnFFXfGsjiAFaJlLtwlt5k0zq1/mQUJcjUKD98 Yl2/H30Tkm2T430gGAIL5rZo7SIco+4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708109344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LIy+v1QxzmWGHbmMqIx5w7+6IieTl4Y2Xxq5xuO/0u4=; b=eWjfjtUQK+vs3+zTwA2o6NuZ4YsKpb1iorpHwofZAOTDMADyKmTQZgmjt5VFnhMbl3fvFK sOX+EXx60O+jLyCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708109342; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LIy+v1QxzmWGHbmMqIx5w7+6IieTl4Y2Xxq5xuO/0u4=; b=rwd+seiTXKksZrKN9kiuopKmwzZqpByyczPrY9gXt3dZaRgF0q3/EhLfbeIQbelGF0YcEO Hx0VOE2TxUjMHY6Y87W6ePqgZ36qCkN5SNIzYzYq8F5hTqU0auNmVohU1k8iyWmkL4OSly nmN4UuF88f4S3yXP3JHlXUV3u5pq+j4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708109342; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LIy+v1QxzmWGHbmMqIx5w7+6IieTl4Y2Xxq5xuO/0u4=; b=25wJnxSUvyyypC+yRSZH8HUJmLzcF7iXGh49A6BF7laqxymAFaJYllMWQvJgzkxlkUkVz/ d07XT0JHI9vzEcDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5AF8F1398D; Fri, 16 Feb 2024 18:49:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id upbPFR2uz2WgbQAAD6G6ig (envelope-from ); Fri, 16 Feb 2024 18:49:01 +0000 Message-ID: <198f835b-35d6-4ae2-b993-675c871c621e@suse.cz> Date: Fri, 16 Feb 2024 19:49:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/35] mm/slab: introduce SLAB_NO_OBJ_EXT to avoid obj_ext creation Content-Language: en-US To: Suren Baghdasaryan Cc: Kent Overstreet , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-8-surenb@google.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8CB95C0018 X-Stat-Signature: tustzri5wsww46971ff94ddg9wsjydq1 X-Rspam-User: X-HE-Tag: 1708109345-14126 X-HE-Meta: U2FsdGVkX1/PfuUzHWIO+kYxQrSLeyk2PMkFTXemCgMPbJgp0fHEzhud/dWKqKGcQNFuK2ODwQr38JOp9mLj53LbmkwkYqFpmpSgE3MlDVm31KmXbJ+IcH1AsiGHSvw2CXFZik/eQo8+N+4hirj+FX+1vz+ZX0U/8CgWA0JpOK9Go/OmcmB9FVkvVLDgI39+sSlAzrEFYLTB4PSOQuA7qppWsSMwslQX6V6DuJYzJ1zs11DBFpQMJkZg/5L9hc1akCO4IZOkGnjSXcyN3ZXC2ODDf9eBMOY3H5nH45Ds3hF8n49VxfFpmB+n6cBC/peG1V8ikWsSf7PgICWXcnGv5wea5Jr6dMvKwoKMrk9GrK+HC0hS6adigBClHzVkX/vJB+ThpAEy0+HP3aK36mEWgkesqzcMGzl1Rfq0l+/23PiU3yeiiJp12qU2Vigcc2QzMATvx74Wxm0Vau7ossCFP+ktk/x6DeZQEQyMxmFI8NHlWL8eCOAbUNuBQXddOtJdS04hoda2e0noW5kcNVyhe7ja+yfkM7N0a2kmrjZr+exRZRfqnsa9bWs5PldBh1BmyahwFhZtkLo8DQTuL9vvIcJQV3fTiaacStom/eBiW8SRsA1x8G12J1qPKk64djUJPpqMdU/VVLuc8FhD9BQDhYeIEG57/UCN0wZ31waLwu6h5EKDDiuX2oLsn9RRRmbhcjpUMh3Albx4BhqdeBika6K4j8r0pXay2MMqBywIGAioC8b5VAXs0TOVSzM2FAOnnFHvYkXzKOqcvV7vYbdLjpUAEnblm5x0r7W/fPJjYX4WqlM9uGpgYp/yCxZz3T2EuQqFGnHN0QTNZuPx4Ci0IVDO40ydXIYLUMI0v7c/pimT+SJePaxeh93vZggaAzVWpL55+WM9q6rRnLC0qaiDcbl8RDeijMEbD8MbHAgmd+1oYIn2s+Jf2tpc2fTFEy/V0BieubjkBgC/lATpbe8 qZt+G0KC NkIRtgQ/w75reYLUlwcmhIavP3/PJw+Gmrh/HWR1T9CxjOXLILF6WBgTfHH242NY0NVKKQquHpOqALkIHtvax5xle+AM/81+ygRsZnTRiXlNM8sp5S+l6qldGkr6DAkFG+GhWKMqBza52W+P2fN566W2y0+bxA26WSBnUAwNaQ+SWOER1tzJDHoIdI8t7sFRkQSoVVxKXRA8OI5A2MqXQMk+QGZjQV7G6CIfo77SjlKG6OzzkBcKmciELr6wx+xn3IruatHQA9/GD/7Hjp4rejq8+6vf9NMdUhbh1s5Oh3zmKDfyHUMc3bvn+qtk2XhJXU5wqEFp88OwBe8/0+YsadOAHQS3Z/JFsIc1d29TWfbcW3DOxgfSXKkYInc3elqWyWfxwwb5uvjl0E0OvbiOI4UZkWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/16/24 19:41, Suren Baghdasaryan wrote: > On Thu, Feb 15, 2024 at 10:10 PM Suren Baghdasaryan wrote: >> >> On Thu, Feb 15, 2024 at 1:50 PM Vlastimil Babka wrote: >> > >> > On 2/15/24 22:37, Kent Overstreet wrote: >> > > On Thu, Feb 15, 2024 at 10:31:06PM +0100, Vlastimil Babka wrote: >> > >> On 2/12/24 22:38, Suren Baghdasaryan wrote: >> > >> > Slab extension objects can't be allocated before slab infrastructure is >> > >> > initialized. Some caches, like kmem_cache and kmem_cache_node, are created >> > >> > before slab infrastructure is initialized. Objects from these caches can't >> > >> > have extension objects. Introduce SLAB_NO_OBJ_EXT slab flag to mark these >> > >> > caches and avoid creating extensions for objects allocated from these >> > >> > slabs. >> > >> > >> > >> > Signed-off-by: Suren Baghdasaryan >> > >> > --- >> > >> > include/linux/slab.h | 7 +++++++ >> > >> > mm/slub.c | 5 +++-- >> > >> > 2 files changed, 10 insertions(+), 2 deletions(-) >> > >> > >> > >> > diff --git a/include/linux/slab.h b/include/linux/slab.h >> > >> > index b5f5ee8308d0..3ac2fc830f0f 100644 >> > >> > --- a/include/linux/slab.h >> > >> > +++ b/include/linux/slab.h >> > >> > @@ -164,6 +164,13 @@ >> > >> > #endif >> > >> > #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */ >> > >> > >> > >> > +#ifdef CONFIG_SLAB_OBJ_EXT >> > >> > +/* Slab created using create_boot_cache */ >> > >> > +#define SLAB_NO_OBJ_EXT ((slab_flags_t __force)0x20000000U) >> > >> >> > >> There's >> > >> #define SLAB_SKIP_KFENCE ((slab_flags_t __force)0x20000000U) >> > >> already, so need some other one? >> >> Indeed. I somehow missed it. Thanks for noticing, will fix this in the >> next version. > > Apparently the only unused slab flag is 0x00000200U, all others seem > to be taken. I'll use it if there are no objections. OK. Will look into the cleanup and consolidation - we already know SLAB_MEM_SPREAD became dead with SLAB removed. If it comes to worst, we can switch to 64 bits again. >> >> > > >> > > What's up with the order of flags in that file? They don't seem to >> > > follow any particular ordering. >> > >> > Seems mostly in increasing order, except commit 4fd0b46e89879 broke it for >> > SLAB_RECLAIM_ACCOUNT? >> > >> > > Seems like some cleanup is in order, but any history/context we should >> > > know first? >> > >> > Yeah noted, but no need to sidetrack you.