From: Anshuman Khandual <anshuman.khandual@arm.com>
To: David Hildenbrand <david@redhat.com>, linux-mm@kvack.org
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/pgtable: Move extern zero_pfn outside __HAVE_COLOR_ZERO_PAGE
Date: Tue, 16 Jun 2020 15:18:53 +0530 [thread overview]
Message-ID: <19858112-8f10-493c-9873-84f2000b00b0@arm.com> (raw)
In-Reply-To: <f55dff2d-d32e-8de1-0177-e6ba713e0cd9@redhat.com>
On 06/16/2020 01:09 PM, David Hildenbrand wrote:
> On 16.06.20 06:08, Anshuman Khandual wrote:
>> zero_pfn variable is required whether __HAVE_COLOR_ZERO_PAGE is enabled
>
> Why is that relevant for this patch?
That just states how it is organized right now wrt __HAVE_COLOR_ZERO_PAGE.
>
>> or not. Also it should not really be declared individually in all functions
>> where it gets used. Just move the declaration outside, which also makes it
>> available for other potential users.
>
> So, all you're essentially doing is exposing zero_pfn in pgtable.h now.
Right, but it just happens in the process of consolidating three different
instances of 'extern unsigned long zero_pfn' in the same file which are
redundant.
>
> If everybody should just use my_zero_pfn(), I don't really see the
> benefit of this patch, sorry.
It consolidates redundant declarations and reduces code. We could just have
a comment for zero_pfn stating that it should not be used directly.
next prev parent reply other threads:[~2020-06-16 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 4:08 Anshuman Khandual
2020-06-16 5:24 ` Anshuman Khandual
2020-06-16 7:39 ` David Hildenbrand
2020-06-16 9:48 ` Anshuman Khandual [this message]
2020-06-16 10:04 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19858112-8f10-493c-9873-84f2000b00b0@arm.com \
--to=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=david@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox