From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE63C433DB for ; Mon, 8 Feb 2021 17:59:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3596564EED for ; Mon, 8 Feb 2021 17:59:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3596564EED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6AB4E6B0006; Mon, 8 Feb 2021 12:59:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 632E46B006C; Mon, 8 Feb 2021 12:59:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ACE96B006E; Mon, 8 Feb 2021 12:59:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id 2F4BE6B0006 for ; Mon, 8 Feb 2021 12:59:55 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EC203824934B for ; Mon, 8 Feb 2021 17:59:54 +0000 (UTC) X-FDA: 77795863908.15.beds93_330aaa627600 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id C5D8E18298B0E for ; Mon, 8 Feb 2021 17:59:54 +0000 (UTC) X-HE-Tag: beds93_330aaa627600 X-Filterd-Recvd-Size: 1921 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Feb 2021 17:59:54 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F3332AE55; Mon, 8 Feb 2021 17:59:52 +0000 (UTC) Subject: Re: [PATCH v3 2/3] mm, slub: don't combine pr_err with INFO To: Matthew Wilcox , Yafang Shao Cc: andriy.shevchenko@linux.intel.com, david@redhat.com, cl@linux.com, linmiaohe@huawei.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, joe@perches.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210208101439.55474-1-laoar.shao@gmail.com> <20210208101439.55474-3-laoar.shao@gmail.com> <20210208172600.GU308988@casper.infradead.org> From: Vlastimil Babka Message-ID: <1975c1e4-8446-a8a2-12c2-44e8e0fd0beb@suse.cz> Date: Mon, 8 Feb 2021 18:59:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210208172600.GU308988@casper.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/8/21 6:26 PM, Matthew Wilcox wrote: > On Mon, Feb 08, 2021 at 06:14:38PM +0800, Yafang Shao wrote: >> It is strange to combine "pr_err" with "INFO", so let's remove the >> prefix completely. > > So is this the right thing to do? Should it be pr_info() instead? > Many of these messages do not appear to be error messages, but > rather informational messages. They are all part of longer error reports. See https://lore.kernel.org/linux-mm/0b2f4419-06a9-0b6c-067b-8d0848e78c33@suse.cz/