From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87FCCC433E1 for ; Sat, 11 Jul 2020 01:48:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 472B320674 for ; Sat, 11 Jul 2020 01:48:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="XZqnGzNd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 472B320674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE23C8D0005; Fri, 10 Jul 2020 21:48:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B92EC8D0001; Fri, 10 Jul 2020 21:48:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA9588D0005; Fri, 10 Jul 2020 21:48:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id 955318D0001 for ; Fri, 10 Jul 2020 21:48:55 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 13B90180AD81A for ; Sat, 11 Jul 2020 01:48:55 +0000 (UTC) X-FDA: 77024111430.01.girls32_5f0774126ed3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id D4E1E20003363265 for ; Sat, 11 Jul 2020 01:48:54 +0000 (UTC) X-HE-Tag: girls32_5f0774126ed3 X-Filterd-Recvd-Size: 4352 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jul 2020 01:48:54 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 10 Jul 2020 18:47:57 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 10 Jul 2020 18:48:53 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 10 Jul 2020 18:48:53 -0700 Received: from [10.2.51.208] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 11 Jul 2020 01:48:51 +0000 Subject: Re: [PATCH v2 6/6] mm: Print hashed address of struct page To: "Matthew Wilcox (Oracle)" , CC: Andrew Morton , Vlastimil Babka , "Kirill A. Shutemov" , William Kucharski , Mike Rapoport References: <20200709202117.7216-1-willy@infradead.org> <20200709202117.7216-7-willy@infradead.org> From: John Hubbard Message-ID: <19709c2e-453c-0899-f8cc-bec32d141ba0@nvidia.com> Date: Fri, 10 Jul 2020 18:48:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200709202117.7216-7-willy@infradead.org> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594432077; bh=AF4YD6W0nTGhLOvvDQPB4ExlWnSWzbUtw45dHinEOl4=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=XZqnGzNdsZle77+2L3WNe5KeoHA4prFOO5qQf+00bmB4PqZcEG+gvWxPrm80R3jx4 aaP4dnkJosYIHPcJppTAdcD14fyrC84o+U64NlTwSERcaeJPRwu/8pvSrNNYx2+2/A qGxHnWIf4plyogujDi6n2ZutlNkxOzgdJDGyKCpERCpwhVWf5NnPy6XzH1UwC8j2Yy I8UTEu+iD2E2AAD375bb+rYQXbncWz7hv1kAY4Nkimp6tHJ4zkxmYMH8YYQ0eSd+QC abmP7c4LQLb4iuii++r76goabgPK1p3fbIdKAmev5mqki1QIsMVEU6nOfK1nKyRWKc QHJ1n+u+2ycZA== X-Rspamd-Queue-Id: D4E1E20003363265 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-07-09 13:21, Matthew Wilcox (Oracle) wrote: > The actual address of the struct page isn't particularly helpful, > while the hashed address helps match with other messages elsewhere. > Add the PFN that the page refers to in order to help diagnose problems > where the page is improperly aligned for the purpose. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/debug.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/debug.c b/mm/debug.c > index 60347d0d7609..033f04ffc398 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -89,17 +89,17 @@ void __dump_page(struct page *page, const char *reason) > */ > mapcount = PageSlab(head) ? 0 : page_mapcount(page); > > - pr_warn("page:%px refcount:%d mapcount:%d mapping:%p index:%#lx\n", > + pr_warn("page:%p refcount:%d mapcount:%d mapping:%p index:%#lx pfn:%#lx\n", > page, page_ref_count(head), mapcount, mapping, > - page_to_pgoff(page)); > + page_to_pgoff(page), page_to_pfn(page)); > if (compound) { > if (hpage_pincount_available(page)) { > - pr_warn("head:%px order:%u compound_mapcount:%d compound_pincount:%d\n", > + pr_warn("head:%p order:%u compound_mapcount:%d compound_pincount:%d\n", > head, compound_order(head), > compound_mapcount(head), > compound_pincount(head)); > } else { > - pr_warn("head:%px order:%u compound_mapcount:%d\n", > + pr_warn("head:%p order:%u compound_mapcount:%d\n", > head, compound_order(head), > compound_mapcount(head)); > } > Seems reasonable. The first output line is getting long again, but it's still OK-ish. Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA