From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE6BC021B1 for ; Thu, 20 Feb 2025 08:38:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEF382802AB; Thu, 20 Feb 2025 03:38:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D76902802AA; Thu, 20 Feb 2025 03:38:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B53612802AB; Thu, 20 Feb 2025 03:38:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 973192802AA for ; Thu, 20 Feb 2025 03:38:29 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 23D7E1A06BB for ; Thu, 20 Feb 2025 08:38:29 +0000 (UTC) X-FDA: 83139671538.30.A9D4F11 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 46BC1C0004 for ; Thu, 20 Feb 2025 08:38:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W16Lzwhj; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740040706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jY7tYtFefzvHG4aShI6b5afWDaM1BnuW3bk8CDdolzk=; b=rAr8M85s7A7dTasrYbdlo3tXhYbb1dAW6fVB205YC0AWyga8y9Ol0ph/KCYUqse+6hYGtP DumP8n9FGqCZfRXfrcxFkJQ4Ym1FjfXWuDma/08wSxY/JDCr23PWYZmKu18TsrSuqQPdgk W8pUqszs/WsF+NCVu9s+LRx7YcwKpms= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740040706; a=rsa-sha256; cv=none; b=IkeF4PRlCv6pGSWx49L+zuTrXbRgnmgeutlBezmGd8MnOBgBOvt8xdoHXvKo1p0PeHTUZl EvugHmU3g6T45CxZZcqrXCkz8iClSky3K7JQoeNIsoJJzlZiP727I6VhWILUBuY94hNQ3b G+pUFTSoGz5QhNVfMOBZfCjQgWiazaM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W16Lzwhj; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740040704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jY7tYtFefzvHG4aShI6b5afWDaM1BnuW3bk8CDdolzk=; b=W16Lzwhjl+qh0odmhxlSm/9qLcItfRFPopERH52eq5/m8dNKEXCV9UabzGrSL478PTt3PJ BKQ2rFrh8j0U0NpEFmwx+Ve/kYsBoAbo5FrJkKO//cyn8tKlutJ8EgGVg3t8izJV87IeFI jrAw2Xl1nKKgXWo44BWMZULzDO1uBwY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-NlrtYsx1OWay4O8DzOV7dg-1; Thu, 20 Feb 2025 03:38:22 -0500 X-MC-Unique: NlrtYsx1OWay4O8DzOV7dg-1 X-Mimecast-MFC-AGG-ID: NlrtYsx1OWay4O8DzOV7dg_1740040702 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4399c32efb4so6938435e9.1 for ; Thu, 20 Feb 2025 00:38:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740040701; x=1740645501; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jY7tYtFefzvHG4aShI6b5afWDaM1BnuW3bk8CDdolzk=; b=X8RFVn/8OnCHQl653Pv13xF8dZ2bv2Xn2qIXowX6aRDDK22HRo+r63Y/F3ANhrtBc1 5zbBRDgKhs3kxxZYQHAEgK1yXrEVQ5xSbOmXaCk2kmdAgdihlpravEnXZ2kTJB6hf0W9 nlZucd+p1ukGO2Bbqu7Pz1p5gfNupPm0aqXgfvyNddVYGj13Ps18Nqm0ahw0HRsT8nXZ gRIZhMzoce7C685+w9JHPejqlnQweadMKDNLj8HF5MI/qR2y8/3XUsN+YrH9/enXnx82 9coThOCZIGLOVDJHePoZXIIfELplgyL6fugpuegI6xFXvHe+8ienfFuP6Rv5TG2+FZXS ELZw== X-Forwarded-Encrypted: i=1; AJvYcCU3IbESH9cYKGV+hfVqnGF6DWscJoHBL5wmLgvoaVxXeTRppwk4ncGAQs+kV9BcPFlUNJnESceJwA==@kvack.org X-Gm-Message-State: AOJu0Yy2oYgc3fV0uaVGH9JydLn2hUPT4VQ8PfL1fNuvaYjZGBBrI8sC anPWZ77UR/fnmr+lwGc1BGotNZl24/9nRDX/B3UUndjN5st4zqFZ51LR90h1DgozK9Swc8LQvcy RuFqG1G5XmLIfU8V6PudllVQV3KZd4fdPPVws6fzx95Bwl54C X-Gm-Gg: ASbGncuJ31wDbcWOLIkF+ij6evfoNre6vdixmG3f691ZcbNNYyGCv9Y5ZkrWGdq15/B N0eE2mvJvi9drsvxU/vf+bOGYKhhthxCdYBh0uZNSR9lGZ2BaZkwZVibGkkv7tRe4mnt1a4N37C AezYo74q4pLNrpvqlh9Mnzm04Y6czfTl/Cuu6Ju/Nw7vTz0uD+/hzGZ8NLTbDxtRHi/aUwHaJrK RamyEfb8If31n5GOOtf8RITlh6/i0c048tZALy3/Sj7Ruhp77qLMYARaNb/Lm5M7DK3lARIXlyb kiD4OKrLWHCJkI1ydis9ZAJ3BId8v2V+Lg== X-Received: by 2002:a5d:6d09:0:b0:38f:4f37:7504 with SMTP id ffacd0b85a97d-38f615be1c7mr1806810f8f.16.1740040701641; Thu, 20 Feb 2025 00:38:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IGp7d6SevuNhLuZV8/jkVX3ymo9iXEjPh8PEOuN3PjCQ/0IUnneKs02MbsGlPfYJTfyuY/WSA== X-Received: by 2002:a5d:6d09:0:b0:38f:4f37:7504 with SMTP id ffacd0b85a97d-38f615be1c7mr1806776f8f.16.1740040701197; Thu, 20 Feb 2025 00:38:21 -0800 (PST) Received: from [192.168.3.141] (p5b0c6195.dip0.t-ipconnect.de. [91.12.97.149]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43990f53847sm83879685e9.1.2025.02.20.00.38.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 00:38:19 -0800 (PST) Message-ID: <196fc7d8-30a8-439a-89bd-57353fd98df8@redhat.com> Date: Thu, 20 Feb 2025 09:38:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page() To: Tong Tiangen , Oleg Nesterov Cc: Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Andrew Morton , Peter Xu , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, wangkefeng.wang@huawei.com, linux-mm References: <20250217123826.88503-1-tongtiangen@huawei.com> <3b893634-5453-42d0-b8dc-e9d07988e9e9@redhat.com> <24a61833-f389-b074-0d9c-d5ad9efc2046@huawei.com> <20250219152237.GB5948@redhat.com> <34e18c47-e536-48e4-80ca-7c7bbc75ecce@redhat.com> <2fe4c4d1-c480-c250-1ba2-1a82caf5d7fa@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2fe4c4d1-c480-c250-1ba2-1a82caf5d7fa@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lbxShE6pr3_a9gJsDWKYFL_F5_K1wWTP1ewKxPw8t0w_1740040702 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 46BC1C0004 X-Rspamd-Server: rspam07 X-Stat-Signature: xfpnootrtnkkxrboadxnyd1ak3dkw7hm X-HE-Tag: 1740040705-782891 X-HE-Meta: U2FsdGVkX1+LShTIc+0HXcmfT5q0kaiiHv67Chx31Qqk7xBdMgSEc10YvdrdFwOzBVcYilBugAQ5cmECbsOcqTT+Q8YP2YII6Hqc8mu5Iik3UlUCckSVDrTA/nxHbD2WHFVSm8A8ydhnjKbfTt71vyUT+5NGUlGkwL8UsmhMhKgRpux9rAwT27i24SNAT7o3jYIKtkQG6KDKoBexX6Q7IyKxpUqNdzqE2lz09arfZIoAJnYTPeKE2Ah89bN3Qk/SQFaaqMLb/k9ImUzODBSsR8M2qXHC5wGRrbineEtMxliRURrhzUgBGop6253NPkBUf1dEWJ2Hx9ER9BwevxFOwWMzVmUaKylZLMSpLwXjpXJBQlrB1LW3tZxCqJJXocJ+HD6G7LWHHPrOMreLTYMPiOX6aK+EcMFZ7w3jgoqRU9Z8weKSk6klVauV0Eq/Fis5Bg3MYM4DPAhnx3Kgd4xboR+4W0xWIZXS13AE/AY+ewf+opgEmNzB4uzFHYQlO1bz6jCpwmWRN0YkiaK3WHO6S7vIGdT5HEEtWOhN2pz9Ylk9bbq6NXv3hZrwixNjR9aN0nHDvjoll1GPQf9BYf7dWwLU+Ins92eOt1Xw41fnTKoIBeG7EgUzPFLnX9/7YHg/tW44tM+6gy/7hCQ3vHhQPOd1Y8Ab74Ri9771LtgG3EdVKpS8OYQEo8vFRHRCyZDNuaHjWYHTKGkZpzUEqk14etCRaXN7kskXIem34P3W4uP26kkGv5MzwslvD3jMb6w9xjqgdLWZEVExhOmmKEhk24X4+/5Q7691y8HXAW7nlDJhbYdMy3mcIghmLe3yq7WdEMVwrB1uYsva5hsbJnLiBmM8sF6NlPH/zCrvail0BFX+qHDkiDUYw89LMp9HP799MVgTb/FfK2H4QKvZebTqHLoRsc9frfTpYsTykWwvitQHg4Sx0aelw5k1U5dhylzAwgASDCPfe43Ppbycnq8 50LebOdV KEWVqwaW7EYLOLuzSzqUQ6UcHdfE9k8riCBGSUjOhai+GWyN+QHaNt2Fck55fKgUzHQg+UwQ2IZT5Yfn3P9gaVEhdJHB5Oyi3ccnqAt0mdMR6aUBlyVRnak1kZ5DngYVeOByKYnzacq6nkkimAmD98k+1Gz/Chro/unJFZ1iI3532JVAM8VzlPovvBCGHa6RVPL5LC2VroJKrbhIlWul96sgVT86mShcjAIN01o941dUctYqcarylHxQ4E9N0FoYwBDv7z/9PrNOUZYU2ZmLBUr3QSIMczSWW2vbzpeNray09yhvRfyJAS6rWFARqYRed412eTtd9rFRNz+e4qOepGFmp9DpwK1x1/loV8cSzqTbEWt8oK6I5NKlF2UH+AQ2KDxHZlIYAhF2/O42sJNHSy3PSIRT+Kxw5LLWQLcSoyLIqphskurVSa0+Ns8EbS5ye1sa4OjVonm6/fTaZ4JQrBx6AN4fzcZi2FS2OYxhE6GXv8kc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.02.25 03:31, Tong Tiangen wrote: > > > 在 2025/2/20 0:12, David Hildenbrand 写道: >> On 19.02.25 16:22, Oleg Nesterov wrote: >>> On 02/18, Tong Tiangen wrote: >>>> >>>> OK, Before your rewrite last merged, How about i change the solution to >>>> just reject them immediately after get_user_page_vma_remote()？ >>> >>> I agree, uprobe_write_opcode() should simply fail if >>> is_zero_page(old_page). >> >> Yes. That's currently only syzkaller that triggers it, not some sane use >> case. > > OK, change as follows: > > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -506,6 +506,12 @@ int uprobe_write_opcode(struct arch_uprobe > *auprobe, struct mm_struct *mm, > if (ret <= 0) > goto put_old; > > + if (WARN(is_zero_page(old_page), This can likely be triggered by user space, so do not use WARN. -- Cheers, David / dhildenb