From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA15C25B75 for ; Mon, 3 Jun 2024 16:37:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C1866B007B; Mon, 3 Jun 2024 12:37:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5718E6B0082; Mon, 3 Jun 2024 12:37:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4129E6B0083; Mon, 3 Jun 2024 12:37:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2049E6B007B for ; Mon, 3 Jun 2024 12:37:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B99BB140ACC for ; Mon, 3 Jun 2024 16:37:52 +0000 (UTC) X-FDA: 82190133984.30.C491809 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by imf13.hostedemail.com (Postfix) with ESMTP id DCD9420009 for ; Mon, 3 Jun 2024 16:37:49 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Vyd4OHAz; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.12 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717432670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8evk6BQflJEpzGYc9ly4En0otPd6lyV9fGYkC70B9Bo=; b=cb3+l3kK0sqf9QTwKBddNnT3D+zwjL8KDDQc/VsBwjusmaOoupaQNxKbS4IRvcKDVrVZPw qOG/YgnLQU6pcf+s4CQlpy1LwdH91A6hMnmZJyFDvsk02N12joit9hcdVcZ2cRPcVZ8SqA 3f8//oN9+7SQrCW8f4CUXZZqt2jNkuM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Vyd4OHAz; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf13.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.12 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717432670; a=rsa-sha256; cv=none; b=wQM7IJ7KEEhFmt03woCeCtXy6Pvb8VkmEqQivplYBF9I0193Pb8DLmrWzdZtLX+d0zUQH+ BEZ4ILOWWxpf+qxqhTBCIExw1CqNInbNKpvhUUK+q51HW3/hoMacbGpV3PqRmuPZHWhFQL ExVT+J5rjkQ4nDz+Po+VbDuX3cFweUw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717432670; x=1748968670; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=jfmJNoqS/aMtSuUlQYpT7Wgh9qVxuLiRembjxum2Y7c=; b=Vyd4OHAzwidLzhBzFXknOXwdeRxFWiEYdG/XWzcTaWWu7zK8swoWbIq7 1DaOPsq/ppW+FHi4WSUcmIk8hYj7TL2TM9r12z8hDGZNV2Ctft+zp7dp2 8LUOil3vpAqZ8hYp0ogJGsFW1uL6NcHLO0LPFtUMZzy8g08dYINUY8OqR u457Lge4BmRWDmXDdqyK7blzW+HHa6+L6hOCP+HaqIXz2+8bYzLTUxQ1s 4btnFmG73ldQdL+HNWO8QP9WXf7Dg31xxVVf8iSp50DEvroPko5X+RjXF q7oOx9cKYCN4GxqIWfzDCsWi5NkpGBoa1Oz8wuxPV5uAKBkeXrZ0B14Ch g==; X-CSE-ConnectionGUID: wdF9uz2JQaesRcbntj+iLg== X-CSE-MsgGUID: 7BgFAkvVQAK/q5igC3eUCA== X-IronPort-AV: E=McAfee;i="6600,9927,11092"; a="25335719" X-IronPort-AV: E=Sophos;i="6.08,212,1712646000"; d="scan'208";a="25335719" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2024 09:37:48 -0700 X-CSE-ConnectionGUID: 6a/WILzaTtS/A6w4ImaBaw== X-CSE-MsgGUID: lsSP7SbuRiak3ysU/Y908g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,212,1712646000"; d="scan'208";a="36827281" Received: from ibganev-desk.amr.corp.intel.com (HELO [10.125.108.143]) ([10.125.108.143]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2024 09:37:47 -0700 Message-ID: <196481bb-b86d-4959-b69b-21fda4daae77@intel.com> Date: Mon, 3 Jun 2024 09:37:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 09/12] mm: implement LUF(Lazy Unmap Flush) defering tlb flush when folios get unmapped To: David Hildenbrand , Byungchul Park Cc: Byungchul Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com References: <20240531092001.30428-1-byungchul@sk.com> <20240531092001.30428-10-byungchul@sk.com> <26dc4594-430b-483c-a26c-7e68bade74b0@redhat.com> <20240603093505.GA12549@system.software.com> <35866f91-7d96-462a-aa0a-ac8a6b8cbcf8@redhat.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <35866f91-7d96-462a-aa0a-ac8a6b8cbcf8@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DCD9420009 X-Stat-Signature: pypqpma83myptthndshao8qy4h7m5r1u X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717432669-355676 X-HE-Meta: U2FsdGVkX1/tHNVe32AgOps1wVWDhyDW6U6YDUHBZiAbDDbWjslPUgVSTQ89fe3y5YHzxQSaHs1IdhbdcpKL540WEKoal1/9EoYYT0XiHlNiktodnHBxKDgBM5UWva59ySC3gCqwnaJ/TflCSSmLHHcj6xcUYWIHqDVmTsBWgTZTdixy5bC0zfYGbRGjzzpsFcAXoaiZrK/tReOWmsW8YKnJHiNuHiFVqjmJSrdPrc3NeJNQMk5mXFMt6f+OiIbJKwa9eVmQMBC0GrY3ScjuMYdCBmpnXxJzsADIGeSlntJiVXtcev9xwT2m2iGcD6IcRAJzSUIY68gE+g6N8ke5gMonFVKNDSqeR8USB5X48OMoTz/1+FlfowMACQpDe29mMu0noQsviFn9z+0J2pHJ2qKwgL+LqTCdElT3HpTDbth8MmpwXTZjTECRTf45xorU4N8G7QV7O/j+POL7i80cXOHD0NvpXu8qdzLAY2yA5J6R5emEhCmK986I2Qu3F79VRzQhEHgva0I7t+cJXfGoowzG3lGsfcxniPZWOyAeVA47PcLCARGJjFjylDrZ61JR19Q/hFpIGVSUKKl3sNTbdDcYTsVeX8csfrs6xgidIc4sNJn4t/hUlQVPb1ancWMljGY1sEgolvXR2/LsroKXrepUVBOm6oHVm7iRJqo33LUNmQyUMcaJEWGQ3mvAxqM6731RzpuoiUHNPIYQ1ywpi8Rb+MG4KtBUSm8Sl8OaVn7zaU6d8dhI+bR4uh5EbSEbMAb0NL2bOi6/DOLKy6K8EACIE8lh6IH3UphbSkwxMVOgwIvPPAFLIt7aemqROojkL4PxL0iO/gb8JMZrXTjix74tl+5o4w83QkbIiwu2eeoggvcgE7dweU//n20JF+yQaAvRmZnBi6zkSckY04spWI+sst31CBhBmpVKTFYA4xZfvktNhLCr6xUXV/8/CUBlyxwG3vnU6pKFb1ZlBcZ 1rs0xJmA NrXYG5s2yRFU80P4sUl+T8c7X2jmWgyf8Gap3+VIwhQuqCNE46wNVbhMJuuRRkR7ERyoPSXgXT+tojVRGbYwEgkOETLCa89DUoq+johAY0GVBU0Mbtobfo3O9u9W/nw6C6IBF8Sr0ksOZyVQ4i0Uo9r9EzwPB8eBlxbdqyUGjSGXAlpw5eRgJY1Z4jkgSlWmn994+f7dPPbO54WQbHfg/RsZDShhz3eXnOi+nCnBylCYtAjILR1OFlV4L/MfQ/520qrqcDuySjobpjnjwioARhUzBgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/3/24 09:05, David Hildenbrand wrote: ... >>    2. A LUF'd page's position in the page cache can't be replaced until >>       after a luf_flush() > > That's the most tricky bit. I think these are the VFS concerns like > > 1) Page migration/reclaim ends up freeing the old page. TLB not flushed. > 2) write() to the new page / write from other process to the new page > 3) CPU reads stale content from old page > > PTE markers can't handle that. Yeah, we'd need some equivalent of a PTE marker, but for the page cache. Presumably some xa_value() that means a reader has to go do a luf_flush() before going any farther. That would actually have a chance at fixing two issues: One where a new page cache insertion is attempted. The other where someone goes to look in the page cache and takes some action _because_ it is empty (I think NFS is doing some of this for file locks). LUF is also pretty fundamentally built on the idea that files can't change without LUF being aware. That model seems to work decently for normal old filesystems on normal old local block devices. I'm worried about NFS, and I don't know how seriously folks take FUSE, but it obviously can't work well for FUSE.