From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A91FC77B73 for ; Sun, 16 Apr 2023 20:40:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EE868E0002; Sun, 16 Apr 2023 16:40:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99E7E8E0001; Sun, 16 Apr 2023 16:40:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 866118E0002; Sun, 16 Apr 2023 16:40:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 730088E0001 for ; Sun, 16 Apr 2023 16:40:06 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 49B94ABCA4 for ; Sun, 16 Apr 2023 20:40:06 +0000 (UTC) X-FDA: 80688421212.29.5AFE749 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf02.hostedemail.com (Postfix) with ESMTP id 5008D80008 for ; Sun, 16 Apr 2023 20:40:03 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MoZJUZMV; spf=pass (imf02.hostedemail.com: domain of ivan.orlov0322@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=ivan.orlov0322@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681677604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5Gmi/do156Oqurn6On7R7qt3l2vNSWVaalWH+Gn/vpM=; b=52w3H+1gxg4bQ8OFfJ9YGPke54RCTa6SUvozwg9x6sztRUYr5l1iRw85MAn649TRFqIiA5 m9czNNryIWH0eQgSoI58EnrjuSiycx80elom0yiZEVZ14NMPQOE9vvfDJ9xd1x4+LBDuDY yUA9TUJXQ7bPUYMu5QmUMedSlbVUNB0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MoZJUZMV; spf=pass (imf02.hostedemail.com: domain of ivan.orlov0322@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=ivan.orlov0322@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681677604; a=rsa-sha256; cv=none; b=AFvNea65Ge6NOicz2WpaZwsMQMzV3D4R/g1w05mVkOrkyTwWpWeQkVZ/aVQQnHXQhaVuQs UlIIZFLU47MG5vOMU5dc9T86XCfFSRP4aNLfHl/kEuPYdZFQ1DS8NCidRD1ditaz+Mx/Qf YRAgBw/9Jvx0NwLIfry1Sb58xUDSxNc= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-50671ef0c48so302710a12.1 for ; Sun, 16 Apr 2023 13:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681677602; x=1684269602; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5Gmi/do156Oqurn6On7R7qt3l2vNSWVaalWH+Gn/vpM=; b=MoZJUZMV6rloOpwXdLAzDuGOg+XGzhwrmBxevKigjbxIyy6Vsf3l8DgMthmIMu93a3 koN9dUheLelFz/KezCQN4OvkEgpwc5o/ds6mwGAlCLnnz8TfgWjO27231txGjGbR1jaO Ri9VwLug1wkXyrloJIYAtLn22yQhe2C8gWYSyrCL56tB6WqPb4Rq91T4QmjgcMfEqCJ5 Xmc6Q/iD5VnQXzDrOEy2Kv1z/w2wxMcrZrITGGIUa226V8CoJ+gvRmVNzFvVaLyMk7rX +YtPh1OkEVw3zaBdaWvO06CdtYRulj/ulvxpYX3ReF4WA1eqi7RURxDI7jGoCdZdxZ/4 iEIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681677602; x=1684269602; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5Gmi/do156Oqurn6On7R7qt3l2vNSWVaalWH+Gn/vpM=; b=VXkS9qEAxXtmaXW7JXuvaPFguJYfNcX4CjgNUuDhvsttSqbTIbpHCPz5CGYgdRq3hJ FQy9sQg/h4J9uU0igsPsxj4r8SnImc0K/QRS6U2CayfvImQi2ULg0Cg08jUYag7kM+K5 h7eGVp1v728iEEtoxus8z3LRvDxOWBzDCvbR0NTxxqLJx4xOqgmB0qSY/gOrCk6ICW2A l4Lq319jnwcX+qaRFjgdu/2bV216XW/9xhyHM5wSpcAI0LivzJSUnHyyx0LnimFd4HKt eY7t/09QgttRxSA/i89r7e17qmN9NqYHY5FwBcp20eGsEd+REvZDwTKi44PlL/exBAJJ vMmg== X-Gm-Message-State: AAQBX9cYSkwtUkD2CLqszBfjXXNBK1I7fc+Qvsembwd5aUbOvQpNGEFl mz/3GyBSyBR32pTnvOc2//A= X-Google-Smtp-Source: AKy350Zl9UbVjnQxDl3btqlMf8RV3X44RulxYOQ2N9ntqnKgRdCPVIMtABj54YobhwzwJahy36T6Cw== X-Received: by 2002:a17:906:19c:b0:94f:66af:b1f7 with SMTP id 28-20020a170906019c00b0094f66afb1f7mr1551753ejb.1.1681677602426; Sun, 16 Apr 2023 13:40:02 -0700 (PDT) Received: from [192.168.10.10] ([37.252.92.4]) by smtp.gmail.com with ESMTPSA id qb3-20020a1709077e8300b008c327bef167sm5562437ejc.7.2023.04.16.13.40.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Apr 2023 13:40:02 -0700 (PDT) Message-ID: <195d006f-b595-c0d4-24a5-49d8d350745b@gmail.com> Date: Mon, 17 Apr 2023 00:39:59 +0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2] mm: khugepaged: Fix kernel BUG in hpage_collapse_scan_file Content-Language: en-US To: Andrew Morton , Zach O'Keefe Cc: Yang Shi , himadrispandya@gmail.com, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-mm@kvack.org, skhan@linuxfoundation.org, syzbot+9578faa5475acb35fa50@syzkaller.appspotmail.com, Mike Kravetz , "Kirill A. Shutemov" , Matthew Wilcox References: <20230330155305.423051-1-ivan.orlov0322@gmail.com> <20230331013301.ecgkjymaf3ws6rfb@google.com> <20230416113335.caeafda1328fdd4bfe2406e8@linux-foundation.org> From: Ivan Orlov In-Reply-To: <20230416113335.caeafda1328fdd4bfe2406e8@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5008D80008 X-Stat-Signature: 7e7upcz8uo8jhhktjqqo7pyuc1uzk6ib X-Rspam-User: X-HE-Tag: 1681677603-408405 X-HE-Meta: U2FsdGVkX19ZNiNflNjvdwwilREx5pYgjyo8voGLQXOkuN/OpNz8W+EuAK5r7efI2AXt4kv1Ump6yx9Rm9mwuCJMpYqKSSBmTd7gXzsrvPJlJ98mzfNaFk+XWAywXOv45Cgp+Qw11hAK5ZMPnO4Pk+/gTjIpd6u2ftJH+SeqfcTHik2J7i8zZ62Do9d7YtoFUoXflnYp/5OaomB4AhsgablTX/V7sL1VGaYtSiMbOB5vijAIU8Ut4kwwj5EYRr99t19HDZTKn5CKz9MiybPuVFmG/j3K1NU9pBPbg2aw+itse7SOSY90smaig5BXqBRi4aWuiG+yTd30hGp6dqCywHDKqUkWROvj+BVz1tNc4pDQIrHfk5T4xQCd1wSjGFcaEqsYAuaKx+6RoyckNrthvtXKXnTDZDnFp97ookBa51eWUtzFCTJ/EzcIjgG8xIT5kYYqNWJE5iaLRh+jwrmPPeRyqMbo40z2LJw1ikCOySyTEy4rUdLnaNjxomDehpRNSy+u0fRWHcJTOf6EH2LUrE23etYl9G44rOFSh9ElhBr1MWIarqN4xK1yn6vtTFOJeCCaQlslq4D5owJwzrKUpaTwe9OmnRRsy9rwFJxgcLtb7Jht5+Zfac6m869/EscKPvCrSkLgVMbUZE5vkpyu4/CtvV4QJuFw1FD2LVKIMlW5UrzumdT9ANoJdORjcuDNLS0BOZHRAZAAXyoqhe3hplqp2SCOe2PuXBE0TRXMTWyp9wHIGM0vZL+VCpwmjlwVItoWEhcDLe7VxlCGUkhABsYu0UIyzjZlyLZMa1eEh1SrpXG7VKGXAINgRqmTmREj3ybobM4/fCYgb8R/tX1z73Q8F2lfz1R3xx1dSU0z2vUYVnM3n+ltEDz47bgfjC0LmNCDSaRu6035xWKtNYFunyedFIkYVGf/EW9+fX4DDWJtKE05biBDPb5y6UuGxBPUQzz5QUtkkNvhOnucIhA 3/kmrDss 7kKnWFfjNPy+bO3+n/fRFS8kCT7QMRhYTCAL+oHnJuh2IKAZX26lQWOpmiAqsjQMYWLEHnOnkvjUalKIVttAjuhuZ6Rs15qb6gfKyV67Dz+y/7h6I0bAyxK9o2ICvEnRzIX2mlPEQ/JTXRWJkvqNk/rKK04wuUNPpILrL89M4K+LRRSoUPb/UGT4L/22ZXJAHgSnOFlygYutH8B+XxS3aeepWHhj93JxzlxPQW1CMXboPCGan4moY0Y8FfGp9g1BbJdcmTj5ZfRb16D+FgZxNJtKS1VnrB8LYsbxEk+LA9TYfeAG8IVtEvEBZZE7Rcot1srkeQW6VCFqNtzDJCRwlhms2GvQrzQ0BHNN6mqikDpz4GA8EqiI8BhWGkgc1PRTf8XCV6kg9difHHFnwuVbY0UyIsP6sznIbbKP3esm+PkkHMvxJy23nh23cVZSzL9eW+uAW7ry6e5quTo3mr6hKU0pA4SK2NTi3ZbVzHH6mLx/IK51r2P3/T4cLRcHGIfOiDugv1+nJJ76mMe7UJDNckZDhJPgmOwvQH7DyRK/c7qypV/VgxS0dRAzJqSPvl0bdCfG9JN87MEi96aD2MxWP7Wt2aPQv4memIGnnTjb34ydu4V1Mnrsp9bFHiuV7taAcWO8k+Eu0RtSDqifHJ3KW5mz0nCiFHbr3l1H0IPVisGATqAtjdya2el6OsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/16/23 22:33, Andrew Morton wrote: > > Circling back to this fix... > > The BUG() is obviously real. We're unsure that Ivan's fix is the best > one. We haven't identified a Fixes:, and as this report is against the 6.2 > kernel, a cc:stable will be needed. > > According to the sysbot bisection > (https://syzkaller.appspot.com/bug?id=7d6bb3760e026ece7524500fe44fb024a0e959fc), > this is present in linux-5.19, so it might predate Zach's > 58ac9a8993a13ebc changes. But that bisection claim might be > misleading. > > And Zach is offline for a few months. So can people please take a look > and see if we can get this wrapped up? > > Matthew, the assertion failure is in the > > VM_BUG_ON(index != xas.xa_index); > > which was added in 77da9389b9d5f, so perhaps you could take a look? > > Thanks. Hello, Andrew! I have been unable to reproduce the problem with any of the existing reproducers on the 3d7cb6b04c3f3115719235cc6866b10326de34cd commit, which was detected by the syzkaller bisection. I also tried to test if the problem is reproducible on this commit via syzbot, but it did not detect the problem. It's possible that the bisection claim is misleading, as the issue may not be consistently reproducible. Why did you mention the 58ac9a8993a13ebc commit? I thought 99cb0dbd47a15 was considered as a "Fixes". 99cb0dbd47a15 is older than 3d7cb6b04c3f3, and the problematic code appeared there, so probably the problem could appear in 99cb0dbd47a15 as well. Please, correct me if I'm missing something. Kind regards, Ivan Orlov.