From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B3A5C432BE for ; Tue, 24 Aug 2021 14:39:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2559E6127B for ; Tue, 24 Aug 2021 14:39:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2559E6127B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9638F6B006C; Tue, 24 Aug 2021 10:39:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9130C6B0071; Tue, 24 Aug 2021 10:39:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 802148D0001; Tue, 24 Aug 2021 10:39:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0234.hostedemail.com [216.40.44.234]) by kanga.kvack.org (Postfix) with ESMTP id 655946B006C for ; Tue, 24 Aug 2021 10:39:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 12BD51A4D1 for ; Tue, 24 Aug 2021 14:39:06 +0000 (UTC) X-FDA: 78510231492.13.FC5B7BF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id A563120019D7 for ; Tue, 24 Aug 2021 14:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629815945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bIzJFNtN7r1shXWsohSNVJgyFOeYy/KSnJVcAMNs8DQ=; b=a0H0xyjLjODqmbCymz6WQa/ZsGyVPuJvmBYhEz7WhcxCriT72ntACF8wTyJ8xcz6ySSUod bH088+OSxM/W58kmq/xLiI1ZpXeC3yY0D5uGlPc1oriiIcJ6WiORcmS92OThKAZUvliShb JMoFNFtHDT+/P83vw4EYl3Tb7F8otUY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-488-ukmS65bfOAWoX3lGu4KGeA-1; Tue, 24 Aug 2021 10:39:03 -0400 X-MC-Unique: ukmS65bfOAWoX3lGu4KGeA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DADBC1082921; Tue, 24 Aug 2021 14:39:01 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.86]) by smtp.corp.redhat.com (Postfix) with ESMTP id 697AD1036D27; Tue, 24 Aug 2021 14:38:56 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <162981147473.1901565.1455657509200944265.stgit@warthog.procyon.org.uk> <162981148752.1901565.3663780601682206026.stgit@warthog.procyon.org.uk> To: Matthew Wilcox Cc: dhowells@redhat.com, Jeffrey Altman , linux-afs@lists.infradead.org, Jeff Layton , Ilya Dryomov , linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] afs: Fix afs_launder_page() to set correct start file position MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1953536.1629815935.1@warthog.procyon.org.uk> Date: Tue, 24 Aug 2021 15:38:55 +0100 Message-ID: <1953537.1629815935@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a0H0xyjL; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=dhowells@redhat.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A563120019D7 X-Stat-Signature: bgmih47qumdyoizghixw3he4dftqf1sb X-HE-Tag: 1629815945-429550 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox wrote: > > This could be page_offset(page), which reads better to me: > > ret = afs_store_data(vnode, &iter, page_offset(page) + f, true); True. It gets converted to folio_pos() in patch #5 - will that do? David