From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44882E677EC for ; Sat, 2 Nov 2024 08:50:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DCB56B0083; Sat, 2 Nov 2024 04:50:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88AD16B0085; Sat, 2 Nov 2024 04:50:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72B7C6B0088; Sat, 2 Nov 2024 04:50:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 52F6E6B0083 for ; Sat, 2 Nov 2024 04:50:17 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E6489C06E7 for ; Sat, 2 Nov 2024 08:50:16 +0000 (UTC) X-FDA: 82740532980.28.456794C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id 21B77160006 for ; Sat, 2 Nov 2024 08:49:49 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LOV4mnni; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=WleoDaiv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LOV4mnni; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=WleoDaiv; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730537289; a=rsa-sha256; cv=none; b=IdpVro/0s7GcmF95mEMGHcLRl2T41uJ2UVgwxCQ+xEjGMr3qY/QNlHmU7pB7jyek8U+r8d UTv6WV1bSuzV0bNdrHj6kQtraAFzXZ+QXxMfTe/Aem5DuXSXUcwGqpMwq5vgnbwY5VZAQW I4LIEWkFA0KT+hRCfZtMV9bRyOiUyUg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LOV4mnni; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=WleoDaiv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LOV4mnni; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=WleoDaiv; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730537289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GmaCLXd53NkWSnjnnOsMXEPXNMelL55zka9KuK+MYvg=; b=MgUd3FfaMY1w33Cc4MZ4uYJ/coK6xoZgMJI6DsNyJlD/NGxV89RiyHdOtsBcUI9rvfTq+c aANUnHWJpZ+QyWOB8A5sZxsZxFNsrwNgWqUYAqWcFuCedHL3w10frUuApxwjnWAk0drDPF 8JMt7Srst09FahXZQ2qMjQiipaskdIU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1B9AC21CAF; Sat, 2 Nov 2024 08:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730537406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmaCLXd53NkWSnjnnOsMXEPXNMelL55zka9KuK+MYvg=; b=LOV4mnniY2X2XmZemLWIhRNDzJW+pT+USfWraZz2IA+6Ezy8r60eIiyb6Grg/t6RV/jGOF KwsW7HngpZ9RFnhy7D7SpytoCIJq/hxTrn6nInwJhrB//QRkZyzBm1/pLAb5+lSnBcezM0 s6LrApdUKp2SIC9XTDyZyUiBeR4/aX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730537406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmaCLXd53NkWSnjnnOsMXEPXNMelL55zka9KuK+MYvg=; b=WleoDaivPVuMev7ymPEDmOngFSGWkngdd2LJnslvFnZ3w7FqfWTYv7u4VdyCxRs3+jzv7z TZ11kC2KBmxfzlDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730537406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmaCLXd53NkWSnjnnOsMXEPXNMelL55zka9KuK+MYvg=; b=LOV4mnniY2X2XmZemLWIhRNDzJW+pT+USfWraZz2IA+6Ezy8r60eIiyb6Grg/t6RV/jGOF KwsW7HngpZ9RFnhy7D7SpytoCIJq/hxTrn6nInwJhrB//QRkZyzBm1/pLAb5+lSnBcezM0 s6LrApdUKp2SIC9XTDyZyUiBeR4/aX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730537406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmaCLXd53NkWSnjnnOsMXEPXNMelL55zka9KuK+MYvg=; b=WleoDaivPVuMev7ymPEDmOngFSGWkngdd2LJnslvFnZ3w7FqfWTYv7u4VdyCxRs3+jzv7z TZ11kC2KBmxfzlDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D4461394A; Sat, 2 Nov 2024 08:50:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ipiIJb3nJWfEfAAAD6G6ig (envelope-from ); Sat, 02 Nov 2024 08:50:05 +0000 Message-ID: <195242b4-5471-419a-a350-08fd246973f0@suse.cz> Date: Sat, 2 Nov 2024 09:53:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/slab: Allow cache creation to proceed even if sysfs registration fails To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, Jinjie Ruan , Liu Shixin References: <20241101130845.19100-1-42.hyeyoo@gmail.com> <35f58f1b-6e71-42ce-8619-2ecd810b4510@suse.cz> From: Vlastimil Babka Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 21B77160006 X-Stat-Signature: jyahk9sww8rhj9k6rfmf93ctwqo6a9o8 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1730537389-633087 X-HE-Meta: U2FsdGVkX1/fYnHFEhQEair+a0ezK0fUpJ1WrYXBa32IULM7Iai75rhSgRmodieIh0L+mTi1fKW3rtfY4Uk6xqHgvGPQswhK6B4n+tCch4PIjkhPLJmLG99hxFCEl7TawS4ySSZysQf+nP3cEMRcd7UWa8sFZJMX+zzmrSZ8CrrZpTdsb/Kdbygbfa8L48Kquf7IXWiMnReR4l0RS9iDpjMuNZPq9OVw9STe9aoFHjoU+FrEwN7exT9+mQU3IKlDQDmzVe7d65alK9iS259ba4kgua5jKd4Gg0kcNuJTcC8rKyA1VFEicrLOWOLnq7Rrbf1pgPD9WQW9LoCZN9sBMJhgDoWg6qmf8pLrWGfquIhx6hE/mQB+hrVM3xKISAp+sFJOqLHCEZvnd75GAqzhfFMCZK2iwBk3T3qYIgXvqYsZhlv0D9+V/UdxjA9/oGTn1v6Zp9vKhknTeNbnJ7Qm4IRqnjT00bWZcnUdPph2DZB4W+WZ26kw1sgmImMVfnhxcapTt2PZUA3C589S+DuwSznFdiyZiwjyx9S65NbjJIdvzKCp1wnvQ6oq3x1pbt31j9/WpT+xHxhtVJZIFKySX+VDt+h4QmBiJIPZMYhmugFrtmYLKCQwR8/7pI0HcqQJlnWCM0xTYklWuqNydNOXb0753FblaNAblEPW/PgEK8OxxWNsxbKjtkTAaNuzu/fh3yD+uZjBMt2wggvfoEgfwwg08x/7ITsfekPy/8kSKll6QIgMIIVk77Htu7iAscx4q4PHhrAnRL9+anpO91EslEKDaPeFv+cFSMsV6T0MBBLC5xraQfYAyF7FM9a0UwMJuMJOEI+RlIusabWLxGZOtpiAkW534lPfpgwXFix/VL3/3QccybdheSY8IGBV7vl3ZXHzMCw+bKlt8d3Mx8Uab0a1sKqwfgs5fTc2OSjVvQXeA+DzT5G7UAtgIZfjPQwMB9VU2fy8HCBw47w3jmK WYamutVq pn2Cyksrqqb+5C6zjKrUcjhaKl2DaGVfTFtPZQ0hJM+UiTozzVjaDLdyl6vmwhrid2o/iIPAHb2VdaqWMUcl2iLTDiVinTSUUNr0w6XIhaDKfnqlDBkQawI5FSlD5f+2+4pw9MSem1LTixMIkwIm/oji6FNfVX/BJ8PHJJ5wiDh8+6W/Qz9XGZf9lq+nOZ+BHq5QtYFPFSl5hYIbLvtpW4MvoWdIcCbACmlhyPmSc6i0U9OsUx5HikFPATK1MzYe5TtHIlZbulimPKh42JYBpUrL/s+HZajgx2b4CepyQRLjJfh/QTo84LXJFjPENvutcmChu/zIb2huZNUV5QEZM03MjpCx5ly5WNqEzPMvxToWmQ4g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/2/24 8:18 AM, Hyeonggon Yoo wrote: >> >> Also here, and simplified to "if (sysfs_slab_add(s)) ... " to avoid dealing >> with err. > > Oh no. err is initialized to -EINVAL, so that will not work as intended. > It is causing the following list corruption. Ooops, right, thanks a lot. Wrongly assumed that a test boot in virtme-ng would catch silly mistakes like that. Looks like all caches were created with SLAB_STATE < FULL. Fixed by setting err = 0 before trying sysfs add. > [ 0.607833] __kmem_cache_create_args(fscrypt_inode_info) failed > with error -22 > [ 0.608518] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0-rc2+ #63 > [ 0.609181] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), > BIOS 1.16.2-1.fc38 04/01/2014 > [ 0.610000] Call Trace: > [ 0.610233] > [ 0.610433] dump_stack_lvl+0x64/0x80 > [ 0.610806] __kmem_cache_create_args+0x1eb/0x280 > [ 0.611253] ? __pfx_fscrypt_init+0x10/0x10 > [ 0.611647] fscrypt_init+0x88/0xf0 > [ 0.611980] ? __pfx_fscrypt_init+0x10/0x10 > [ 0.612373] do_one_initcall+0x5b/0x320 > [ 0.612736] kernel_init_freeable+0x351/0x510 > [ 0.613150] ? __pfx_kernel_init+0x10/0x10 > [ 0.613536] kernel_init+0x1a/0x1d0 > [ 0.613865] ret_from_fork+0x34/0x50 > [ 0.614207] ? __pfx_kernel_init+0x10/0x10 > [ 0.614591] ret_from_fork_asm+0x1a/0x30 > [ 0.614968] > [ 0.615203] list_add corruption. prev->next should be next > (ffff986bc2bb9aa0), but was ffff986bc2b6. > [ 0.616308] ------------[ cut here ]------------ > [ 0.616746] kernel BUG at lib/list_debug.c:32! > [ 0.617173] Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI > [ 0.617709] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0-rc2+ #63 > [ 0.618372] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), > BIOS 1.16.2-1.fc38 04/01/2014 > [ 0.619192] RIP: 0010:__list_add_valid_or_report+0x78/0xa0 > [ 0.619714] Code: 8b ff 0f 0b 48 89 c1 48 c7 c7 50 ca c0 9a e8 2f > f4 8b ff 0f 0b 48 89 d1 48 89 c6 b > [ 0.621473] RSP: 0018:ffffa47380013c98 EFLAGS: 00010246 > [ 0.621969] RAX: 0000000000000075 RBX: ffff986bc2b63238 RCX: ffffffff9b5646a8 > [ 0.622638] RDX: 0000000000000000 RSI: 0000000000000003 RDI: 0000000000000001 > [ 0.623313] RBP: ffff986bc2bb9ab8 R08: 0000000000000000 R09: 205d333032353136 > [ 0.623996] R10: 74707572726f6320 R11: 6464615f7473696c R12: ffff986bc2bb9aa0 > [ 0.624673] R13: ffff986bc2b63240 R14: ffff986bc2b63240 R15: ffff986bc2b631c0 > [ 0.625355] FS: 0000000000000000(0000) GS:ffff986bdf400000(0000) > knlGS:0000000000000000 > [ 0.626111] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 0.626653] CR2: ffff986bd3801000 CR3: 000000001242a000 CR4: 00000000000006f0 > [ 0.627325] Call Trace: > [ 0.627559] > [ 0.627760] ? die+0x36/0x90 > [ 0.628039] ? do_trap+0xdd/0x100 > [ 0.628354] ? __list_add_valid_or_report+0x78/0xa0 > [ 0.628814] ? do_error_trap+0x6a/0x90 > [ 0.629172] ? __list_add_valid_or_report+0x78/0xa0 > [ 0.629633] ? exc_invalid_op+0x50/0x70 > [ 0.630001] ? __list_add_valid_or_report+0x78/0xa0 > [ 0.630463] ? asm_exc_invalid_op+0x1a/0x20 > [ 0.630861] ? __list_add_valid_or_report+0x78/0xa0 > [ 0.631324] ? __list_add_valid_or_report+0x78/0xa0 > [ 0.631784] kobject_add_internal+0x78/0x2a0 > [ 0.632192] kobject_init_and_add+0x8c/0xd0 > [ 0.632589] ? kernfs_find_ns+0x35/0xc0 > [ 0.632957] sysfs_slab_add+0x193/0x1e0 > [ 0.633318] do_kmem_cache_create+0x455/0x630 > [ 0.633727] __kmem_cache_create_args+0x157/0x280 > [ 0.634176] ? __pfx_fsverity_init+0x10/0x10 > [ 0.634586] fsverity_init_info_cache+0x66/0x90 > [ 0.635022] fsverity_init+0x13/0x40 > [ 0.635365] do_one_initcall+0x5b/0x320 > [ 0.635734] kernel_init_freeable+0x351/0x510 > [ 0.636154] ? __pfx_kernel_init+0x10/0x10 > [ 0.636547] kernel_init+0x1a/0x1d0 > [ 0.636881] ret_from_fork+0x34/0x50 > [ 0.637227] ? __pfx_kernel_init+0x10/0x10 > [ 0.637619] ret_from_fork_asm+0x1a/0x30 > [ 0.637998] > [ 0.638211] Modules linked in: > [ 0.638512] ---[ end trace 0000000000000000 ]--- > [ 0.638962] RIP: 0010:__list_add_valid_or_report+0x78/0xa0 > [ 0.639483] Code: 8b ff 0f 0b 48 89 c1 48 c7 c7 50 ca c0 9a e8 2f > f4 8b ff 0f 0b 48 89 d1 48 89 c6 b > [ 0.641253] RSP: 0018:ffffa47380013c98 EFLAGS: 00010246 > [ 0.641753] RAX: 0000000000000075 RBX: ffff986bc2b63238 RCX: ffffffff9b5646a8 > [ 0.642431] RDX: 0000000000000000 RSI: 0000000000000003 RDI: 0000000000000001 > [ 0.643118] RBP: ffff986bc2bb9ab8 R08: 0000000000000000 R09: 205d333032353136 > [ 0.643795] R10: 74707572726f6320 R11: 6464615f7473696c R12: ffff986bc2bb9aa0 > [ 0.644471] R13: ffff986bc2b63240 R14: ffff986bc2b63240 R15: ffff986bc2b631c0 > [ 0.645152] FS: 0000000000000000(0000) GS:ffff986bdf400000(0000) > knlGS:0000000000000000 > [ 0.645923] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 0.646470] CR2: ffff986bd3801000 CR3: 000000001242a000 CR4: 00000000000006f0 > [ 0.647156] note: swapper/0[1] exited with preempt_count 1 > [ 0.647686] Kernel panic - not syncing: Attempted to kill init! > exitcode=0x0000000b > [ 0.648446] Kernel Offset: 0x18000000 from 0xffffffff81000000 > (relocation range: 0xffffffff80000000) > [ 0.649466] ---[ end Kernel panic - not syncing: Attempted to kill > init! exitcode=0x0000000b ]--- > > >>>> + } >>>> >>>> if (s->flags & SLAB_STORE_USER) >>>> debugfs_slab_add(s); >>>> @@ -7276,7 +7283,8 @@ static int sysfs_slab_add(struct kmem_cache *s) >>>> >>>> void sysfs_slab_unlink(struct kmem_cache *s) >>>> { >>>> - kobject_del(&s->kobj); >>>> + if (s->kobj.state_in_sysfs) >>>> + kobject_del(&s->kobj); >>>> } >>>> >>>> void sysfs_slab_release(struct kmem_cache *s) >>>> @@ -7305,6 +7313,11 @@ static int sysfs_slab_alias(struct kmem_cache *s, const char *name) >>>> * If we have a leftover link then remove it. >>>> */ >>>> sysfs_remove_link(&slab_kset->kobj, name); >>>> + /* >>>> + * The original cache may have failed to generate sysfs file. >>>> + * In that case, sysfs_create_link() returns -ENOENT and >>>> + * symbolic link creation is skipped. >>>> + */ >>>> return sysfs_create_link(&slab_kset->kobj, &s->kobj, name); >>>> } >>>> >>>> -- >>>> 2.45.0 >>>> >>