From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CDBC432BE for ; Tue, 24 Aug 2021 14:11:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E4D5610FB for ; Tue, 24 Aug 2021 14:11:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1E4D5610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id AE1728D0001; Tue, 24 Aug 2021 10:11:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A915D6B0071; Tue, 24 Aug 2021 10:11:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9806B8D0001; Tue, 24 Aug 2021 10:11:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id 7EA7F6B006C for ; Tue, 24 Aug 2021 10:11:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1B4F6181AC1F5 for ; Tue, 24 Aug 2021 14:11:57 +0000 (UTC) X-FDA: 78510163074.10.530EFFB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf04.hostedemail.com (Postfix) with ESMTP id B38E350000AE for ; Tue, 24 Aug 2021 14:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629814316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B7csfGznQ1Q++PNssOARKkoGks0RWXUGuEYc3/fzXSM=; b=UoUDo+u3kJhMPzkgXohhjO063kWUaSocaKj3LAgCrAvf+JAXoWwnppFZfYtqoyLLeijK+Z Gu/RL3piZD1JcLhBHoLtQP3Df20DI0bE9uEZPVQOb5ZbkYRrihaDm3iG0b5dlH8gT9MSyN jhMtqMXjhryC40dUrj8GKKuSlni4rc0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-6t25SUB3PRaCvUt6qPogYw-1; Tue, 24 Aug 2021 10:11:54 -0400 X-MC-Unique: 6t25SUB3PRaCvUt6qPogYw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 046971082921; Tue, 24 Aug 2021 14:11:53 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.86]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC8415C25A; Tue, 24 Aug 2021 14:11:46 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <162981147473.1901565.1455657509200944265.stgit@warthog.procyon.org.uk> <162981151155.1901565.7010079316994382707.stgit@warthog.procyon.org.uk> To: Matthew Wilcox Cc: dhowells@redhat.com, Jeff Layton , Ilya Dryomov , linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] folio: Add a function to get the host inode for a folio MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1951629.1629814305.1@warthog.procyon.org.uk> Date: Tue, 24 Aug 2021 15:11:45 +0100 Message-ID: <1951630.1629814305@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Rspamd-Queue-Id: B38E350000AE Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UoUDo+u3; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf04.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com X-Rspamd-Server: rspam01 X-Stat-Signature: ex98ye1otdk5zteg34op7w15teuezezk X-HE-Tag: 1629814316-385164 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox wrote: > > +static inline struct inode *folio_inode(struct folio *folio) > > +{ > > + return folio_file_mapping(folio)->host; > > You're contradicting yourself here. If you're allowed to call this > function for swap cache pages, then the documentation needs to change. > If you're not, then we can just use folio->mapping->host. Um. I don't know. I'll do the latter, then, for now. David