From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48589C0015E for ; Thu, 27 Jul 2023 09:07:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A0DC6B0072; Thu, 27 Jul 2023 05:07:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 550CE6B0074; Thu, 27 Jul 2023 05:07:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F15C8D0001; Thu, 27 Jul 2023 05:07:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2BFD16B0072 for ; Thu, 27 Jul 2023 05:07:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E849CC10A4 for ; Thu, 27 Jul 2023 09:07:17 +0000 (UTC) X-FDA: 81056812914.24.7B38882 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf13.hostedemail.com (Postfix) with ESMTP id 544D320029 for ; Thu, 27 Jul 2023 09:07:14 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=DjrROq91; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690448835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UKiGuCYavgdrONYSlKU+hjlx/AzCB2LKMORbFgw7HEo=; b=EpH2kLKr0u1RalwEFk4ojGXH5TL4vFwFVqXqJH/pZbsjwWAGxhlbk2cXd3svey0rg9hyAb rF/lgtftCxkrNs//0QjcL26YN6Q0KRbarU9N+3wSmcFPV9bWpGGeBxUryGs2JQ6l2UXXw8 1subrxjXVtOfbCVF0XknU9uyziP3GwU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690448835; a=rsa-sha256; cv=none; b=qP66Cu/3gE6f+xZzKtGq5rhdnDDhuHGYtG6dn7KAa8kIEIxPvOkGmwTlMBHlfjsbehPVmY xp6GwtlEdR605SCtAE3RSCWwh9Es9zTLvCpBu0Oa33PaEFxFk/j+CxKRpQzGtozI/ruFv/ xYcarVQRwSNioD6lJ1OI0589eSlP5uI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=DjrROq91; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2659b1113c2so145045a91.1 for ; Thu, 27 Jul 2023 02:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690448833; x=1691053633; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UKiGuCYavgdrONYSlKU+hjlx/AzCB2LKMORbFgw7HEo=; b=DjrROq91sf6Va+7++jhnZLLfMfZ3NpR+vs103Gffs3+O08HW6byjEgnIqMIjx7XVVU 6Esw8LCCRNx5FIzgZD2yLlNtiJ3fWUXbMzLdc62rKZLebfjHSG7L7jgEMl0D1hE7ZoNg HZ2c9Q9i+LL0tt0iImhvHFOK+Hduw2G0dP+6wK+guSG8W2Nz3BegBODQY1lmNQJ14Dz4 uuXi2h/k5/64PvGOHou6Defqpklm1cGUHs8RqpArf+xI1YmvbpRswY34ry3JAORO90Jx 4NSzh0j5w+vqWxK/Ia35MiibA4wNxyya8QHOgB3QIdRRJ50Wt48gZu09EVgownqRkh1E f6DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690448833; x=1691053633; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UKiGuCYavgdrONYSlKU+hjlx/AzCB2LKMORbFgw7HEo=; b=PA/bo1NuufrvG6efAUcPxrC4bhpZGoskINfcR/944DlqFzHgXnUu9g6kYEDApJx5cS 3+8mVtEPRv85d7AvR+G+m5qPH0pHYBN7DaOWs/9RXWcMVp1E0kruU1sKetdq4MuGonm+ z00w4VOHGX3+1+CnRf7vnNEQISFCQpKcwXNzmoFQZ9S4VnP/61AIjPrxQ7Z1iFZkBhcZ +YzbTc9lz7473P1AKG9gwUJ6zdExLLr3QOsJSa3XK3vlZ4j5/m10YXXwckWqE6geb18f +DQw8X4kRWVTq3tOWuC4jRj/Ce/TkPzo942vfy/C2NjOmeuOYNCe50GaQHRhu1+awT90 pIcA== X-Gm-Message-State: ABy/qLZk4l3mGSkOVz5jwXlq7Jw/ydOJMKsX3WyC/MTHf82mmbTbyjHM jIanOwYjcdhCXFDiISI1hv3C3A== X-Google-Smtp-Source: APBJJlEquEzidizjgrmS1e55j2UU3CMKKyxPnlaVqAXQYQ+ePfvdxx8A4f9JU/BbmCjGKzVhoGuchQ== X-Received: by 2002:a17:90a:128e:b0:263:25f9:65b2 with SMTP id g14-20020a17090a128e00b0026325f965b2mr4139877pja.4.1690448832920; Thu, 27 Jul 2023 02:07:12 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id a11-20020a170902ee8b00b001b7e63cfa19sm1063627pld.234.2023.07.27.02.07.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 02:07:12 -0700 (PDT) Message-ID: <19461737-db63-2ab5-110b-e65035881ae2@bytedance.com> Date: Thu, 27 Jul 2023 17:06:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 15/49] nfs: dynamically allocate the nfs-acl shrinker Content-Language: en-US To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-16-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: <20230727080502.77895-16-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: qjbkqrb9795p1w3kx95o4o6caatz4tw5 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 544D320029 X-Rspam-User: X-HE-Tag: 1690448834-468157 X-HE-Meta: U2FsdGVkX1/NyCY9rTvd/QIuDJKX4MB46a3agJ8mVpx36QEshK3elIFXoNMOfE0oYSvEXYljBrBUbL/C/jmBHfk2eBEqwuwoz3JMk26hfoxPfSLFOAQAi1tVZ5iUwyB1u0FZqBn6O5NQVOOwjmp2zTJJeS2615KwUAvR3+n32QhYhHzTBqd8Z+pRdWT4oENylrUz7MTei/VpSnyJLzUMmDJAy370+NXHFmRBpzVSAw1jyFpxHgbqLZGUJiDmqdxMRSZiVEQ7cGPwDFCRBG6i0KXQxWuIdi+tfXX8tlIPqBhFTRMEY48Zw7rWPhPUOB/AVUAJnXGjqmpZ4R3Mo2HMmsK5QndL4WF23ajwT0inrm/2elCEamZuv2EiIKgFyPfbVCOZmD1Na8iLOMGJWnvPCeCzFikjtA564Rqg6kZlGka2OEHZ48k9Ad2V7qyv16aLzLRuv31eGSgOxz8amNI+QMTBcJIp6M1r9oOERtQ6q22c70K4JaxzFgq3sshUSMKVjxjGZtoJah4a3agiOFQ6eGS6uliSiHBfVJ7HLpT9LwCHNBNTUiRTirgBJDHhU2/2XfEKtj7E0LpGDpu0W3IJ2HYLEO4ptH7ZxuAq06FuDtVsmCvKaTMgD6I1Rb5ajRtM7dMweA0kL21DZupwoGNki6/DanaRv/pD1PzzB/GKJoIAHIPCaKBKGIFpyMEdrOr5Ge2ItLO/ZishtC7RmfCrQU3IWhH2c0O15LyslNokAptURbiqsM3PqBPecs2Igykts3n0/szYb/TouiyZHVgFp0UsWhA5LvwxLsjslo7+IRY9BanEQedSVdKDwmFdp4jPuWiMyDnGGB2WvVd+IM9yKsBODHUJzqh3sU9LMojBtQPfyyE3JlGkt1eptVuog1V33Gt7N7HJE9g5eB8FYB+w0WUIZqC6SDgDQMFG1TCwENlIifFtWSCTHe1HOFEonLGrTEto7K3HzkEonZqtSsK zE+M/EvK Ia2oE/ibMnOEhlfLWByEnXzhQtE82deCjkLAYdgWUsdliVIASzTEZ7bNKKjTq81BkALpi/nmo0VLM/J6el0bs6PnKN2bB01+JJr3yfiRLclgguPmK+kRSRz/JYPC8EqN9zogKp2L1zJw7+hGaJYIUFGEy0adw6CAWxcXQrWeRqPHONitEORU9Q+NVgqcSbgj1OlxmdDgLuIV4McJBFzcpQqWf1wMmsHd3XlTVQMOoyaatRwLLpzTypRD9zdKkmPq0uctw7dUq/+Jw68S3V4/YTNOb6MqrYaw7HQhGZWMzwVBhsXh+qfRTKVtRL9aDsYaTPdWuydbTuowho8F80cTFxs/59fPMdZyHSkD2uUiw85I0yDTxjQpoBdM2bOGod6XJpNlWCIRyHe5Ijx4zrk7Tqtwn99WHhWYukrgr6Pej9EQBVXw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/27 16:04, Qi Zheng wrote: > Use new APIs to dynamically allocate the nfs-acl shrinker. > > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > --- > fs/nfs/super.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index 2284f749d892..072d82e1be06 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -129,11 +129,7 @@ static void nfs_ssc_unregister_ops(void) > } > #endif /* CONFIG_NFS_V4_2 */ > > -static struct shrinker acl_shrinker = { > - .count_objects = nfs_access_cache_count, > - .scan_objects = nfs_access_cache_scan, > - .seeks = DEFAULT_SEEKS, > -}; > +static struct shrinker *acl_shrinker; > > /* > * Register the NFS filesystems > @@ -153,9 +149,17 @@ int __init register_nfs_fs(void) > ret = nfs_register_sysctl(); > if (ret < 0) > goto error_2; > - ret = register_shrinker(&acl_shrinker, "nfs-acl"); > - if (ret < 0) > + > + acl_shrinker = shrinker_alloc(0, "nfs-acl"); > + if (!acl_shrinker) > goto error_3; Here should set ret to -ENOMEM, will fix. > + > + acl_shrinker->count_objects = nfs_access_cache_count; > + acl_shrinker->scan_objects = nfs_access_cache_scan; > + acl_shrinker->seeks = DEFAULT_SEEKS; > + > + shrinker_register(acl_shrinker); > + > #ifdef CONFIG_NFS_V4_2 > nfs_ssc_register_ops(); > #endif > @@ -175,7 +179,7 @@ int __init register_nfs_fs(void) > */ > void __exit unregister_nfs_fs(void) > { > - unregister_shrinker(&acl_shrinker); > + shrinker_free(acl_shrinker); > nfs_unregister_sysctl(); > unregister_nfs4_fs(); > #ifdef CONFIG_NFS_V4_2