From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B74DE77188 for ; Mon, 6 Jan 2025 17:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D512F6B0089; Mon, 6 Jan 2025 12:29:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D02136B008A; Mon, 6 Jan 2025 12:29:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA26D6B0092; Mon, 6 Jan 2025 12:29:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9B9176B0089 for ; Mon, 6 Jan 2025 12:29:40 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9EC23160145 for ; Mon, 6 Jan 2025 17:29:39 +0000 (UTC) X-FDA: 82977714078.23.7516A69 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf01.hostedemail.com (Postfix) with ESMTP id 06D7C40007 for ; Mon, 6 Jan 2025 17:29:36 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VrsuLoMl; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736184577; a=rsa-sha256; cv=none; b=gvQnVUypv454FOe7P1g+ZiH2GOiLlcxJP/GBNYHaYZf5b4U/Ofys2qby9/gqBnPZVI5E/V twDZAiukTN5SoQ930w6AKKKmbdst7FBMrDa1fRompHX8bvNdY/BYMdTjsOdpd48TPO9wAZ mH0O2YRcudelkp7sxChCtvSYYmQse5Y= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VrsuLoMl; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736184577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hZRVWvLLHD0q+TL9q9ZyuxDwuNKmUBmb+819CubEVi0=; b=Ee7sQP8xkxwkBTB5Irk7cy5ckDqThE8Fqfl1n9w21KWO17vlLwKbr9lcywK/+JJBw9xu+1 DT+2J/bHc7s8JODdWgPlg/zl/tW0vx2HKQPpRyxXjk17Urg7S1G+50y+ICQLeCMfkEPGBw 9P0JQ2QyTNycVO3KfMWy9dXmUGLknWI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736184577; x=1767720577; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=k22vd2OHew/638bah/70y+UL8xR9Xewyc0w8cfFgcRI=; b=VrsuLoMlh3M7rm/97A1f/sjuU3fIIcNgXSHY2qci8tjquXBIA3bvb0hj 9x+Gch7VYPUcFgfaRSHYY2maRGab1neBsS7wVF051je8MR2MHFGVRLMeE p2wPljes6UzcL/AvQYS5+gDeeKI74hLxwZZKSuojlNwG3hnSC2kUmiUwX ytrSCyxhZAdWbkg8NsDG//fxi8z+eS5lk3j6aP3ICAsF/r/d51Wy/dg1w tu4xzw36xtQefhtnPRNdUQUk7X5ds5P7PmH4yMnCtfEGb8eooDb4xCxer qljLsQp53WGwQQtJXstvw6/nfHXR0PpVbzLfKqcIhJ134qDZhay+j3p+3 g==; X-CSE-ConnectionGUID: 7QpuwJUDT1qQc2e0Sl+vWg== X-CSE-MsgGUID: r5XXAINTR/eX52HEz5mXfA== X-IronPort-AV: E=McAfee;i="6700,10204,11307"; a="40016540" X-IronPort-AV: E=Sophos;i="6.12,293,1728975600"; d="scan'208";a="40016540" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 09:29:35 -0800 X-CSE-ConnectionGUID: 1FsBwZ5LQNOoS0xlIMuVQQ== X-CSE-MsgGUID: xyEwL5VXTXithg3p24ClwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,293,1728975600"; d="scan'208";a="107361916" Received: from lbogdanm-mobl3.ger.corp.intel.com (HELO [10.124.220.224]) ([10.124.220.224]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 09:29:33 -0800 Message-ID: <194072ff-32af-4a5d-8e73-0a45f75290e7@intel.com> Date: Mon, 6 Jan 2025 09:29:33 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/12] x86/tlb: use INVLPGB in flush_tlb_all To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-8-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20241230175550.4046587-8-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 06D7C40007 X-Stat-Signature: 4uyin4t1rbygbu5mzyjyb7ossnossf9f X-Rspam-User: X-HE-Tag: 1736184576-221955 X-HE-Meta: U2FsdGVkX18n7QG9EzQi3wldbyujZ8IZZVsTqdTkY374u5Psgx4HNce0kCmpMKs1Jy6auVv5olPD9hoFTARUh5TYKu4/mZNlPWhmBPlyqzgFWUiUJEbUiq3ED2jNLqCOtN2bTrCj3M/PbzxmqCAqZNbRN/9dPk4j3YCbpa/Fhtyazu9d+ab2gGJ9EVBfjpBrmrtDKfmK3ospc1VYEuAARTcwcRXOtj9Kk6ELNBSVct0G0k1fkQpPzNnOqEYi72chXEIBkubc0nTSJYlCDemxKSCTnjsrv0XGrYHgoYphASdZISPcWB8K5+NoJ4fk1eTz4fsPrpgbeL8TLmren/848luQ+EovwDQ3ucHeDonceNIEAunEK4e6O57BYyYPosdzZGUVDvHfyilGldNaG1flYWpUbTnJPjkX90VoHsIxzAI4VI4RtcL0ChyjW12CdbXsT7mEFBwGn4sBR0n1eBwPKzmcZZKoxDYgc4C244SHtopXYsVLRuO1dPVS26h2lWXlAh/25XRStb83Ogk+b1oUE8tkFqxIDwQMHohwG+Hj7AHYfH/vGQ8dmoYMR5vNuruQk0yp61B0Sil/XeyGlahk7nZRz8mcG2as4crMPSnw1jGUz0f9sahF8wR5uFKxNS/3MS4mQ7HGCVnomp8IowKX1VUCJVjIPqgH2VAu6Ee24QnAil2JoHkWCdjHViHEGF3Ar8t63kNjE6lCXXdQjdE8H+fA8WbTDz+NVNkoeeJw4u3l5Zp4zWxCaMnFk25piwhdg/g+D692Rkdk08BpUTLY8np+TJg9qXg9IiVjTz2DExkPf1VgNq0GiA4LwfozMvaH1cFZDMWLyho1JlvWnGXbt3d57gTXjqdKtL2HqajalxyofQ1BpWN6fMuTX7hUjetXOS0FUNbvGaXL2uWh240ib+ar+KgFWH/KaeyGs/i/RLOYjWFQynw9rAJuMm4fTv0IxHHVE27uQpXkmD+IJGM 8kw19uIL fN1UpTxodKI+5Z3N4BSDOgZ+83t5T5D7LotrzcE5tp0fL6K/svB/7PtPs9QKA09mQG3t14PTiVVmCnXf16oJpuKDqO00l+5nXoZIyiQ4xlt+xdockbJYv6+Q8wfeVR7NqYjq5So52zRYiLJog3bEIFcQc2Cq9PYeMDOO+/G5u5lU6X5PMZ7nemGP+MvrgXJfpgfIQysvdrLYsw4ha1Opx2ZiCH4NvgpWyHnnVPfPH3ili7Fwpiosy+C38VclAh+sYFlpwYw6zPNQwLgqt8qXQyxPKUUO4L8ClPdbK7OoulDbhREIDAFaZgcN2s3ugVLnQSPNM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/30/24 09:53, Rik van Riel wrote: > --- a/arch/x86/mm/tlb.c > +++ b/arch/x86/mm/tlb.c > @@ -1074,6 +1074,12 @@ static void do_flush_tlb_all(void *info) > void flush_tlb_all(void) > { > count_vm_tlb_event(NR_TLB_REMOTE_FLUSH); > + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { > + guard(preempt)(); > + invlpgb_flush_all(); > + tlbsync(); > + return; > + } After seeing a few of these, I'd really prefer that the preempt and tlbsync() logic be hidden in the invlpgb_*() helper, or *a* helper at least. This would be a lot easier on the eyes if it were something like: flushed = invlpgb_flush_all(); if (flushed) return; or even: if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { invlpgb_flush_all(); return; }