From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1583C352A9 for ; Thu, 26 Sep 2019 13:38:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7EAB4222C0 for ; Thu, 26 Sep 2019 13:38:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EAB4222C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1201B8E0010; Thu, 26 Sep 2019 09:38:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ABDF8E0001; Thu, 26 Sep 2019 09:38:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB3168E0010; Thu, 26 Sep 2019 09:38:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id C4B9E8E0001 for ; Thu, 26 Sep 2019 09:38:25 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 60ED755FB6 for ; Thu, 26 Sep 2019 13:38:25 +0000 (UTC) X-FDA: 75977176170.23.power87_f4b92a2fa148 X-HE-Tag: power87_f4b92a2fa148 X-Filterd-Recvd-Size: 3777 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Sep 2019 13:38:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0613C10DCC82; Thu, 26 Sep 2019 13:38:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EEB4960933; Thu, 26 Sep 2019 13:38:23 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E098C18089C8; Thu, 26 Sep 2019 13:38:23 +0000 (UTC) Date: Thu, 26 Sep 2019 09:38:23 -0400 (EDT) From: Pankaj Gupta To: "Aneesh Kumar K.V" Cc: dan j williams , akpm@linux-foundation.org, David Hildenbrand , linux-nvdimm@lists.01.org, linux-mm@kvack.org Message-ID: <193523014.3320073.1569505103872.JavaMail.zimbra@redhat.com> In-Reply-To: <20190926122552.17905-2-aneesh.kumar@linux.ibm.com> References: <20190830091428.18399-1-david@redhat.com> <20190926122552.17905-1-aneesh.kumar@linux.ibm.com> <20190926122552.17905-2-aneesh.kumar@linux.ibm.com> Subject: Re: [PATCH 2/2] mm/memmap_init: Update variable name in memmap_init_zone MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.117.36, 10.4.195.4] Thread-Topic: mm/memmap_init: Update variable name in memmap_init_zone Thread-Index: y3EnjbYa8cm00jnkkNb2efXWw9841Q== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Thu, 26 Sep 2019 13:38:24 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > The third argument is actually number of pages. Changes the variable name > from size to nr_pages to indicate this better. > > No functional change in this patch. > > Signed-off-by: Aneesh Kumar K.V > --- > mm/page_alloc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3334a769eb91..df9e09a5359f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5914,10 +5914,10 @@ void __meminit memmap_init_zone(unsigned long size, > int nid, unsigned long zone, > #ifdef CONFIG_ZONE_DEVICE > void __ref memmap_init_zone_device(struct zone *zone, > unsigned long start_pfn, > - unsigned long size, > + unsigned long nr_pages, > struct dev_pagemap *pgmap) > { > - unsigned long pfn, end_pfn = start_pfn + size; > + unsigned long pfn, end_pfn = start_pfn + nr_pages; > struct pglist_data *pgdat = zone->zone_pgdat; > struct vmem_altmap *altmap = pgmap_altmap(pgmap); > unsigned long zone_idx = zone_idx(zone); > @@ -5934,7 +5934,7 @@ void __ref memmap_init_zone_device(struct zone *zone, > */ > if (altmap) { > start_pfn = altmap->base_pfn + vmem_altmap_offset(altmap); > - size = end_pfn - start_pfn; > + nr_pages = end_pfn - start_pfn; > } > > for (pfn = start_pfn; pfn < end_pfn; pfn++) { > @@ -5981,7 +5981,7 @@ void __ref memmap_init_zone_device(struct zone *zone, > } > > pr_info("%s initialised %lu pages in %ums\n", __func__, > - size, jiffies_to_msecs(jiffies - start)); > + nr_pages, jiffies_to_msecs(jiffies - start)); > } > > #endif > -- > 2.21.0 Reviewed-by: Pankaj Gupta > > >