From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69FA2C5321E for ; Mon, 26 Aug 2024 13:52:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0A976B0083; Mon, 26 Aug 2024 09:52:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBAAE6B0085; Mon, 26 Aug 2024 09:52:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A82126B0088; Mon, 26 Aug 2024 09:52:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 89B4C6B0083 for ; Mon, 26 Aug 2024 09:52:33 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3B94DA11B4 for ; Mon, 26 Aug 2024 13:52:33 +0000 (UTC) X-FDA: 82494536586.13.6C88250 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf04.hostedemail.com (Postfix) with ESMTP id B8DDD4001B for ; Mon, 26 Aug 2024 13:52:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724680281; a=rsa-sha256; cv=none; b=3Z5XbGps/onxZ7l9UPTn6y1SIAuGZJegI7r8z2JbrKfmbwxLXlYcGtQGYS6BmJo0LImaPs tjPgwJFImq2XymUkKTRZCwAfU/3OSEFEanhq1AVH3rbjJbMZWJozGVZaB1oIp5fb8n6Eeu m72Z0pua5cOT+CV9K97MaElHFC7+ihY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724680281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oSssw7qJWpCpZUOcvuSyBVDfyc1BCbCirR77NnMPzU4=; b=AYLvsqsJcLLj9yfwRqyu9GyLjA7CwhMFcggi/W0xJHHfx44dRF/fxhfhiJb8k2m2vMMjTV 6VPzha5jrmmpLW/53BPi8XZYD4LxNhPauyBDSImLqVfrTMnv1XNu7aMDGaSznzWpYwxUG0 7hJiEdmCRwIdS8Kf+6udFSeebOTjCtw= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WssXp2LYczyQNN; Mon, 26 Aug 2024 21:51:38 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 51839180064; Mon, 26 Aug 2024 21:52:24 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 26 Aug 2024 21:52:23 +0800 Message-ID: <19306ff9-f886-4490-9d23-68e9741bf384@huawei.com> Date: Mon, 26 Aug 2024 21:52:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] mm: remove isolate_lru_page() Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , David Hildenbrand , Baolin Wang , Zi Yan , Alistair Popple , Jonathan Corbet , References: <20240826065814.1336616-1-wangkefeng.wang@huawei.com> <20240826065814.1336616-6-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B8DDD4001B X-Stat-Signature: uownckd8apo3e6xur1grmij8obrjq75c X-Rspam-User: X-HE-Tag: 1724680349-151733 X-HE-Meta: U2FsdGVkX18b5CR9zdTubvACzWXlZIhrmOagjtcPLDXgPZqBVW8YIa/ZS7OrNDc6Ik8Xv1SmVxjMVpTjcvdn5RcO3Q+kJaL+B30IQNWHRgWWOVqbnOx/1yk+Lra3NwAI1O89LgMkNMcK6v0ia4gMKo5boKuBBdbjVIxK8I4UOGBn6IZR3YzmzpT8zk4vVF0kthAYps18m9E9TG6C3GDVmgjTo+nJwqRMhXDXVo5ypPe07Kl3ZjCGOl+BognSW5VS9v5Ohqfq0osbgJ6fJIAo+/0EyIwTVrkSsJSjR803El3QwVQVmqCiHlTog8UgPnkb7rPcG2Sjklnlr/4B1YG+KawtX+SwwldcxKWIdI337aIjiQSM5P5w8PKo93x38ACmCBAjb1NF/Dd37Pc6i2O497Eovpnn16vadzMRI26dvGboDpkcjC+zqI243ZWhkL3RP5Zq1ai5uorYp3a+Fsdl/ZB9vILA6Z3foYUJkE/VQV3+7vVX3pPlrKeFax8upY2cikBggHGMjPoSBPX+eoaNvpkQGdAx+aGHVaEt9T3vmztLTQM+Tw7ZKMk3Oz+HivIj0KW+7s3tN6W25EoeBHafmOsmLag+vh6lsZK6SM26ILfkndZK0VGboLOoklFCRVVUb6nzef2aS3QSp1pXRGD0P/RyG4kWJeQJCN8oO9xnrGEegit8vYWyguYFiTf1OBcRGsLusuzQ7IcvjgL7aNpTLyZnXJAydsJ3aIGJxfnzwFIwL+ZzD+LQDFW8lRqBvrxlTMuJv015qCiLBrowjhCDGSHtFnJmLa9XEf7pzDPc++/Jp6WAjBlWvQmIh+mDykBWuH2btNCYlrP7Wv+IpyKCZdlnMmy7KvYzUiDYYjrm0ECK6g+sIAVC3VW1UoNbW07iXSiqeMoWY4e1J384qK9xDS/goUObpNoZFjq5KkWzz4CgVoYOktS1XJ4OiWX9/34OVvI2ZfYfVLjGAt3cF2Y NwW67bkU rKjH04D6OBo9cqk3PzFBPB4ejgxIq7hzu9tBgfRemRTSqgth4F2DRpqBVuPsQ+4r0K+4NLABnstuh1W2wduc4GSXgS4AfYOM40oC4trFHsdkHOVJF5GErZtLzzD/tUBymiLhJZlTEmW3mK5WRbGq21iAscS3hkdz+WdAA/gFp9Zoej3RxcGaaPcOHNc2MVQGMHv5gHPlfF4QkEaEcCrfXEDwogfVqAy8+LZMqOEUBi8vMgn4CgzlEFTS/2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/26 21:05, Matthew Wilcox wrote: > On Mon, Aug 26, 2024 at 02:58:13PM +0800, Kefeng Wang wrote: >> +++ b/Documentation/mm/page_migration.rst >> @@ -67,8 +67,8 @@ In kernel use of migrate_pages() >> >> Lists of pages to be migrated are generated by scanning over >> pages and moving them into lists. This is done by >> - calling isolate_lru_page(). >> - Calling isolate_lru_page() increases the references to the page >> + calling folio_isolate_lru(). >> + Calling folio_isolate_lru() increases the references to the page > > s/page/folio/ > >> @@ -86,7 +86,7 @@ How migrate_pages() works >> >> migrate_pages() does several passes over its list of pages. A page is moved > > list of folios. A folio is moved ... > > (etc) > >> +++ b/mm/swap.c >> @@ -906,7 +906,7 @@ atomic_t lru_disable_count = ATOMIC_INIT(0); >> >> /* >> * lru_cache_disable() needs to be called before we start compiling >> - * a list of pages to be migrated using isolate_lru_page(). >> + * a list of pages to be migrated using folio_isolate_lru(). > > a list of folios > >> * It drains pages on LRU cache and then disable on all cpus until > > drains folios OK， just use sed to replace then isolate_lru_page(), will re-check the changes and update other page to folio, thanks. > >> * lru_cache_enable is called. >> * >> -- >> 2.27.0 >> >