linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@redhat.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Zi Yan <ziy@nvidia.com>, Alistair Popple <apopple@nvidia.com>,
	Jonathan Corbet <corbet@lwn.net>, <linux-mm@kvack.org>
Subject: Re: [PATCH 5/6] mm: remove isolate_lru_page()
Date: Mon, 26 Aug 2024 21:52:23 +0800	[thread overview]
Message-ID: <19306ff9-f886-4490-9d23-68e9741bf384@huawei.com> (raw)
In-Reply-To: <Zsx9r_PgfcMA4W87@casper.infradead.org>



On 2024/8/26 21:05, Matthew Wilcox wrote:
> On Mon, Aug 26, 2024 at 02:58:13PM +0800, Kefeng Wang wrote:
>> +++ b/Documentation/mm/page_migration.rst
>> @@ -67,8 +67,8 @@ In kernel use of migrate_pages()
>>   
>>      Lists of pages to be migrated are generated by scanning over
>>      pages and moving them into lists. This is done by
>> -   calling isolate_lru_page().
>> -   Calling isolate_lru_page() increases the references to the page
>> +   calling folio_isolate_lru().
>> +   Calling folio_isolate_lru() increases the references to the page
> 
> s/page/folio/
> 
>> @@ -86,7 +86,7 @@ How migrate_pages() works
>>   
>>   migrate_pages() does several passes over its list of pages. A page is moved
> 
> list of folios.  A folio is moved ...
> 
> (etc)
> 
>> +++ b/mm/swap.c
>> @@ -906,7 +906,7 @@ atomic_t lru_disable_count = ATOMIC_INIT(0);
>>   
>>   /*
>>    * lru_cache_disable() needs to be called before we start compiling
>> - * a list of pages to be migrated using isolate_lru_page().
>> + * a list of pages to be migrated using folio_isolate_lru().
> 
> a list of folios
> 
>>    * It drains pages on LRU cache and then disable on all cpus until
> 
> drains folios


OK, just use sed to replace then isolate_lru_page(), will re-check the
changes and update other page to folio, thanks.

> 
>>    * lru_cache_enable is called.
>>    *
>> -- 
>> 2.27.0
>>
> 


  reply	other threads:[~2024-08-26 13:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26  6:58 [PATCH 0/6] mm: finish isolate/putback_lru_page() Kefeng Wang
2024-08-26  6:58 ` [PATCH 1/6] mm: migrate_device: convert to migrate_device_coherent_folio() Kefeng Wang
2024-08-26 15:04   ` David Hildenbrand
2024-08-26 17:52   ` Vishal Moola
2024-08-27  5:42   ` Alistair Popple
2024-08-26  6:58 ` [PATCH 2/6] mm: migrate_device: use a folio in migrate_device_range() Kefeng Wang
2024-08-26 15:05   ` David Hildenbrand
2024-08-26 17:53   ` Vishal Moola
2024-08-27  5:46   ` Alistair Popple
2024-08-26  6:58 ` [PATCH 3/6] mm: migrate_device: use more folio in migrate_device_unmap() Kefeng Wang
2024-08-26 15:06   ` David Hildenbrand
2024-08-26 17:53   ` Vishal Moola
2024-08-27  5:47   ` Alistair Popple
2024-08-26  6:58 ` [PATCH 4/6] mm: migrate_device: use more folio in migrate_device_finalize() Kefeng Wang
2024-08-26 17:53   ` Vishal Moola
2024-08-27  5:48   ` Alistair Popple
2024-08-26  6:58 ` [PATCH 5/6] mm: remove isolate_lru_page() Kefeng Wang
2024-08-26 13:05   ` Matthew Wilcox
2024-08-26 13:52     ` Kefeng Wang [this message]
2024-08-26 14:41   ` [PATCH 5-fix/6] mm: remove isolate_lru_page() fix Kefeng Wang
2024-08-26 17:54     ` Vishal Moola
2024-08-26  6:58 ` [PATCH 6/6] mm: remove putback_lru_page() Kefeng Wang
2024-08-26 15:08   ` David Hildenbrand
2024-08-26 17:54   ` Vishal Moola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19306ff9-f886-4490-9d23-68e9741bf384@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=corbet@lwn.net \
    --cc=david@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox