From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C6EC7EE23 for ; Tue, 23 May 2023 09:41:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95086900003; Tue, 23 May 2023 05:41:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 900C1900002; Tue, 23 May 2023 05:41:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C7D5900003; Tue, 23 May 2023 05:41:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6CE52900002 for ; Tue, 23 May 2023 05:41:33 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 241A9AE288 for ; Tue, 23 May 2023 09:41:33 +0000 (UTC) X-FDA: 80821027266.15.20BE6EF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id B58D610001B for ; Tue, 23 May 2023 09:41:29 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=are2AHHN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684834889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZDccK11tKb/DU0VHaHNBaId4k6b+Ap4leLuwcKO7ZrY=; b=1BD//gmlyX12r4QWlD+HMkBiuxjJtneIsF3m9D9A+utSiYFiACHptb5Vkp9qTY+W5/Lz52 nxNNydeoINYI04nKqP7dVJz3xXKiNCrhExXm5ATFlpndxmXnpcYGGLMIeCckc2Lim94DdY jQwGMAvoqgDdxMGacxVL3++wIhQRdfY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=are2AHHN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684834889; a=rsa-sha256; cv=none; b=C5YXLorae5MhejKkiLLIFiXA/MO9xRcE32dwELv2tiDx32TWQHk5qBxo60fd549A8clurp kSF1LAisqDUcHezq/EY1EzGB+MFaX4b1tze72+vAZJb9PidbW0w7TexF3VrhF76lmzdbBe zHEzE5Miz9FHqMadF2WrIQCq62WDIzA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684834888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZDccK11tKb/DU0VHaHNBaId4k6b+Ap4leLuwcKO7ZrY=; b=are2AHHNTcW8S5G/7Ecs979ZueFIqL6HRbnXnzZ8w7vsp8+uj4dxUW5/r+a8xGEmbEwNSm YCwlGM2QS2OFWM6AQeHYNaRegluQDiiYycP7Qm+/nMoZPIvHrNx4GMpCSmuIcqdq3QBKzO 1TCFYSRJeX8h0+ZmJPR4QRsibiD379w= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-XNeiIQmTN7qMHkRoZLakow-1; Tue, 23 May 2023 05:41:27 -0400 X-MC-Unique: XNeiIQmTN7qMHkRoZLakow-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f4dd7f13d0so27867255e9.3 for ; Tue, 23 May 2023 02:41:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684834886; x=1687426886; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZDccK11tKb/DU0VHaHNBaId4k6b+Ap4leLuwcKO7ZrY=; b=KATWMbrH/hANoY4TvnttCpQA8Wh9fq78Bv7Ia8jsxS8VRcnqB98+5bCz5qcTm+960S W3rCA72dZJNxtOsQsMna/MvxqYWwrC6b1JBFlf0ZOmAYpDZ3s1yyyp8QsC3iZw4UWt0L 8q/8+UB1fiB7msMvXLEwAgUuDwAw0RsgakdplOs0KA2cWNhEZzy6C/eqgws7GTJm8wLh CwDIh+l7gLuVLOPw3T0egaOZGyBiuhte4qDa+HdyVQGaGcQLAUmPsavdbNThMU+KJyEj j2IrDIt2JhfrKWSEbQKYefG3YVOsi9BFjOGVCrty9qvc+OKUf8+O0YO7e5ELlJDsqlqm FeSQ== X-Gm-Message-State: AC+VfDzejs1YZ0gD880otKIJLT6LLCvEEj+h1/2Ww3k7OUR5yYdbZMuz v4dKFcwtVYQ+s5xhxbgMjbSPGYnZjI5JIjQOeDuCiWnboQwNgCEPxuXJkTjmsDEL8w02YKhl8py bupn7zhpTwvk= X-Received: by 2002:a05:600c:3658:b0:3f4:2438:31ca with SMTP id y24-20020a05600c365800b003f4243831camr9540356wmq.26.1684834886119; Tue, 23 May 2023 02:41:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6moStJZq0DXZPe8Acop7zOR1G4ELRA7FwbpGohqKxxjZg25oZi8IALChaxSaMIIYU7+03mxQ== X-Received: by 2002:a05:600c:3658:b0:3f4:2438:31ca with SMTP id y24-20020a05600c365800b003f4243831camr9540339wmq.26.1684834885766; Tue, 23 May 2023 02:41:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd? (p200300cbc74cb4005c8ba0b2f57ee1cd.dip0.t-ipconnect.de. [2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd]) by smtp.gmail.com with ESMTPSA id e19-20020a05600c219300b003f50876905dsm11227542wme.6.2023.05.23.02.41.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 02:41:25 -0700 (PDT) Message-ID: <1925d301-462d-6b33-8867-4e1646b2dbd6@redhat.com> Date: Tue, 23 May 2023 11:41:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Yang Yang , akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn References: <202305221842587200002@zte.com.cn> <20230522104908.3999-1-yang.yang29@zte.com.cn> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v8 1/6] ksm: support unsharing KSM-placed zero pages In-Reply-To: <20230522104908.3999-1-yang.yang29@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B58D610001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: da1pf17y7kod57863z1duu6xa5jn3uhm X-HE-Tag: 1684834889-658606 X-HE-Meta: U2FsdGVkX19y+VHaUpr574nD9t4iIOJaFnoNQzHwLzz56Uz0fzeNVOOeP5/4YnV8lI7emuTsnk1bFQvDezMa79+32DMsIqirlTFRIt+J08rTADOHFWrpY5G8twcTsXIo14HznfGO5IPPqa4UZSacGod3MbSD4ja/nKdjhx4Qw29MRd3uNsOoTvxAAxno8ehMxtYnlVqsdrAJ7AKUKn2eLwqlGh3VLne4YRsffHnguWZXnftmUAYRjohz9uV6MMq/azyoyK2JZX/VTk8AaPBg3tMV8v8N7k7cU2gl6m7sEy+qBUPfZwf8+6nVNHJo5cSVLna9Rzu+zIKt8go+z1hDTYQIGkE0b8JuC96faWCZ3GZKh3UG4oV1GARGam8R+6Ucq6LSWkV8QbnSEnsV103iRArYvM13kluf7GM1gATwsVmrgPyrx/WdNYFlDquNTAmlfQbxWDDc4pcElCLiPCMfi4lLdi+TtdkJp5HulMiJSM0oYXiKza87N4j6wsVswLZmV7eO+qArMI6AVNhZzB/GUxRbeeCyEOmX+cEyTvGEdrfHx9gC+ClyT9simt1svioHUxWx1wf/VZrWAhBqoiQDLxDngteehqNqBdbhIXNTTqWFDF9mOVXaBhkbRFyTbthcjGfv/+6dEBYfyiUzEkYluX58mf03F1r/5QGr+lEov6PDmt8VQSQv8G8SsF0N8f/R5PorUuTAYK2oGcwVkBWTKfwnonNLrA3RcGIK+TgAm+t4qjQf+ORGtqC8upGR2XGpMyc2GJxk2vh2w/8qW/0xDjGihkq9FUyVLqzVOftlQZpVlDzCWqWtmae3ZXbDLZyIMIMBswz5bkzlAeVLIqph11R8QCAd6rDMJkDZDd8X53NVKg0vinephUaGGn9aIUCVaEulYTLkXoNr89dBtGAMtMp6cE92nRIRyj3KyBxAHp+VniiSw23P5b2KfWrJNJxonTSIVTiNjYB/uAD+RW0 v5n2EHe0 Gw2mVlGx7KKqq8jU1vx1JExD5B2GXCVXtlHdGfbeVgBVlITOcWCbfDqpfb6gqtLzXBkhBaQd5jraJjPJ+9NR3FE3NB5GZQKOQzoxzSlUL121deBPN+wCI8PA6hWGQf3CTv41OoCuT1991CFk1JY6JBtfsfdar5wRKgStITkxkmzA6ED1Pl4NgBLd5Ldv+dMCR29NoDh07+8xks9sYegxHRfRj0fu0gk6Nb8QZ0q7SHWj2N6QogObp0j3RNJrjg71WhvvPCudyWFPN4ogiabKygfeZJSoCjJ7GYfMvHbXvoRz6AGGLs30JO4g+G0ucWvm42NAmevkytUCEFDZ6W0Dd9Fo/THU8GVyhmDXiGfWxsH/Ibh5cS8iFwyWcaDihx4d5VClLONtqnoNU+Sv9tTXo+I5vC4j2mWRkePeJoIRyp8UlzfZoO+ejZ6gdwoW6Q1KVQ5r3K5lisRnPvQSTzi9FoMNy2tXX5Me/6Z1CrDel7rThQMJ4O0W7FfkgKLYrpI02X+tQ3yRtpF/tybiRQCymzLI4zLyQhjIVzefC3H/8fo8bKSpDX2YrvHEECQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.05.23 12:49, Yang Yang wrote: > From: xu xin > > When use_zero_pages of ksm is enabled, madvise(addr, len, MADV_UNMERGEABLE) > and other ways (like write 2 to /sys/kernel/mm/ksm/run) to trigger > unsharing will *not* actually unshare the shared zeropage as placed by KSM > (which is against the MADV_UNMERGEABLE documentation). As these KSM-placed > zero pages are out of the control of KSM, the related counts of ksm pages > don't expose how many zero pages are placed by KSM (these special zero > pages are different from those initially mapped zero pages, because the > zero pages mapped to MADV_UNMERGEABLE areas are expected to be a complete > and unshared page) > > To not blindly unshare all shared zero_pages in applicable VMAs, the patch > use pte_mkdirty (related with architecture) to mark KSM-placed zero pages. > Thus, MADV_UNMERGEABLE will only unshare those KSM-placed zero pages. > > The patch will not degrade the performance of use_zero_pages as it doesn't > change the way of merging empty pages in use_zero_pages's feature. > Maybe add: "We'll reuse this mechanism to reliably identify KSM-placed zeropages to properly account for them (e.g., calculating the KSM profit that includes zeropages) next." > Signed-off-by: xu xin > Suggested-by: David Hildenbrand > Cc: Claudio Imbrenda > Cc: Xuexin Jiang > Reviewed-by: Xiaokai Ran > Reviewed-by: Yang Yang > --- > include/linux/ksm.h | 6 ++++++ > mm/ksm.c | 5 +++-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/include/linux/ksm.h b/include/linux/ksm.h > index 899a314bc487..7989200cdbb7 100644 > --- a/include/linux/ksm.h > +++ b/include/linux/ksm.h > @@ -26,6 +26,9 @@ int ksm_disable(struct mm_struct *mm); > > int __ksm_enter(struct mm_struct *mm); > void __ksm_exit(struct mm_struct *mm); > +/* use pte_mkdirty to track a KSM-placed zero page */ > +#define set_pte_ksm_zero(pte) pte_mkdirty(pte_mkspecial(pte)) If there is only a single user (which I assume), please inline it instead. Let's add some more documentation: /* * To identify zeropages that were mapped by KSM, we reuse the dirty bit * in the PTE. If the PTE is dirty, the zeropage was mapped by KSM when * deduplicating memory. */ > +#define is_ksm_zero_pte(pte) (is_zero_pfn(pte_pfn(pte)) && pte_dirty(pte)) > > static inline int ksm_fork(struct mm_struct *mm, struct mm_struct *oldmm) > { > @@ -95,6 +98,9 @@ static inline void ksm_exit(struct mm_struct *mm) > { > } > > +#define set_pte_ksm_zero(pte) pte_mkspecial(pte) > +#define is_ksm_zero_pte(pte) 0 > + > #ifdef CONFIG_MEMORY_FAILURE > static inline void collect_procs_ksm(struct page *page, > struct list_head *to_kill, int force_early) > diff --git a/mm/ksm.c b/mm/ksm.c > index 0156bded3a66..9962f5962afd 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -447,7 +447,8 @@ static int break_ksm_pmd_entry(pmd_t *pmd, unsigned long addr, unsigned long nex > if (is_migration_entry(entry)) > page = pfn_swap_entry_to_page(entry); > } > - ret = page && PageKsm(page); > + /* return 1 if the page is an normal ksm page or KSM-placed zero page */ > + ret = (page && PageKsm(page)) || is_ksm_zero_pte(*pte); > pte_unmap_unlock(pte, ptl); > return ret; > } > @@ -1220,7 +1221,7 @@ static int replace_page(struct vm_area_struct *vma, struct page *page, > page_add_anon_rmap(kpage, vma, addr, RMAP_NONE); > newpte = mk_pte(kpage, vma->vm_page_prot); > } else { > - newpte = pte_mkspecial(pfn_pte(page_to_pfn(kpage), > + newpte = set_pte_ksm_zero(pfn_pte(page_to_pfn(kpage), > vma->vm_page_prot)); > /* > * We're replacing an anonymous page with a zero page, which is Apart from that LGTM. -- Thanks, David / dhildenb