From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6BB5C38142 for ; Fri, 27 Jan 2023 17:59:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE48C6B0072; Fri, 27 Jan 2023 12:59:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E95336B0073; Fri, 27 Jan 2023 12:59:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5CE86B0074; Fri, 27 Jan 2023 12:59:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C6B436B0072 for ; Fri, 27 Jan 2023 12:59:02 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6CDCCC07EC for ; Fri, 27 Jan 2023 17:59:02 +0000 (UTC) X-FDA: 80401340124.18.412A98F Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf21.hostedemail.com (Postfix) with ESMTP id 70C651C0021 for ; Fri, 27 Jan 2023 17:58:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QxKKB9s4; spf=pass (imf21.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674842339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z4/3pp0HtNFhDGsx2C/KQB+H4Bh6uN2vy4tMssC8orA=; b=IwiX8ClyC6fd732TEwb1jNGZr57A9lTUG2czubhKE0OGrfHF/y/GJ05PiZ/uCRwoKXIvL2 6+vZD8ipyZ2y5KQv3g+pyAkTW2xUBm6+34Q8EdtukllYKyocoEKIhZc6LsdyPW+aFSZv4d 4M4tl9Zgr8HTXXhbtC/kDwSyudCGkmc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QxKKB9s4; spf=pass (imf21.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674842339; a=rsa-sha256; cv=none; b=qqhj9IxpfLJnrYWI/HEHp867KTmoe1zq+AOtucu7OVzV4yOMc+mgw3vYFTHeRZl6yh8K8O TjzfIuuMSXFnL/rS6U2/Y3hYUYC4DKHDwpEmE8MPtSvjaqjG5j/HD5A6F95NtgB0R2gCm3 Ur8YHPw2I/edG9sYeF+PgB/gevvvho0= Received: by mail-wm1-f48.google.com with SMTP id fl11-20020a05600c0b8b00b003daf72fc844so5955234wmb.0 for ; Fri, 27 Jan 2023 09:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z4/3pp0HtNFhDGsx2C/KQB+H4Bh6uN2vy4tMssC8orA=; b=QxKKB9s46hophXakrt/hDNgI5V23ayIGQVuMDVyYv60I1k/sJ6jhP1maC+4IiGRxgp lQShEzXuxbIAvd7iXsWanMUdEYbnISFnsOWbC6VJskcs3PHRIb5Bf9r2uhYWIRm74Dzw tdueKlrFFv/CBNwrnGc9iwrKzvaGXrTrzC3CJwyiVYkMaqonAl7MynZaO1hj9gvEWkcI QmoWVbniUi8zkgp2oD0qUVpE9Q3E/Byw7o+wYhGcJIUP/K/2u89673w4WJpL/0cWrQUe UTn+3+j99wPBjMZFsnDZa8o80zQMLYWbeBq/TaAS54kVNt5cEXd2n/b6xjpMnkkDI6JT Gtfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z4/3pp0HtNFhDGsx2C/KQB+H4Bh6uN2vy4tMssC8orA=; b=Gs1KyQRBwgWV4oJ3g+s57HjsMQmp1IOnGoPGsoIOuuxUJwoDst4WrPTGezCOVXyfad QAvlkLOIElh8WRpuBu+3K+Af46fbt3akrwvlICK7HXG2p3bA7Mt1gB3vTl8VoijuLMoN 4u/8HH+BgrXtmNk2MtXbfWkJLukj5TppvwInAuxuNdsPOH5wuF8kCuE+H6m6TzKXjIru OHZ3+QqODFcp7jToNyv3est3BBxx65ncarlmEjv0m24dad7aj+tchy5FEhZl45hcVTcK 8L+RsSsN003893u/CAcWO1N9/3+vVpyBtVya3wkRdee4QWncaoQ9D4RS5EnE9pIntFC6 x1Xw== X-Gm-Message-State: AFqh2kqFh5p4lfEq+K5DFDq7d3t2UXc4LIMtIKQ0x8VM/tv4dbjUYDxr 1MTFjZoyaqZuhutjhQL3kXw= X-Google-Smtp-Source: AMrXdXvNTPwj4cemkaOMxVKHEhwQGm4HuykOww+mQpA07rnd2kqZWmX31ukrCrdwsHUUU6ClEmdUpQ== X-Received: by 2002:a05:600c:a4c:b0:3dc:d5b:5f73 with SMTP id c12-20020a05600c0a4c00b003dc0d5b5f73mr14881327wmq.19.1674842337893; Fri, 27 Jan 2023 09:58:57 -0800 (PST) Received: from suse.localnet (host-82-60-215-65.retail.telecomitalia.it. [82.60.215.65]) by smtp.gmail.com with ESMTPSA id a18-20020a05600c069200b003db305bece4sm4888766wmn.45.2023.01.27.09.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 09:58:57 -0800 (PST) From: "Fabio M. De Francesco" To: Matthew Wilcox Cc: Andrew Morton , Ira Weiny , Sebastian Andrzej Siewior , Alexander Potapenko , Andrey Konovalov , Tony Luck , Bagas Sanjaya , David Sterba , Kees Cook , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Thomas Gleixner , Al Viro , Helge Deller Subject: Re: [PATCH] mm/highmem: Align-down to page the address for kunmap_flush_on_unmap() Date: Fri, 27 Jan 2023 18:58:55 +0100 Message-ID: <1920277.PYKUYFuaPT@suse> In-Reply-To: References: <20230126143346.12086-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Rspamd-Queue-Id: 70C651C0021 X-Stat-Signature: 66hauoe4xtu8oyod3sc3ch9hxaukjc9k X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674842339-914904 X-HE-Meta: U2FsdGVkX19zQGD2OHbn0/M7DO2DK5nOGXjCQ2kJT/lKrjsluVv0Ds8WYOXH4rJBQh0CRgplEPDF4htmGT8oYe1o0ArgRKUPZtVAhKUm8X9UtTET3ahaKzCeyu4vsyn+Dlymyt3NLKbprFfRmKhuzRBppLbwx7ybERdUT8C6gpy2cYsI1ngL+rKudl6OosgiDuu0qSL6HabKJiFoY+iTerxJuP14K/D6oAYwj03vQJ5fFz/s0alJy4mW9nW4UXr8LYKk7aUlUUrt3madeALloqKOdqZTiZQ7PZ0LXCosKA/pYm4CAkO4DfHv7PlMdGLlIFYZqqZkMpnVpV0crJYXs+BlWg5chLwzatRiXn63m1sfrBqFwmtjmcImLiT/3dtY5UUyzGBrCMDIns10Jc8Krjx+NDPKJPe2gzJrvKDvGAl1ssfyznJzV27sU7iK/RpPoebgK+r4pm53Xfh1JtsyDGosN0/+8cKGSlyNLrihDeSh9XVJOxnSrWV4X6KLOqpj1rhvh6qe5tV6VRa1xVXjcZyb6zCHnddzolSexAOfyuzhqHRtEd9WZT4Kvo8pNxcB3Fmt6jpxl+49lCRkc4wCQz2UWTpkRnUhXhJCWa51CN7ogXngGBhLhQEtxPzkLp9XPcDAbyfgA8YJl9rR28m/JB4Oh0MmXRfdZ0W36WR/siDhiFj2VCCOg8S2AucVDMR50S8KXeBmUKhuOEicMJvumnES3sjggBD7GSwmEBHm9bnERKHjkLAiWyVqxYj7vCmQHn/PqKsEJ+R8ks+3WpIPi10Lm5NhUax2hz4TrTiBvxOkxiQYeqAmvf2ZnjzT9lBxKnLTNIQfIE2fqZOinXyqnHWvbLp9CQVkZ8JTqQeoeks7rfWB849wOHm9mj1qIBLQbdgINjB9diqIy+rtyB0gIex66alwH9m9gsK+WvYm3+4YCR3rJvDBaGCBlGV7Ow12cRvtoBb00t46Iip0765 +4wdE3Gj f+qQhT9hq6M6q6BS8ML3eiHz9otEAo0aabXdTtaPN0EhHdv7A7Q7qh5lpIv4Mr3uhBX8WFL2uXQhkXxFCu5sCnX/73O099VO6T17rOwEscP9oar9UrZ1+a7vD0qNLnk6nq8UgyXFWfVZErOl7ZNIYRRPG0D1dN+OKjR4gq5ksToX9Mzi8eCArhq5R/OFaV02BBl3KvdeuyAom4TjEno6/kozQKuCz8ux0WPJQIR4oz2K+mDlf4GE0k4NPZgTLRR9qSjWqNrgK+44aKFPMztNucXMuNEMNVkh1oYllsjkIeg1rs3408ZZ9nxgXMFAOn307q8w6oDwA986ataU+WTaXJD1fjVfXWXSAqQzf9YoFGcRzL9figooyAFPoiz92q9cFgWe1jLHIo6m+CXpowuFfFpNXm2GK8sLiJyPJfCDvr9cktEYvkV767RIWpmWrVKzpvhMJEXZgygkLHg41i5v3M7CVM6Nr9cRHvGav58+7o4gDH47eWLNtIwqj/Ft9JI6xx5r8OVMWwdDBqac3Yh5hJHswcRWzn+5GndF6F5uqAUnhTac= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000041, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On gioved=EC 26 gennaio 2023 21:07:53 CET Matthew Wilcox wrote: > On Thu, Jan 26, 2023 at 03:33:46PM +0100, Fabio M. De Francesco wrote: > > If ARCH_HAS_FLUSH_ON_KUNMAP is defined (PA-RISC case), __kunmap_local() > > calls kunmap_flush_on_unmap(). The latter currently flushes the wrong > > address (as confirmed by Matthew Wilcox and Helge Deller). Al Viro > > proposed to call kunmap_flush_on_unmap() on an aligned-down to page > > address in order to fix this issue. Consensus has been reached on this > > solution. > >=20 > > Therefore, if ARCH_HAS_FLUSH_ON_KUNMAP is defined, call > > kunmap_flush_on_unmap() on an aligned-down to page address computed with > > the PTR_ALIGN_DOWN() macro. >=20 > You missed a spot. Sent the version I've had in my tree for a few days. I'm sorry for missing the other call site. =46urthermore, your patch has a better commit message.=20 However, I'm also sorry because I would have expected a different kind of=20 support from you. My patch could have been improved with v2. Anyway, I assume that you missed that I had asked you and Al if anybody wer= e=20 interested in doing these changes and probably you missed also that Ira=20 encouraged me to send a patch, whereas you did not show any interest... https://lore.kernel.org/lkml/3146373.5fSG56mABF@suse/ =46abio P.S.: Helge wrote to me privately but you cannot know it.