From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C023AEE0206 for ; Wed, 11 Sep 2024 17:18:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AC1C94007B; Wed, 11 Sep 2024 13:18:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25C0B940066; Wed, 11 Sep 2024 13:18:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 123F494007B; Wed, 11 Sep 2024 13:18:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5206A940066 for ; Wed, 11 Sep 2024 13:18:21 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EAFA8141743 for ; Wed, 11 Sep 2024 17:18:20 +0000 (UTC) X-FDA: 82553115960.11.D8BD6B2 Received: from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com [136.143.188.12]) by imf04.hostedemail.com (Postfix) with ESMTP id B10F440015 for ; Wed, 11 Sep 2024 17:18:18 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=b7Wgo39K; spf=pass (imf04.hostedemail.com: domain of bob.beckett@collabora.com designates 136.143.188.12 as permitted sender) smtp.mailfrom=bob.beckett@collabora.com; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726075046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kHt9rOniL8UPmfa6CZvU4/AXUR0LYrsD4geKIuDucB4=; b=5hPOR6DX+LUodZHc25SyIXtXyjJstCEu9TEpIG0MVULQTnuskuXaV08t+CFYlVyEOGaJG7 AsoMGxl8McHOBDNBpfVOvJOtnF2x2uUUKMifnShFmCDV/CodT9jcIZJGst+/p/u4erqE/h FrWN5o7EdM7hnJT07IrDMGyYUreILF8= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=b7Wgo39K; spf=pass (imf04.hostedemail.com: domain of bob.beckett@collabora.com designates 136.143.188.12 as permitted sender) smtp.mailfrom=bob.beckett@collabora.com; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1726075046; a=rsa-sha256; cv=pass; b=XyXUjpIxNr7DADmOSj5dmzjluATyIPW3EyCNlJ9CfB4zJ/yeimrIlviblRAoaIhEDJ49vN mfZOn48oPPog6gFBHukDnMaahgZoidOv357DU4JR19IZpjBzFwffVyScSZtz+Rrsb4aSmI CuIRYhPLGemTILEZ7Q5RqP5oJgqHsNU= ARC-Seal: i=1; a=rsa-sha256; t=1726075085; cv=none; d=zohomail.com; s=zohoarc; b=ICd5B7KHj1s4gGVMpQOg9SQo0qmPzP++hoalDDuLpuOnBr72UYwJY4+pPuaqUTUz+ZH5mUkdAFYHSwqNfympZNWXthHMoUm0NA3hYrp7bIUuS8j/nEaDFe601c0WMmFqb39Uyo6TajpxDlmy5XTG2Fy6OZcdSBggoJo5SKSOCCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726075085; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=kHt9rOniL8UPmfa6CZvU4/AXUR0LYrsD4geKIuDucB4=; b=PrVmqMtkooY35kx266pwDM8LCADNVRA0Uacec4n2Iq3HEp0LxT1nVsAwv6Z8JgyHOL3Y3ssyQB3FgkK8+guaDkJ++wPSYy0L+wsvlMPmcsfc1eGpihbaXFInsWeJyzpGzhOSDhQGAkesMw8yPIxJFwiDdUc/H2dA1N0E9R6QeKI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=bob.beckett@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1726075085; s=zohomail; d=collabora.com; i=bob.beckett@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=kHt9rOniL8UPmfa6CZvU4/AXUR0LYrsD4geKIuDucB4=; b=b7Wgo39K0AAFXXnZmnur0x8RCPKrQ6+93Sd40tWzTShl1cBFtkTDeOojY4T9sUjQ ue7T2bLq4zKcUgjJa9+NCSmiVMye+3KF3C0Ru8Cwiz7E1MPyRiCirSszyOqpvG1ssGS BH5PYCnUBlFmZe2p063WwD/R8Zw7/O3xGDZ4XxzQ= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1726075054333294.76086684496613; Wed, 11 Sep 2024 10:17:34 -0700 (PDT) Date: Wed, 11 Sep 2024 18:17:34 +0100 From: Robert Beckett To: "Keith Busch" Cc: "linux-nvme" , "Jens Axboe" , "Christoph Hellwig" , "Sagi Grimberg" , "Andrew Morton" , "linux-mm" Message-ID: <191e21728e2.db9e9ba41614298.5814843736445682725@collabora.com> In-Reply-To: References: <191d810a4e3.fcc6066c765804.973611676137075390@collabora.com> <191db450152.e0b28690987786.6989198174827147639@collabora.com> <191dcfa4846.bb18f3291189856.1624418308692137124@collabora.com> <191e203fd17.118394e2d1606957.7379866259983341167@collabora.com> Subject: Re: possible regression fs corruption on 64GB nvme MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: B10F440015 X-Stat-Signature: r1z9idsh4pb8i86ecso3xob3biqmgh5t X-HE-Tag: 1726075098-430393 X-HE-Meta: U2FsdGVkX1/Y1ko5ze0TbHt2rVHyaFmIjCAynTEosx85w9LAd/cW4vrthjTcErPVC+WY2ytkh8l1WajKuKSVDpD1IX8YlBBgt8PkRRXLK8+7WLROctUXv3OVoH7H2DHH0IjnE3+KJVa5IO14afEcejknnC8W4wMmv5+kipK0I7euxoWKfcgnmQBMMbygZaNVqwj7p3rUhb9eP6GOVz3MOT9Iatdv7qZT/Egt3mHF0eh0CCnFHXJ6Cvh18T2p3ZVUFemv/tDHSrcBJN/ZuE21DkLUEmy42F7NcRVO2whAbo4yfpClr4XLb2065i8MP6CmBsq9DTwkadeO/8Cbe7abehfRoFR80S4hvvQwfXVGJPJj+Uwh3Hk4SkGDWW5d4mXklpPZ1aQoqI1Gwgy9z8yc4r0+Nb813XX+H05R+FKGCN5jwjWI1c3PVa+/ZIxqKRbs2gOfxL0oqPOPjRRs8JkwyCj6AGuoiVEJMxr7H+uN+c+9/T0t+JGhziIhoNB62AV0KJ+kRKY4a0SydSf6cN5rA+SF5Qsj7Cs8eygyssIcFgqqxEklHDsJmvDKWbalxnh1hZLhx/R5wBRbs+6Py8OsW3eIGd8avIOOH9hjpGQ7tFaWnRmDX06qYfB7Ah5+lZfhhR7L9dvpTe+iy1LN5Evskqoyvwx0rlE1Bw4SMEb4QYpZwSebC9C5SheecOWXx8oTxz9VlHfh2lVQ7L1IeimouAd9DhGI4PiYj2FBUeQPSPP62R2gHFKxGom6kqe9SpLDg3pC/LkAHCQyj1bmu003YNntsuPpuHuakijILN5DUe1QZCLuV4KNjmYOTyA1z2jn+xCJ1oktt5r6kJeq1/yCx9qS2xiPMoYi6CQ3z0O6XmMgXc0SclX2T4B+xCSOD0bLkRxwvvEqmXMiwnpHrnSDlXA1GFZQa9UbeYePdLTwYjhbelTxcOANBZudJsFwxFrRoKtRx0rQBP/qOBJRK+0 cWWjM5fa A4a3HKfiSDAQaiH9dV6HOlm1jWZIkYajnEjAgvtIVlh5i2aRg2AzqM6i/ozhqotwvnEmqUCC8mNle8fYDAzD7CmCCLuChFZ8Bdfd1kMnxgNQcbj7SrN3eLaVUTNGqXAlJX6D/ESa32JFoyRicOs6Qjkkn9XyXfvJN/Icxhwutalefx0965sLQGHv6GoxVB6pID5TyLFFHo/LiRHhOMqxk0LiZRS28k+y+MhpLgkfLgQs9kaY5pzE72FTk3wN6XL5L1lZqw3734IMvwh7BXR0D7LNAEeqbqT77ZMNMnZ/aOo2q0cWgsJy/OTJt+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ---- On Wed, 11 Sep 2024 18:08:50 +0100 Keith Busch wrote --- > On Wed, Sep 11, 2024 at 05:56:37PM +0100, Robert Beckett wrote: > > > > given this ~9 year old temporary fix is still in the kernel for the > > Apple device, could we just add another device specific override? I > > could maybe convert it to a quirk that is set for them both (and any > > future devices) > > Sure, that's an option. Do you want to send a patch? Alternatively you > can reply with the PCI VID:DID of your problematic device and I'll write > one for testing and consideration. looks like it's 1217:8760 01:00.0 Non-Volatile memory controller [0108]: O2 Micro, Inc. Device [1217:8760] (rev 01) (prog-if 02 [NVM Express]) Subsystem: O2 Micro, Inc. Device [1217:0002] Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- Kernel driver in use: nvme Kernel modules: nvme > > And just fyi, there are potential performance implications for doing > this. It's less noticable on higher latency devices, which sounds like > what you have anyway, so may not matter much for you. Just getting that > out there to avoid any surprises. Understood. I'll do some benchmarking with and without it to check difference. I think for now it is safer to get it in the code as it can cause corruption. We can always revert it if we figure out a fix with less performance degredation. Cheers muchly!