From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED863C433F5 for ; Mon, 4 Apr 2022 07:43:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F04446B0072; Mon, 4 Apr 2022 03:43:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB3FD6B0073; Mon, 4 Apr 2022 03:43:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7B396B0074; Mon, 4 Apr 2022 03:43:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id C9CAF6B0072 for ; Mon, 4 Apr 2022 03:43:02 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 70D661837E010 for ; Mon, 4 Apr 2022 07:42:52 +0000 (UTC) X-FDA: 79318404984.24.3FFCBFF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf24.hostedemail.com (Postfix) with ESMTP id E9CFE18001E for ; Mon, 4 Apr 2022 07:42:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 76C391F381; Mon, 4 Apr 2022 07:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649058170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+LWlYv9cz7gaJxOzL+xR1zHRqTA1ZXCYk0EA7akS3Q=; b=KJgPqp2gTIdVAhpodnARX8ZFr/hA/T/hJ2qux30lf/agq7dwFaBnIXpiK+zFZlz8lyJ1Jt ZU+LtfJHQOhv+Hc6+/IF5HPURrA3btikua+yTYwXGrd2+Vio7oZFbF+LhNZMOK+8XnXC2a ZaMkenl8WZCubwPR7gcvePE5fAyVufA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649058170; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+LWlYv9cz7gaJxOzL+xR1zHRqTA1ZXCYk0EA7akS3Q=; b=lVEFLsp17eaJoj062wqgYZ9ktKh/BXwfi4d94DCDyA7HIiF71X3LBdDtPe2Q2mLxdfanAk 1QRGCO0ipqB4VqCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4E17313216; Mon, 4 Apr 2022 07:42:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yh9YEnqhSmKGbQAAMHmgww (envelope-from ); Mon, 04 Apr 2022 07:42:50 +0000 Message-ID: <191c3fd8-b858-06b7-df1f-f2f40490d1b6@suse.cz> Date: Mon, 4 Apr 2022 09:42:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation. Content-Language: en-US To: Zi Yan , linux-mm@kvack.org Cc: Linus Torvalds , Steven Rostedt , David Hildenbrand , Mel Gorman , Mike Rapoport , Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org References: <20220401230804.1658207-1-zi.yan@sent.com> <20220401230804.1658207-2-zi.yan@sent.com> From: Vlastimil Babka In-Reply-To: <20220401230804.1658207-2-zi.yan@sent.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 5tpiygi4b39bt7qt9j33ss9is6mj1fgx Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KJgPqp2g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=lVEFLsp1; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E9CFE18001E X-HE-Tag: 1649058171-863725 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/2/22 01:08, Zi Yan wrote: > From: Zi Yan > > Whenever the buddy of a page is found from __find_buddy_pfn(), > page_is_buddy() should be used to check its validity. Add a helper > function find_buddy_page_pfn() to find the buddy page and do the check > together. > > Suggested-by: Linus Torvalds > Link: https://lore.kernel.org/linux-mm/CAHk-=wji_AmYygZMTsPMdJ7XksMt7kOur8oDfDdniBRMjm4VkQ@mail.gmail.com/ > Signed-off-by: Zi Yan Acked-by: Vlastimil Babka Thanks.