From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9DEEC5AD49 for ; Wed, 28 May 2025 11:04:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8364D6B0096; Wed, 28 May 2025 07:04:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E6576B0098; Wed, 28 May 2025 07:04:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AEAA6B0099; Wed, 28 May 2025 07:04:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 50A8A6B0096 for ; Wed, 28 May 2025 07:04:03 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 158671D3323 for ; Wed, 28 May 2025 11:04:03 +0000 (UTC) X-FDA: 83492031966.21.B0D8BF0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 9A0E2140013 for ; Wed, 28 May 2025 11:04:00 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iLUKkqpW; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748430240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XUmqPZP/ey41I54C3VrrZw/viH8NhQ/UPLK7npoUAdQ=; b=NzP0bKyul3SZNU0zZi1kOcFgHDO3ZbZ/YD6CEKZhoAGZ+eQH+urQZ1K+DImYrUK4rNyG+3 e/H59tsuTyAO31J9uvz+bPivNdPDsTHYMlHcAt6gpw8YSiVmJEqPjbdOofcw/6GPSBeq8d 1sndi7tr3mkAgJOSOeKw7B8Fiv5+JS8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iLUKkqpW; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748430240; a=rsa-sha256; cv=none; b=2T4ZdR61udX2NyFeXxTMGyQt2Pry8W+uHYEglKHDp65JEfmVwKN3NUJgsz4zUCqUjgOMAG dLdH2OX02hpcN9wPL0lPlH6zSAmHGoRW+oIt2rRDRx63xCufYBrFucs6/Ilw28X61dq+Uv X0lwULglkGMO45vKwcD6o5KYDRpMddg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748430239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XUmqPZP/ey41I54C3VrrZw/viH8NhQ/UPLK7npoUAdQ=; b=iLUKkqpWoFJm05XyivLt9XbL3SKLXowMTMr19ZYBZDoU411wl2JgjVYLAaVCLsVVwYFofy 8Bu8UhT8/RXivPZK1d6ZyTLD9g+ZiEpv/XMiyKM3oS/q0QYV+9ADm5MdfSpfpDBLbi0BZg DeoPaJ6eV5uqAwh4bmFm3vFy/itPpUw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-cAid7V0UM8aB2Q6jglXJFA-1; Wed, 28 May 2025 07:03:56 -0400 X-MC-Unique: cAid7V0UM8aB2Q6jglXJFA-1 X-Mimecast-MFC-AGG-ID: cAid7V0UM8aB2Q6jglXJFA_1748430235 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-442cdf07ad9so23283465e9.2 for ; Wed, 28 May 2025 04:03:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748430235; x=1749035035; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XUmqPZP/ey41I54C3VrrZw/viH8NhQ/UPLK7npoUAdQ=; b=sl72944zMGMkSnLO2qmrprUEuyXqsVg+xSrYw9cogIG4bpyPCQa2AE9NR1czxINX9/ r37wbP25rn5PYuBpqR1bUtU0mRQ6ttUfJ3X6mQqqu3ptDtkm/o3qBxCa2jKoOWQObPka QtmkkMd9eJLHXhFxfDieRgNB8f9ESsbbnqdz0zIOmFs3rfGW6U4nwyF1qSlzSqj5ZacR wPcPiu5b7ADQtLsUE1+tTCksC8isvkZg22SUY2BTew/vw3nG8cGFLRq6sFm8cvSPw2sf F+BKtsFTVS7KbQk+Kil2RYHRXlbNnwK9gFjUgfhVg4DYgzIVmN6CMQPpUrvokhJcsZKF 1VcA== X-Gm-Message-State: AOJu0YyEEa72F8kggcmSmgUH1I8UYtutg5BhhPlIIYBTJHXppcGm26ZH r0727ONcslfr4bwOXcLrl7BdCCiviFdfu2nmeDKQFhiVcaKH5OOtiZPv1VdkyUZEiL9jpcgePkM lq9v/tmy2pwv9DyUFyVKARYQTYqA8gUyrGfxDN8lyXJgjxpUWfpXq X-Gm-Gg: ASbGnctYYeZ7Pxv2VecShBuwhCUJSQsWfJwIROnI4bhJ5QK8GbfMyQkUCA/oZaPnSCu Pjah482vjJvQVCNt/yRNeaVoKeXuqPYfy7UAY1XmMUc5th3/kgYHCuiNCp9FJ28aQ1jY5b/lY18 P1ms5b2MK17G+prO/+KgpclSa4DB+dHxxClACPzTlFUbN4NOQD2xg8zTxCBkE/qGI1nLS59Q+Ed j5OAeIB7J2SQc+rSkNXWgVFSCKVelHBPSEt0v380nkDcSOtRQmXgYGOyAlw2gtHMM+hkiGHCL90 Wc9beayFIiUOm3+iebFUPyuBDSH28ny7YOqR+hpOXRmuPiP8US4LAsRnu6fZ+6cUF2P7+WkEy5z nB1qw8+/pKJ9gt/etFWZ9EWarmIfHDoBxdCrmD1Y= X-Received: by 2002:a05:600c:8283:b0:43d:45a:8fca with SMTP id 5b1f17b1804b1-44c94c2a4c6mr152075865e9.30.1748430235211; Wed, 28 May 2025 04:03:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvB4aiJDW65BI5a6zIT3DqbPJQlHU1DBllsmOfsWcS0yLV/1OUCDbL+TV1jsIMb/aPOJARjA== X-Received: by 2002:a05:600c:8283:b0:43d:45a:8fca with SMTP id 5b1f17b1804b1-44c94c2a4c6mr152075445e9.30.1748430234770; Wed, 28 May 2025 04:03:54 -0700 (PDT) Received: from ?IPV6:2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36? (p200300d82f30ec008f7e58a4ebf06a36.dip0.t-ipconnect.de. [2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44ffc0eb7afsm18341125e9.0.2025.05.28.04.03.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 04:03:54 -0700 (PDT) Message-ID: <1916ff1c-93e7-442a-b1be-e0e35190a6ba@redhat.com> Date: Wed, 28 May 2025 13:03:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Andrew Morton , Shuah Khan , Lorenzo Stoakes , Ingo Molnar , Peter Xu , Dev Jain , Aishwarya TCV References: <20250509153033.952746-1-david@redhat.com> <232960c2-81db-47ca-a337-38c4bce5f997@arm.com> <7cb7f23a-ce9e-4664-8083-deb73ed23da3@redhat.com> <3c15a093-7c19-4c2a-a571-56a5ed4b445f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: f4tfelr9ZhKsr4GEQdd08p-WfvkQ4fQOa9eiBbvMLNg_1748430235 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9A0E2140013 X-Stat-Signature: 16ak3yw1gh45n4xnioqhwkkwm4iuu5us X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748430240-14699 X-HE-Meta: U2FsdGVkX1/6gjiEFO9EPvJk4D/M0/OUj+mU32aeG6hS0DNWsQs5VyqCaMUaYZgTzvWznILeQQHpmPAfTv9FOEhvNyXBP407fKQUxyaWWeBk+ceU7i5KztC7ayvtSaiWGJudQu5kQyh34dgNAV7Zer4RlMKGmSKMIjQQOBsI8/i5trjdATFLF7IjfobgnB5Qu4zJbx5QbtEa9smZhXZno+V/H0GRHmdo6VjxaAK3xN4QO7J5x5k9YKBUUl6VC8Gb4mdXBH1tr5r4brkuK5H5P3SLqiYOzAJsPrJXKEA0jc8k4IMETKmcJIfznuySZxO38sxDm/BHzkzInBp7FLOjCNLVP0OCXoK7QffS+BcDaLTVsnkVTtDeiZM514F3Ud/gQGqx+cV7/DTkPzePvN8hNb1rMMj5FCdMepynaZODJVE/r7AJE9jQmDMiwCeaqhbSqikXsAsRkUmH9W99ymtw94tEPaYom+u7aqOezRNbnyju/ys00AjSAIvAxVmhQOEm97fqoXpoAuC+jM+Q/Cn6cYt8nXlAcZybHc88n1SZ6s2eyIS+a+SqVkDNJlCeXONkksgjQskLCVadEuSw9eubxvJNzO+PNlD6Rw95Flm0JjOQhHCgKjD9Rnyqt1HWz65LS1GDaDMBPK0PlmzuKA3/BPK6Aa8+0+LBBkXjRcq3HmWylH9zoG36RrYYcFZ51fXJj5jieqe5plqa8mIe9lY8fOGMCQFJDUwckadhpoBadnrLMA2wctRJaH4axVgPOE7ISukLCkYkrxmSj1Cg6mmx4dl5Xcivonao068BPcG6PDQmbO/WgO/2HNhVIxs6D1F5JzP/n+7w9MNSDVqfba70BUQ7JK+bOml81uzBKvGKv1Rm0zZ7tspZlndpMbPpJzJS0Trw7USzlKrn4Ke/e4zixmgur75zEFGS5xWdGBRw0zAR+9o0uYM4AlyH6rjB5xHYhGaeXaAUEMWuBpPVEQu KSPEd8ft vd+ioqU5aTTTAH9gbMk5grWKtfaHwtvtTMK6rWa9jsjJhaWTsobkCvrhkFx9ilSqZTFGLH6g9nuDWiaqzjr3HOcEE0FTtI2F8u9TUL62EfpPMPLgNL8bsY/4IQr8DuJLRKhhiT1btThiF5/sPyRToIVmjRPZSlU6sP4nbF8rBPqNsaysbQKdz/3VT3CeMLB3hWvQE52HNBKS3648fbIUF3yfdxNz0SUl0wX+7fkOtJcK4JFPS7OUFG3Ks5dO06BB9C9mvxaOEY+EsdykFsL0hqzZlaQjs5CnENoHiyntuXMggnEcxd5Z3ccHWcplglvOrGFEWBykyguDgRXynfjVR6R2sd/GNfxiKx5xxlIxWnNjlJb8kPIHRSPSemZ4OAfdOjrvR34FIEhWm69tNnKtLRkM88XAAOuENpjr0xk5eiFflz0aJk2vbCP5Ng2rk86ZzGPqvwsEkOR54M8s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.05.25 12:53, Ryan Roberts wrote: > On 28/05/2025 11:48, David Hildenbrand wrote: >> On 28.05.25 12:44, David Hildenbrand wrote: >>> On 28.05.25 12:34, Ryan Roberts wrote: >>>> Hi David, >>>> >>>> >>>> On 09/05/2025 16:30, David Hildenbrand wrote: >>>>> Let's test some basic functionality using /dev/mem. These tests will >>>>> implicitly cover some PAT (Page Attribute Handling) handling on x86. >>>>> >>>>> These tests will only run when /dev/mem access to the first two pages >>>>> in physical address space is possible and allowed; otherwise, the tests >>>>> are skipped. >>>> >>>> We are seeing really horrible RAS errors with this test when run on arm64 tx2 >>>> machine. Based solely on reviewing the code, I think the problem is that tx2 >>>> doesn't have anything at phys address 0, so test_read_access() is trying to put >>>> trasactions out to a bad address on the bus. >>>> >>>> tx2 /proc/iomem: >>>> >>>> $ sudo cat /proc/iomem >>>> 30000000-37ffffff : PCI ECAM >>>> 38000000-3fffffff : PCI ECAM >>>> 40000000-5fffffff : PCI Bus 0000:00 >>>> ... >>>> >>>> Whereas my x86 box has some reserved memory: >>>> >>>> $ sudo cat /proc/iomem >>>> 00000000-00000fff : Reserved >>>> 00001000-0003dfff : System RAM >>>> ... >>>> >>> >>> A quick fix would be to make this test specific to x86 (the only one I >>> tested on). We should always have the lower two pages IIRC (BIOS stuff etc). > > I'm not sure how far along this patch is? I'm guessing mm-stable? Perhaps you > can do the quick fix, then I'd be happy to make this more robust for arm64 later? Already hacking on the parsing :) -- Cheers, David / dhildenb